[PATCH] since the definition of dst_discard_in and dst_discard_out are the same,

2007-06-01 Thread Denis Cheng
they should merged into one Signed-off-by: Denis Cheng <[EMAIL PROTECTED]> --- net/core/dst.c | 17 - 1 files changed, 4 insertions(+), 13 deletions(-) diff --git a/net/core/dst.c b/net/core/dst.c index 764bccb..c6a0587 100644 --- a/net/core/dst.c +++ b/net/core/dst.c @@ -111,1

Re: Mixing tagged and untagged vlans using via-velocity driver

2007-06-01 Thread Stephen Hemminger
On Fri, 25 May 2007 09:37:09 +0200 "Nicklas Bondesson" <[EMAIL PROTECTED]> wrote: > I am trying to setup two vlans (one tagged and one untagged) using the > native via-velocity driver in kernel 2.6.21.1 on a single nic. > > I can set it up tagged or untagged without any problems, but not both at

small forcedeth WoL fix

2007-06-01 Thread Tim Mann
I happened to notice that a system with an NVidia NIC using the forcedeth driver won't wake-on-LAN if the interface was in promiscuous mode when you power off. By experiment, it looks like the hardware needs to have NvRegPacketFilterFlags set to NVREG_PFF_ALWAYS|NVREG_PFF_MYADDR (i.e., receive uni

[RFC PATCH 2/2] dmaengine: move channel management to the client

2007-06-01 Thread Dan Williams
This effectively makes channels a shared resource rather than tying them to a specific client. dmaengine now assumes that clients will internally track how many channels they need and dmaengine will learn if the client cares about a channel at dma_event_callback time. This also enables a client

[RFC PATCH 1/2] dmaengine: add base support for the async_tx api

2007-06-01 Thread Dan Williams
In preparation for the async_tx (dmaengine client) API this patch: 1/ introduces struct dma_async_tx_descriptor as a common field for all dmaengine software descriptors. The primary role of this structure is to enable callbacks at transaction completion time, and support transaction chain

[RFC PATCH 0/2] dmaengine: preparation for raid acceleration

2007-06-01 Thread Dan Williams
Hello David, The following two patches are part of the raid acceleration series I would like to push for 2.6.23 consideration. I am sending these two separately for your review for the following reasons: the 'dmaengine' core initially came in through netdev, patch #2 makes changes to net/dev/cor

RE: ETHTOOL_GSET IOCTL on GigE links

2007-06-01 Thread Jeff Haran
> -Original Message- > From: Jeff Garzik [mailto:[EMAIL PROTECTED] > Sent: Friday, June 01, 2007 4:05 PM > To: Jeff Haran > Cc: [EMAIL PROTECTED]; netdev > Subject: Re: ETHTOOL_GSET IOCTL on GigE links > > Jeff Haran wrote: > > OK, but my question remains. In the case where a device > su

Re: [PATCH] spidernet: checksum and ethtool

2007-06-01 Thread Linas Vepstas
On Tue, May 29, 2007 at 05:24:36PM -0700, Stephen Hemminger wrote: > It doesn't look like spidernet hardware can really checksum all protocols, > the code looks like it does IPV4 only. If so, it should use NETIF_F_IP_CSUM > instead of NETIF_F_HW_CSUM. > > The driver doesn't need it's own get/set

Re: ETHTOOL_GSET IOCTL on GigE links

2007-06-01 Thread Jeff Garzik
Jeff Haran wrote: OK, but my question remains. In the case where a device supports one set of speeds via autonegotiation and another set via forcing, how does one tell which speeds can be forced and which can be autonegotiated? The interface does not currently support such enumeration. You can

RE: ETHTOOL_GSET IOCTL on GigE links

2007-06-01 Thread Jeff Haran
> -Original Message- > From: Jeff Garzik [mailto:[EMAIL PROTECTED] > Sent: Friday, June 01, 2007 3:40 PM > To: Jeff Haran > Cc: [EMAIL PROTECTED]; netdev > Subject: Re: ETHTOOL_GSET IOCTL on GigE links > > Jeff Haran wrote: > > With 10/100 Mbps links it wasn't such an issue since the > d

Re: ETHTOOL_GSET IOCTL on GigE links

2007-06-01 Thread David Miller
From: "Jeff Haran" <[EMAIL PROTECTED]> Date: Fri, 1 Jun 2007 15:51:18 -0700 > OK, but my question remains. In the case where a device supports one set > of speeds via autonegotiation and another set via forcing, how does one > tell which speeds can be forced and which can be autonegotiated? Unfor

Re: ETHTOOL_GSET IOCTL on GigE links

2007-06-01 Thread Jeff Garzik
Jeff Haran wrote: With 10/100 Mbps links it wasn't such an issue since the devices tend to support the same forced speeds and duplexities as they are capable of negotiating, but with GigE links that's not always the case, at least not according to what I've read. For instance, the following doc f

Re: [PATCH] e1000: disable polling before registering netdevice

2007-06-01 Thread Doug Chapman
On Fri, 2007-06-01 at 10:22 -0700, Auke Kok wrote: > To assure the symmetry of poll enable/disable in up/down, we should > initialize the netdevice to be poll_disabled at load time. Doing > this after register_netdevice leaves us open to another race, so > lets move all the netif_* calls above regi

Re: [PATCH] e1000: disable polling before registering netdevice

2007-06-01 Thread Herbert Xu
On Fri, Jun 01, 2007 at 10:22:39AM -0700, Auke Kok wrote: > To assure the symmetry of poll enable/disable in up/down, we should > initialize the netdevice to be poll_disabled at load time. Doing > this after register_netdevice leaves us open to another race, so > lets move all the netif_* calls abo

Re: [PATCH] fix e100 rx path on ARM (was [PATCH] e100 rx: or s and el bits)

2007-06-01 Thread Kok, Auke
Jeff Garzik wrote: David Acker wrote: Milton Miller wrote: the el flag but we leave the size was 0 bit set. This was we can find this buffer again later. If the hardware sees the el-bit cleared without the size set, it will move on to the next buffer and skip this one. If it sees the siz

Re: Please pull 'libertas' branch of wireless-2.6

2007-06-01 Thread Dan Williams
On Thu, 2007-05-31 at 17:16 -0400, John W. Linville wrote: > On Thu, May 31, 2007 at 05:13:17PM -0400, Dan Williams wrote: > > On Wed, 2007-05-30 at 11:28 -0400, Dan Williams wrote: > > > On Wed, 2007-05-30 at 10:07 -0400, Jeff Garzik wrote: > > > > John W. Linville wrote: > > > > > Lots of stuff h

Re: [PATCH] fix e100 rx path on ARM (was [PATCH] e100 rx: or s and el bits)

2007-06-01 Thread Jeff Garzik
David Acker wrote: Milton Miller wrote: Your logic works, this adds some conditional branching but saves a pointer, not sure which is better. Mine can be used for initializing without special casing since it will just calculate rx_to_unmark as rx[n-2] and rx_to_mark as rx[n-2] != rx[n-2]->pre

Re: [PATCH] fix e100 rx path on ARM (was [PATCH] e100 rx: or s and el bits)

2007-06-01 Thread David Acker
Milton Miller wrote: Your logic works, this adds some conditional branching but saves a pointer, not sure which is better. Mine can be used for initializing without special casing since it will just calculate rx_to_unmark as rx[n-2] and rx_to_mark as rx[n-2] != rx[n-2]->prev; unmarking a never

Re: [PATCH 2.6.21.3] bonding: Fix 802.3ad no carrier on "no partner found" instance

2007-06-01 Thread Jay Vosburgh
Jeff, please apply wherever seems appropriate. It is a bug fix, but for a pretty obscure bit of standards compliance. Signed-off-by: Jay Vosburgh <[EMAIL PROTECTED]> -J Laurent Chavey <[EMAIL PROTECTED]> wrote: >Remove the requirement to have at least one configured partner t

Re: [PATCH 7/7] cxgb3 - Add SW LRO support

2007-06-01 Thread Jeff Garzik
Brice Goglin wrote: Steve Wise wrote: You're right. But cxgb3 has it now in the driver (tested and working). Shouldn't it be pulled in? When the network stack design gets done (which could take a few releases to finalize), all the drivers can be updated to use it. It doesn't seem reasonable t

[PATCH 2.6.21.3] bonding: Fix 802.3ad no carrier on "no partner found" instance

2007-06-01 Thread Laurent Chavey
Remove the requirement to have at least one configured partner to enable the operation of links. The later is necessary to have the code in compliance with section 43.3.9 of IEEE 802.3, Signed-off-by: Laurent Chavey <[EMAIL PROTECTED]> -- diff -ru linux-2.6.21.3/drivers/net/bonding/bond_3ad.c li

Re: [PATCH]: bonding: Fix 802.3ad no carrier on "no partner found" instance

2007-06-01 Thread Jay Vosburgh
Laurent Chavey <[EMAIL PROTECTED]> wrote: >On 6/1/07, Jay Vosburgh <[EMAIL PROTECTED]> wrote: [...] >> Prior to the change in question, the carrier state of the master >> device was always on, regardless of the state of the slaves (so even if >> things didn't work, bonding would claim to b

Re: [ICMP]: Fix icmp_errors_use_inbound_ifaddr sysctl

2007-06-01 Thread David Miller
From: Patrick McHardy <[EMAIL PROTECTED]> Date: Fri, 01 Jun 2007 19:24:18 +0200 > It seems like you missed this patch in the previous thread discussing > the problem, so here's a resend. Thanks for resending, applied, thanks Patrick. - To unsubscribe from this list: send the line "unsubscribe net

[PATCH] rfkill: Make rfkill->name const

2007-06-01 Thread Ivo van Doorn
The rfkill name can be made const safely, this makes the compiler happy when drivers make it point to some const string used elsewhere. Signed-off-by: Ivo van Doorn <[EMAIL PROTECTED]> --- diff --git a/include/linux/rfkill.h b/include/linux/rfkill.h index 7c1ffba..a8a6ea8 100644 --- a/include/li

Re: [PATCH 0/5] NetXen: Bug fixes and updates

2007-06-01 Thread Vernon Mauery
On Friday 01 June 2007 4:11:25 am Mithlesh Thukral wrote: > Hi All, > > I will be sending bug fixes and updates to NetXen's 1/10G Ethernet > driver in subsequent mails. > These patches are wrt netdev#master. These patches seem to work for me on my i386 machine with a dual port card. Acked-by: V

Re: [PATCH 4/5] atl1: eliminate unneeded kill_vid code

2007-06-01 Thread Chris Snook
Stephen Hemminger wrote: This driver has unneeded stubs for VLAN filtering. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- drivers/net/atl1/atl1_main.c | 25 + --- drivers/net/atl1/atl1_main.c | 33 + 1 file changed, 1 in

Re: [PATCH]: bonding: Fix 802.3ad no carrier on "no partner found" instance

2007-06-01 Thread Laurent Chavey
On 6/1/07, Jay Vosburgh <[EMAIL PROTECTED]> wrote: Laurent Chavey <[EMAIL PROTECTED]> wrote: >On 5/31/07, Laurent Chavey <[EMAIL PROTECTED]> wrote: >> if a host configured with 802.3ad bond mode is connected to a switch >> that does not support 802.3ad, then an aggregator is selected as the >>

Re: [PATCH]: bonding: Fix 802.3ad no carrier on "no partner found" instance

2007-06-01 Thread Jay Vosburgh
Laurent Chavey <[EMAIL PROTECTED]> wrote: >On 5/31/07, Laurent Chavey <[EMAIL PROTECTED]> wrote: >> if a host configured with 802.3ad bond mode is connected to a switch >> that does not support 802.3ad, then an aggregator is selected as the >> active aggregator (first link that has carrier in the

[ICMP]: Fix icmp_errors_use_inbound_ifaddr sysctl

2007-06-01 Thread Patrick McHardy
It seems like you missed this patch in the previous thread discussing the problem, so here's a resend. [ICMP]: Fix icmp_errors_use_inbound_ifaddr sysctl Currently when icmp_errors_use_inbound_ifaddr is set and an ICMP error is sent after the packet passed through ip_output(), an address from the

[PATCH] e1000: disable polling before registering netdevice

2007-06-01 Thread Auke Kok
To assure the symmetry of poll enable/disable in up/down, we should initialize the netdevice to be poll_disabled at load time. Doing this after register_netdevice leaves us open to another race, so lets move all the netif_* calls above register_netdevice so the stack starts out how we expect it to

Re: [PATCH 0/5] VLAN driver API fixes

2007-06-01 Thread Patrick McHardy
Stephen Hemminger wrote: > Patrick's fix for sky2 VLAN unregister, started me looking at > other drivers. Many drivers had bogus kill_vid hooks, and the whole > interface for kill_vid is only useful for devices that do receive > filtering, so fix the interface and the drivers. Looks good too me.

[PATCH 4/5] atl1: eliminate unneeded kill_vid code

2007-06-01 Thread Stephen Hemminger
This driver has unneeded stubs for VLAN filtering. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- drivers/net/atl1/atl1_main.c | 25 + --- drivers/net/atl1/atl1_main.c | 33 + 1 file changed, 1 insertion(+), 32 deletions(-)

[PATCH 5/5] network drivers: eliminate unneeded kill_vid code

2007-06-01 Thread Stephen Hemminger
Many drivers had code that did kill_vid, but they weren't doing vlan filtering. With new API the stub is unneeded unless device sets NETIF_F_HW_VLAN_FILTER. Bad habit: I couldn't resist fixing a couple of nearby style things in acenic, and forcedeth. Signed-off-by: Stephen Hemminger <[EMAIL PROTE

[PATCH 2/5] sky2: Fix VLAN unregistration

2007-06-01 Thread Stephen Hemminger
Fix sky2 disabling VLAN completely when the first vid is unregistered. sky2 disables VLAN completely when the first VID is unregistered. It should instead disable VLAN when the group is unregistered by calling sky2_vlan_rx_register with grp = NULL. Signed-off-by: Patrick McHardy <[EMAIL PROTECTED

[PATCH 3/5] 8139cp: fix VLAN unregistration

2007-06-01 Thread Stephen Hemminger
The 8139cp driver did VLAN unregistration incorrectly. It disables VLAN completely when the first VID is unregistered. It should instead disable VLAN when the group is unregistered by calling cp_vlan_rx_register with a NULL grp. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- drivers/n

[PATCH 0/5] VLAN driver API fixes

2007-06-01 Thread Stephen Hemminger
Patrick's fix for sky2 VLAN unregister, started me looking at other drivers. Many drivers had bogus kill_vid hooks, and the whole interface for kill_vid is only useful for devices that do receive filtering, so fix the interface and the drivers. -- Stephen Hemminger <[EMAIL PROTECTED]> - To unsub

[PATCH 1/5] VLAN: kill_vid is only useful for VLAN filtering devices

2007-06-01 Thread Stephen Hemminger
The interface for network device VLAN extension was confusing. The kill_vid function is only really useful for devices that do hardware filtering. Devices that only do VLAN receiption without filtering were being forced to provide the hook, and there were bugs in those devices. Many drivers had ki

Re: [Cbe-oss-dev] [PATCH 0/2] RFC: PS3 network driver

2007-06-01 Thread Geoff Levand
Christoph Hellwig wrote: > On Fri, Jun 01, 2007 at 02:31:54PM +0900, MOKUNO Masakazu wrote: >> Hi >> >> This is the first submission of the PS3 network driver >> [1] ps3: gigabit ethernet driver for PS3 > > What happened to the idea of incorporating support into spidernet? That is still our goa

[PATCH]: bonding: Fix 802.3ad no carrier on "no partner found" instance

2007-06-01 Thread Laurent Chavey
%diff -ru linux-2.6.21.3/drivers/net/bonding/bond_3ad.c linux-2.6.21.3.new/drivers/net/bonding/bond_3ad.c --- linux-2.6.21.3/drivers/net/bonding/bond_3ad.c 2007-05-24 14:22:47.0 -0700 +++ linux-2.6.21.3.new/drivers/net/bonding/bond_3ad.c 2007-06-01 09:28:07.0 -0700 @@ -2312

Re: [PATCH] NET: add MAINTAINERS entry for ucc_geth driver

2007-06-01 Thread Kim Phillips
On Fri, 25 May 2007 13:54:02 +0800 Li Yang <[EMAIL PROTECTED]> wrote: > Signed-off-by: Li Yang <[EMAIL PROTECTED]> Acked-by: Kim Phillips <[EMAIL PROTECTED]> Kim - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info

Re: [PATCH]: sky2: Fix VLAN unregistration

2007-06-01 Thread Stephen Hemminger
I am working on a multi-driver cleanup patch right now... - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

[TCP]: Honour sk_bound_dev_if in tcp_v4_send_ack

2007-06-01 Thread Patrick McHardy
[TCP]: Honour sk_bound_dev_if in tcp_v4_send_ack A time_wait socket inherits sk_bound_dev_if from the original socket, but it is not used when sending ACK packets using ip_send_reply. Fix by passing the oif to ip_send_reply in struct ip_reply_arg and use it for output routing. Signed-off-by: Pat

Re: [PATCH]: sky2: Fix VLAN unregistration

2007-06-01 Thread Patrick McHardy
Stephen Hemminger wrote: > On Thu, 31 May 2007 19:37:07 +0200 > Patrick McHardy <[EMAIL PROTECTED]> wrote: > > >>Stephen Hemminger wrote: >> >>>On Sun, 27 May 2007 20:44:04 +0200 >>>Patrick McHardy <[EMAIL PROTECTED]> wrote: >>> >>> >>> Fix sky2 disabling VLAN completely when the first vid is

[RFC] [XFRM] SAD only lookup

2007-06-01 Thread jamal
Folks, shit happened and my old hard-drive was whipped containing my old ipsec pktgen patches. I am now trying to recover them. Luckily, this one patch i sent on email - so it was an easy recovery. I know James and Herbert had both commented in the past on this patch. Please look at it again and

Re: [patch 5/7] CAN: Add virtual CAN netdevice driver

2007-06-01 Thread Patrick McHardy
Oliver Hartkopp wrote: > Patrick McHardy wrote: > >>Urs Thuermann wrote: >> >> >>>+/* tx socket reference pointer: Loopback required if not NULL */ >>>+loop = *(struct sock **)skb->cb != NULL; >>> >> >> >>Qdiscs might change skb->cb. Maybe use skb->sk? >> >> > > due to current pro

Re: [IPV4] LVS: Allow to send ICMP unreachable responses when real-servers are removed

2007-06-01 Thread KOVACS Krisztian
Hi, On Friday 01 June 2007 01:18, Julian Anastasov wrote: > What about something like this, it even reduces checks > in the fast path. You can post new version if the following change > looks good to you and to other developers. If additional sign line is > needed here it is: > > Signed-o

Re: Suspicious fackets_out handling

2007-06-01 Thread Ilpo Järvinen
On Thu, 31 May 2007, David Miller wrote: > From: "Ilpo_Järvinen" <[EMAIL PROTECTED]> > Date: Mon, 23 Apr 2007 14:28:21 +0300 (EEST) > > > There are IMHO two problems in it. First of all, nothing ensures that the > > skb TCP is fragmenting is actually below the forwardmost sack block (and > > th

Re: [Oops] unix_dgram_connect locking problem?

2007-06-01 Thread Frederik Deweerdt
On Thu, May 31, 2007 at 03:22:27PM -0700, David Miller wrote: > From: Frederik Deweerdt <[EMAIL PROTECTED]> > Date: Fri, 11 May 2007 17:00:14 +0200 > > > I'm seeing an Oops[1] with a 2.6.19.2 kernel: > > Frederik, I finally was able to spend some quality time on > this issue today. Sorry for tak

Re: [PATCH 2/5] NetXen: Multicast filter for NetXen driver

2007-06-01 Thread Michael Buesch
On Friday 01 June 2007 13:14:35 Mithlesh Thukral wrote: > NetXen: Add multicast filter code > This patch will add manage the multicast filter from driver. > It will add capability to write multicast addresses to hardware. > > Signed-by: Mithlesh Thukral <[EMAIL PROTECTED]> > --- > > drivers/net/

Re: [PATCH] [TCP]: Fix GSO ignorance of pkts_acked arg (cong.cntrl modules)

2007-06-01 Thread Ilpo Järvinen
On Thu, 31 May 2007, David Miller wrote: > From: "Ilpo_Järvinen" <[EMAIL PROTECTED]> > Date: Wed, 30 May 2007 12:10:06 +0300 (EEST) > > > [PATCH] [TCP]: Fix GSO ignorance of pkts_acked arg (cong.cntrl modules) > > > > The code used to ignore GSO completely, passing either way too > > small or ze

[PATCH 4/5] NetXen: Fix ping issue

2007-06-01 Thread Mithlesh Thukral
NetXen: Fix initialization and subsequent ping issue This patch will fix the initialization and ping issues seen on certain PPC architecture blades. Signed-off by: Wen Xiong <[EMAIL PROTECTED]> Signed-off by: Mithlesh Thukral <[EMAIL PROTECTED]> --- drivers/net/netxen/netxen_nic_main.c |7 ++

[PATCH 5/5] NetXen: Fix link status messages

2007-06-01 Thread Mithlesh Thukral
NetXen: Correct link status messages. This patch will fix the problem of wrong link status messages that were reported. Signed-off by: Wen Xiong <[EMAIL PROTECTED]> Signed-off by: Mithlesh Thukral <[EMAIL PROTECTED]> --- drivers/net/netxen/netxen_nic.h |1 + drivers/net/netxen/netxen_n

[PATCH 3/5] NetXen: Add NETXEN prefix to macros

2007-06-01 Thread Mithlesh Thukral
NetXen: Add NETXEN prefix to a macro This patch will add the "NETXEN" prefix to "USER_START" macro. Signed-off by: Wen Xiong <[EMAIL PROTECTED]> Signed-off by: Mithlesh Thukral <[EMAIL PROTECTED]> --- drivers/net/netxen/netxen_nic.h |4 ++-- drivers/net/netxen/netxen_nic_ethtool.c |

[PATCH 2/5] NetXen: Multicast filter for NetXen driver

2007-06-01 Thread Mithlesh Thukral
NetXen: Add multicast filter code This patch will add manage the multicast filter from driver. It will add capability to write multicast addresses to hardware. Signed-by: Mithlesh Thukral <[EMAIL PROTECTED]> --- drivers/net/netxen/netxen_nic.h | 24 + drivers/net/netxen/netxen_nic_hdr.

[PATCH 1/5] NetXen: Removal of extra free_irq call

2007-06-01 Thread Mithlesh Thukral
NetXen: Removal of redundant free_irq This patch removes a redundant free_irq() call from remove() routine. This will also eliminate a warning during unload of driver. Signed-by: Mithlesh Thukral <[EMAIL PROTECTED]> --- drivers/net/netxen/netxen_nic_main.c |2 -- 1 files changed, 2 deletions

[PATCH 0/5] NetXen: Bug fixes and updates

2007-06-01 Thread Mithlesh Thukral
Hi All, I will be sending bug fixes and updates to NetXen's 1/10G Ethernet driver in subsequent mails. These patches are wrt netdev#master. Regards, Mithlesh Thukral - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo in

Re: [PATCH 0/2] RFC: PS3 network driver

2007-06-01 Thread Christoph Hellwig
On Fri, Jun 01, 2007 at 02:31:54PM +0900, MOKUNO Masakazu wrote: > Hi > > This is the first submission of the PS3 network driver > [1] ps3: gigabit ethernet driver for PS3 What happened to the idea of incorporating support into spidernet? - To unsubscribe from this list: send the line "unsubscr

[PATCH 0/2] RFC: PS3 network driver

2007-06-01 Thread MOKUNO Masakazu
Hi This is the first submission of the PS3 network driver [1] ps3: gigabit ethernet driver for PS3 [2] ps3: add wireless LAN support for PS3 They are submitted for review since some of the underlying infrastructure code hasn't been submitted yet. For reference, you can take a look at Geoff's gi