Re: forcedeth: Reside in 100Mbit Kconfig but also supports 1000Mbit cards

2007-05-28 Thread Krzysztof Halasa
Stefan Schmidt <[EMAIL PROTECTED]> writes: > I still like the partition by speed. Me 2 > It makes it a lot easier to find > the right driver in the bunch of available ones. Sure. Unless you have a 100 Mb/s card and you don't know the same driver works with newer 1000 Mb/s models. IOW - questio

Re: [PATCH 10/12] drivers: PMC MSP71xx ethernet driver

2007-05-28 Thread Jeff Garzik
Marc St-Jean wrote: Jeff Garzik wrote: Marc St-Jean wrote: > + res = platform_get_resource(pldev, IORESOURCE_MEM, 0); > + if (!res) { > + printk(KERN_ERR "MSPETH(probe) %s: " > + "IOMEM resource not found for eth%d\n", > + dev->nam

Re: [ipvs] BUG: soft lockup detected on CPU#3!

2007-05-28 Thread Horms
On Mon, May 28, 2007 at 04:20:32PM +0200, Sebastien Estienne wrote: > On 5/28/07, Horms <[EMAIL PROTECTED]> wrote: > >On Sat, May 26, 2007 at 11:22:40AM +0900, Horms wrote: > >> On Fri, May 25, 2007 at 09:30:52AM +, Sebastien Estienne wrote: > >> > > >> > I didn't try 2.6.21 yet, but using ubun

Re: [PATCH 4/7 RESEND] cxgb3 - Update FW to 4.1

2007-05-28 Thread Jeff Garzik
[EMAIL PROTECTED] wrote: From: Divy Le Ray <[EMAIL PROTECTED]> Bump FW version to 4.1. Modify chip tuning in consequence. Signed-off-by: Divy Le Ray <[EMAIL PROTECTED]> --- drivers/net/cxgb3/regs.h|4 drivers/net/cxgb3/t3_hw.c | 40 ++-- dr

Re: [PATCH 3/7] cxgb3 - Fix direct XAUI support

2007-05-28 Thread Jeff Garzik
[EMAIL PROTECTED] wrote: From: Divy Le Ray <[EMAIL PROTECTED]> Check all lanes for link status on direct XAUI cards. Don't assume that direct XAUI always uses XGMAC 1. Signed-off-by: Divy Le Ray <[EMAIL PROTECTED]> --- drivers/net/cxgb3/ael1002.c | 10 -- drivers/net/cxgb3/regs.h

Re: [PATCH 2/7] cxgb3 - fix netpoll hanlder

2007-05-28 Thread Jeff Garzik
[EMAIL PROTECTED] wrote: From: Divy Le Ray <[EMAIL PROTECTED]> Fix netpoll handler to work with line interrupt, msi and msi-x. Signed-off-by: Divy Le Ray <[EMAIL PROTECTED]> --- drivers/net/cxgb3/cxgb3_main.c | 12 +--- drivers/net/cxgb3/sge.c|1 - 2 files changed, 9 ins

Re: [PATCH 1/7] cxgb3 - Fix SGE page management

2007-05-28 Thread Jeff Garzik
[EMAIL PROTECTED] wrote: From: Divy Le Ray <[EMAIL PROTECTED]> Streamline page management on RX. Fix dma mappings. Signed-off-by: Divy Le Ray <[EMAIL PROTECTED]> NAK #1: "streamline" is not a bug-fixes-only change, which is the only type of change appropriate for 2.6.22-rc. NAK #2: You s

Re: IFF_PROMISC again

2007-05-28 Thread Martín Ferrari
Stephen, On 5/28/07, Stephen Hemminger <[EMAIL PROTECTED]> wrote: > Great that you point it out. Then, we're back to the initial > situation, there is no reliable way of polling promisc state, and I am > looking for a way to do that. Ways I think it could be done: Back to the original question

Re: [PCNET32] Lock solid with netconsole

2007-05-28 Thread Francois Romieu
Thomas Bogendoerfer <[EMAIL PROTECTED]> : [...] > for normal interrupt delivery it doesn't matter, because there shouldn't > be any more interrupts coming in at that point. But netconsole uses > pcnet32_interrupt for polling the chip. So if during service of a > a real interrupt a polled pcnet32_in

Re: [PATCH 10/12] drivers: PMC MSP71xx ethernet driver

2007-05-28 Thread Marc St-Jean
Jeff, thanks for the feedback. If dropped your comments for the sections I've either already implemented or will be doing shortly. The remaining comments are below to help clarify the code in question or if I didn't understand your comment. Marc Jeff Garzik wrote: > Marc St-Jean wrote: > > [PATC

Re: b44: regression in 2.6.22 (resend)

2007-05-28 Thread Thomas Gleixner
On Mon, 2007-05-28 at 22:55 +0200, Maximilian Engelhardt wrote: > > > I additionally built my 2.6.22-rc2-mm1 kernel without High Resolution > > > Timer, but the high ping problem is still there. > > > > Hmm, that's mysterious. Wild guess is that highres exposes the hidden > > "feature" in a differe

Re: [SKY2]: Fix VLAN unregistration

2007-05-28 Thread Ben Greear
Patrick McHardy wrote: Fix sky2 disabling VLAN completely when the first vid is unregistered. For some reason the VLAN code insists on the driver providing a vlan_rx_kill_vid function even if only NETIF_F_HW_VLAN_RX and not NETIF_F_HW_VLAN_FILTER is set, so this patch keeps an empty function. Th

Re: r8169 in 2.6.18 silently corrupting data, 2.6.22-rc3 link not detected at all

2007-05-28 Thread Francois Romieu
Andrew Paprocki <[EMAIL PROTECTED]> : [...] > The align errors in ethtool show up even in the "working" 2.6.18. > Could this be related to the fact that other hosts on this gigabit > network run with a 9000 MTU ? I saw that this chipset has a hardware > limitation and the drivers caps off at 7200..

"[IPV6]: Fix routing round-robin locking." breaks manual default route (bug 8349)

2007-05-28 Thread Simon Arlott
Initial state - address, no routes: # ip -6 a 2: eth0: mtu 1500 qlen 1000 inet6 2001:4b10:1005:0:202:44ff:fe50:91af/64 scope global valid_lft forever preferred_lft forever inet6 fe80::202:44ff:fe50:91af/64 scope link valid_lft forever preferred_lft forever # ip -6 r fe80::/64 de

Re: [PCNET32] Lock solid with netconsole

2007-05-28 Thread Francois Romieu
Lennart Sorensen <[EMAIL PROTECTED]> : [...] > Hmm, I have been seeing lockups too and asked about doing something > almost exactly the same as this recently, but was told that it shouldn't > need irqs disabled at this point. Yes. The patch should not be needed. OTOH, it is still interesting to k

Re: b44: regression in 2.6.22 (resend)

2007-05-28 Thread Maximilian Engelhardt
On Monday 28 May 2007, Thomas Gleixner wrote: > On Mon, 2007-05-28 at 19:44 +0200, Maximilian Engelhardt wrote: > > > Can you please keep CONFIG_HIGH_RES_TIMERS and CONFIG_NOHZ and try the > > > following combinations on the kernel command line: > > > > > > 1) highres=off nohz=off (should be the sa

Re: [PCNET32] Lock solid with netconsole

2007-05-28 Thread Thomas Bogendoerfer
On Mon, May 28, 2007 at 02:31:48PM -0400, Lennart Sorensen wrote: > On Mon, May 28, 2007 at 05:25:51PM +0200, Emmanuel Fust? wrote: > > > Any difference if you disable the debug messages in the pcnet32 > > > driver and you apply the patch below ? > > > > > > diff --git a/drivers/net/pcnet32.c b/dr

Re: r8169 in 2.6.18 silently corrupting data, 2.6.22-rc3 link not detected at all

2007-05-28 Thread Andrew Paprocki
I will check your patch against what I already grabbed from 2.6.22-rc2-mm1. I had already booted into the new kernel and captured all the info I could.. no luck. I see that all of your recent changes are in the mm1 driver, but I'll see if the patch link you dumped has anything new. I'll get the o

Re: r8169 in 2.6.18 silently corrupting data, 2.6.22-rc3 link not detected at all

2007-05-28 Thread Francois Romieu
Andrew Paprocki <[EMAIL PROTECTED]> : [...] > This struck me as strange, so I checked and it is directly connected > to the MAC addr of the ethernet card: 00:0c:76:ae:b5:16 > > I figured that a newer kernel might fix this issue, so I built > 2.6.22-rc3 and under that kernel the r8169 device doesn'

Re: b44: regression in 2.6.22 (resend)

2007-05-28 Thread Thomas Gleixner
On Mon, 2007-05-28 at 19:44 +0200, Maximilian Engelhardt wrote: > > Can you please keep CONFIG_HIGH_RES_TIMERS and CONFIG_NOHZ and try the > > following combinations on the kernel command line: > > > > 1) highres=off nohz=off (should be the same as your working config) > > 2) highres=off > > 3) noh

Re: [PCNET32] Lock solid with netconsole

2007-05-28 Thread Lennart Sorensen
On Mon, May 28, 2007 at 05:25:51PM +0200, Emmanuel Fust? wrote: > > Any difference if you disable the debug messages in the pcnet32 > > driver and you apply the patch below ? > > > > diff --git a/drivers/net/pcnet32.c b/drivers/net/pcnet32.c > > index 9c171a7..be4513f 100644 > > --- a/drivers/net/

r8169 in 2.6.18 silently corrupting data, 2.6.22-rc3 link not detected at all

2007-05-28 Thread Andrew Paprocki
I've installed a Debian lenny test DVD onto a system with two r8169 devices, and the default 2.6.18 kernel that comes with the install DVD causes silent data corruption! The network appears to be working fine, but if you attempt to transfer any sizable amount of data (a 10meg file of /dev/zero, fo

Re: b44: regression in 2.6.22 (resend)

2007-05-28 Thread Maximilian Engelhardt
On Monday 28 May 2007, Thomas Gleixner wrote: > On Mon, 2007-05-28 at 17:14 +0200, Michael Buesch wrote: > > > The -oldconfig1 is the kernel that had no problems and the other shows > > > the b44 problem. So if High Resolution Timer Support is disabled > > > everything works fine and if I enable it

Re: b44: regression in 2.6.22 (resend)

2007-05-28 Thread Michael Buesch
On Monday 28 May 2007 17:32:51 Thomas Gleixner wrote: > On Mon, 2007-05-28 at 17:14 +0200, Michael Buesch wrote: > > > The -oldconfig1 is the kernel that had no problems and the other shows > > > the b44 > > > problem. So if High Resolution Timer Support is disabled everything works > > > fine a

Re: b44: regression in 2.6.22 (resend)

2007-05-28 Thread Thomas Gleixner
On Mon, 2007-05-28 at 17:14 +0200, Michael Buesch wrote: > > The -oldconfig1 is the kernel that had no problems and the other shows the > > b44 > > problem. So if High Resolution Timer Support is disabled everything works > > fine and if I enable it the problems do appear again. > > > > I didn'

Re: [PCNET32] Lock solid with netconsole

2007-05-28 Thread Emmanuel Fusté
> Any difference if you disable the debug messages in the pcnet32 > driver and you apply the patch below ? > > diff --git a/drivers/net/pcnet32.c b/drivers/net/pcnet32.c > index 9c171a7..be4513f 100644 > --- a/drivers/net/pcnet32.c > +++ b/drivers/net/pcnet32.c > @@ -2556,11 +2556,12 @@ pcnet32_in

Re: b44: regression in 2.6.22 (resend)

2007-05-28 Thread Michael Buesch
On Monday 28 May 2007 16:09:46 Maximilian Engelhardt wrote: > On Monday 28 May 2007, Michael Buesch wrote: > > Can you give 2.6.16 a try? The diff is not that big and we might > > be able to find out what broke if you find out 2.6.16 works. > > You can also try later kernels like .17, .18, .19 to f

Re: b44: regression in 2.6.22 (resend)

2007-05-28 Thread Michael Buesch
On Monday 28 May 2007 16:12:12 Maximilian Engelhardt wrote: > On Monday 28 May 2007, Michael Buesch wrote: > > Can you also test the following patch? > > I think there's a bug in b44 that is doesn't properly discard > > shared IRQs, so it might possibly generate a NAPI storm, dunno. > > Worth a try

Re: [ipvs] BUG: soft lockup detected on CPU#3!

2007-05-28 Thread Sebastien Estienne
On 5/28/07, Horms <[EMAIL PROTECTED]> wrote: On Sat, May 26, 2007 at 11:22:40AM +0900, Horms wrote: > On Fri, May 25, 2007 at 09:30:52AM +, Sebastien Estienne wrote: > > > > I didn't try 2.6.21 yet, but using ubuntu dapper kernel (2.6.15) i > > can't reproduce the bug. > > When i was using fe

Re: b44: regression in 2.6.22 (resend)

2007-05-28 Thread Maximilian Engelhardt
On Monday 28 May 2007, Michael Buesch wrote: > Can you also test the following patch? > I think there's a bug in b44 that is doesn't properly discard > shared IRQs, so it might possibly generate a NAPI storm, dunno. > Worth a try. > > Index: linux-2.6.22-rc3/drivers/net/b44.c >

Re: b44: regression in 2.6.22 (resend)

2007-05-28 Thread Maximilian Engelhardt
On Monday 28 May 2007, Michael Buesch wrote: > Can you give 2.6.16 a try? The diff is not that big and we might > be able to find out what broke if you find out 2.6.16 works. > You can also try later kernels like .17, .18, .19 to further > reduce the patch. (You could also git-bisect, if you have t

Re: Generic netlink interface help

2007-05-28 Thread Samuel Ortiz
On Sun, May 27, 2007 at 07:47:59PM +0200, Rodolfo Giometti wrote: > On Sun, May 27, 2007 at 03:54:30PM +0200, Johannes Berg wrote: > > > It's written in python without using libnl: > > http://git.sipsolutions.net/pynl80211.git > > If I well understand I should do something like this: > > s

Feedback on AX88796 driver

2007-05-28 Thread Ben Dooks
I posted [1] an driver for the Asix AX88796 network controller a while back, and have had no feedback. Is this driver suitable for submission for the next kernel window, or is there anything that needs to be done for it? If it is, then is jgarzik the right person to send this patch to, or is there

Re: b44: regression in 2.6.22 (resend)

2007-05-28 Thread Michael Buesch
Can you also test the following patch? I think there's a bug in b44 that is doesn't properly discard shared IRQs, so it might possibly generate a NAPI storm, dunno. Worth a try. Index: linux-2.6.22-rc3/drivers/net/b44.c === --- linux-

[PATCH] merge dst_discard in & out into one, this decrements the vmlinux image by 21 bytes under i386 arch.

2007-05-28 Thread rae l
On 5/28/07, Jan Engelhardt <[EMAIL PROTECTED]> wrote: Uhm, just replace every invocation of dst_discard_in/_out() directly by dst_discard ... don't add macros for that. so that, the trival patch changed to this: because the definition of dst_discard_in and dst_discard_out are the same, so they

Re: [PATCH 0/9]: tcp-2.6 patchset

2007-05-28 Thread Ilpo Järvinen
On Sun, 27 May 2007, Ilpo Järvinen wrote: > On Sun, 27 May 2007, Baruch Even wrote: > > > * Ilpo J?rvinen <[EMAIL PROTECTED]> [070527 14:16]: > > > > > > Thus, my original question basically culminates in this: should cc > > > modules be passed number of packets acked or number of skbs acked? >

Re: b44: regression in 2.6.22 (resend)

2007-05-28 Thread Michael Buesch
Can you give 2.6.16 a try? The diff is not that big and we might be able to find out what broke if you find out 2.6.16 works. You can also try later kernels like .17, .18, .19 to further reduce the patch. (You could also git-bisect, if you have the time). git-diff v2.6.16..v2.6.22-rc3 drivers/net/

Re: [PATCH] merge dst_discard in & out into one, this decrements the vmlinux image by 21 bytes under i386 arch.

2007-05-28 Thread Jan Engelhardt
On May 28 2007 10:41, rae l wrote: > > diff --git a/net/core/dst.c b/net/core/dst.c > index 764bccb..daa0439 100644 > --- a/net/core/dst.c > +++ b/net/core/dst.c > @@ -111,17 +111,14 @@ out: > spin_unlock(&dst_lock); > } > > -static int dst_discard_in(struct sk_buff *skb) > +static int dst_di

Re: [ipvs] BUG: soft lockup detected on CPU#3!

2007-05-28 Thread Horms
On Sat, May 26, 2007 at 11:22:40AM +0900, Horms wrote: > On Fri, May 25, 2007 at 09:30:52AM +, Sebastien Estienne wrote: > > > > I didn't try 2.6.21 yet, but using ubuntu dapper kernel (2.6.15) i > > can't reproduce the bug. > > When i was using feisty kernel (2.6.20), i can reproduce in less

RE: [PATCH 2/5] phylib: enable RGMII-ID on the Marvell m88e1111 PHY

2007-05-28 Thread Li Yang-r58472
> -Original Message- > From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] On > Behalf Of Kim Phillips > Sent: Saturday, May 12, 2007 7:25 AM > To: Jeff Garzik; netdev@vger.kernel.org > Subject: [PATCH 2/5] phylib: enable RGMII-ID on the Marvell m88e PHY > > Support for configuring RGMII

Re: Generic netlink interface help

2007-05-28 Thread Rodolfo Giometti
On Mon, May 28, 2007 at 04:42:47AM +0300, Samuel Ortiz wrote: > > > > Is that right? > At first glance, this could work yes. Great! Now I have only to write the userland tool. :) > However, it seems you're trying to encapsulate your pps_netlink_msg into > a generic netlink message which itself i

Re: EIP is at netlink_insert+0x41/0x10c

2007-05-28 Thread David Miller
From: Andrew Morton <[EMAIL PROTECTED]> Date: Sun, 27 May 2007 23:52:34 -0700 > I wonder how /bin/init got to run netlink stuff. glibc uses it, but I don't think init does anything which would make use of those features. - To unsubscribe from this list: send the line "unsubscribe netdev" in the b