> > We're trying to track down the source of a problem that occurs
> > whenever the atl1 network driver is activated on a 32-bit 2.6.21-rc4
>
> and -rc5, -rc6, 2.6.20.x, 2.6.19.3, and probably others.
>
> > We can load the driver just fine, but whenever we activate the
> > network, we see APIC er
On Fri, May 11, 2007 at 08:36:52PM -0400, Jeff Garzik wrote:
> Linas Vepstas wrote:
> >
> >I've also got a multi-month old s2io patch that's in limbo. It was
> >ack'ed by an s2io maintainer, but otherwise fell through the cracks.
> >If you can find it and apply it, great, otherwise I'll resubmit
>
Linas Vepstas wrote:
On Fri, May 11, 2007 at 04:56:28PM -0400, Jeff Garzik wrote:
applied.
Thanks.
Please move comments that do not belong in the permanent
record BELOW the "---". See Documentation/SubmittingPatches for more info.
oops, sorry.
--linas
I've also got a multi-month old s2
On Fri, May 11, 2007 at 04:56:28PM -0400, Jeff Garzik wrote:
>
> applied.
Thanks.
> Please move comments that do not belong in the permanent
> record BELOW the "---". See Documentation/SubmittingPatches for more info.
oops, sorry.
--linas
I've also got a multi-month old s2io patch that's
From: Kapil Juneja <[EMAIL PROTECTED]>
Add code for initialising and configuring TBI interface and
programming it for connecting to on-chip SERDES (Lynx PHY)
in case of SGMII mode selected through HRCW at reset.
also add defines for TBI register configuration. TBI
interface is programmed towards
From: Kapil Juneja <[EMAIL PROTECTED]>
If connected via SGMII, initialize with SGMII mode configured.
Signed-off-by: Kapil Juneja <[EMAIL PROTECTED]>
Signed-off-by: Andy Fleming <[EMAIL PROTECTED]>
Signed-off-by: Kim Phillips <[EMAIL PROTECTED]>
---
drivers/net/phy/marvell.c | 16 +
From: Michael Barkowski <[EMAIL PROTECTED]>
The ICPlus IP175C sports a 100Mbit/s 4-port switch in addition
to a dedicated 100Mbit/s WAN port.
Signed-off-by: Michael Barkowski <[EMAIL PROTECTED]>
Signed-off-by: Kim Phillips <[EMAIL PROTECTED]>
---
RESEND of missed from last series submitted, this
Support for configuring RGMII-ID (RGMII with internal delay) mode on the
88e and 88e1145.
Also renamed 88es -> 88e (no references to an 88es part were
found), and fixed some whitespace.
Signed-off-by: Kim Phillips <[EMAIL PROTECTED]>
---
drivers/net/phy/marvell.c | 62 +
It was agreed that phy-connection-type was a better name for
the interface-type property, so this patch renames it.
Also, the max-speed property name was determined too generic,
and is therefore eliminated in favour of phy-connection-type
derivation logic.
includes corrections to copyright text.
On Fri, 2007-11-05 at 15:01 -0700, Waskiewicz Jr, Peter P wrote:
> The current requeue calls in qdisc_restart() returns a value of 1 to the
> upper layer.
Which was not meaningful ;->
i.e qdisc run would break as a result.
Note, this is still in conformance with net-2.6 based on a change in the
> Ok, booting fine to me;
> if you receive this email, it must have worked. OTOH, if you
> didnt receive this it probably failed ;-> (as the presenter
> said "if you cant hear me in the far corner please raise your hand").
>
> clip away ...
+static inline int
+handle_dev_requeue(struct sk_buff *sk
On Fri, 11 May 2007 23:32:08 +0200 (MEST)
Jan Engelhardt <[EMAIL PROTECTED]> wrote:
>
> On May 11 2007 16:57, Jeff Garzik wrote:
> >>
> >> CONFIG_NETDEVICES, CONFIG_NET_ETHERNET:
> >> Change Kconfig objects from "menu, config" into "menuconfig" so
> >> that the user can disable the whole feature
On May 11 2007 16:57, Jeff Garzik wrote:
>>
>> CONFIG_NETDEVICES, CONFIG_NET_ETHERNET:
>> Change Kconfig objects from "menu, config" into "menuconfig" so
>> that the user can disable the whole feature without having to
>> enter the menu first.
>>
>> CONFIG_SMC9194:
>> Move it so that it appears
[EMAIL PROTECTED] wrote:
+/* pointers to maintain transmit list */
+static struct net_dma_desc_tx *tx_list_head;
+static struct net_dma_desc_tx *tx_list_tail;
+static struct net_dma_desc_rx *rx_list_head;
+static struct net_dma_desc_rx *rx_list_tail;
+static struct net_dma_desc_rx *current_rx_ptr
On Fri, 11 May 2007 14:03:09 -0700 (PDT)
David Miller <[EMAIL PROTECTED]> wrote:
> From: Jeff Garzik <[EMAIL PROTECTED]>
> Date: Fri, 11 May 2007 16:57:19 -0400
>
> > applied
>
> I was under the impression that this patch didn't actually fix the
> problem yet? I might be thinking about somethin
From: Jeff Garzik <[EMAIL PROTECTED]>
Date: Fri, 11 May 2007 16:57:19 -0400
> applied
I was under the impression that this patch didn't actually fix the
problem yet? I might be thinking about something else...
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a m
John W. Linville wrote:
The following changes since commit 1f8a6b658a943b4f04a1fc7b3a420360202c86cd:
Linus Torvalds (1):
Merge git://git.kernel.org/.../bunk/trivial
are found in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/linville/wireless-2.6.git
libertas
Kim Phillips wrote:
From: Michael Barkowski <[EMAIL PROTECTED]>
The ICPlus IP175C sports a 100Mbit/s 4-port switch in addition
to a dedicated 100Mbit/s WAN port.
Signed-off-by: Michael Barkowski <[EMAIL PROTECTED]>
Signed-off-by: Kim Phillips <[EMAIL PROTECTED]>
---
v2: adjusted to read PHY re
Kim Phillips wrote:
Distinguish between the Davicom DM9161A PHY and the DM9161E.
Signed-off-by: Kim Phillips <[EMAIL PROTECTED]>
---
resend of the one of six in the series Jeff didn't receive.
note that when there is a problem, I drop the entire patch series. This
is ALWAYS how it's been don
Stephen Hemminger wrote:
If the device is fails during module startup for some reason like
unsupported chip version then the driver would crash dereferencing a
null pointer, on shutdown or suspend/resume.
Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]>
---
drivers/net/sky2.c | 10 ++
[EMAIL PROTECTED] wrote:
From: Jan Engelhardt <[EMAIL PROTECTED]>
CONFIG_NETDEVICES, CONFIG_NET_ETHERNET:
Change Kconfig objects from "menu, config" into "menuconfig" so
that the user can disable the whole feature without having to
enter the menu first.
CONFIG_SMC9194:
Move it so that it appear
[EMAIL PROTECTED] wrote:
From: Jan Engelhardt <[EMAIL PROTECTED]>
Change Kconfig objects from "menu, config" into "menuconfig" so
that the user can disable the whole feature without having to
enter the menu first.
Signed-off-by: Jan Engelhardt <[EMAIL PROTECTED]>
Cc: Jeff Garzik <[EMAIL PROTECT
[EMAIL PROTECTED] wrote:
From: Jan Engelhardt <[EMAIL PROTECTED]>
Use menuconfigs instead of menus, so the whole menu can be disabled at once
instead of going through all options.
Signed-off-by: Jan Engelhardt <[EMAIL PROTECTED]>
Cc: Jeff Garzik <[EMAIL PROTECTED]>
Signed-off-by: Andrew Morton
applied
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Linas Vepstas wrote:
Jeff, please apply for 2.6.22; This is a purely janitorial patch.
(I will have additonal patches for the spidernet in a few days;
I'm still debugging a rather nasty hang.)
--linas
From: Ishizaki Kou <[EMAIL PROTECTED]>
This patch removes unnecessary accesses to phy regi
Sreenivasa Honnur wrote:
Adding get_ringparam ethtool option.
Signed-off-by: Sreenivasa Honnur <[EMAIL PROTECTED]>
applied 1-3
Please send follow-up patch that removes braces around single C statements:
+ for (i = 0 ; i < sp->config.tx_fifo_num ; i++) {
+ tx_desc_count +
[EMAIL PROTECTED] wrote:
From: Jan Engelhardt <[EMAIL PROTECTED]>
Make a "menuconfig" out of the Kconfig objects "menu, ..., endmenu",
so that the user can disable all the options in that menu at once
instead of having to disable each option separately.
Signed-off-by: Jan Engelhardt <[EMAIL PRO
Michael Chan wrote:
Add 2.5G Serdes support to ethtool user program and ethtool.8 man
page. The missing pause bits are also added to keep ethtool-copy.h
in sync with the kernel's version.
Signed-off-by: Michael Chan <[EMAIL PROTECTED]>
applied
-
To unsubscribe from this list: send the line
The following changes since commit 1f8a6b658a943b4f04a1fc7b3a420360202c86cd:
Linus Torvalds (1):
Merge git://git.kernel.org/.../bunk/trivial
are found in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/linville/wireless-2.6.git
libertas
Dan Williams (19):
On Fri, 2007-11-05 at 11:46 -0700, Waskiewicz Jr, Peter P wrote:
> Clippers are standing by. :)
Nothing as nice as time off to code away;->
Ok, booting fine to me;
if you receive this email, it must have worked. OTOH, if you didnt
receive this it probably failed ;->
(as the presenter said "if
The network device frontend driver allows the kernel to access network
devices exported exported by a virtual machine containing a physical
network device driver.
Signed-off-by: Jeremy Fitzhardinge <[EMAIL PROTECTED]>
Signed-off-by: Chris Wright <[EMAIL PROTECTED]>
Cc: Ian Pratt <[EMAIL PROTECTE
Hi Yoshifuji-san
YOSHIFUJI Hideaki / 吉藤英明 wrote:
> The "fix" for emerging security threats was overkill and it broke
> basic semantic of IPv6 routing header processing. We should assume
> RT0 (or even RT2, depends on configuration) as "unknown" RH type so
> that we
> - silently ignore the routing
> For lockless drivers, I think it could be moved up; only
> thing is nothing is stopping it from changing again at transmit time.
> For drivers that are not lockless, i am wondering if its even
> useful to have that check given we have already grabbed the tx lock.
Good point. I live in an LLTX
On Fri, 2007-11-05 at 11:13 -0700, Waskiewicz Jr, Peter P wrote:
> After thinking about this a bit more: even if the queue is stopped,
> you'd end up requeueing anyways. Plus, you'd need to re-acquire
> dev->queue_lock (which is what happens today). I think the best way
> overall would be to che
Use DMI to add a blacklist of broken boards (so far only one).
Hopefully, the problems will be solved later, and the the whole
blacklist can disappear.
Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]>
---
drivers/net/sky2.c | 41 ++---
1 file changed, 30
The driver is not ready to support 88e8071 chip.
If this chip is present, system will hang on boot.
So remove it from PCI device id's for now.
Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]>
---
drivers/net/sky2.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- sky2-2.6.21.o
If device is not fails during module startup (like unsupported chip
version) then driver would crash dereferencing a null pointer, on shutdown
or suspend/resume.
Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]>
---
drivers/net/skge.c |9 +
1 file changed, 9 insertions(+)
--- sky
These are all bug fixes for 2.6.22. I'll spin a set for the
2.6.21 stable kernel after that.
--
Stephen Hemminger <[EMAIL PROTECTED]>
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/m
If the device is fails during module startup for some reason like
unsupported chip version then the driver would crash dereferencing a
null pointer, on shutdown or suspend/resume.
Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]>
---
drivers/net/sky2.c | 10 ++
1 file changed, 10 in
Hirokazu Takahashi wrote:
> I think the concept of TBF is quit good but the userspace tools have
> become old that it doesn't fit to Gb ethernet environment.
> The tools should be updated to care about much faster network and
> GbE jumbo frames. I agree with you at this point.
>
> On the other han
On Fri, 2007-11-05 at 19:01 +0200, Thomas Graf wrote:
> * jamal <[EMAIL PROTECTED]> 2007-05-10 20:13
> > * Compute the worst case header length according to the protocols
> > diff --git a/net/sched/sch_generic.c b/net/sched/sch_generic.c
> > index f28bb2d..b821040 100644
> > --- a/net/sched/sch_
> On Fri, 2007-11-05 at 08:56 -0700, Waskiewicz Jr, Peter P wrote:
>
> > In qdisc_restart(), you removed any check for if
> > (!netif_queue_stopped(dev)) before calling
> dev_hard_start_xmit(). If
> > the underlying queue is stopped and you send the skb,
> you'll generate
> > a requeue. Is t
On Fri, 2007-11-05 at 08:56 -0700, Waskiewicz Jr, Peter P wrote:
> In qdisc_restart(), you removed any check for if
> (!netif_queue_stopped(dev)) before calling dev_hard_start_xmit(). If
> the underlying queue is stopped and you send the skb, you'll generate a
> requeue. Is there a reason it was
* jamal <[EMAIL PROTECTED]> 2007-05-10 20:13
> diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h
> index f671cd2..718d6fd 100644
> --- a/include/linux/netdevice.h
> +++ b/include/linux/netdevice.h
> @@ -83,6 +83,9 @@ struct wireless_dev;
> #define NETDEV_TX_OK 0 /* d
* YOSHIFUJI Hideaki / 吉藤英明 ([EMAIL PROTECTED]) wrote:
> Chris, I think it is okay, but
> please wait for Dave's approval.
Alright, will do.
thanks,
-chris
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http
In article <[EMAIL PROTECTED]> (at Fri, 11 May 2007 09:22:43 -0700), Chris
Wright <[EMAIL PROTECTED]> says:
> * YOSHIFUJI Hideaki / 吉藤英明 ([EMAIL PROTECTED]) wrote:
> > The "fix" for emerging security threats was overkill and it broke
> > basic semantic of IPv6 routing header processing. We shoul
* YOSHIFUJI Hideaki / 吉藤英明 ([EMAIL PROTECTED]) wrote:
> The "fix" for emerging security threats was overkill and it broke
> basic semantic of IPv6 routing header processing. We should assume
> RT0 (or even RT2, depends on configuration) as "unknown" RH type so
> that we
> - silently ignore the rou
On Fri, 11 May 2007 14:40:45 +0900
Kenji Kaneshige <[EMAIL PROTECTED]> wrote:
> Hi,
>
> I encountered the following error when I was hot-plugging network card
> using pci hotplug driver.
>
> kobject_add failed for eth8 with -EEXIST, don't try to register things with
> the same name in the same
In article <[EMAIL PROTECTED]> (at Sat, 12 May 2007 01:10:04 +0900), Mitsuru
Chinen <[EMAIL PROTECTED]> says:
> [IPV4] SNMP: Display new statistics at /proc/net/netstat
>
> This displays the statistics specified in the updated IP-MIB RFC
> (RFC4293) in /proc/net/netstat. The reason why these are
The "fix" for emerging security threats was overkill and it broke
basic semantic of IPv6 routing header processing. We should assume
RT0 (or even RT2, depends on configuration) as "unknown" RH type so
that we
- silently ignore the routing header if segleft == 0
- or, send ICMPv6 Parameter Problem
The "fix" for emerging security threats was overkill and it broke
basic semantic of IPv6 routing header processing. We should assume
RT0 (or even RT2, depends on configuration) as "unknown" RH type so
that we
- silently ignore the routing header if segleft == 0,
- or, send ICMPv6 Parameter Problem
The "fix" for emerging security threats was overkill and it broke
basic semantic of IPv6 routing header processing. We should assume
RT0 as "unknown" RH type so that we
- silently ignore the routing header if segleft == 0
- or, send ICMPv6 Parameter Problem message back to the sender,
otherwise.
Joakim Koskela wrote:
> I'm running a system where there might be multiple simultenously
> active ipsec states between two hosts (ipv6, but guess it applies to
> v4 as well) where the outer ip is the same for all states, but the
> inner differ (using beet mode).
>
> The problem is that after estab
On Mon, 7 May 2007 20:29:05 +0900
Mitsuru Chinen <[EMAIL PROTECTED]> wrote:
> On Thu, 03 May 2007 03:15:46 -0700 (PDT)
> David Miller <[EMAIL PROTECTED]> wrote:
>
> > From: Mitsuru Chinen <[EMAIL PROTECTED]>
> > Date: Wed, 2 May 2007 10:05:13 +0900
> >
> > > [IPV4] SNMP: Display new statistics a
> This compiles and passes some basic tests - no serious testing.
> Against net-2.6.
>
> The patch is ugly looking, so i have at the end the
> re-written qdisc; you can easily tell the rest from the patch.
>
> Please flush out any fluff - I would like to submit this
> (almost lost it, thanks to
On Fri, 11 May 2007 14:40:45 +0900
Kenji Kaneshige <[EMAIL PROTECTED]> wrote:
> Hi,
>
> I encountered the following error when I was hot-plugging network card
> using pci hotplug driver.
>
> kobject_add failed for eth8 with -EEXIST, don't try to register things with
> the same name in the same
On Fri, 11 May 2007 12:27:40 +0100
"Simon Arlott" <[EMAIL PROTECTED]> wrote:
>
> On Fri, May 11, 2007 06:16, Andrew Hall wrote:
> >> -Original Message-
> >> From: Robert Iakobashvili [mailto:[EMAIL PROTECTED]
> >> Sent: Friday, 11 May 2007 2:38 PM
> >> To: Andrew Hall
> >> Cc: netdev@vger
On May 11 2007 10:12, Vlad Yasevich wrote:
>Brian Haley wrote:
>> [EMAIL PROTECTED] wrote:
>>> diff -puN net/sctp/Kconfig~use-menuconfig-objects-sctp net/sctp/Kconfig
>>> --- a/net/sctp/Kconfig~use-menuconfig-objects-sctp
>>> +++ a/net/sctp/Kconfig
>>> @@ -2,11 +2,9 @@
>>> # SCTP configuration
>>
Hi,
I'm seeing an Oops[1] with a 2.6.19.2 kernel:
BUG: unable to handle kernel NULL pointer dereference at virtual address
018c
printing eip:
c01cc54f
*pde =
Oops: [#1]
PREEMPT SMP
Modules linked in: ipmi_si ipmi_devintf ipmi_msghandler nfsd exportfs i8xx_tco
i2c_dev i2c_core
On May 11, 2007, at 8:49 AM, Matvejchikov Ilya wrote:
2007/5/11, Kumar Gala <[EMAIL PROTECTED]>:
On May 11, 2007, at 5:58 AM, Matvejchikov Ilya wrote:
> Signed-off-by: Matvejchikov Ilya <[EMAIL PROTECTED]>
> ---
>
> diff -purN linux-2.6.21-clean/drivers/net/phy/phy.c
> linux-2.6.21/drivers/n
Corrects a small word-size dependency in an exposed kernel structure
so that mmaped packet sockets will work correctly from 32-bit userspace
on a 64-bit kernel.
Signed-off-by: Marc A. Pelletier <[EMAIL PROTECTED]>
---
As an aside, I've considered changing the setsockopt() for that feature
so that
Brian Haley wrote:
> [EMAIL PROTECTED] wrote:
>> diff -puN net/sctp/Kconfig~use-menuconfig-objects-sctp net/sctp/Kconfig
>> --- a/net/sctp/Kconfig~use-menuconfig-objects-sctp
>> +++ a/net/sctp/Kconfig
>> @@ -2,11 +2,9 @@
>> # SCTP configuration
>> #
>>
>> -menu "SCTP Configuration (EXPERIMENTAL
Hi all,
I'm running a system where there might be multiple simultenously
active ipsec states between two hosts (ipv6, but guess it applies to
v4 as well) where the outer ip is the same for all states, but the
inner differ (using beet mode).
The problem is that after establishing these states, it
2007/5/11, Kumar Gala <[EMAIL PROTECTED]>:
On May 11, 2007, at 5:58 AM, Matvejchikov Ilya wrote:
> Signed-off-by: Matvejchikov Ilya <[EMAIL PROTECTED]>
> ---
>
> diff -purN linux-2.6.21-clean/drivers/net/phy/phy.c
> linux-2.6.21/drivers/net/phy/phy.c
> --- linux-2.6.21-clean/drivers/net/phy/phy
[EMAIL PROTECTED] wrote:
diff -puN net/sctp/Kconfig~use-menuconfig-objects-sctp net/sctp/Kconfig
--- a/net/sctp/Kconfig~use-menuconfig-objects-sctp
+++ a/net/sctp/Kconfig
@@ -2,11 +2,9 @@
# SCTP configuration
#
-menu "SCTP Configuration (EXPERIMENTAL)"
- depends on INET && EXPERIMENTAL
Hi Jiri,
On 4/26/07, Jiri Kosina <[EMAIL PROTECTED]> wrote:
On Mon, 23 Apr 2007, Jiri Kosina wrote:
> > BUG: sleeping function called from invalid context at net/core/sock.c:1523
> > in_atomic():1, irqs_disabled():0
> > 1 lock held by khubd/180:
> > #0: (old_style_rw_init#2){-.-?}, at: []
hc
On May 11, 2007, at 5:58 AM, Matvejchikov Ilya wrote:
Signed-off-by: Matvejchikov Ilya <[EMAIL PROTECTED]>
---
diff -purN linux-2.6.21-clean/drivers/net/phy/phy.c
linux-2.6.21/drivers/net/phy/phy.c
--- linux-2.6.21-clean/drivers/net/phy/phy.c 2007-04-26
07:08:32.0 +0400
+++ linux-2.6
This patch adds support for the ASIX AX88796
10/100 network controller. This device is an
NE2000 compatible chip, with a 10/100 phy.
The driver attaches via the platform bus,
and takes platform data specified in the
include file to allow the
chip to be configured. It fully supports
devices where
On Fri, 2007-11-05 at 14:41 +0200, stf wrote:
> Hi!
>
> I want to write a library or application showing processes and net
> connections. I was looking on ps and netstat to see how those programs
> are retrieving the information. It seems that they are parsing /proc
> entries.
>
> Is there any
Hi!
I want to write a library or application showing processes and net
connections. I was looking on ps and netstat to see how those programs
are retrieving the information. It seems that they are parsing /proc
entries.
Is there any other kernel API to get information about processes or net
Russell King wrote:
You might also want to fix the other stupidity with this. See my message
on this very subject ("select is evil: another reason" from May 9th on lkml.)
I submitted a patch yesterday which includes both fixes. Apparently, it's
already in the -mm tree.
-
To unsubscribe from
On Fri, 2007-11-05 at 15:53 +0400, Evgeniy Polyakov wrote:
> As I said there might be another lock, if interrupt handler is shared,
> or registers are accessed, but it is privite driver's business, which
> has nothing in common with stack itself.
Ok, we are saying the same thing then. eg in e100
On Fri, May 11, 2007 at 07:30:02AM -0400, jamal ([EMAIL PROTECTED]) wrote:
> > I meant no locks during processing of the packets (pci read/write, dma
> > setup and so on), of course it is needed to dequeue a packet, but only
> > for that operation.
>
> I dont think you can avoid the lock Evgeniy.
On Fri, 2007-05-11 at 10:22 +0900, Simon Horman wrote:
> Actually, it was with ARCH=ia64. I have a feeling that you can get
> it to show up quite easily with anything other than ARCH=powerpc.
Ick, I didn't know that drivers/macintosh was now included for all
arches! Hmm. That's a bit of a problem
On Fri, 2007-11-05 at 13:56 +0400, Evgeniy Polyakov wrote:
> I meant no locks during processing of the packets (pci read/write, dma
> setup and so on), of course it is needed to dequeue a packet, but only
> for that operation.
I dont think you can avoid the lock Evgeniy. You need to protect again
On Fri, May 11, 2007 06:16, Andrew Hall wrote:
>> -Original Message-
>> From: Robert Iakobashvili [mailto:[EMAIL PROTECTED]
>> Sent: Friday, 11 May 2007 2:38 PM
>> To: Andrew Hall
>> Cc: netdev@vger.kernel.org
>> Subject: Re: Accessing certain web sites broken from 2.6.19+
>>
>> On 5/11/07
On Fri, 2007-11-05 at 10:52 +0530, Krishna Kumar2 wrote:
> I didn't try to optimize the driver to take any real advantage, I coded it
> as simply as :
>
> top:
> next = skb->skb_flink;
> Original driver code here, or another option is to remove the locking
> and put it bef
> Sounds a good idea. I had a question on error handling. What happens if
> the driver asynchronously returns an error for this WR (single WR
> containing multiple skbs) ? Does it mean all the skbs failed to be sent ?
> Requeuing all of them is a bad idea since it leads to infinitely doing the
> I wasn't talking about sending.
>
> But there actually is :- TSO/GSO.
As I said before, getting multiple packets in one call to xmit would
be nice for amortizing per-xmit overhead in IPoIB. So it would be
nice if the cases where the stack does GSO ended up passing all the
segments into the
Signed-off-by: Matvejchikov Ilya <[EMAIL PROTECTED]>
---
diff -purN linux-2.6.21-clean/drivers/net/phy/phy.c
linux-2.6.21/drivers/net/phy/phy.c
--- linux-2.6.21-clean/drivers/net/phy/phy.c2007-04-26 07:08:32.0
+0400
+++ linux-2.6.21/drivers/net/phy/phy.c 2007-05-04 08:22:01.
Andrew Morton <[EMAIL PROTECTED]> wrote:
> Yes, it's a shame that there doesn't seem to be a fine-grained way of
> turning on -W's useful bits.
You can turn off -W's undesirable bits. For net/rxrpc/ and fs/afs/ at least,
adding:
CFLAGS += -W -Wno-unused-parameter
to the Makefile genera
On Fri, 11 May 2007 10:49:23 +0100 David Howells <[EMAIL PROTECTED]> wrote:
> Andrew Morton <[EMAIL PROTECTED]> wrote:
>
> > > Following bug was uncovered by compiling with '-W' flag:
> >
> > gcc -W finds a number of fairly scary bugs.
>
> Do you mean in my code specifically? Or in the kernel
Andrew Morton <[EMAIL PROTECTED]> wrote:
> More than one would expect, given that it is recommended in
> Documentation/SubmitChecklist, which everyone reads ;)
Which states incorrectly:
| 22: Newly-added code has been compiled with `gcc -W'. This will generate
| lots of noise, but is good f
On Fri, May 11, 2007 at 03:22:13PM +0530, Krishna Kumar2 ([EMAIL PROTECTED])
wrote:
> > No locks, no requeues? Seems simple imho.
>
> I will analyze this in more detail when I return (leaving just now, so got
> really no time). The only issue that I see quickly is "No locks", since to
> get thing
Evgeniy Polyakov <[EMAIL PROTECTED]> wrote on 05/11/2007 03:02:02 PM:
> On Fri, May 11, 2007 at 02:48:14PM +0530, Krishna Kumar2
([EMAIL PROTECTED]) wrote:
> > > And what if you have thousand(s) of packets queued and first one has
> > > failed, requeing all the rest one-by-one is not a solution. I
Andrew Morton <[EMAIL PROTECTED]> wrote:
> > Following bug was uncovered by compiling with '-W' flag:
>
> gcc -W finds a number of fairly scary bugs.
Do you mean in my code specifically? Or in the kernel in general? As far as
I can tell -W only finds an eye-glazingly large quantity of 'unused
Hi all,
Very preliminary testing with 20 procs on E1000 driver gives me following
result:
skbszOrg BW New BW % Org demand
New Demand %
32 315.98 347.489.97% 21090
20958 0.62%
96
On Fri, May 11, 2007 at 02:48:14PM +0530, Krishna Kumar2 ([EMAIL PROTECTED])
wrote:
> > And what if you have thousand(s) of packets queued and first one has
> > failed, requeing all the rest one-by-one is not a solution. If it is
> > being done under heavy lock (with disabled irqs especially) it b
Hi Evgeniy,
Evgeniy Polyakov <[EMAIL PROTECTED]> wrote on 05/11/2007 02:31:38 PM:
> On Fri, May 11, 2007 at 10:34:22AM +0530, Krishna Kumar2
([EMAIL PROTECTED]) wrote:
> > Not combining packets, I am sending them out in the same sequence it
was
> > queued. If the xmit failed, the driver's new API
On Fri, May 11, 2007 at 10:34:22AM +0530, Krishna Kumar2 ([EMAIL PROTECTED])
wrote:
> Not combining packets, I am sending them out in the same sequence it was
> queued. If the xmit failed, the driver's new API returns the skb which
> failed to be sent. This skb and all other linked skbs are requeu
Hi Andy,
Andi Kleen <[EMAIL PROTECTED]> wrote on 05/11/2007 03:07:14 PM:
> But without it aggregation on RX is much less useful because the packets
> cannot be kept together after socket demux which happens relatively early
> in the packet processing path.
Then I misunderstood you, my proposal
On Fri, May 11, 2007 at 02:02:55PM +0530, Krishna Kumar2 wrote:
> Hi Andy,
>
> [EMAIL PROTECTED] wrote on 05/11/2007 02:35:05 PM:
>
> > You don't need that. You can just use the normal next/prev pointers.
> > In general it's a good idea to lower lock overhead etc., the VM has
> > used similar tri
Hi Andy,
[EMAIL PROTECTED] wrote on 05/11/2007 02:35:05 PM:
> You don't need that. You can just use the normal next/prev pointers.
> In general it's a good idea to lower lock overhead etc., the VM has
> used similar tricks very successfully in the past.
Does this mean each skb should be for the
On Fri, 11 May 2007 10:27:38 +0200 Frederik Deweerdt <[EMAIL PROTECTED]> wrote:
> On Wed, May 09, 2007 at 01:23:22AM -0700, Andrew Morton wrote:
> >
> > ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.21/2.6.21-mm2/
> >
>
> ERROR: "csum_partial_copy_from_user" [net/rxrpc/af-rx
Krishna Kumar <[EMAIL PROTECTED]> writes:
> Doing some measurements, I found that for small packets like 128 bytes,
> the bandwidth is approximately 60% of the line speed. To possibly speed
> up performance of small packet xmits, a method of "linking" skbs was
> thought of - where two pointers (sk
On Thu, May 10, 2007 at 08:47:05PM -0500, Kumar Gala wrote:
> On Fri, 11 May 2007, Simon Horman wrote:
>
> > On Thu, May 10, 2007 at 11:56:48AM -0500, Timur Tabi wrote:
> > > Simon Horman wrote:
> > >
> > > >>So my question is: in which Kconfig do I define "UCC_FAST_TEMP" and
> > > >>"UCC_SLOW_TEM
Hi Roland,
Roland Dreier <[EMAIL PROTECTED]> wrote on 05/11/2007 01:51:50 AM:
> This is pretty interesting to me for IP-over-InfiniBand, for a couple
> of reasons. First of all, I can push multiple send requests to the
> underlying adapter in one go, which saves taking and dropping the same
> lo
Hi Gagan,
> I have to claim incomplete familiarity for the code. But still, if
> you're out there running with no locks for a period, there's no
> assumption you can make. The "lock could be held quickly" assertion is a
> fallacy.
I will try to explain since the code is pretty complicated. Packet
(Mistaken didn't reply-all previous time)
Hi Dave,
David Stevens <[EMAIL PROTECTED]> wrote on 05/11/2007 02:57:56 AM:
> The word "small" is coming up a lot in this discussion, and
> I think packet size really has nothing to do with it. Multiple
> streams generating packets of any size would ben
[EMAIL PROTECTED] wrote:
From: Ingo Molnar <[EMAIL PROTECTED]>
Another forcedeth.c thing: i noticed that its NAPI handler does not do
tx-ring processing. The patch below implements this - tested on DESC_VER_2
hardware, with CONFIG_FORCEDETH_NAPI=y.
Signed-off-by: Ingo Molnar <[EMAIL PROTECTED
100 matches
Mail list logo
