[PATCH] fix atl1 braino

2007-02-12 Thread Al Viro
Spot the bug... Signed-off-by: Al Viro <[EMAIL PROTECTED]> --- diff --git a/drivers/net/atl1/atl1_hw.c b/drivers/net/atl1/atl1_hw.c index 08b2d78..e28707a 100644 --- a/drivers/net/atl1/atl1_hw.c +++ b/drivers/net/atl1/atl1_hw.c @@ -357,7 +357,7 @@ void atl1_hash_set(struct atl1_hw *hw, u32 hash_v

[PATCH][NET][BRIDGE] br_if: oops in port_carrier_check

2007-02-12 Thread Jarek Poplawski
On Mon, Feb 12, 2007 at 09:47:38AM -0800, Stephen Hemminger wrote: > On Mon, 12 Feb 2007 11:28:48 +0100 > Jarek Poplawski <[EMAIL PROTECTED]> wrote: > > > Here is my patch proposal for testing. > > If it doesn't work - forget about it. > > (Prepared with 2.6.20-git6 but could > > be applied to 2.6

[git patches] gianfar sysfs driver fix

2007-02-12 Thread Kumar Gala
Please pull from 'gfar' branch of master.kernel.org/pub/scm/linux/kernel/git/galak/powerpc.git gfar (will try this as a git pull request, see if that works better :) to receive the following updates: drivers/net/gianfar_sysfs.c | 108 ++-- 1 file change

Re: [take35 0/10] kevent: Generic event handling mechanism.

2007-02-12 Thread Evgeniy Polyakov
On Mon, Feb 12, 2007 at 09:13:35AM -0800, Andrew Morton ([EMAIL PROTECTED]) wrote: > > On Mon, 12 Feb 2007 13:35:10 +0300 Evgeniy Polyakov <[EMAIL PROTECTED]> > > wrote: > > Andrew, do you consider kevent for inclusion or declining? > > I haven't had time to think about it in the past month or t

Re: [take35 0/10] kevent: Generic event handling mechanism.

2007-02-12 Thread Evgeniy Polyakov
On Mon, Feb 12, 2007 at 06:59:17AM -0800, Ulrich Drepper ([EMAIL PROTECTED]) wrote: > Evgeniy Polyakov wrote: > > I think that mean that everybody is happy with APi, design and set of > > features. > > No comment means that I still have not been able to test anything since > regardless of what v

Re: [XFRM]: Fix IPv4 tunnel mode decapsulation with IPV6=n

2007-02-12 Thread David Miller
Thanks for this bug fix Patrick, applied. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 2.6.20.y & net-2.6] [IPV6] HASHTABLES: Use appropriate seed for caluculating ehash index.

2007-02-12 Thread David Miller
From: YOSHIFUJI Hideaki <[EMAIL PROTECTED]> Date: Tue, 13 Feb 2007 09:48:41 +0900 (JST) > Tetsuo Handa <[EMAIL PROTECTED]> told me that connect(2) with TCPv6 > socket almost always took a few minutes to return when we did not have any > ports available in the range of net.ipv4.ip_local_port_range.

Re: 2.6.20-git8 fails compile -- net/built-in.o __ipv6_addr_type

2007-02-12 Thread David Miller
From: Neil Brown <[EMAIL PROTECTED]> Date: Tue, 13 Feb 2007 13:52:26 +1100 > On Monday February 12, [EMAIL PROTECTED] wrote: > > Quoting YOSHIFUJIHideaki/=?iso-2022-jp?B?GyRCNUhGIzFRTEAbKEI=?= > > > In article <[EMAIL PROTECTED]> (at Mon, 12 Feb 2007 18:12:16 -0800), > > Andrew Morton <[EMAIL P

Re: 2.6.20-git8 fails compile -- net/built-in.o __ipv6_addr_type

2007-02-12 Thread David Miller
From: Andrew Morton <[EMAIL PROTECTED]> Date: Mon, 12 Feb 2007 18:12:16 -0800 > > On Mon, 12 Feb 2007 20:10:13 -0500 (EST) Pete Clements <[EMAIL PROTECTED]> > > wrote: > > 2.6.20-git8 fails compile: > > > > CHK include/linux/compile.h > > UPD include/linux/compile.h > > CC ini

Re: [PATCH 4/5] r8169: more alignment for the 0x8168

2007-02-12 Thread Philip Craig
Francois Romieu wrote: > Two thirds of packets are lost because of misalignment. Users of > Asus laptop did apparently not notice it. > > Reported on Gigabyte GA-945GM-S2. > > Fix for http://bugzilla.kernel.org/show_bug.cgi?id=7517 > > Signed-off-by: Francois Romieu <[EMAIL PROTECTED]> > --- >

Re: 2.6.20-git8 fails compile -- net/built-in.o __ipv6_addr_type

2007-02-12 Thread Pete Clements
Patched, compiles. -- Pete Clements Quoting YOSHIFUJI Hideaki / =?iso-2022-jp?B?GyRCNUhGIzFRTEAbKEI=?= > > Ah, this is because of new ipv6 support in sunrpc code. > Enable it if it is statically compiled. > > Alternatively, we could > - export __ipv6_addr_type in new net/ipv6/addrco

Re: 2.6.20-git8 fails compile -- net/built-in.o __ipv6_addr_type

2007-02-12 Thread YOSHIFUJI Hideaki / 吉藤英明
In article <[EMAIL PROTECTED]> (at Mon, 12 Feb 2007 21:35:59 -0500 (EST)), Pete Clements <[EMAIL PROTECTED]> says: > Quoting YOSHIFUJIHideaki/=?iso-2022-jp?B?GyRCNUhGIzFRTEAbKEI=?= > > In article <[EMAIL PROTECTED]> (at Mon, 12 Feb 2007 18:12:16 -0800), > Andrew Morton <[EMAIL PROTECTED]> says

Re: 2.6.20-git8 fails compile -- net/built-in.o __ipv6_addr_type

2007-02-12 Thread Neil Brown
On Monday February 12, [EMAIL PROTECTED] wrote: > Quoting YOSHIFUJIHideaki/=?iso-2022-jp?B?GyRCNUhGIzFRTEAbKEI=?= > > In article <[EMAIL PROTECTED]> (at Mon, 12 Feb 2007 18:12:16 -0800), > Andrew Morton <[EMAIL PROTECTED]> says: > > > > > > On Mon, 12 Feb 2007 20:10:13 -0500 (EST) Pete Clem

Re: 2.6.20-git8 fails compile -- net/built-in.o __ipv6_addr_type

2007-02-12 Thread Pete Clements
Quoting YOSHIFUJIHideaki/=?iso-2022-jp?B?GyRCNUhGIzFRTEAbKEI=?= > In article <[EMAIL PROTECTED]> (at Mon, 12 Feb 2007 18:12:16 -0800), Andrew Morton <[EMAIL PROTECTED]> says: > > > > On Mon, 12 Feb 2007 20:10:13 -0500 (EST) Pete Clements <[EMAIL PROTECTED]> wrote: > > > 2.6.20-git8 fails

Re: 2.6.20-git8 fails compile -- net/built-in.o __ipv6_addr_type

2007-02-12 Thread YOSHIFUJI Hideaki / 吉藤英明
In article <[EMAIL PROTECTED]> (at Mon, 12 Feb 2007 18:12:16 -0800), Andrew Morton <[EMAIL PROTECTED]> says: > > On Mon, 12 Feb 2007 20:10:13 -0500 (EST) Pete Clements <[EMAIL PROTECTED]> > > wrote: > > 2.6.20-git8 fails compile: > > > > CHK include/linux/compile.h > > UPD include/l

Re: 2.6.20-git8 fails compile -- net/built-in.o __ipv6_addr_type

2007-02-12 Thread Andrew Morton
> On Mon, 12 Feb 2007 20:10:13 -0500 (EST) Pete Clements <[EMAIL PROTECTED]> > wrote: > 2.6.20-git8 fails compile: > > CHK include/linux/compile.h > UPD include/linux/compile.h > CC init/version.o > LD init/built-in.o > LD .tmp_vmlinux1 > net/built-in.o: In functi

Re: [PATCH] RFC: Broadcom PHY forcing fix

2007-02-12 Thread Andy Fleming
On Jan 26, 2007, at 08:36, Maciej W. Rozycki wrote: Kumar, I've got a BCM5461 that requires this fix to be able to force the speeds on the PHY. Not sure if its needed on the other variants or not. The problem is the genphy_config_aneg resets the PHY when forcing the speed and once we r

[PATCH 2.6.16.y] [IPV6] HASHTABLES: Use appropriate seed for caluculating ehash index.

2007-02-12 Thread YOSHIFUJI Hideaki / 吉藤英明
Tetsuo Handa <[EMAIL PROTECTED]> told me that connect(2) with TCPv6 socket almost always took a few minutes to return when we did not have any ports available in the range of net.ipv4.ip_local_port_range. The reason was that we used incorrect seed for calculating index of hash when we check establ

[PATCH 2.6.20.y & net-2.6] [IPV6] HASHTABLES: Use appropriate seed for caluculating ehash index.

2007-02-12 Thread YOSHIFUJI Hideaki / 吉藤英明
Tetsuo Handa <[EMAIL PROTECTED]> told me that connect(2) with TCPv6 socket almost always took a few minutes to return when we did not have any ports available in the range of net.ipv4.ip_local_port_range. The reason was that we used incorrect seed for calculating index of hash when we check establ

Re: [PATCH 0/4] spidernet: support for Celleb

2007-02-12 Thread Benjamin Herrenschmidt
On Mon, 2007-02-12 at 17:49 -0600, Linas Vepstas wrote: > On Wed, Feb 07, 2007 at 05:49:50PM +0900, Ishizaki Kou wrote: > > This is a revised spidernet patch set based on > > netdev-2.6.git#upstream. > > Tested this series of patches together with Jen's "version 3" patch, > it worked for me. Code

[XFRM]: Fix IPv4 tunnel mode decapsulation with IPV6=n

2007-02-12 Thread Patrick McHardy
[XFRM]: Fix IPv4 tunnel mode decapsulation with IPV6=n Add missing break when CONFIG_IPV6=n. Signed-off-by: Patrick McHardy <[EMAIL PROTECTED]> --- commit 651521586d5f08c5d6d7198ceef1555b93135b6a tree 5ee1183f4bc1f49f467b5bdcfebf1c5181bffcd7 parent 6ec183b20c4a1c0eafd541444ae11f8e5779d153 author

Re: [PATCH 0/4] spidernet: support for Celleb

2007-02-12 Thread Linas Vepstas
On Wed, Feb 07, 2007 at 05:49:50PM +0900, Ishizaki Kou wrote: > This is a revised spidernet patch set based on > netdev-2.6.git#upstream. Tested this series of patches together with Jen's "version 3" patch, it worked for me. Code looks reasonable. Thus Acked-by: Linas Vepstas <[EMAIL PROTECTED]>

Re: [PATCH] [XFRM] AUDIT: Fix audit buffer leakage in error path.

2007-02-12 Thread YOSHIFUJI Hideaki / 吉藤英明
In article <[EMAIL PROTECTED]> (at Mon, 12 Feb 2007 15:23:17 -0800 (PST)), David Miller <[EMAIL PROTECTED]> says: > From: YOSHIFUJI Hideaki <[EMAIL PROTECTED]> > Date: Tue, 13 Feb 2007 00:34:29 +0900 (JST) > > > Signed-off-by: YOSHIFUJI Hideaki <[EMAIL PROTECTED]> > > Oh yes. I noticed this to

Re: [PATCH] IPv6: Implement RFC 4429 Optimistic Duplicate Address Detection

2007-02-12 Thread YOSHIFUJI Hideaki / 吉藤英明
In article <[EMAIL PROTECTED]> (at Thu, 8 Feb 2007 08:07:15 -0500), Neil Horman <[EMAIL PROTECTED]> says: > > I still have a question. Now, who will install the kernel route for > > the incoming packet? Can we get packet for our unicast address during > > optimistic DAD period? > > > Not sure

Re: [PATCH] spidernet: move medium variable into card struct

2007-02-12 Thread Linas Vepstas
On Mon, Feb 12, 2007 at 09:37:15PM +0100, Jens Osterkamp wrote: > This moves the medium variable into the spidernet card structure. > It renames the GMII_ variables to BCM54XX specific ones. > > Signed-off-by: Jens Osterkamp <[EMAIL PROTECTED]> Boot-tested the patch, it works for me Acked-by: Li

Re: [PATCH] [v3] spidernet : add improved phy support

2007-02-12 Thread Linas Vepstas
Tested the patch, it works for me. Thus I'll attach a pre-emptive Acked-by: Linas Vepstas <[EMAIL PROTECTED]> However, some quibbbles, which I think would be nice to see fixed: On Mon, Feb 12, 2007 at 09:35:34PM +0100, Jens Osterkamp wrote: > > Index: linux-2.6.20/drivers/net/sungem_phy.c > =

Re: [PATCH] [XFRM] AUDIT: Fix audit buffer leakage in error path.

2007-02-12 Thread David Miller
From: YOSHIFUJI Hideaki <[EMAIL PROTECTED]> Date: Tue, 13 Feb 2007 00:34:29 +0900 (JST) > Signed-off-by: YOSHIFUJI Hideaki <[EMAIL PROTECTED]> Oh yes. I noticed this too while working with Joy Latten's OOPS fix for this function. Event types other than those 4 mentioned in the switch() statemen

[ANNOUNCE] sk-drivers mailing list

2007-02-12 Thread Stephen Hemminger
I have created a list for discussing issues and announcing test versions of the skge and sky2 drivers. There are many people with problems and several vendors are using the hardware as well, therefore I want to be able to make sure everyone can see the information without having to be distracted by

Re: [BUG] 2.6.20 Oopses in xfrm_audit_log

2007-02-12 Thread Andrew Morton
> On Mon, 12 Feb 2007 14:49:38 -0800 (PST) David Miller <[EMAIL PROTECTED]> > wrote: > Andrew, we're already discussing a fix for this in another > thread today: Yeah, I noticed. Vitimised again by those darn MUA vendors and/or users who bust their In-Reply-To/References headers :( - To unsubscr

Re: [patch 3/3] tcp: remove experimental variants from default list

2007-02-12 Thread David Miller
From: Baruch Even <[EMAIL PROTECTED]> Date: Tue, 13 Feb 2007 00:12:41 +0200 > The problem is that you actually put a mostly untested algorithm as the > default for everyone to use. The BIC example is important, it was the > default algorithm for a long while and had implementation bugs that no > o

Re: [BUG] 2.6.20 Oopses in xfrm_audit_log

2007-02-12 Thread David Miller
Andrew, we're already discussing a fix for this in another thread today: commit 13fcfbb0675bf87da694f55dec11cada489a205c Author: David S. Miller <[EMAIL PROTECTED]> Date: Mon Feb 12 13:53:54 2007 -0800 [XFRM]: Fix OOPSes in xfrm_audit_log(). Make sure that this function is called

Re: [PATCH 1/1] NetXen: Fix to get the driver working after sparse changes

2007-02-12 Thread Al Viro
On Mon, Feb 12, 2007 at 04:33:38AM -0800, Amit S. Kale wrote: > Signed-off-by: Amit S. Kale <[EMAIL PROTECTED]> ACK. My apologies - that pile of brainos had been introduced when I'd been fixing the set_bit() abuses in there (a bunch of places had been casting address of u32 to unsigned long * and

Fw: [BUG] 2.6.20 Oopses in xfrm_audit_log

2007-02-12 Thread Andrew Morton
Begin forwarded message: Date: Mon, 12 Feb 2007 15:16:04 +0100 From: Charles-Edouard Ruault <[EMAIL PROTECTED]> To: linux-kernel@vger.kernel.org, linux-net@vger.kernel.org Subject: [BUG] 2.6.20 Oopses in xfrm_audit_log Hi All, i upgraded to vanilla kernel 2.6.20 and while i was using strongsw

Re: [patch 3/3] tcp: remove experimental variants from default list

2007-02-12 Thread Baruch Even
* David Miller <[EMAIL PROTECTED]> [070212 22:21]: > From: Baruch Even <[EMAIL PROTECTED]> > Date: Mon, 12 Feb 2007 21:11:01 +0200 > > > Since no one really agrees on the relative merits and problems of the > > different algorithms and since the users themselves dont know, dont care > > and have n

Re: [PATCH][RESPIN] gianfar: Convert network devices to use struct device instead of class_device

2007-02-12 Thread Andy Fleming
On Feb 9, 2007, at 15:33, Kumar Gala wrote: Convert network devices to use struct device instead of class_device. Greg missed this one in his cleanup path. Signed-off-by: Kumar Gala <[EMAIL PROTECTED]> Acked-by: Andy Fleming <[EMAIL PROTECTED]> Jeff, please get this into 2.6.21. The cur

[PATCH] gianfar: don't duplicate gfar_error()

2007-02-12 Thread Sergei Shtylyov
It was hardly necessary to repeat most of the code from gfar_error() in gfar_interrupt(), especially having some inconsistencies between the two. So, make the gfar_interrupt() just call gfar_error(), and not acknowledge the interrupts itself as gfar_{receive/transmit/error}() do it anyway. While at

[PATCH] sundance: add IFF_RUNNING support

2007-02-12 Thread Leigh Brown
Patch to add IFF_RUNNING support for sundance. I copied the basic code for this from the forcedeth driver, and I've tested it using the ifplugstatus command from the ifplugd package. This is very handy if you use Quagga or keepalived. Signed-off-by: Leigh Brown <[EMAIL PROTECTED]> diff -urN a/dr

Re: [PATCH] [v3] spidernet : add improved phy support

2007-02-12 Thread Benjamin Herrenschmidt
> +static int bcm5461_enable_fiber(struct mii_phy* phy, int autoneg) > +{ > + /* select fiber mode, enable 1000 base-X registers */ > + phy_write(phy, MII_NCONFIG, 0xfc0b); > + > + if (autoneg) { > + /* enable fiber with no autonegotiation */ > + phy_write(phy,

Re: [patch 1/3] tcp: cleanup of htcp (resend)

2007-02-12 Thread David Miller
From: Stephen Hemminger <[EMAIL PROTECTED]> Date: Mon, 12 Feb 2007 13:28:22 -0800 > Minor non-invasive cleanups: > * white space around operators and line wrapping > * use const > * use __read_mostly > > Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> Applied, thanks Stephen. - To unsubs

[patch 1/3] tcp: cleanup of htcp (resend)

2007-02-12 Thread Stephen Hemminger
Minor non-invasive cleanups: * white space around operators and line wrapping * use const * use __read_mostly Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- net/ipv4/tcp_htcp.c | 65 +--- 1 file changed, 37 insertions(+), 28 deletions

Re: [PATCH] IPv6: Implement RFC 4429 Optimistic Duplicate Address Detection

2007-02-12 Thread Neil Horman
> > New patch attached with these fixes included > > Ping? Any further thoughts here? My (allbeit limited) testing seems to be going fairly well so far... Neil > Thanks & Regards > Neil > > Signed-off-by: Neil Horman <[EMAIL PROTECTED]> > > > include/linux/if_addr.h |1 > include/linu

Re: [patch 2/3] tcp: use read mostly for CUBIC parameters

2007-02-12 Thread David Miller
From: Stephen Hemminger <[EMAIL PROTECTED]> Date: Mon, 12 Feb 2007 08:03:19 -0800 > These module parameters should be in the read mostly area > to avoid cache pollution. > > Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> Applied, thanks Stephen. - To unsubscribe from this list: send the li

Re: [BUG] 2.6.20 Oopses in xfrm_audit_log

2007-02-12 Thread Charles-Edouard Ruault
Alexey Dobriyan wrote: > [removing l-k from CC, and switching to netdev] > > Please, send your .config. > Is it reproducible? > > On Mon, Feb 12, 2007 at 03:16:04PM +0100, Charles-Edouard Ruault wrote: > >> i upgraded to vanilla kernel 2.6.20 and while i was using strongswan >> 2.8.2 to setup a

Re: [patch 1/3] tcp: cleanup of htcp

2007-02-12 Thread David Miller
From: Stephen Hemminger <[EMAIL PROTECTED]> Date: Mon, 12 Feb 2007 08:03:18 -0800 > Minor non-invasive cleanups: > * white space around operators and line wrapping > * use const > * use __read_mostly > > Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> Yoshifuji fixed all the whitespace i

Re: [patch 3/3] tcp: remove experimental variants from default list

2007-02-12 Thread Ian McDonald
On 2/13/07, David Miller <[EMAIL PROTECTED]> wrote: This is not the internet of 15 years ago, please wake up everyone. We cannot sit on eggs for 5 years to make sure they hatch perfectly like was previously possible. OK. I get the point. I am more conservative by nature and more of an academic.

Re: netfilter tables config problem

2007-02-12 Thread Randy Dunlap
On Mon, 12 Feb 2007 21:30:02 +0100 Patrick McHardy wrote: > David Miller wrote: > > From: Randy Dunlap <[EMAIL PROTECTED]> > > Date: Fri, 22 Dec 2006 18:33:12 -0800 > > > > I'm pretty sure we fixed that one already. Randy do you have some > > objection to testing 2.6.20-final when discoving such

Re: [patch 3/3] tcp: remove experimental variants from default list

2007-02-12 Thread David Miller
From: Stephen Hemminger <[EMAIL PROTECTED]> Date: Mon, 12 Feb 2007 12:37:13 -0800 > My patches weren't reactionary. Going to pure old Reno is reactionary. > It was more looking at the state of the code on the flight back > and cleaning house. Others were/are reactionary. Ok. The only patch I ha

Re: [PATCH 0/4] spidernet: support for Celleb

2007-02-12 Thread Jens Osterkamp
On Wednesday 07 February 2007, Ishizaki Kou wrote: > This is a revised spidernet patch set based on > netdev-2.6.git#upstream. > > This patch set is merged Jens-san's spidernet patch and works on > Toshiba Cell reference set (aka Celleb). > It requires Jens-san's phy patch > (http://ozlabs.org/pi

Re: [patch 3/3] tcp: remove experimental variants from default list

2007-02-12 Thread Stephen Hemminger
On Mon, 12 Feb 2007 12:32:40 -0800 (PST) David Miller <[EMAIL PROTECTED]> wrote: > From: "Ian McDonald" <[EMAIL PROTECTED]> > Date: Tue, 13 Feb 2007 09:13:52 +1300 > > > Unless of course the papers you saw at PFLDNET showed that Cubic was a > > really good choice and you want to point us to those

[PATCH] spidernet: move medium variable into card struct

2007-02-12 Thread Jens Osterkamp
This moves the medium variable into the spidernet card structure. It renames the GMII_ variables to BCM54XX specific ones. Signed-off-by: Jens Osterkamp <[EMAIL PROTECTED]> --- Index: linux-2.6.20/drivers/net/spider_net.c === --- li

Re: netfilter tables config problem

2007-02-12 Thread David Miller
From: Patrick McHardy <[EMAIL PROTECTED]> Date: Mon, 12 Feb 2007 21:30:02 +0100 > David Miller wrote: > > From: Randy Dunlap <[EMAIL PROTECTED]> > > Date: Fri, 22 Dec 2006 18:33:12 -0800 > > > > I'm pretty sure we fixed that one already. Randy do you have some > > objection to testing 2.6.20-fin

[PATCH] [v3] spidernet : add improved phy support

2007-02-12 Thread Jens Osterkamp
This version moves the medium variable to the card specific structure and changes the GMII_* to BCM54XX_* #defines. This patch adds improved version of enable_fiber for both the 5421 and the 5461 phy. It is now possible to specify with these wether you want autonegotiation or not. This is needed f

Re: [patch 3/3] tcp: remove experimental variants from default list

2007-02-12 Thread David Miller
From: Stephen Hemminger <[EMAIL PROTECTED]> Date: Mon, 12 Feb 2007 12:26:34 -0800 > No magic paper. But the impression from multiple talks is that Cubic > is still doing fine. Also for non high speed flows, it really doesn't matter > because all the loss based congestion controls behave the same.

Re: [patch 3/3] tcp: remove experimental variants from default list

2007-02-12 Thread David Miller
From: "Ian McDonald" <[EMAIL PROTECTED]> Date: Tue, 13 Feb 2007 09:13:52 +1300 > Unless of course the papers you saw at PFLDNET showed that Cubic was a > really good choice and you want to point us to those papers. I heavily dislike all of these "reactionary" patches from Stephen after he attende

Re: netfilter tables config problem

2007-02-12 Thread Patrick McHardy
David Miller wrote: > From: Randy Dunlap <[EMAIL PROTECTED]> > Date: Fri, 22 Dec 2006 18:33:12 -0800 > > I'm pretty sure we fixed that one already. Randy do you have some > objection to testing 2.6.20-final when discoving such bugs? :-) Sorry for the confusion, we had an 8 months backlog of non

Re: [patch 3/3] tcp: remove experimental variants from default list

2007-02-12 Thread Stephen Hemminger
On Tue, 13 Feb 2007 09:13:52 +1300 "Ian McDonald" <[EMAIL PROTECTED]> wrote: > On 2/13/07, Baruch Even <[EMAIL PROTECTED]> wrote: > > * Stephen Hemminger <[EMAIL PROTECTED]> [070212 18:04]: > > > The TCP Vegas implementation is buggy, and BIC is too agressive > > > so they should not be in the def

Re: Fw: PROBLEM: xt_state compiles without errors but cannot be loaded

2007-02-12 Thread Patrick McHardy
Andrew Morton wrote: > > Begin forwarded message: > > Date: Fri, 9 Feb 2007 16:00:50 -0800 (PST) > From: "Administrative Services" <[EMAIL PROTECTED]> > To: linux-kernel@vger.kernel.org > Subject: PROBLEM: xt_state compiles without errors but cannot be loaded > > > [1.] module: xt_state compile

Re: netfilter tables config problem

2007-02-12 Thread David Miller
From: Randy Dunlap <[EMAIL PROTECTED]> Date: Fri, 22 Dec 2006 18:33:12 -0800 > > (on 2.6.20-rc1-git8) > > It's possible to have > CONFIG_NETFILTER_XTABLES=y > and > CONFIG_IP6_NF_MATCH_IPV6HEADER=m, > > which causes this build error: > net/built-in.o: In function `hashlimit_match': > xt_hashlim

Re: [patch 3/3] tcp: remove experimental variants from default list

2007-02-12 Thread David Miller
From: Baruch Even <[EMAIL PROTECTED]> Date: Mon, 12 Feb 2007 21:11:01 +0200 > Since no one really agrees on the relative merits and problems of the > different algorithms and since the users themselves dont know, dont care > and have no clue on what should be the correct behaviour to report bugs >

Re: [patch 3/3] tcp: remove experimental variants from default list

2007-02-12 Thread Ian McDonald
On 2/13/07, Baruch Even <[EMAIL PROTECTED]> wrote: * Stephen Hemminger <[EMAIL PROTECTED]> [070212 18:04]: > The TCP Vegas implementation is buggy, and BIC is too agressive > so they should not be in the default list. Westwood is okay, but > not well tested. Since no one really agrees on the rel

Fw: PROBLEM: xt_state compiles without errors but cannot be loaded

2007-02-12 Thread Andrew Morton
Begin forwarded message: Date: Fri, 9 Feb 2007 16:00:50 -0800 (PST) From: "Administrative Services" <[EMAIL PROTECTED]> To: linux-kernel@vger.kernel.org Subject: PROBLEM: xt_state compiles without errors but cannot be loaded [1.] module: xt_state compiles without errors but cannot be loaded [

Re: [ANNOUNCE] d80211 based driver for Intel PRO/Wireless 3945ABG

2007-02-12 Thread James Ketrenos
Hesse, Christian wrote: On Saturday 10 February 2007 14:23, Hesse, Christian wrote: On Friday 09 February 2007 22:12, James Ketrenos wrote: We are pleased to announce the availability of a new driver for the Intel PRO/Wireless 3945ABG Network Connection adapter. ... Oh, I forgot one note: "mak

Re: [patch 3/3] tcp: remove experimental variants from default list

2007-02-12 Thread Baruch Even
* Stephen Hemminger <[EMAIL PROTECTED]> [070212 18:04]: > The TCP Vegas implementation is buggy, and BIC is too agressive > so they should not be in the default list. Westwood is okay, but > not well tested. Since no one really agrees on the relative merits and problems of the different algorithms

Re: [BUG] 2.6.20 Oopses in xfrm_audit_log

2007-02-12 Thread Alexey Dobriyan
[removing l-k from CC, and switching to netdev] Please, send your .config. Is it reproducible? On Mon, Feb 12, 2007 at 03:16:04PM +0100, Charles-Edouard Ruault wrote: > i upgraded to vanilla kernel 2.6.20 and while i was using strongswan > 2.8.2 to setup an IPSEC VPN i got the following kernel O

Re: [PATCH][NET][BRIDGE] br_if: oops in port_carrier_check

2007-02-12 Thread Stephen Hemminger
On Mon, 12 Feb 2007 11:28:48 +0100 Jarek Poplawski <[EMAIL PROTECTED]> wrote: > Here is my patch proposal for testing. > If it doesn't work - forget about it. > (Prepared with 2.6.20-git6 but could > be applied to 2.6.20 also.) > > Jarek P. > > > dev_hold/dev_put added to prevent dev kfree > du

Re: [Bugme-new] [Bug 7952] New: slattach only works every other time

2007-02-12 Thread Stephen Hemminger
On Mon, 12 Feb 2007 09:36:09 +0100 Jarek Poplawski <[EMAIL PROTECTED]> wrote: > On 06-02-2007 22:57, Andrew Morton wrote: > ... > > First time slattach is run to set up a SLIP line all is ok. > > If slattach process is then killed and restarted it fails with message: > > SLIP_set_disc(1): File exi

Re: [take35 0/10] kevent: Generic event handling mechanism.

2007-02-12 Thread Andrew Morton
> On Mon, 12 Feb 2007 13:35:10 +0300 Evgeniy Polyakov <[EMAIL PROTECTED]> wrote: > Andrew, do you consider kevent for inclusion or declining? I haven't had time to think about it in the past month or two, sorry. However we might as well get it back in there for review-and-test - please send a new

Re: [ipw3945-devel] [ANNOUNCE] d80211 based driver for Intel PRO/Wireless 3945ABG

2007-02-12 Thread dragoran
Hesse, Christian wrote: On Saturday 10 February 2007 14:23, Hesse, Christian wrote: On Friday 09 February 2007 22:12, James Ketrenos wrote: We are pleased to announce the availability of a new driver for the Intel PRO/Wireless 3945ABG Network Connection adapter. Wow, great news

[patch 1/3] tcp: cleanup of htcp

2007-02-12 Thread Stephen Hemminger
Minor non-invasive cleanups: * white space around operators and line wrapping * use const * use __read_mostly Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- net/ipv4/tcp_htcp.c | 69 +--- 1 file changed, 39 insertions(+), 30 deletions

[patch 3/3] tcp: remove experimental variants from default list

2007-02-12 Thread Stephen Hemminger
The TCP Vegas implementation is buggy, and BIC is too agressive so they should not be in the default list. Westwood is okay, but not well tested. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- net/ipv4/Kconfig | 10 +- 1 file changed, 1 insertion(+), 9 deletions(-) --- tcp.o

[patch 0/3] TCP trivial patches

2007-02-12 Thread Stephen Hemminger
Minor changes for 2.6.21 -- - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

[patch 2/3] tcp: use read mostly for CUBIC parameters

2007-02-12 Thread Stephen Hemminger
These module parameters should be in the read mostly area to avoid cache pollution. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- net/ipv4/tcp_cubic.c | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) --- tcp.orig/net/ipv4/tcp_cubic.c 2007-02-12 07:2

[PATCH] [XFRM] AUDIT: Fix audit buffer leakage in error path.

2007-02-12 Thread YOSHIFUJI Hideaki / 吉藤英明
Signed-off-by: YOSHIFUJI Hideaki <[EMAIL PROTECTED]> diff --git a/net/xfrm/xfrm_policy.c b/net/xfrm/xfrm_policy.c index b7e537f..af85ac9 100644 --- a/net/xfrm/xfrm_policy.c +++ b/net/xfrm/xfrm_policy.c @@ -1999,7 +1999,7 @@ void xfrm_audit_log(uid_t auid, u32 sid, int type, int result,

Re: [take35 0/10] kevent: Generic event handling mechanism.

2007-02-12 Thread Ulrich Drepper
Evgeniy Polyakov wrote: > I think that mean that everybody is happy with APi, design and set of > features. No comment means that I still have not been able to test anything since regardless of what version I tried, it failed to build. -- ➧ Ulrich Drepper ➧ Red Hat, Inc. ➧ 444 Castro St ➧ Mount

Re: Missing csum_fold() in ip6t_HL.c ?

2007-02-12 Thread YOSHIFUJI Hideaki / 吉藤英明
In article <[EMAIL PROTECTED]> (at Mon, 12 Feb 2007 15:52:13 +0100), Patrick McHardy <[EMAIL PROTECTED]> says: > This already is taken care of. I noticed our listmaster didn't > approve any held messages for a couple of month and am currently > going through the backlog (Alexey's mail is quite ol

Re: Missing csum_fold() in ip6t_HL.c ?

2007-02-12 Thread YOSHIFUJI Hideaki / 吉藤英明
In article <[EMAIL PROTECTED]> (at Fri, 15 Sep 2006 14:37:56 +0400), Alexey Dobriyan <[EMAIL PROTECTED]> says: > It looks like "diffs" array is write-only. It also looks like ipv4 > occurences use some csum_fold() trickery. Was is forgotten here? Should > "diffs" be removed? Since we do not have

Re: [take36 10/10] kevent: Kevent based generic AIO.

2007-02-12 Thread Evgeniy Polyakov
On Mon, Feb 12, 2007 at 01:12:57PM +, Alan ([EMAIL PROTECTED]) wrote: > > I'm sure others would want them then for their favourite system call combo > > too. If they were really useful it might make more sense to have a batch() > > system call that works for arbitary calls, but I'm not convinc

Re: [take36 10/10] kevent: Kevent based generic AIO.

2007-02-12 Thread Alan
> I'm sure others would want them then for their favourite system call combo > too. If they were really useful it might make more sense to have a batch() > system call that works for arbitary calls, but I'm not convinced yet > it's even needed. It would be certainly ugly. batch() would possibly m

[PATCH] dm9000: do not kfree() netdevice

2007-02-12 Thread Ben Dooks
The DM9000 network driver is calling kfree() on an netdev causing the system to oops if the probe fails. The right thing to do is call free_netdev(). Thanks to Russell King for spotting this. Signed-off-by: Ben Dooks <[EMAIL PROTECTED]> diff -urpN -X ../dontdiff linux-2.6.20/drivers/net/dm9000.c

[PATCH 1/1] NetXen: Fix to get the driver working after sparse changes

2007-02-12 Thread Amit S. Kale
Signed-off-by: Amit S. Kale <[EMAIL PROTECTED]> --- netxen_nic.h |8 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/net/netxen/netxen_nic.h b/drivers/net/netxen/netxen_nic.h index e021a30..2807ef4 100644 --- a/drivers/net/netxen/netxen_nic.h +++ b/drivers/net/

Re: [take36 10/10] kevent: Kevent based generic AIO.

2007-02-12 Thread Evgeniy Polyakov
On Mon, Feb 12, 2007 at 02:08:10PM +0100, Andi Kleen ([EMAIL PROTECTED]) wrote: > Evgeniy Polyakov <[EMAIL PROTECTED]> writes: > > > > aio_sendfile_path() is essentially aio_sendfile(), except that it takes > > source filename as parameter, has a pointer to private header > > and its size (which a

Re: [take36 10/10] kevent: Kevent based generic AIO.

2007-02-12 Thread Andi Kleen
Evgeniy Polyakov <[EMAIL PROTECTED]> writes: > > aio_sendfile_path() is essentially aio_sendfile(), except that it takes > source filename as parameter, has a pointer to private header > and its size (which allows to send header and file's content in one syscall > instead of three (open, send, sen

Re: [PATCH 1/5] Add PCBC crypto template support

2007-02-12 Thread David Howells
David Miller <[EMAIL PROTECTED]> wrote: > > Thanks. However, I'll continue to include the patches in my set until they > > reach Linus's tree. > > They are in Linus's tree. Yay! - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] Mor

[take36 5/10] kevent: Timer notifications.

2007-02-12 Thread Evgeniy Polyakov
Timer notifications. Timer notifications can be used for fine grained per-process time management, since interval timers are very inconvenient to use, and they are limited. This subsystem uses high-resolution timers. id.raw[0] is used as number of seconds id.raw[1] is used as number of nanose

[take36 8/10] kevent: Kevent posix timer notifications.

2007-02-12 Thread Evgeniy Polyakov
Kevent posix timer notifications. Simple extension to POSIX timers which allows to deliver notification of the timer expiration through kevent queue. Example application posix_timer.c can be found in archive on project homepage. Signed-off-by: Evgeniy Polyakov <[EMAIL PROTECTED]> diff --git a

[take36 4/10] kevent: Socket notifications.

2007-02-12 Thread Evgeniy Polyakov
Socket notifications. This patch includes socket send/recv/accept notifications. Signed-off-by: Evgeniy Polyakov <[EMAIL PROTECTED]> diff --git a/fs/inode.c b/fs/inode.c index bf21dc6..82817b1 100644 --- a/fs/inode.c +++ b/fs/inode.c @@ -21,6 +21,7 @@ #include #include #include +#include

[take36 9/10] kevent: Private userspace notifications.

2007-02-12 Thread Evgeniy Polyakov
Private userspace notifications. Allows to register notifications of any private userspace events over kevent. Events can be marked as ready using kevent_ctl(KEVENT_READY) command. Signed-off-by: Evgeniy Polyakov <[EMAIL PROTECTED]> diff --git a/kernel/kevent/kevent_unotify.c b/kernel/kevent/k

[take36 10/10] kevent: Kevent based generic AIO.

2007-02-12 Thread Evgeniy Polyakov
Kevent based generic AIO. This patch only implements network AIO, which is _COMPLETELY_ impossible and broken in _ANY_ micro-thread design. For details and test consider following link: http://tservice.net.ru/~s0mbre/blog/2007/02/10#2007_02_10 Designing AIO without network in mind can only be

[take36 7/10] kevent: Signal notifications.

2007-02-12 Thread Evgeniy Polyakov
Signal notifications. This type of notifications allows to deliver signals through kevent queue. One can find example application signal.c on project homepage. If KEVENT_SIGNAL_NOMASK bit is set in raw_u64 id then signal will be delivered only through queue, otherwise both delivery types are use

[take36 1/10] kevent: Description.

2007-02-12 Thread Evgeniy Polyakov
Description. diff --git a/Documentation/kevent.txt b/Documentation/kevent.txt new file mode 100644 index 000..d6e126f --- /dev/null +++ b/Documentation/kevent.txt @@ -0,0 +1,271 @@ +Description. + +int kevent_init(struct kevent_ring *ring, unsigned int ring_size, + unsigned int flags)

[take36 3/10] kevent: poll/select() notifications.

2007-02-12 Thread Evgeniy Polyakov
poll/select() notifications. This patch includes generic poll/select notifications. kevent_poll works simialr to epoll and has the same issues (callback is invoked not from internal state machine of the caller, but through process awake, a lot of allocations and so on). Signed-off-by: Evgeniy Po

[take36 6/10] kevent: Pipe notifications.

2007-02-12 Thread Evgeniy Polyakov
Pipe notifications. diff --git a/fs/pipe.c b/fs/pipe.c index 68090e8..0c75bf1 100644 --- a/fs/pipe.c +++ b/fs/pipe.c @@ -16,6 +16,7 @@ #include #include #include +#include #include #include @@ -313,6 +314,7 @@ redo: break; } if

Re: [take35 0/10] kevent: Generic event handling mechanism.

2007-02-12 Thread Evgeniy Polyakov
On Mon, Feb 05, 2007 at 05:23:36PM +0300, Evgeniy Polyakov ([EMAIL PROTECTED]) wrote: > On Thu, Feb 01, 2007 at 01:12:30PM +0300, Evgeniy Polyakov ([EMAIL > PROTECTED]) wrote: > > > > Generic event handling mechanism. > > > > Kevent is a generic subsytem which allows to handle event notificatio

[PATCH][NET][BRIDGE] br_if: oops in port_carrier_check

2007-02-12 Thread Jarek Poplawski
Here is my patch proposal for testing. If it doesn't work - forget about it. (Prepared with 2.6.20-git6 but could be applied to 2.6.20 also.) Jarek P. dev_hold/dev_put added to prevent dev kfree during port_carrier_check runnig, while dev and port are removed. Submitted and tested by: Pascal Te

Re: NetXen driver name

2007-02-12 Thread Amit Kale
On Monday 12 February 2007 13:59, Al Viro wrote: > On Mon, Feb 12, 2007 at 09:12:56AM +0100, Andi Kleen wrote: > > On Monday 12 February 2007 09:03, Amit Kale wrote: > > > The already released kernel contains a broken driver. It broke due to > > > some code rearrangement changes someone submitted

Re: NetXen driver name

2007-02-12 Thread Amit Kale
The already released kernel contains a broken driver. It broke due to some code rearrangement changes someone submitted to fix sparse warnings. -Amit On Thursday 08 February 2007 23:45, Andi Kleen wrote: > Amit Kale <[EMAIL PROTECTED]> writes: > > Hi, > > > > NetXen ethernet driver present in 2

Re: NetXen driver name

2007-02-12 Thread Andi Kleen
On Monday 12 February 2007 09:28, Amit Kale wrote: > On Monday 12 February 2007 13:42, Andi Kleen wrote: > > On Monday 12 February 2007 09:03, Amit Kale wrote: > > > The already released kernel contains a broken driver. It broke due to > > > some code rearrangement changes someone submitted to fix

Re: Fw: [Bugme-new] [Bug 7952] New: slattach only works every other time

2007-02-12 Thread Jarek Poplawski
On 06-02-2007 22:57, Andrew Morton wrote: ... > First time slattach is run to set up a SLIP line all is ok. > If slattach process is then killed and restarted it fails with message: > SLIP_set_disc(1): File exists > Problem still occurs in 2.6.20rc6 kernel > > dmesg shows: > object_add failed for

Re: NetXen driver name

2007-02-12 Thread Al Viro
On Mon, Feb 12, 2007 at 09:12:56AM +0100, Andi Kleen wrote: > On Monday 12 February 2007 09:03, Amit Kale wrote: > > The already released kernel contains a broken driver. It broke due to some > > code rearrangement changes someone submitted to fix sparse warnings. s/sparse warnings/breakage on

Re: NetXen driver name

2007-02-12 Thread Amit Kale
Sending it again from correct smtp server. On Monday 12 February 2007 13:42, Andi Kleen wrote: > On Monday 12 February 2007 09:03, Amit Kale wrote: > > The already released kernel contains a broken driver. It broke due to > > some code rearrangement changes someone submitted to fix sparse warning

  1   2   >