Re: r8169: Crash after reloading driver if network hangs

2007-01-28 Thread Francois Romieu
Bernhard Walle <[EMAIL PROTECTED]> : [...] > Doesn't compile, I think you mean this? Yes. > @@ -1371,10 +1371,9 @@ static inline void rtl8169_request_timer > return; > > init_timer(timer); > - timer->expires = jiffies + RTL8169_PHY_TIMEOUT; > timer->data =

Re: net-2.6.21 GIT tree

2007-01-28 Thread Baruch Even
* David Miller <[EMAIL PROTECTED]> [070129 02:54]: > > I just cut it at: > > kernel.org:/pub/scm/linux/kernel/git/davem/net-2.6.21.git > > Feel free to send me feature patches for consideration. > > I'll probably toss things like Baruch's latest SACK fixes in > there so they can cook for

Re: 2.6.20-rc6-mm1

2007-01-28 Thread Herbert Xu
On Sun, Jan 28, 2007 at 10:43:12PM -0800, Andrew Morton wrote: > > > IIRC Ingo had made fixes for the networking stack in his rt tree since > > the networking code assumes in lots of places that rcu_read_lock > > disables preemption. > > oh. We'd better find those fixes then. I wonder what other

Re: 2.6.20-rc6-mm1

2007-01-28 Thread Andrew Morton
On Mon, 29 Jan 2007 16:29:29 +1100 Herbert Xu <[EMAIL PROTECTED]> wrote: > On Mon, Jan 29, 2007 at 04:17:44PM +1100, Herbert Xu wrote: > > Michal Piotrowski <[EMAIL PROTECTED]> wrote: > > > > > Jan 28 22:58:29 euridica kernel: BUG: using smp_processor_id() in > > > preemptible [0001] code: y

[PATCH] PA Semi PWRficient Ethernet driver

2007-01-28 Thread Olof Johansson
Driver for the PA Semi PWRficient on-chip Ethernet (1/10G) Basic enablement, will be complemented with performance enhancements over time. PHY support will be added as well. This patch still uses the numerical PCI vendor id, it will be replaced when the pci_ids.h change goes in (same as the other

RE: [PATCH 2.6.20 1/5] s2io: Making LRO and UFO as module loadable parameter.

2007-01-28 Thread Sivakumar Subramani
Hi Jeff, As per your comment I have synced up the patch with the latest netdev-2.6.git#upstream branch. Also I have corrected the white space issue. I have resubmitted the patches again. Thanks, ~Siva -Original Message- From: Jeff Garzik [mailto:[EMAIL PROTECTED] Sent: Wednesday, Januar

[PATCH 2.6.20 4/5] s2io: Removed enabling of some of the unused interrupts.

2007-01-28 Thread Ananda Raju
Removed unused code in en_dis_able_nic_intrs(), TX_DMA_INTR, RX_DMA_INTR, TX_XGXS_INTR, MC_INTR Signed-off-by: Sivakumar Subramani <[EMAIL PROTECTED]> --- diff -urpN patch3/drivers/net/s2io.c patch4/drivers/net/s2io.c --- patch3/drivers/net/s2io.c 2007-01-28 11:48:34.0 +0530 +++ patch4/d

[PATCH 2.6.20 3/5] s2io: Fixes in updating skb->truesize and code cleanup.

2007-01-28 Thread Ananda Raju
1. Fix for updating skb->truesize properly. 2. Disable NAPI only if more than one ring configured in case of MSI/MSI-X interrupts. Previously we were disabling NAPI irrespective of number of rings when MSI/MSI-X interrupts were used. 3. Code cleanup. Signed-off-by: Sivakumar Subramani <[EMAI

[PATCH 2.6.20 2/5] S2IO: Fixes for reset and link handling.

2007-01-28 Thread Ananda Raju
1. Fix for reset and link handling. 2. Allow for promiscuos mode and multicast state be maintained through ifconfig up and down. 3. Support to print adapter serial number. Signed-off-by: Sivakumar Subramani <[EMAIL PROTECTED]> --- diff -urpN patch1/drivers/net/s2io.c patch2/drivers/net/s2io.c -

[PATCH 2.6.20 1/5] s2io: Making LRO and UFO as module loadable parameter.

2007-01-28 Thread Ananda Raju
This patch adds two load parameters napi and ufo. Previously NAPI was compilation option with these changes wan enable disable NAPI using load parameter. Also we are introducing ufo load parameter to enable/disable ufo feature Signed-off-by: Sivakumar Subramani <[EMAIL PROTECTED]> --- diff -urpN o

Re: 2.6.20-rc6-mm1

2007-01-28 Thread Herbert Xu
On Mon, Jan 29, 2007 at 04:17:44PM +1100, Herbert Xu wrote: > Michal Piotrowski <[EMAIL PROTECTED]> wrote: > > > Jan 28 22:58:29 euridica kernel: BUG: using smp_processor_id() in > > preemptible [0001] code: yum-updatesd/2846 > > Jan 28 22:58:29 euridica kernel: caller is nf_conntrack_in+0x36

Re: [PATCH 2/3] Seperate DSACK from SACK fast path

2007-01-28 Thread David Miller
From: Herbert Xu <[EMAIL PROTECTED]> Date: Mon, 29 Jan 2007 16:06:07 +1100 > Baruch Even <[EMAIL PROTECTED]> wrote: > >> > >> > Since the SACK receive cache doesn't need the data to be in host > >> > order we also remove the ntohl in the checking loop. > >> ... > >> > - for (i = 0; i< num_sack

Re: 2.6.20-rc6-mm1

2007-01-28 Thread Herbert Xu
Michal Piotrowski <[EMAIL PROTECTED]> wrote: > Jan 28 22:58:29 euridica kernel: BUG: using smp_processor_id() in preemptible > [0001] code: yum-updatesd/2846 > Jan 28 22:58:29 euridica kernel: caller is nf_conntrack_in+0x363/0x47f > [nf_conntrack] > Jan 28 22:58:29 euridica kernel: [] show_

Re: [PATCH 2/3] Seperate DSACK from SACK fast path

2007-01-28 Thread Herbert Xu
Baruch Even <[EMAIL PROTECTED]> wrote: >> >> > Since the SACK receive cache doesn't need the data to be in host >> > order we also remove the ntohl in the checking loop. >> ... >> > - for (i = 0; i< num_sacks; i++) { >> > - __u32 start_seq = ntohl(sp[i].start_seq); >> > - __

Re: [2.6 patch] NF_CONNTRACK_H323 must depend on (IPV6 || IPV6=n)

2007-01-28 Thread Randy Dunlap
Adrian Bunk wrote: On Sun, Jan 28, 2007 at 04:04:42PM -0800, David Miller wrote: From: Adrian Bunk <[EMAIL PROTECTED]> Date: Mon, 29 Jan 2007 01:00:11 +0100 On Sun, Jan 28, 2007 at 03:53:48PM -0800, David Miller wrote: Adrian is this the correct way to constrain the selection between "n" and

[PATCH] zd1211rw: Remove noisy debug message

2007-01-28 Thread Daniel Drake
This causes a lot of uninteresting output in noisy environments, and doesn't really serve any purpose. Signed-off-by: Daniel Drake <[EMAIL PROTECTED]> --- zd_mac.c |2 -- 1 files changed, 0 insertions(+), 2 deletions(-) Index: linux/drivers/net/wireless/zd1211rw/zd_mac.c

[PATCH] zd1211rw: Reset device in the probe call

2007-01-28 Thread Daniel Drake
From: Ulrich Kunitz <[EMAIL PROTECTED]> This resets the device in the probe call. It does work with 2.6.19.2 including the softmac patches. It might fix the reboot/reset problems a lot of people reported. Signed-off-by: Ulrich Kunitz <[EMAIL PROTECTED]> Signed-off-by: Daniel Drake <[EMAIL PROTECT

[PATCH] zd1211rw: Added error stats update

2007-01-28 Thread Daniel Drake
From: Ulrich Kunitz <[EMAIL PROTECTED]> Added update of network device error statistics. Based on earlier work by Maxime Austruy. Signed-off-by: Ulrich Kunitz <[EMAIL PROTECTED]> Signed-off-by: Daniel Drake <[EMAIL PROTECTED]> --- zd_mac.c | 37 - zd_usb.c

[PATCH] zd1211rw: Fixed array size issue in reset_mode

2007-01-28 Thread Daniel Drake
From: Ulrich Kunitz <[EMAIL PROTECTED]> Andy Green found this issue. Signed-off-by: Daniel Drake <[EMAIL PROTECTED]> --- zd_mac.c |5 ++--- 1 files changed, 2 insertions(+), 3 deletions(-) Index: linux/drivers/net/wireless/zd1211rw/zd_mac.c ==

[PATCH] zd1211rw: fix potential leak in usb_init

2007-01-28 Thread Daniel Drake
From: Maxime Austruy <[EMAIL PROTECTED]> usb_init should call destroy_workqueue when usb_register fails. Signed-off-by: Maxime Austruy <[EMAIL PROTECTED]> Signed-off-by: Ulrich Kunitz <[EMAIL PROTECTED]> Signed-off-by: Daniel Drake <[EMAIL PROTECTED]> --- zd_usb.c |1 + 1 files changed, 1 in

[PATCH] zd1211rw: Reset device in the probe call

2007-01-28 Thread Daniel Drake
From: Ulrich Kunitz <[EMAIL PROTECTED]> This resets the device in the probe call. It does work with 2.6.19.2 including the softmac patches. It might fix the reboot/reset problems a lot of people reported. Signed-off-by: Ulrich Kunitz <[EMAIL PROTECTED]> Signed-off-by: Daniel Drake <[EMAIL PROTECT

net-2.6.21 GIT tree

2007-01-28 Thread David Miller
I just cut it at: kernel.org:/pub/scm/linux/kernel/git/davem/net-2.6.21.git Feel free to send me feature patches for consideration. I'll probably toss things like Baruch's latest SACK fixes in there so they can cook for a while and then perhaps after some time we'll backport them into w

Re: [2.6 patch] NF_CONNTRACK_H323 must depend on (IPV6 || IPV6=n)

2007-01-28 Thread Adrian Bunk
On Sun, Jan 28, 2007 at 04:04:42PM -0800, David Miller wrote: > From: Adrian Bunk <[EMAIL PROTECTED]> > Date: Mon, 29 Jan 2007 01:00:11 +0100 > > > On Sun, Jan 28, 2007 at 03:53:48PM -0800, David Miller wrote: > > > Adrian is this the correct way to constrain the selection between > > > "n" and "m

Re: [2.6 patch] NF_CONNTRACK_H323 must depend on (IPV6 || IPV6=n)

2007-01-28 Thread David Miller
From: Adrian Bunk <[EMAIL PROTECTED]> Date: Mon, 29 Jan 2007 01:00:11 +0100 > On Sun, Jan 28, 2007 at 03:53:48PM -0800, David Miller wrote: > > Adrian is this the correct way to constrain the selection between > > "n" and "m" in this kind of situation? I thought doing something > > like "depends

Re: [2.6 patch] NF_CONNTRACK_H323 must depend on (IPV6 || IPV6=n)

2007-01-28 Thread Adrian Bunk
On Sun, Jan 28, 2007 at 03:53:48PM -0800, David Miller wrote: > From: Adrian Bunk <[EMAIL PROTECTED]> > Date: Sun, 28 Jan 2007 23:21:37 +0100 > > > On Sun, Jan 28, 2007 at 11:41:48AM -0800, Randy Dunlap wrote: > > >... > > > net/built-in.o: In function `q931_help': > > > nf_conntrack_h323_main.c:(

Re: [PATCH] netfilter@ is subscribers-only

2007-01-28 Thread David Miller
From: Randy Dunlap <[EMAIL PROTECTED]> Date: Sun, 28 Jan 2007 15:11:08 -0800 > From: Randy Dunlap <[EMAIL PROTECTED]> > > netfilter mailing list is subscribers-only. > > Signed-off-by: Randy Dunlap <[EMAIL PROTECTED]> Applied, thanks Randy. - To unsubscribe from this list: send the line "unsubs

Re: [2.6 patch] NF_CONNTRACK_H323 must depend on (IPV6 || IPV6=n)

2007-01-28 Thread David Miller
From: Adrian Bunk <[EMAIL PROTECTED]> Date: Sun, 28 Jan 2007 23:21:37 +0100 > On Sun, Jan 28, 2007 at 11:41:48AM -0800, Randy Dunlap wrote: > >... > > net/built-in.o: In function `q931_help': > > nf_conntrack_h323_main.c:(.text.q931_help+0x6ad): undefined reference to > > `ip6_route_output' > > n

[PATCH] netfilter@ is subscribers-only

2007-01-28 Thread Randy Dunlap
From: Randy Dunlap <[EMAIL PROTECTED]> netfilter mailing list is subscribers-only. Signed-off-by: Randy Dunlap <[EMAIL PROTECTED]> --- MAINTAINERS |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- linux-2620-rc6.orig/MAINTAINERS +++ linux-2620-rc6/MAINTAINERS @@ -2290,7 +2290,7 @@ P:

Re: 2.6.20-rc6-mm1

2007-01-28 Thread Andrew Morton
On Sun, 28 Jan 2007 23:31:00 +0100 Michal Piotrowski <[EMAIL PROTECTED]> wrote: > Jan 28 22:58:29 euridica kernel: BUG: using smp_processor_id() in preemptible > [0001] code: yum-updatesd/2846 > Jan 28 22:58:29 euridica kernel: caller is nf_conntrack_in+0x363/0x47f > [nf_conntrack] I'll plu

Re: 2.6.20-rc6-mm1

2007-01-28 Thread Michal Piotrowski
Andrew Morton napisaƂ(a): > Temporarily at > > http://userweb.kernel.org/~akpm/2.6.20-rc6-mm1/ > > will appear one day at > > > ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.20-rc6/2.6.20-rc6-mm1/ > > Jan 28 22:58:29 euridica kernel: BUG: using smp_processor_i

[2.6 patch] NF_CONNTRACK_H323 must depend on (IPV6 || IPV6=n)

2007-01-28 Thread Adrian Bunk
On Sun, Jan 28, 2007 at 11:41:48AM -0800, Randy Dunlap wrote: >... > net/built-in.o: In function `q931_help': > nf_conntrack_h323_main.c:(.text.q931_help+0x6ad): undefined reference to > `ip6_route_output' > nf_conntrack_h323_main.c:(.text.q931_help+0x6c3): undefined reference to > `ip6_route_out

Re: Hidden SSID's

2007-01-28 Thread Larry Finger
Dan Williams wrote: > On Fri, 2007-01-26 at 21:48 -0600, Larry Finger wrote: >> Is there a convention regarding the information that a wireless MAC layer >> should provide when >> reporting scan data from an AP with a hidden SSID? >> >> In ieee80211, the software inserts the string "" for such an

[PATCH] bcm43xx: Enable fwpostfix in nondebug bcm43xx

2007-01-28 Thread Larry Finger
From: Michael Buesch <[EMAIL PROTECTED]> The in-kernel bcm43xx driver only works with V3 firmware, whereas the experimental version that incorporates the d80211 stack requires V4 firmware. In bcm43xx-d80211, the fwpostfix module parameter is used to differentiate between the versions. In bcm43xx-s

Re: r8169: Crash after reloading driver if network hangs

2007-01-28 Thread Bernhard Walle
* Francois Romieu <[EMAIL PROTECTED]> [2007-01-28 20:04]: > Bernhard Walle <[EMAIL PROTECTED]> : > [...] > > Simple fix is attached. Although that seems to fix the symptom and not > > the cause, please apply it if you don't have a better solution. > > What about the patch below ? > > diff --git a

Re: r8169: Crash after reloading driver if network hangs

2007-01-28 Thread Francois Romieu
Bernhard Walle <[EMAIL PROTECTED]> : [...] > Simple fix is attached. Although that seems to fix the symptom and not > the cause, please apply it if you don't have a better solution. What about the patch below ? diff --git a/drivers/net/r8169.c b/drivers/net/r8169.c index 577babd..4e22af7 100644 -

r8169: Crash after reloading driver if network hangs

2007-01-28 Thread Bernhard Walle
Hello, also after applying the latest patch that was posted on that mailing list, I have still the problem described in http://bugzilla.kernel.org/show_bug.cgi?id=5137. So after a network hang with several NETDEV WATCHDOG: eth0: transmit timed out in the kernel log, I removed the drive