Re: Bluetooth fixes for 2.6.20-rc5

2007-01-23 Thread Marcel Holtmann
Hi Dave, > > I have one of these and I played with it. They use HID over Bluetooth as > > protocol, but all reports are vendor specific. So you need a specific > > driver to make something useful out of these events. > > It really shouldn't be hard to reverse engineer this right? > Just press a b

What's in netdev-2.6.git

2007-01-23 Thread Jeff Garzik
This is the stuff queued for 2.6.21 in netdev-2.6.git#upstream. Nothing earthshakingly notable. A couple new drivers, a couple removed drivers, a bunch of driver updates. Adrian Bunk (4): remove the broken SKMC driver make hdlc_setup() static again remove the broken OAKNET driv

[git patch] net driver fix

2007-01-23 Thread Jeff Garzik
As the patch indicates, the Al Viro patch had already been merged into my history (and another branch depending on it, making rebasing difficult if not impossible), but since it was merged by Linus, the actual patch isn't shown here by 'git diff'. Please pull from 'upstream-linus' branch of master

Re: [PATCH 10/12] forcedeth: tx max work

2007-01-23 Thread Jeff Garzik
Ayaz Abdulla wrote: This patch adds a limit to how much tx work can be done in each iteration of tx processing. If the max limit is reached, remaining tx completions will be handled by timer interrupt. Signed-Off-By: Ayaz Abdulla <[EMAIL PROTECTED]> applied 10-12 - To unsubscribe from this

Re: [IPV6] RAW: Add checksum default defines for MH.

2007-01-23 Thread Herbert Xu
On Wed, Jan 24, 2007 at 04:05:41PM +0900, YOSHIFUJI Hideaki / ?$B5HF#1QL@ wrote: > > The only reason they (not myself :-)) want to put this in is > because the RFC says that MIP6 implementation MUST compute > checksum by default when it passes the MH to userspace. On > the other hand, it also sta

Re: [IPV6] RAW: Add checksum default defines for MH.

2007-01-23 Thread YOSHIFUJI Hideaki / 吉藤英明
In article <[EMAIL PROTECTED]> (at Wed, 24 Jan 2007 17:56:23 +1100), Herbert Xu <[EMAIL PROTECTED]> says: > David Miller <[EMAIL PROTECTED]> wrote: > > > > Did a complete agreement occur that this patch is ok? > > My only concern is that we're putting an arbitrary list of > protocols in the gene

Re: [IPV6] RAW: Add checksum default defines for MH.

2007-01-23 Thread David Miller
From: Herbert Xu <[EMAIL PROTECTED]> Date: Wed, 24 Jan 2007 17:56:23 +1100 > David Miller <[EMAIL PROTECTED]> wrote: > > > > Did a complete agreement occur that this patch is ok? > > My only concern is that we're putting an arbitrary list of > protocols in the generic raw.c. What's the justifica

Re: [IPV6] RAW: Add checksum default defines for MH.

2007-01-23 Thread Herbert Xu
David Miller <[EMAIL PROTECTED]> wrote: > > Did a complete agreement occur that this patch is ok? My only concern is that we're putting an arbitrary list of protocols in the generic raw.c. What's the justification for including these protocols in particular but not others? Is there any reason wh

Re: Bluetooth fixes for 2.6.20-rc5

2007-01-23 Thread David Miller
From: Marcel Holtmann <[EMAIL PROTECTED]> Date: Wed, 24 Jan 2007 08:38:53 +0100 > I have one of these and I played with it. They use HID over Bluetooth as > protocol, but all reports are vendor specific. So you need a specific > driver to make something useful out of these events. It really shoul

Re: Bluetooth fixes for 2.6.20-rc5

2007-01-23 Thread Marcel Holtmann
Hi Dave, > BTW, do you know if anyone has successfully used the Linux > Bluetooth stack to communicate with the Nintendo Wii > controllers? I am under the impression that they speak > bluetooth. :) I have one of these and I played with it. They use HID over Bluetooth as protocol, but all reports

Re: [PATCH 2/4] [SCTP]: Verify some mandatory parameters.

2007-01-23 Thread David Miller
From: Brian Haley <[EMAIL PROTECTED]> Date: Wed, 17 Jan 2007 15:22:21 -0500 > > --- a/net/sctp/sm_statefuns.c > > +++ b/net/sctp/sm_statefuns.c > > @@ -462,24 +461,6 @@ sctp_disposition_t sctp_sf_do_5_1C_ack(const struct > > sctp_endpoint *ep, > > > - if (!init_tag) { > > - struct sc

Re: why would EPIPE cause socket port to change?

2007-01-23 Thread David Miller
From: Herbert Xu <[EMAIL PROTECTED]> Date: Wed, 24 Jan 2007 16:58:33 +1100 > On Tue, Jan 23, 2007 at 12:26:52PM -0800, Stephen Hemminger wrote: > > > > Why does write cause an autobind? One would think that on a > > SOCK_STREAM socket, the write should just fail with ENOTCONN > > The autobind is

Re: why would EPIPE cause socket port to change?

2007-01-23 Thread Herbert Xu
On Tue, Jan 23, 2007 at 12:26:52PM -0800, Stephen Hemminger wrote: > > Why does write cause an autobind? One would think that on a > SOCK_STREAM socket, the write should just fail with ENOTCONN The autobind is occuring in generic code, i.e., inet_sendmsg(). It will subsequently fail because the s

Re: [IPV6] RAW: Add checksum default defines for MH.

2007-01-23 Thread David Miller
From: Masahide NAKAMURA <[EMAIL PROTECTED]> Date: Wed, 3 Jan 2007 18:32:22 +0900 > Add checksum default defines for mobility header(MH) which > goes through raw socket. As the result kernel's behavior is > to handle MH checksum as default. > > This patch also removes verifying inbound MH checksu

Re: [IP] TUNNEL: Fix to be built with user application.

2007-01-23 Thread David Miller
From: Masahide NAKAMURA <[EMAIL PROTECTED]> Date: Wed, 3 Jan 2007 18:42:53 +0900 > include/linux/if_tunnel.h is broken for user application > because it was changed to use __be32 which is required > to include linux/types.h in advance but didn't. > > (This issue is found when building MIPL2 daem

Re: [PATCH] [IPV6] fixed the size of the netlink message notified by inet6_rt_notify().

2007-01-23 Thread David Miller
From: Patrick McHardy <[EMAIL PROTECTED]> Date: Wed, 17 Jan 2007 13:33:22 +0100 > Thomas Graf wrote: > > * Noriaki TAKAMIYA <[EMAIL PROTECTED]> 2007-01-16 14:01 > >> > >> I think the return value of rt6_nlmsg_size() should includes the > >> amount of RTA_METRICS. > >> > >>Signed-off-by: Noriaki

Re: [PATCH] [IPV6] fixed the size of the netlink message notified by inet6_rt_notify().

2007-01-23 Thread David Miller
From: Thomas Graf <[EMAIL PROTECTED]> Date: Wed, 17 Jan 2007 11:50:06 +0100 > * Noriaki TAKAMIYA <[EMAIL PROTECTED]> 2007-01-16 14:01 > > Hi, > > > > I'm sorry to re-send... > > > > I think the return value of rt6_nlmsg_size() should includes the > > amount of RTA_METRICS. > > > > Regar

Re: why would EPIPE cause socket port to change?

2007-01-23 Thread dean gaudet
On Tue, 23 Jan 2007, David Miller wrote: > From: dean gaudet <[EMAIL PROTECTED]> > Date: Tue, 23 Jan 2007 12:11:01 -0800 (PST) > > > libnss-ldap has some code which attempts to determine if its private > > socket has been trampled on in between calls to the library... and to do > > this it cach

Re: [PATCH] tcp_output: Re: rare bad TCP checksum with 2.6.19?

2007-01-23 Thread David Miller
From: Jarek Poplawski <[EMAIL PROTECTED]> Date: Mon, 22 Jan 2007 07:52:14 +0100 > [PATCH][NET] tcp_output: rare bad TCP checksum with 2.6.19 > > The patch "Replace CHECKSUM_HW by CHECKSUM_PARTIAL/CHECKSUM_COMPLETE" > changed to unconditional copying of ip_summed field from collapsed > skb. This p

Re: [2.6 patch] process include/linux/if_{addr,link}.h with unifdef

2007-01-23 Thread David Miller
From: Adrian Bunk <[EMAIL PROTECTED]> Date: Sun, 21 Jan 2007 20:13:19 +0100 > After commit d3dcc077bf88806201093f86325ec656e4dbfbce, > include/linux/if_{addr,link}.h should be processed with unifdef. > > Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> Applied, thanks Adrian. I believe at least

Re: Bluetooth fixes for 2.6.20-rc5

2007-01-23 Thread David Miller
From: Marcel Holtmann <[EMAIL PROTECTED]> Date: Mon, 22 Jan 2007 22:42:14 +0100 > Hi Dave, > > here are two additional fixes for the Bluetooth subsystem that should go > in before the final 2.6.20 release. It was possible that the well known > PSM could be bound by anybody. That should not be pos

Re: Can someone please try...

2007-01-23 Thread Pavel Roskin
On Tue, 2007-01-23 at 10:21 +0100, Michael Buesch wrote: > On Tuesday 23 January 2007 07:14, Pavel Roskin wrote: > > I have tried the patch, and it doesn't fix the problem. It's a separate > > problem. It happens when bcm43xx_interrupt_handler() is called on a > > device that has already been rem

Re: [2.6 patch] drivers/net/irda/vlsi_ir.{h,c}: remove kernel 2.4 code

2007-01-23 Thread David Miller
From: Samuel Ortiz <[EMAIL PROTECTED]> Date: Sun, 21 Jan 2007 23:36:58 +0200 > On Thu, Jan 18, 2007 at 10:56:13PM +0100, Adrian Bunk wrote: > > This patch removes kernel 2.4 compatibility code. > Looks correct to me, thanks. > > > > Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> > Acked-by: Samu

Re: why would EPIPE cause socket port to change?

2007-01-23 Thread David Miller
From: dean gaudet <[EMAIL PROTECTED]> Date: Tue, 23 Jan 2007 12:11:01 -0800 (PST) > libnss-ldap has some code which attempts to determine if its private > socket has been trampled on in between calls to the library... and to do > this it caches getsockname/getpeername results and compares them e

Re: [PATCH 2.6.20-rc5] IPV6: skb is unexpectedly freed.

2007-01-23 Thread David Miller
From: YOSHIFUJI Hideaki <[EMAIL PROTECTED]> Date: Wed, 24 Jan 2007 13:37:25 +0900 (JST) > In article <[EMAIL PROTECTED]> (at Wed, 24 Jan 2007 15:31:47 +1100), Herbert > Xu <[EMAIL PROTECTED]> says: > > > Masayuki Nakagawa <[EMAIL PROTECTED]> wrote: > > > > > > I suggest to use kfree_skb() inste

Re: [PATCH 2.6.20-rc5] IPV6: skb is unexpectedly freed.

2007-01-23 Thread YOSHIFUJI Hideaki / 吉藤英明
In article <[EMAIL PROTECTED]> (at Wed, 24 Jan 2007 15:31:47 +1100), Herbert Xu <[EMAIL PROTECTED]> says: > Masayuki Nakagawa <[EMAIL PROTECTED]> wrote: > > > > I suggest to use kfree_skb() instead of __kfree_skb(). > > I agree. In fact please do it for all paths in that function, i.e., > just

Re: [PATCH 2.6.20-rc5] IPV6: skb is unexpectedly freed.

2007-01-23 Thread Herbert Xu
Masayuki Nakagawa <[EMAIL PROTECTED]> wrote: > > I suggest to use kfree_skb() instead of __kfree_skb(). I agree. In fact please do it for all paths in that function, i.e., just change __kfree_skb to kfree_skb rather than adding a special case for this path. Thanks, -- Visit Openswan at http://

Re: dscape doesn't auto associate

2007-01-23 Thread Michael Wu
On Tuesday 23 January 2007 20:48, Jon Smirl wrote: > I'll try running NetworkManager in the debugger and see if I can > figure out what is failing. NetworkManager is working ok for me on > non-dscape devices. > Dan, any idea what's happening? FWIW, I'm running NetworkManager 0.6.2 (from SuSE 10.1)

Re: dscape doesn't auto associate

2007-01-23 Thread Michael Wu
On Tuesday 23 January 2007 20:48, Jon Smirl wrote: > As for running as an AP: > rt2570 will start in Master mode > zd1211 refused to set Master mode > No master mode support in zd1211 yet - I haven't had time (and the other two developers don't work on the d80211 version yet). Only client mode is

[PATCH 2.6.20-rc5] IPV6: skb is unexpectedly freed.

2007-01-23 Thread Masayuki Nakagawa
I encountered a kernel panic with my test program, which is a very simple IPv6 client-server program. The server side sets IPV6_RECVPKTINFO on a listening socket, and the client side just sends a message to the server. Then the kernel panic occurs on the server. (If you need the test program, pleas

Re: dscape doesn't auto associate

2007-01-23 Thread Jon Smirl
On 1/23/07, Michael Wu <[EMAIL PROTECTED]> wrote: On Tuesday 23 January 2007 18:23, Jon Smirl wrote: > I have to manually associate the dscape stack with my AP. Is this way > the code is supposed to work? Everything works ok after the manual > association. > It's suppose to work with wpa_supplica

Re: dscape doesn't auto associate

2007-01-23 Thread Jon Smirl
On 1/23/07, Michael Wu <[EMAIL PROTECTED]> wrote: On Tuesday 23 January 2007 18:23, Jon Smirl wrote: > I have to manually associate the dscape stack with my AP. Is this way > the code is supposed to work? Everything works ok after the manual > association. > It's suppose to work with wpa_supplica

Re: dscape doesn't auto associate

2007-01-23 Thread Michael Wu
On Tuesday 23 January 2007 18:23, Jon Smirl wrote: > I have to manually associate the dscape stack with my AP. Is this way > the code is supposed to work? Everything works ok after the manual > association. > It's suppose to work with wpa_supplicant which sets every parameter. NetworkManager uses

Re: [PACKET]: Add PACKET_AUXDATA cmsg

2007-01-23 Thread Herbert Xu
On Wed, Jan 10, 2007 at 01:54:35PM +1100, Herbert Xu wrote: > > [PACKET]: Add optional checksum computation for recvmsg Unfortunately I missed the fact the skb->cb is already used to store the sockaddr. This patch fixes it up. [PACKET]: Fix skb->cb clobbering between aux and sockaddr Both aux

Re: dscape doesn't auto associate

2007-01-23 Thread Johannes Berg
On Tue, 2007-01-23 at 18:23 -0500, Jon Smirl wrote: > I have to manually associate the dscape stack with my AP. Is this way > the code is supposed to work? Everything works ok after the manual > association. Yeah, you currently need to set the channel, BSSID and finally the SSID to get it to assoc

dscape doesn't auto associate

2007-01-23 Thread Jon Smirl
I have to manually associate the dscape stack with my AP. Is this way the code is supposed to work? Everything works ok after the manual association. Is there documentation for this stack? Any special utilities for it? I'd like to get my devices operating in master mode. -- Jon Smirl [EMAIL PROT

Re: [PATCH 10/12] forcedeth: tx max work

2007-01-23 Thread Jeff Garzik
Jeff Garzik wrote: Please resend patches 11 & 12 too. Whereever I stop applying patches, in a patch series, the remaining patches are dropped. Received patches 11 & 12. Maybe my email system was just slow. If so, sorry for the noise. Jeff - To unsubscribe from this list: send th

Re: [PATCH] bcm43xx: Fix scaling error for 'iwlist freq' information

2007-01-23 Thread Michael Buesch
On Tuesday 23 January 2007 23:43, Larry Finger wrote: > The bcm43xx driver returns the available frequencies to 'iwlist freq' with > the wrong scaling. > > Signed-off-by: Larry Finger <[EMAIL PROTECTED]> > --- > > John, > > This is to be applied to wireless-2.6. It could also be sent upstream t

[PATCH 12/12] forcedeth: statistics optimization

2007-01-23 Thread Ayaz Abdulla
This patch optimizes the data paths that can support hw counters. It removes the sw counted statistics. This is the last patch for the optimization set. Bumping up version of driver. Signed-Off-By: Ayaz Abdulla <[EMAIL PROTECTED]> --- orig/drivers/net/forcedeth.c2007-01-21 17:38:50.00

[PATCH 11/12] forcedeth: statistics supported

2007-01-23 Thread Ayaz Abdulla
This patch introduces hw statistics for older devices that supported it. It breaks up the counters supported into separate versions. Signed-Off-By: Ayaz Abdulla <[EMAIL PROTECTED]> --- orig/drivers/net/forcedeth.c2007-01-21 17:33:59.0 -0500 +++ new/drivers/net/forcedeth.c 2007-01

Re: [PATCH 10/12] forcedeth: tx max work

2007-01-23 Thread Jeff Garzik
Ayaz Abdulla wrote: This patch adds a limit to how much tx work can be done in each iteration of tx processing. If the max limit is reached, remaining tx completions will be handled by timer interrupt. Signed-Off-By: Ayaz Abdulla <[EMAIL PROTECTED]> Thanks, will apply soon. Please resend pa

[PATCH] bcm43xx: Fix scaling error for 'iwlist freq' information

2007-01-23 Thread Larry Finger
The bcm43xx driver returns the available frequencies to 'iwlist freq' with the wrong scaling. Signed-off-by: Larry Finger <[EMAIL PROTECTED]> --- John, This is to be applied to wireless-2.6. It could also be sent upstream to 2.6.20, but it is not very important. Larry --- Index: wireless-2.6/

[PATCH 10/12] forcedeth: tx max work

2007-01-23 Thread Ayaz Abdulla
This patch adds a limit to how much tx work can be done in each iteration of tx processing. If the max limit is reached, remaining tx completions will be handled by timer interrupt. Signed-Off-By: Ayaz Abdulla <[EMAIL PROTECTED]> --- orig/drivers/net/forcedeth.c2007-01-19 11:13:59.

Re: [PATCH 4/4] atl1: Ancillary C files for Attansic L1 driver

2007-01-23 Thread Jeff Garzik
Randy Dunlap wrote: Stephen Hemminger wrote: On Tue, 23 Jan 2007 16:33:29 -0500 Jeff Garzik <[EMAIL PROTECTED]> wrote: Stephen Hemminger wrote: IMHO the MSI disabling should be removed from drivers and be done in the PCI core. That is the consensus opinion. Currently drivers implement the M

Re: [PATCH 4/4] atl1: Ancillary C files for Attansic L1 driver

2007-01-23 Thread Randy Dunlap
Stephen Hemminger wrote: On Tue, 23 Jan 2007 16:33:29 -0500 Jeff Garzik <[EMAIL PROTECTED]> wrote: Stephen Hemminger wrote: IMHO the MSI disabling should be removed from drivers and be done in the PCI core. That is the consensus opinion. Currently drivers implement the MSI tests because the

Re: [PATCH 4/4] atl1: Ancillary C files for Attansic L1 driver

2007-01-23 Thread Stephen Hemminger
On Tue, 23 Jan 2007 16:33:29 -0500 Jeff Garzik <[EMAIL PROTECTED]> wrote: > Stephen Hemminger wrote: > > IMHO the MSI disabling should be removed from drivers and be done > > in the PCI core. > > That is the consensus opinion. > > Currently drivers implement the MSI tests because the core PCI co

Re: [PATCH] bcm43xx: Fix scaling error for 'iwlist rate' information

2007-01-23 Thread Rafael J. Wysocki
On Tuesday, 23 January 2007 21:26, Larry Finger wrote: > The bcm43xx scales the rate information supplied to a WE iwlist rate call > incorrectly. > > Signed-off-by: Larry Finger <[EMAIL PROTECTED]> > --- > > John, > > This fix should be applied to wireless-2.6. As it is a bug fix, it could also

Re: [PATCH 4/4] atl1: Ancillary C files for Attansic L1 driver

2007-01-23 Thread Jeff Garzik
Stephen Hemminger wrote: IMHO the MSI disabling should be removed from drivers and be done in the PCI core. That is the consensus opinion. Currently drivers implement the MSI tests because the core PCI code hasn't been up to snuff. I (and others) have been discouraging that, but when a user

Re: [PATCH 0/8] partial resend: e1000 fixes and updates

2007-01-23 Thread Jeff Garzik
Auke Kok wrote: Jeff Garzik wrote: Kok, Auke wrote: Hi, This patch series contains exclusively fixes for e1000. Some of these patches were already sent in december, but didn't make it into any usptream tree yet. Most importantly, it addresses two issues in the recently merged msi interrupt

Re: [git patches] net driver fixes

2007-01-23 Thread Jeff Garzik
Auke Kok wrote: Jeff Garzik wrote: Auke Kok wrote: Jeff Garzik wrote: Please pull from 'upstream-linus' branch of master.kernel.org:/pub/scm/linux/kernel/git/jgarzik/netdev-2.6.git upstream-linus Jeff, is there a reason that you didn't pull the e1000 tree from us? I send you all the infor

Re: [PATCH] mv643xx_eth: Fix race condition in mv643xx_eth_free_tx_descs

2007-01-23 Thread Jeff Garzik
Dale Farnsworth wrote: From Dale Farnsworth <[EMAIL PROTECTED]> mv643xx_eth: Fix race condition in mv643xx_eth_free_tx_descs This bug was found and isolated by Thibaut VARENE <[EMAIL PROTECTED]> and Jarek Poplawski <[EMAIL PROTECTED]>. This patch is a modification of their fixes. We acquire

Re: [PATCH 0/4] atl1: Attansic L1 ethernet driver

2007-01-23 Thread Jeff Garzik
Jay Cliburn wrote: Perhaps a dumb question, but when can I begin submitting differential patches? Now? I'd like to incorporate some of Arjan's and Randy's comments. Submit patches starting... now! :) Jeff - To unsubscribe from this list: send the line "unsubscribe netdev" in the

Re: [PATCH 4/4] atl1: Ancillary C files for Attansic L1 driver

2007-01-23 Thread Luca Tettamanti
Il Tue, Jan 23, 2007 at 11:25:22AM -0800, Stephen Hemminger ha scritto: > On Mon, 22 Jan 2007 21:00:04 +0100 > Luca Tettamanti <[EMAIL PROTECTED]> wrote: > > > Il Sun, Jan 21, 2007 at 09:33:39PM -0600, Jay Cliburn ha scritto: > > > Randy Dunlap wrote: > > > >On Sun, 21 Jan 2007 15:07:37 -0600 Ja

Re: [PATCH] IPv6: Implement RFC 4429 Optimistic Duplicate Address Detection

2007-01-23 Thread Neil Horman
On Tue, Jan 23, 2007 at 09:18:20AM +0900, YOSHIFUJI Hideaki / 吉藤英明 wrote: > Hello. New patch attached, incorporating Yoshijui and Vlads latest comments. I didn't follow guidance on the ndisc_recv_ns comment, Yoshifuji, since Vlad had already suggested an alternate solution in a previous post, bu

Re: Soft lockups with dscape on wireless-dev tree

2007-01-23 Thread Jon Smirl
On 1/23/07, Michael Wu <[EMAIL PROTECTED]> wrote: On Tuesday 23 January 2007 12:10, Jon Smirl wrote: > I've hit this twice. This time I unplugged my USB hub which had the > device in it. > Please try the patch I posted earlier: http://marc.theaimsgroup.com/?l=linux-netdev&m=116841004113998&w=2

[PATCH] bcm43xx: Fix scaling error for 'iwlist rate' information

2007-01-23 Thread Larry Finger
The bcm43xx scales the rate information supplied to a WE iwlist rate call incorrectly. Signed-off-by: Larry Finger <[EMAIL PROTECTED]> --- John, This fix should be applied to wireless-2.6. As it is a bug fix, it could also be sent to 2.6.20; however, it has no real effect on system operations,

Re: why would EPIPE cause socket port to change?

2007-01-23 Thread Stephen Hemminger
On Tue, 23 Jan 2007 16:44:10 +1100 Herbert Xu <[EMAIL PROTECTED]> wrote: > dean gaudet <[EMAIL PROTECTED]> wrote: > > in the test program below the getsockname result on a TCP socket changes > > across a write which produces EPIPE... here's a fragment of the strace: > > > > getsockname(3, {sa_fa

Re: why would EPIPE cause socket port to change?

2007-01-23 Thread dean gaudet
On Tue, 23 Jan 2007, Rick Jones wrote: > Herbert Xu wrote: > > Prior to the last write, the socket entered the CLOSED state meaning > > that the old port is no longer allocated to it. As a result, the > > last write operates on an unconnected socket which causes a new local > > port to be allocat

RE: [PATCH 2.6.20 5/5] s2io: De-typedef driver.

2007-01-23 Thread Sivakumar Subramani
Hi Jeff, Thanks for the comments. We have implemented the comments and resubmitted all five patch again. Thanks, ~Siva -Original Message- From: Jeff Garzik [mailto:[EMAIL PROTECTED] Sent: Tuesday, January 23, 2007 11:18 AM To: Ananda Raju Cc: netdev@vger.kernel.org; Leonid Grossman; Al

[PATCH 2.6.20 4/5] s2io: Removed enabling of some of the unused interrupts.

2007-01-23 Thread Ananda Raju
Removed unused code in en_dis_able_nic_intrs(), TX_DMA_INTR, RX_DMA_INTR, TX_XGXS_INTR, MC_INTR Signed-off-by: Sivakumar Subramani <[EMAIL PROTECTED]> --- diff -urpN patch3/drivers/net/s2io.c patch4/drivers/net/s2io.c --- patch3/drivers/net/s2io.c 2007-01-24 01:11:17.0 +0530 +++ patch4/d

[PATCH 2.6.20 3/5] s2io: Fixes in updating skb->truesize and code cleanup.

2007-01-23 Thread Ananda Raju
1. Fix for updating skb->truesize properly. 2. Disable NAPI only if more than one ring configured in case of MSI/MSI-X interrupts. Previously we were disabling NAPI irrespective of number of rings when MSI/MSI-X interrupts were used. 3. Code cleanup. Signed-off-by: Sivakumar Subramani <[EMAI

[PATCH 2.6.20 2/5] S2IO: Fixes for reset and link handling.

2007-01-23 Thread Ananda Raju
1. Fix for reset and link handling. 2. Allow for promiscuos mode and multicast state be maintained through ifconfig up and down. 3. Support to print adapter serial number. Signed-off-by: Sivakumar Subramani <[EMAIL PROTECTED]> --- diff -urpN patch1/drivers/net/s2io.c patch2/drivers/net/s2io.c -

Re: [PATCH 4/4] atl1: Ancillary C files for Attansic L1 driver

2007-01-23 Thread Stephen Hemminger
On Mon, 22 Jan 2007 21:00:04 +0100 Luca Tettamanti <[EMAIL PROTECTED]> wrote: > Il Sun, Jan 21, 2007 at 09:33:39PM -0600, Jay Cliburn ha scritto: > > Randy Dunlap wrote: > > >On Sun, 21 Jan 2007 15:07:37 -0600 Jay Cliburn wrote: > > [snip] > > > > >>+ value = ioread16(hw->hw_addr + REG_PCIE_CAP_

Re: [PATCH] IPv6: Implement RFC 4429 Optimistic Duplicate Address Detection

2007-01-23 Thread Vlad Yasevich
Hi Neil Neil Horman wrote: > + /* > + * This is not a dad solicitation, meaning we > may > + * need to respond to it, if we are > + * an optimistic node, go ahead, otherwise > +

Re: [PATCH] Marvell Libertas 8388 802.11b/g USB driver (v2)

2007-01-23 Thread Johannes Berg
On Tue, 2007-01-23 at 19:30 +0100, Johannes Berg wrote: > .11s also introduces new frame types/subtypes that probably need to be > ACKed which usually the firmware won't do since it doesn't understand > those frame types/subtypes yet. This assertion might have been premature, it's entirely possib

Re: [PATCH] Marvell Libertas 8388 802.11b/g USB driver (v2)

2007-01-23 Thread Jon Smirl
On 1/23/07, Johannes Berg <[EMAIL PROTECTED]> wrote: On Tue, 2007-01-23 at 12:59 -0500, Dan Williams wrote: > I believe it needs to at least support 4 address frames, which usually > requires firmware changes on fullmac cards, but fully softmac cards > (atheros, broadcom) probably would not. .1

Re: Soft lockups with dscape on wireless-dev tree

2007-01-23 Thread Michael Wu
On Tuesday 23 January 2007 12:10, Jon Smirl wrote: > I've hit this twice. This time I unplugged my USB hub which had the > device in it. > Please try the patch I posted earlier: http://marc.theaimsgroup.com/?l=linux-netdev&m=116841004113998&w=2 Also can be found here: http://kernel.org/git/?p=li

Re: [PATCH] select: fix sys_select to not leak ERESTARTNOHAND to userspace

2007-01-23 Thread Neil Horman
On Tue, Jan 23, 2007 at 10:02:49AM +1100, Andi Kleen wrote: > On Tuesday 23 January 2007 00:00, Neil Horman wrote: > > As it is currently written, sys_select checks its return code to convert > > ERESTARTNOHAND to EINTR. However, the check is within an if (tvp) clause, > > and so if select is call

Re: [PATCH] IPv6: Implement RFC 4429 Optimistic Duplicate Address Detection

2007-01-23 Thread Neil Horman
On Mon, Jan 22, 2007 at 03:25:39PM -0500, Vlad Yasevich wrote: > Hi Neil Yeah, I think your right. I missed the implication of testing for (!dad) at the top of that clause. I think we could accomplish the same thing by moving my additions to the top of the clause, but I think your logic reads m

Re: [PATCH] Marvell Libertas 8388 802.11b/g USB driver (v2)

2007-01-23 Thread Johannes Berg
On Tue, 2007-01-23 at 12:59 -0500, Dan Williams wrote: > I believe it needs to at least support 4 address frames, which usually > requires firmware changes on fullmac cards, but fully softmac cards > (atheros, broadcom) probably would not. .11s also introduces new frame types/subtypes that probab

Re: [PATCH] Marvell Libertas 8388 802.11b/g USB driver (v2)

2007-01-23 Thread Jon Smirl
On 1/23/07, Dan Williams <[EMAIL PROTECTED]> wrote: On Tue, 2007-01-23 at 12:14 -0500, Jon Smirl wrote: > On 1/23/07, Johannes Berg <[EMAIL PROTECTED]> wrote: > > On Tue, 2007-01-23 at 11:18 -0500, Jon Smirl wrote: > > > > > Is the 802.11s Draft 1.0 spec publicly available yet? It is supposed > >

Re: why would EPIPE cause socket port to change?

2007-01-23 Thread Rick Jones
Herbert Xu wrote: dean gaudet <[EMAIL PROTECTED]> wrote: in the test program below the getsockname result on a TCP socket changes across a write which produces EPIPE... here's a fragment of the strace: getsockname(3, {sa_family=AF_INET, sin_port=htons(37636), sin_addr=inet_addr("127.0.0.1")}

bonding: bug in balance-alb mode (incorrect update-ARP-replies)

2007-01-23 Thread JUNG, Christian
Hello, I've discovered a bug in the bonding module of the Linux Kernel, which appears only in bonding-mode balance-alb. Description: You have to setup a box with at least two NICs, a bonding device enslaving those, assign at least two IPs to the bond and make some traffic from a dif

Re: [PATCH] Marvell Libertas 8388 802.11b/g USB driver (v2)

2007-01-23 Thread Dan Williams
On Tue, 2007-01-23 at 12:14 -0500, Jon Smirl wrote: > On 1/23/07, Johannes Berg <[EMAIL PROTECTED]> wrote: > > On Tue, 2007-01-23 at 11:18 -0500, Jon Smirl wrote: > > > > > Is the 802.11s Draft 1.0 spec publicly available yet? It is supposed > > > to be making changes at the very lowest MAC layers.

Re: [PATCH] cfg80211: Correct conditional compile of wext-common.c.

2007-01-23 Thread Johannes Berg
On Sun, 2007-01-21 at 18:19 +0100, Marcus Better wrote: > wext-common.o is required if CONFIG_WIRELESS_EXT is set. Looks like > `CONFIG_NET_WIRELESS' is a typo. > > Signed-off-by: Marcus Better <[EMAIL PROTECTED]> Acked-by: Johannes Berg <[EMAIL PROTECTED]> > --- a/net/wireless/Makefile > +++ b

Re: [PATCH] Marvell Libertas 8388 802.11b/g USB driver (v2)

2007-01-23 Thread Johannes Berg
On Tue, 2007-01-23 at 12:14 -0500, Jon Smirl wrote: > I haven't seen the 11s spec, are devices with softmac implementations > flexible enough to implement it or do they need firmware changes too? I'm pretty sure bcm43xx would need firmware changes. johannes signature.asc Description: This is a

Re: [PATCH] Marvell Libertas 8388 802.11b/g USB driver (v2)

2007-01-23 Thread Jon Smirl
On 1/23/07, Johannes Berg <[EMAIL PROTECTED]> wrote: On Tue, 2007-01-23 at 11:18 -0500, Jon Smirl wrote: > Is the 802.11s Draft 1.0 spec publicly available yet? It is supposed > to be making changes at the very lowest MAC layers. It will be hard to > be compatible with that from user space. Goo

Soft lockups with dscape on wireless-dev tree

2007-01-23 Thread Jon Smirl
I've hit this twice. This time I unplugged my USB hub which had the device in it. Jan 23 11:47:08 jonsmirl kernel: BUG: soft lockup detected on CPU#1! Jan 23 11:47:08 jonsmirl kernel: [softlockup_tick+156/224] softlockup_tick+0x9c/0xe0 Jan 23 11:47:08 jonsmirl kernel: [update_process_times+51/1

Re: [PATCH] mv643xx_eth: Fix race condition in mv643xx_eth_free_tx_descs

2007-01-23 Thread Thibaut VARENE
On 1/23/07, Dale Farnsworth <[EMAIL PROTECTED]> wrote: From Dale Farnsworth <[EMAIL PROTECTED]> mv643xx_eth: Fix race condition in mv643xx_eth_free_tx_descs This bug was found and isolated by Thibaut VARENE <[EMAIL PROTECTED]> and Jarek Poplawski <[EMAIL PROTECTED]>. This patch is a modificati

Re: [PATCH] Marvell Libertas 8388 802.11b/g USB driver (v2)

2007-01-23 Thread Johannes Berg
On Tue, 2007-01-23 at 11:18 -0500, Jon Smirl wrote: > Is the 802.11s Draft 1.0 spec publicly available yet? It is supposed > to be making changes at the very lowest MAC layers. It will be hard to > be compatible with that from user space. Good point, it's not possible to implement this without ch

[PATCH] mv643xx_eth: Fix race condition in mv643xx_eth_free_tx_descs

2007-01-23 Thread Dale Farnsworth
>From Dale Farnsworth <[EMAIL PROTECTED]> mv643xx_eth: Fix race condition in mv643xx_eth_free_tx_descs This bug was found and isolated by Thibaut VARENE <[EMAIL PROTECTED]> and Jarek Poplawski <[EMAIL PROTECTED]>. This patch is a modification of their fixes. We acquire and release the lock for

[PATCH resend] bcm43xx-d80211: Fix DMA TX skb doublefree

2007-01-23 Thread Michael Buesch
This fixes a possible double-free of the TX skb buffers. Always NULL the pointer after freeing. Signed-off-by: Michael Buesch <[EMAIL PROTECTED]> -- I already sent this patch to you on 21 Dec 2006. This is a pretty critical patch, so I'd like to make sure it's in your merge queue and is not lost

Re: [PATCH 0/4] atl1: Attansic L1 ethernet driver

2007-01-23 Thread Jay Cliburn
Jeff Garzik wrote: OK, I have merged the monolithic patch into jgarzik/netdev-2.6.git#atl1. Once I'm done merging patches tonight, I will merge this new 'atl1' branch into the 'ALL' meta-branch, which will auto-propagate this driver into Andrew Morton's -mm for testing. For future driver up

[PATCH review] b44: Port to ssb subsystem

2007-01-23 Thread Michael Buesch
This patch ports b44 to the new SSB subsystem and makes it possible to turn off PCI related stuff. This patch is against my tree, where I have implemented the ssb subsystem. If you're all OK with this patch, I'd like apply it to my tree. I think that's best. Although it's not wireless-related, it

Re: [PATCH] Marvell Libertas 8388 802.11b/g USB driver (v2)

2007-01-23 Thread Jon Smirl
On 1/23/07, Johannes Berg <[EMAIL PROTECTED]> wrote: On Mon, 2007-01-22 at 10:20 -0500, Jon Smirl wrote: > What is the general solution for 802.11s? None yet. > I'm working on an embedded > design that would benefit from 11s support and I'd rather not have to > roll my own mesh implementation

2.6.19.2 sky2/acpi crashes

2007-01-23 Thread Lionel Landwerlin
Hi, I'm running a macbook with a Marvell ethernet controller, and I have a lots of freezes when using the ethernet controller under a load of ~100K/s. Since I'm running a 2.6.19.2 kernel, I'm able to get some report from the kernel. Here they are : Jan 23 09:30:57 cocoduo kernel: [ 662.92] N

Re: [PATCH] Marvell Libertas 8388 802.11b/g USB driver (v2)

2007-01-23 Thread Johannes Berg
On Mon, 2007-01-22 at 10:20 -0500, Jon Smirl wrote: > What is the general solution for 802.11s? None yet. > I'm working on an embedded > design that would benefit from 11s support and I'd rather not have to > roll my own mesh implementation in user space. Well, there is no mesh implementation t

Re: [PATCH] bcm43xx: Fix problem with >1 GB RAM

2007-01-23 Thread Michael Buesch
On Tuesday 23 January 2007 16:18, Dan Williams wrote: > > At present, I have a problem getting NetworkManager to see the d80211 > > wireless interface. Once I get > > that solved, I plan to use my system to test with > 1 GB RAM on your git > > tree. In that case, I'll > > switch to the pci-form o

Re: adm8211 (from linville wireless-2.6) in xen guest

2007-01-23 Thread Dan Williams
On Mon, 2007-01-22 at 14:30 -0500, Michael Wu wrote: > On Saturday 20 January 2007 07:19, Jan Evert van Grootheest wrote: > > Hi, > > > > Just writing to thank all of you that made the adm8211 driver in John > > Linvilles wireless-2.6 development tree (not the dscape one, which I > > will try also)

Re: [PATCH] bcm43xx: Fix problem with >1 GB RAM

2007-01-23 Thread Dan Williams
On Mon, 2007-01-22 at 14:18 -0600, Larry Finger wrote: > Michael Buesch wrote: > > On Saturday 20 January 2007 17:18, Larry Finger wrote: > >> Some versions of the bcm43xx chips only support 30-bit DMA, which means > >> that the descriptors and buffers must be in the first 1 GB of RAM. On > >> the

Re: [RFC] airo.c: Description and function is not the same

2007-01-23 Thread Dan Williams
On Sun, 2007-01-21 at 13:01 +0100, Richard Knutsson wrote: > Hello > > In the tour of converting local definitions of boolean-type/values, I > ran into airo.c's description of ex decapsulate(): > > * Returns: BOOLEAN - TRUE if packet should be dropped otherwise FALSE > > but returns SUCCE

Re: [PATCH] Re: kernel BUG in eth_alloc_tx_desc_index at drivers/net/mv643xx_eth.c:1069!

2007-01-23 Thread Thibaut VARENE
On 1/23/07, Thibaut VARENE <[EMAIL PROTECTED]> wrote: - As Jarek pointed out, you're checking twice the value of mp->tx_desc_count, which means dereferencing a pointer and accessing memory twice. I don't know how perf-critical this bit of code is, but I wonder which of keeping the lock for a long

Re: [PATCH] Re: kernel BUG in eth_alloc_tx_desc_index at drivers/net/mv643xx_eth.c:1069!

2007-01-23 Thread Thibaut VARENE
On 1/22/07, Dale Farnsworth <[EMAIL PROTECTED]> wrote: Jarek and Thibaut, Thank you both very much for your work finding and fixing this bug. Jarek, can you verify that the following patch fixes the problem you were seeing? -Dale Hi Dale, The patch seems to work fine. Just thinking out loud

Re: why would EPIPE cause socket port to change?

2007-01-23 Thread Herbert Xu
On Tue, Jan 23, 2007 at 02:15:45PM +0300, Michael Tokarev wrote: > > Still, after the connection has been closed, there's no chance to do > anything with the filedescriptor but to close it as well, right? Or > can the fd be reused by making new connection with it, as if it were > just returned fr

Re: why would EPIPE cause socket port to change?

2007-01-23 Thread Michael Tokarev
Herbert Xu wrote: > On Tue, Jan 23, 2007 at 02:10:39PM +0300, Michael Tokarev wrote: >> Well, but why getsockname() didn't just return ENOTCONN? > > It's perfectly valid to have a local port number without being connected. Er. You're right - I was confusing getSOCKname() and getPEERname(). Stil

Re: why would EPIPE cause socket port to change?

2007-01-23 Thread Herbert Xu
On Tue, Jan 23, 2007 at 02:10:39PM +0300, Michael Tokarev wrote: > > Well, but why getsockname() didn't just return ENOTCONN? It's perfectly valid to have a local port number without being connected. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <[EMAIL PROT

Re: why would EPIPE cause socket port to change?

2007-01-23 Thread Michael Tokarev
Herbert Xu wrote: > dean gaudet <[EMAIL PROTECTED]> wrote: >> in the test program below the getsockname result on a TCP socket changes >> across a write which produces EPIPE... here's a fragment of the strace: >> >> getsockname(3, {sa_family=AF_INET, sin_port=htons(37636), >> sin_addr=inet_addr("

Re: XFRM does not rate limit messages from the kernel to userspace

2007-01-23 Thread Marco Berizzi
Herbert Xu wrote: > Marco Berizzi <[EMAIL PROTECTED]> wrote: > > > > AFAIK it was applied to osw 2.4.2 > > Also changelog confirm this: > > > > v2.4.2 > > Indeed. Somehow I couldn't find the patch in the git tree that > I had here. It wasn't the 2.4 branch though. > > I presume you're using 2.4.

Re: XFRM does not rate limit messages from the kernel to userspace

2007-01-23 Thread Herbert Xu
Marco Berizzi <[EMAIL PROTECTED]> wrote: > > AFAIK it was applied to osw 2.4.2 > Also changelog confirm this: > > v2.4.2 Indeed. Somehow I couldn't find the patch in the git tree that I had here. It wasn't the 2.4 branch though. I presume you're using 2.4.x as well? If so I'll neet to look a

Re: [PATCH] bcm43xx_d80211: Fix major memory corruption bug

2007-01-23 Thread Michael Buesch
On Sunday 21 January 2007 06:27, Pavel Roskin wrote: > Set phy->lo_control to NULL whenever it's freed. Failure to do so leads > to zeroing a block of memory that uses to hold *phy->lo_control, which > caused random crashes down the road. > > Signed-off-by: Pavel Roskin <[EMAIL PROTECTED]> Appli

  1   2   >