RE: [PATCH 2.6.20-rc3] UCC Ether driver: kmalloc casting cleanups

2007-01-07 Thread Li Yang-r58472
> -Original Message- > From: Ahmed S. Darwish [mailto:[EMAIL PROTECTED] > Sent: Monday, January 08, 2007 12:27 PM > To: Li Yang-r58472 > Cc: linux-kernel@vger.kernel.org; netdev@vger.kernel.org > Subject: Re: [PATCH 2.6.20-rc3] UCC Ether driver: kmalloc casting cleanups > > On Mon, Jan 08,

Re: BUG: soft lockup detected on CPU#0! (2.6.18.2 plus hacks)

2007-01-07 Thread Jarek Poplawski
On Fri, Jan 05, 2007 at 12:33:43PM -0800, Ben Greear wrote: ... > So, I do believe this was the problem we were hitting, and it seems fixed. Congratulations! But I can see one strange thing in vlan.c: /* Must be invoked with RCU read lock (no preempt) */ static struct vlan_group *__vlan_find_gro

Re: [PATCH 2.6.20-rc3] UCC Ether driver: kmalloc casting cleanups

2007-01-07 Thread Ahmed S. Darwish
On Mon, Jan 08, 2007 at 11:12:28AM +0800, Li Yang-r58472 wrote: > > NACK about the 2 clean-ups above. Cast from pointer to integer is > required here. > Hi, here's the modified patch. A patch to switch kmalloc to kzalloc and clean some redundant kmalloc casts. Signed-off-by: Ahmed S. Darwish <

Re: [PATCH 2.6.20-rc3] UCC Ether driver: kmalloc casting cleanups

2007-01-07 Thread Ahmed S. Darwish
On Mon, Jan 08, 2007 at 11:12:28AM +0800, Li Yang-r58472 wrote: > > From: Ahmed S. Darwish [mailto:[EMAIL PROTECTED] > > > > Hi, > > A kmalloc casting cleanup patch. > > Signed-off-by: Ahmed Darwish <[EMAIL PROTECTED]> [..] > > - (u32) (kmalloc((u32) (length + align), >

Re: Bluetooth fixes for 2.6.20-rc4

2007-01-07 Thread David Miller
From: Marcel Holtmann <[EMAIL PROTECTED]> Date: Mon, 08 Jan 2007 02:44:41 +0100 > it is way too late and you are absolutely right. However since the > current code doesn't produce a compiler warning of an uninitialized > variable, I prefer to not go with a "int err = 0" to make this work. > > I r

Re: Pull request for 'qla3xxx-upstream-fixes-20070103-00' tag

2007-01-07 Thread Jeff Garzik
Francois Romieu wrote: Please pull from tag 'qla3xxx-upstream-fixes-20070103-00' in repository git://electric-eye.fr.zoreil.com/home/romieu/linux-2.6.git tag qla3xxx-upstream-fixes-20070103-00 to get the changes below. Distance from 'netdev-2.6-upstream-fixes'

Re: [PATCH RESEND] 3 ixgb fixes, please pull

2007-01-07 Thread Jeff Garzik
Auke Kok wrote: Hi, These 3 patches were earlier submitted and ACKed by Jeff Garzik on 12/08, 12/11. They were part of a larger submission that also included e1000 patches. The ixgb patches still need to be merged. The spurious NETIF_F_TSO flags were removed from patch "Fix early TSO comple

Re: Bluetooth fixes for 2.6.20-rc4

2007-01-07 Thread Marcel Holtmann
Hi Dave, > > > > Commit: 2b2e64be763c5e64d4ae4a061825b18decf1edf7 > > > > Author: Marcel Holtmann <[EMAIL PROTECTED]> Mon, 08 Jan 2007 01:00:33 > > > > +0100 > > > > > > > > [Bluetooth] Fix uninitialized return value for RFCOMM sendmsg() > > > > > > > > When calling send() with a

Re: Bluetooth fixes for 2.6.20-rc4

2007-01-07 Thread David Miller
From: Marcel Holtmann <[EMAIL PROTECTED]> Date: Mon, 08 Jan 2007 02:19:13 +0100 > Hi Dave, > > > > Commit: 2b2e64be763c5e64d4ae4a061825b18decf1edf7 > > > Author: Marcel Holtmann <[EMAIL PROTECTED]> Mon, 08 Jan 2007 01:00:33 > > > +0100 > > > > > > [Bluetooth] Fix uninitialized return valu

Re: Bluetooth fixes for 2.6.20-rc4

2007-01-07 Thread Marcel Holtmann
Hi Dave, > > Commit: 2b2e64be763c5e64d4ae4a061825b18decf1edf7 > > Author: Marcel Holtmann <[EMAIL PROTECTED]> Mon, 08 Jan 2007 01:00:33 +0100 > > > > [Bluetooth] Fix uninitialized return value for RFCOMM sendmsg() > > > > When calling send() with a zero length parameter on a RFCOMM

Re: Bluetooth fixes for 2.6.20-rc4

2007-01-07 Thread David Miller
From: Marcel Holtmann <[EMAIL PROTECTED]> Date: Mon, 08 Jan 2007 01:31:44 +0100 > Commit: 2b2e64be763c5e64d4ae4a061825b18decf1edf7 > Author: Marcel Holtmann <[EMAIL PROTECTED]> Mon, 08 Jan 2007 01:00:33 +0100 > > [Bluetooth] Fix uninitialized return value for RFCOMM sendmsg() > > W

Bluetooth fixes for 2.6.20-rc4

2007-01-07 Thread Marcel Holtmann
Hi Dave, here are the missing fixes for the Bluetooth subsystem that should go in before the final 2.6.20 release. Please forward them to Linus as soon as possible. Regards Marcel Please pull from git://git.kernel.org/pub/scm/linux/kernel/git/holtmann/bluetooth-2.6.git This will upda

Re: 2.6.20-rc4: known regressions with patches available

2007-01-07 Thread Marcel Holtmann
Hi Adrian, > This email lists some known regressions in 2.6.20-rc4 compared to 2.6.19 > with patches available. > > If you find your name in the Cc header, you are either submitter of one > of the bugs, maintainer of an affectected subsystem or driver, a patch > of you caused a breakage or I'm co

2.6.20-rc4: known regressions with patches available

2007-01-07 Thread Adrian Bunk
This email lists some known regressions in 2.6.20-rc4 compared to 2.6.19 with patches available. If you find your name in the Cc header, you are either submitter of one of the bugs, maintainer of an affectected subsystem or driver, a patch of you caused a breakage or I'm considering you in any oth

2.6.20-rc4: known unfixed regressions

2007-01-07 Thread Adrian Bunk
This email lists some known regressions in 2.6.20-rc4 compared to 2.6.19. If you find your name in the Cc header, you are either submitter of one of the bugs, maintainer of an affectected subsystem or driver, a patch of you caused a breakage or I'm considering you in any other way possibly involve

Re: [PATCH/RFC 00/10] Transparent proxying patches version 4

2007-01-07 Thread Lennert Buytenhek
On Sun, Jan 07, 2007 at 03:11:34PM +0100, Harald Welte wrote: > > So instead of using NAT to dynamically redirect traffic to local > > addresses, we now rely on "native" non-locally-bound sockets and do > > early socket lookups for inbound IPv4 packets. > > It's good to see a solid implementatio

Re: [PATCH/RFC 00/10] Transparent proxying patches version 4

2007-01-07 Thread Harald Welte
Hi Krisztian! On Wed, Jan 03, 2007 at 05:33:57PM +0100, KOVACS Krisztian wrote: > So instead of using NAT to dynamically redirect traffic to local > addresses, we now rely on "native" non-locally-bound sockets and do > early socket lookups for inbound IPv4 packets. It's good to see a solid imple