Re: [PATCH] net: ifb error path loop fix

2007-01-01 Thread David Miller
From: Mariusz Kozlowski <[EMAIL PROTECTED]> Date: Tue, 2 Jan 2007 00:55:51 +0100 > On error we should start freeing resources at [i-1] not [i-2]. > > Signed-off-by: Mariusz Kozlowski <[EMAIL PROTECTED]> Patch applied, thanks Mariusz. > diff -upr linux-2.6.20-rc2-mm1-a/drivers/net/ifb.c > linux

Re: BUG: soft lockup detected on CPU#0! (2.6.18.2 plus hacks)

2007-01-01 Thread Jarek Poplawski
On Mon, Jan 01, 2007 at 09:00:05PM -0800, Ben Greear wrote: > I finally had time to look through the code in this backtrace in > detail. I think it *could* > be a race between ip_rcv and inetdev_init, but I am not certain. Other > than that, I'm real > low on ideas. I found a few more stack tr

Re: BUG: soft lockup detected on CPU#0! (2.6.18.2 plus hacks)

2007-01-01 Thread Ben Greear
I finally had time to look through the code in this backtrace in detail. I think it *could* be a race between ip_rcv and inetdev_init, but I am not certain. Other than that, I'm real low on ideas. I found a few more stack trace debugging options to enable..perhaps that will give a better bac

Re: pktgen

2007-01-01 Thread David Miller
From: Robert Olsson <[EMAIL PROTECTED]> Date: Fri, 1 Dec 2006 09:14:01 +0100 > > David Miller writes: > > > Agreed. > > > > Robert, please fix this by using a completion so that we can > > wait for the threads to start up, something like this: > > Included. It passes my test but Alexey and

Re: [patch] ifb double-counts packets

2007-01-01 Thread David Miller
From: dean gaudet <[EMAIL PROTECTED]> Date: Sat, 23 Dec 2006 13:58:24 -0800 (PST) > On Sat, 23 Dec 2006, jamal wrote: > > > On Sat, 2006-23-12 at 02:35 -0800, dean gaudet wrote: > > > it seems that ifb counts packets twice... both at xmit time and also in > > > the tasklet. i'm not sure which o

Re: [git patches] net driver fixes

2007-01-01 Thread Herbert Xu
Jeff Garzik <[EMAIL PROTECTED]> wrote: > > e1000: Do not truncate TSO TCP header with 82544 workaround This change obsoletes the following change. > e1000: disable TSO on the 82544 with slab debugging So the slab debugging patch should be reverted. Thanks, -- Visit Openswan at http:

[PATCH] net: ifb error path loop fix

2007-01-01 Thread Mariusz Kozlowski
Hello, On error we should start freeing resources at [i-1] not [i-2]. Signed-off-by: Mariusz Kozlowski <[EMAIL PROTECTED]> drivers/net/ifb.c |3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff -upr linux-2.6.20-rc2-mm1-a/drivers/net/ifb.c linux-2.6.20-rc2-mm1-b/drivers/net

[PATCH] d80211: Fix inconsistent sta_lock usage

2007-01-01 Thread Jan Kiszka
Hacking a bit on rt2x00 to make it work in master and ad-hoc mode, lockdep popped up on some hostapd ioctls, pointing out remaining inconsistencies related to sta_lock: 1. sta_lock holders must always be protected against softirq 2. bss_tim_set/clear must not be called with sta_lock held, rather a

[PATCH] d80211: Reinit keys on mode change

2007-01-01 Thread Jan Kiszka
Switching the interface mode with some encryption keys set and then later touching any key, triggers an oops because ieee80211_if_reinit fails to NULL'ify the related pointers after free'ing the key on mode change. Long explanation, simple fix below. Signed-off-by: Jan Kiszka <[EMAIL PROTECTED]>

Re: [PATCH] net/core/flow.c: compare data with memcmp

2007-01-01 Thread Daniel Marjamäki
Hello! I have done a little testing on my own. My results is that memcpy is many times faster even with aligned data. I am testing in an ordinary console program. I am including the code below. If I'm doing something wrong, please tell me so. As you can see I am not using the same datadeclarati

Re: [PATCH] net/core/flow.c: compare data with memcmp

2007-01-01 Thread David Miller
From: "Daniel_Marjamäki" <[EMAIL PROTECTED]> Date: Mon, 1 Jan 2007 08:47:48 +0100 > So you mean that in this particular case it's faster with a handcoded > comparison than memcmp? Because both key1 and key2 are located at > word-aligned addresses? > That's fascinating. Essentially, yes. However,

Re: [BUG KERNEL 2.6.20-rc1] ftp: get or put stops during file-transfer

2007-01-01 Thread Komuro
> > Can you reproduce it with other ftp client and/or server? I tried the proftpd-1.3.0a-1.fc6(kernel version is 2.6.19). The ftp stop problem does not happen. Therefore, this problem is reproduced when client's kernel-version is 2.6.20-rc1 or later and server is vsftpd. Server's kernel-version