Re: [PATCH wireless-2.6-git] prism54: WPA/RSN support for fullmac cards

2006-11-17 Thread Dmitry Torokhov
On Friday 17 November 2006 15:53, [EMAIL PROTECTED] wrote: > > > > The card is WG511 talking to netgear WGR614 router. I am using WEP128 > > with shared keys. Router is set to be "g" only. The OS is Fedora Core > > 3 (I swear I will upgrade :) ), just recompiled wireless tools from > > sources in F

Re: [PATCH 00/13] NetLabel cleanups for 2.6.20 [GIT]

2006-11-17 Thread James Morris
On Fri, 17 Nov 2006, [EMAIL PROTECTED] wrote: > This patchset consists of a lot of small-ish cleanups for NetLabel and in some > cases labeled networking in general. I've tested these patches for the past > few days and I haven't seen any regressions so please consider them for the > net-2.6.20 g

[PATCH 2/2] chelsio: 1G board support

2006-11-17 Thread Stephen Hemminger
This patch is the addon to the Chelsio 10G driver to support their 1G boards. I extracted this from the vendor driver version 2.2 code, and cleaned it up to match the mainline code. I don't have the hardware, so it probably doesn't work as is. But getting it to development kernel will get others

Re: [PATCH]: bcm43xx-d80211: fix hwcrypto issues (mcast)

2006-11-17 Thread Paul TBBle Hampson
On Fri, Nov 17, 2006 at 06:46:29PM +1100, Benjamin Herrenschmidt wrote: > On Thu, 2006-11-16 at 15:07 +0100, Michael Buesch wrote: >> This fixes various bcm43xx-d80211 hwcrypto issues, >> which mainly prevented mcast frames from being decrypted properly. >> >> This is mostly a rewrite of the key m

[PATCH 2/2] chelsio: use kzalloc

2006-11-17 Thread Stephen Hemminger
Use kzalloc() in chelsio driver. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- chelsio-t2.orig/drivers/net/chelsio/sge.c +++ chelsio-t2/drivers/net/chelsio/sge.c @@ -335,10 +335,9 @@ static int alloc_rx_resources(struct sge goto err_no_mem; mems

[PATCH 1/2] chelsio: use __netif_rx_schedule_prep

2006-11-17 Thread Stephen Hemminger
The chelsio driver can use __netif_rx_schedule_prep instead of it's own test_and_set inline. Applies after the previous 4 patches. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- chelsio-t2.orig/drivers/net/chelsio/sge.c +++ chelsio-t2/drivers/net/chelsio/sge.c @@ -929,18 +929,6 @@ sta

Re: [PATCH 0/10] d80211: move away from wmaster towards wiphy

2006-11-17 Thread Johannes Berg
> No driver updates for now, sorry. Ah well, here we go :) bcm43xx patch to go with this. I noticed one bug in my other patches, if you have already downloaded them please do so again. This thing will conflict with lots of things Michael has in his tree, but just as a starting point... Working

[RFC: 2.6 patch] remove broken net drivers

2006-11-17 Thread Adrian Bunk
This patch removes net drivers that: - had already been marked as BROKEN in 2.6.0 three years ago and - are still marked as BROKEN. These are the following drivers: - MAC89x0 - ATARI_BIONET - ATARI_PAMSNET - SKMC Drivers that had been marked as BROKEN for such a long time seem to be unlikely to

Re: d80211: RFC: divide by zero when hw->maxssi not set

2006-11-17 Thread Michael Wu
On Friday 17 November 2006 18:51, David Kimdon wrote: > - reject registration of devices which do not set maxssi > - do not attempt to report link quality for drivers which do not > set maxssi > - other ideas? > I've noticed that too. p54 didn't get a driver update when maxssi was added. I don't

Re: Generic Netlink HOW-TO based on Jamal's original doc

2006-11-17 Thread Paul Moore
jamal wrote: > #1. I think the content layout has improved over the previous doc. So > good stuff. > Something still bothers me though; whether there is too much theory or > verbosity (not that this long email has any of those > characteristics;->). I am wondering if that affects usability. As a >

d80211: RFC: divide by zero when hw->maxssi not set

2006-11-17 Thread David Kimdon
Hi, commit 448bf25bc9e3d70a211fdf235426472089371c43 added ieee80211_get_wireless_stats in net/d80211/ieee80211_ioctl.c. At present we get a divide by zero (oops) if the low level driver does not set the new hw->maxssi field. Perhaps: - reject registration of devices which do not set maxssi - do

Re: [PATCH 0/10] d80211: move away from wmaster towards wiphy

2006-11-17 Thread Pavel Roskin
Hello Johannes, On Fri, 2006-11-17 at 23:27 +0100, Johannes Berg wrote: > Since it looks like we'll be able to move the qdisc stuff over to a new > wiphy concept the master device is getting completely useless. Joy :) Could you please provide details about the solution? Maybe a link? Here's wh

Re: [PATCH]: bcm43xx-d80211: fix hwcrypto issues (mcast)

2006-11-17 Thread Martin Langer
On Fri, Nov 17, 2006 at 12:04:42PM +0100, Johannes Berg wrote: > On Fri, 2006-11-17 at 11:35 +0100, Andreas Schwab wrote: > > > Still the same. One of them does not exist, the other one requires > > Javascript! > > Yeah, looks like Martin forgot to put the URLs in the the readme while > he put t

[PATCH 10/13] NetLabel: use cipso_v4_doi_search() for local CIPSOv4 functions

2006-11-17 Thread paul . moore
From: Paul Moore <[EMAIL PROTECTED]> The cipso_v4_doi_search() function behaves the same as cipso_v4_doi_getdef() but is a local, static function so use it whenever possibile in the CIPSOv4 code base. Signed-of-by: Paul Moore <[EMAIL PROTECTED]> --- net/ipv4/cipso_ipv4.c |6 +++--- 1 files c

[PATCH] d80211: remove useless driver name field

2006-11-17 Thread Johannes Berg
struct ieee80211_ops has a driver name field that's never used. Remove it. Signed-off-by: Johannes Berg <[EMAIL PROTECTED]> --- applies after the 10 patches --- wireless-dev.orig/include/net/d80211.h 2006-11-17 23:37:10.249703408 +0100 +++ wireless-dev/include/net/d80211.h 2006-11-17 23:

[PATCH 07/13] NetLabel: fixup the handling of CIPSOv4 tags to allow for multiple tag types

2006-11-17 Thread paul . moore
From: Paul Moore <[EMAIL PROTECTED]> While the original CIPSOv4 code had provisions for multiple tag types the implementation was not as great as it could be, pushing a lot of non-tag specific processing into the tag specific code blocks. This patch fixes that issue making it easier to support mu

[PATCH 12/13] SELinux: peer secid consolidation for external network labeling

2006-11-17 Thread paul . moore
From: Paul Moore <[EMAIL PROTECTED]> Now that labeled IPsec makes use of the peer_sid field in the sk_security_struct we can remove a lot of the special cases between labeled IPsec and NetLabel. In addition, create a new function, security_skb_extlbl_sid(), which we can use in several places to g

[PATCH 05/13] NetLabel: check for a CIPSOv4 option before we do call into the CIPSOv4 layer

2006-11-17 Thread paul . moore
From: Paul Moore <[EMAIL PROTECTED]> Right now the NetLabel code always jumps into the CIPSOv4 layer to determine if a CIPSO IP option is present. However, we can do this check directly in the NetLabel code by making use of the CIPSO_V4_OPTEXIST() macro which should save us a function call in the

[PATCH 13/13] NetLabel: honor the audit_enabled flag

2006-11-17 Thread paul . moore
From: Paul Moore <[EMAIL PROTECTED]> The audit_enabled flag is used to signal when syscall auditing is to be performed. While NetLabel uses a Netlink interface instead of syscalls, it is reasonable to consider the NetLabel Netlink interface as a form of syscall so pay attention to the audit_enabl

[PATCH 04/13] NetLabel: make netlbl_lsm_secattr struct easier/quicker to understand

2006-11-17 Thread paul . moore
From: Paul Moore <[EMAIL PROTECTED]> The existing netlbl_lsm_secattr struct required the LSM to check all of the fields to determine if any security attributes were present resulting in a lot of work in the common case of no attributes. This patch adds a 'flags' field which is used to indicate wh

[PATCH 06/13] NetLabel: add tag verification when adding new CIPSOv4 DOI definitions

2006-11-17 Thread paul . moore
From: Paul Moore <[EMAIL PROTECTED]> Currently the CIPSOv4 engine does not do any sort of checking when a new DOI definition is added. The tags are still verified but only as a side effect of normal NetLabel operation (packet processing, socket labeling, etc.) which would cause application errors

[PATCH 01/13] NetLabel: use gfp_t instead of int where it makes sense

2006-11-17 Thread paul . moore
From: Paul Moore <[EMAIL PROTECTED]> There were a few places in the NetLabel code where the int type was being used instead of the gfp_t type, this patch corrects this mistake. Signed-off-by: Paul Moore <[EMAIL PROTECTED]> --- include/net/netlabel.h |2 +- 1 files changed, 1 insertion(+), 1

[PATCH 03/13] NetLabel: change netlbl_secattr_init() to return void

2006-11-17 Thread paul . moore
From: Paul Moore <[EMAIL PROTECTED]> The netlbl_secattr_init() function would always return 0 making it pointless to have a return value. This patch changes the function to return void. Signed-off-by: Paul Moore <[EMAIL PROTECTED]> --- include/net/netlabel.h |6 ++ 1 files changed, 2 in

[PATCH 02/13] NetLabel: convert the unlabeled accept flag to use RCU

2006-11-17 Thread paul . moore
From: Paul Moore <[EMAIL PROTECTED]> Currently the NetLabel unlabeled packet accept flag is an atomic type and it is checked for every non-NetLabel packet which comes into the system but rarely ever changed. This patch changes this flag to a normal integer and protects it with RCU locking. Signe

[PATCH 09/13] NetLabel: use the correct CIPSOv4 MLS label limits

2006-11-17 Thread paul . moore
From: Paul Moore <[EMAIL PROTECTED]> The CIPSOv4 engine currently has MLS label limits which are slightly larger than what the draft allows. This is not a major problem due to the current implementation but we should fix this so it doesn't bite us later. Signed-off-by: Paul Moore <[EMAIL PROTECT

[PATCH 00/13] NetLabel cleanups for 2.6.20

2006-11-17 Thread paul . moore
This patchset consists of a lot of small-ish cleanups for NetLabel and in some cases labeled networking in general. I've tested these patches for the past few days and I haven't seen any regressions so please consider them for the net-2.6.20 git tree. The patches are fairly varied so it doesn't m

[PATCH 11/13] NetLabel: SELinux cleanups

2006-11-17 Thread paul . moore
From: Paul Moore <[EMAIL PROTECTED]> This patch does a lot of cleanup in the SELinux NetLabel support code. A summary of the changes include: * Use RCU locking for the NetLabel state variable in the skk_security_struct instead of using the inode_security_struct mutex. * Remove unnecessary para

[PATCH 08/13] NetLabel: return the correct error for translated CIPSOv4 tags

2006-11-17 Thread paul . moore
From: Paul Moore <[EMAIL PROTECTED]> The CIPSOv4 translated tag #1 mapping does not always return the correct error code if the desired mapping does not exist; instead of returning -EPERM it returns -ENOSPC indicating that the buffer is not large enough to hold the translated value. This was caus

[PATCH]: spidernet poor network performance

2006-11-17 Thread Linas Vepstas
Andrew, Please apply. --linas This patch corrects a problem seen on later kernels running the NetPIPE application. Specifically, NetPIPE would begin running very slowly at the 1533 packet size. It was determined that Spidernet slowed with an idle DMA engine. Signed-off-by: James K Lewis

[PATCH 0/10] d80211: move away from wmaster towards wiphy

2006-11-17 Thread Johannes Berg
Hi, Since it looks like we'll be able to move the qdisc stuff over to a new wiphy concept the master device is getting completely useless. Joy :) Here's a series of patches to migrate d80211 away from the wmaster and more towards a wiphy concept. This series targets the driver API. Since I have

Re: [PATCH 1/10] cxgb3 - main header files

2006-11-17 Thread Roland Dreier
> > +#define MDIO_LOCK(adapter) down(&(adapter)->mdio_lock) > > +#define MDIO_UNLOCK(adapter) up(&(adapter)->mdio_lock) > > Please don't wrap locks Plus these should probably be mutexes, not semaphores. > > +int t3_offload_tx(struct t3cdev *tdev, struct sk_buff *skb); > > What kind of of

[PATCH] netdev: don't allow register_netdev with blank name

2006-11-17 Thread Stephen Hemminger
This bit of old backwards compatibility cruft can be removed in 2.6.20. If there is still an device that calls register_netdev() with a zero or blank name, it will get -EINVAL from register_netdevice(). Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- linux-2.6.19-rc6.orig/net/core/dev.c

Re: [PATCH wireless-2.6-git] prism54: WPA/RSN support for fullmac cards

2006-11-17 Thread chunkeey
> > Btw, it usually locks up under heavyish load. I.e. if I just ssh into > my devel box and code in vi it will stay jsut fine for hours. But > FTPing stuff over quite often locks it up. k, I've seen this phenomenon too, but on my a PCI card. Alright, when you come home, you should check the sysl

Re: [PATCH wireless-2.6-git] prism54: WPA/RSN support for fullmac cards

2006-11-17 Thread Dmitry Torokhov
On 11/17/06, Dmitry Torokhov <[EMAIL PROTECTED]> wrote: On 11/17/06, [EMAIL PROTECTED] <[EMAIL PROTECTED]> wrote: > > > > The reason for me trying the patch is that the card locks up > > frequently (the amber transmission light turns on stays this way). > > Do you get any fancy "mgt timeout ..."

Re: [PATCH wireless-2.6-git] prism54: WPA/RSN support for fullmac cards

2006-11-17 Thread Dmitry Torokhov
On 11/17/06, [EMAIL PROTECTED] <[EMAIL PROTECTED]> wrote: > > The reason for me trying the patch is that the card locks up > frequently (the amber transmission light turns on stays this way). Do you get any fancy "mgt timeout ..." or something in dmesg, when the cards locks up? (include one, if

Re: [PATCH 8/10] cxgb3 - offload capabilities

2006-11-17 Thread Stephen Hemminger
On Fri, 17 Nov 2006 12:25:39 -0800 "Divy Le Ray <[EMAIL PROTECTED]>" <[EMAIL PROTECTED]> wrote: > From: Divy Le Ray <[EMAIL PROTECTED]> > > This patch implements the offload capabilities of the > Chelsio network adapter's driver. Could you implement these as sysfs attributes on the device instea

Re: [PATCH wireless-2.6-git] prism54: WPA/RSN support for fullmac cards

2006-11-17 Thread chunkeey
> > The card is WG511 talking to netgear WGR614 router. I am using WEP128 > with shared keys. Router is set to be "g" only. The OS is Fedora Core > 3 (I swear I will upgrade :) ), just recompiled wireless tools from > sources in FC6. > > > for debugging: > > dmesg & iwevent output would be nice...

Re: [PATCH 1/10] cxgb3 - main header files

2006-11-17 Thread Stephen Hemminger
> + > +struct work_struct; > +struct dentry; Why do you need these extra forward declarations? ... > + > +struct sge_rspq { /* state for an SGE response queue */ > + unsigned int credits; /* # of pending response credits */ > + unsigned int size; /* cap

Re: [PATCH 11/13] Core Resource Allocation

2006-11-17 Thread Roland Dreier
> I think we can use random32() or get_random_bytes(). I need to > re-review how this algorithm works. Its randomizing the stag IDs so > they are not predictable. I assume based on the algorithm you have now that they don't need to be cryptographically unpredictable. So random32() would prob

[PATCH 10/10] cxgb3 - build files and versioning

2006-11-17 Thread Divy Le Ray <[EMAIL PROTECTED]>
From: Divy Le Ray <[EMAIL PROTECTED]> This patch implements build files and versioning for the Chelsio T3 network adapter's driver. Signed-off-by: Divy Le Ray <[EMAIL PROTECTED]> --- drivers/net/Kconfig | 18 ++ drivers/net/Makefile|1 + drivers/net/cxgb3/

2.6.19-rc6: known regressions (v2)

2006-11-17 Thread Adrian Bunk
This email lists some known regressions in 2.6.19-rc6 compared to 2.6.18 that are not yet fixed in Linus' tree. If you find your name in the Cc header, you are either submitter of one of the bugs, maintainer of an affectected subsystem or driver, a patch of you caused a breakage or I'm considering

Re: driver support for Chelsio T210 10Gb ethernet in 2.6.x

2006-11-17 Thread Jeff Garzik
Jeff Garzik wrote: Felix Marti wrote: Jeff, as indicated by Chris, the driver that is in the kernel is for N110 and N210. So far, we have not received any customer complaints regarding bugs in the driver and thus it has not been updated in a long time. If you feel like there are some missing fea

Re: driver support for Chelsio T210 10Gb ethernet in 2.6.x

2006-11-17 Thread Jeff Garzik
Felix Marti wrote: Jeff, as indicated by Chris, the driver that is in the kernel is for N110 and N210. So far, we have not received any customer complaints regarding bugs in the driver and thus it has not been updated in a long time. If you feel like there are some missing features/bug fixes, I'd

[PATCH 6/10] cxgb3 - on board memory, MAC and PHY

2006-11-17 Thread Divy Le Ray <[EMAIL PROTECTED]>
From: Divy Le Ray <[EMAIL PROTECTED]> This patch implements on board memory, MAC and PHY management for the Chelsio T3 network adapter's driver. Signed-off-by: Divy Le Ray <[EMAIL PROTECTED]> --- drivers/net/cxgb3/ael1002.c | 223 + drivers/net/cxgb3/mc5.c | 453 ++

[PATCH 8/10] cxgb3 - offload capabilities

2006-11-17 Thread Divy Le Ray <[EMAIL PROTECTED]>
From: Divy Le Ray <[EMAIL PROTECTED]> This patch implements the offload capabilities of the Chelsio network adapter's driver. Signed-off-by: Divy Le Ray <[EMAIL PROTECTED]> --- drivers/net/cxgb3/cxgb3_offload.c | 1204 + drivers/net/cxgb3/l2t.c | 5

[PATCH 4/10] cxgb3 - HW access routines - part 2

2006-11-17 Thread divy
From: Divy Le Ray <[EMAIL PROTECTED]> This patch implements the HW access routines for the Chelsio T3 network adapter's driver. This patch is split. This is the second part. Signed-off-by: Divy Le Ray <[EMAIL PROTECTED]> --- + return t3_wait_op_done(adapter, A_SG_CONTEXT_CMD, F_CONTEXT_CMD

[PATCH 7/10] cxgb3 - offload header files

2006-11-17 Thread Divy Le Ray <[EMAIL PROTECTED]>
From: Divy Le Ray <[EMAIL PROTECTED]> This patch implements the offload operations header files for the Chelsio T3 network adapter's driver. Signed-off-by: Divy Le Ray <[EMAIL PROTECTED]> --- drivers/net/cxgb3/cxgb3_ctl_defs.h | 141 drivers/net/cxgb3/cxgb3_defs.h | 100 +++ drivers/

[PATCH 9/10] cxgb3 - register definitions

2006-11-17 Thread Divy Le Ray <[EMAIL PROTECTED]>
From: Divy Le Ray <[EMAIL PROTECTED]> This patch implements the registers definitions for the Chelsio network adapter's driver. Signed-off-by: Divy Le Ray <[EMAIL PROTECTED]> --- drivers/net/cxgb3/regs.h | 2754 ++ 1 files changed, 2754 insertions(+),

[PATCH 0/10] cxgb3: Chelsio T3 1G/10G ethernet device driver

2006-11-17 Thread Divy Le Ray
Hi, Based on Arnd's feedback, I re-submit the patch supporting the latest Chelsio T3 adapter in inlined mails. Some header files were trimmed down to reduce the code footprint. This patch adds support for the latest Chelsio adapter, T3. It is built against 2.6.19-rc6. A corresponding monolith

[PATCH 1/10] cxgb3 - main header files

2006-11-17 Thread Divy Le Ray <[EMAIL PROTECTED]>
From: Divy Le Ray <[EMAIL PROTECTED]> This patch implements the main header files of the Chelsio T3 network driver. Signed-off-by: Divy Le Ray <[EMAIL PROTECTED]> --- drivers/net/cxgb3/adapter.h | 317 +++ drivers/net/cxgb3/common.h | 702 +++

Re: [PATCH wireless-2.6-git] prism54: WPA/RSN support for fullmac cards

2006-11-17 Thread Dmitry Torokhov
On 11/17/06, [EMAIL PROTECTED] <[EMAIL PROTECTED]> wrote: Am Freitag, 17. November 2006 06:42 schrieben Sie: > > > > No, more that my card doesn't successfully associate at all even > > _without_ the patch on unencrypted or WEP APs; I just can't test it, > > since my card seems to be broken... >

[PATCH 2/4] chelsio: whitespace cleanup

2006-11-17 Thread Stephen Hemminger
Whitespace cleanups. Replace leading spaces with tabs and fix indentation Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- drivers/net/chelsio/cxgb2.c | 202 ++-- 1 file changed, 101 insertions(+), 101 deletions(-) --- chelsio-t2.orig/drivers/ne

[PATCH 4/4] chelsio: free_netdev

2006-11-17 Thread Stephen Hemminger
Network devices need to be free'd with free_netdev() not kfree() otherwise the kernel will panic if an application has /sys/class/net/ethX/value open and reads it. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- drivers/net/chelsio/cxgb2.c | 14 +++--- 1 file changed, 7 insert

[PATCH 1/4] chelsio: remove leftover code

2006-11-17 Thread Stephen Hemminger
The chelsio network driver has some extra ifdef's that got in because the driver was originally based on code that worked on 2.4 as well as 2.6. This patch removes the dead code. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- chelsio-t2.orig/drivers/net/chelsio/cxgb2.c +++ chelsio-t2/dr

[PATCH 3/4] chelsio: procectomy

2006-11-17 Thread Stephen Hemminger
Complete removal of proc stuff from chelsio. The orignal driver had a debug proc interface, but not all the code got removed. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- drivers/net/chelsio/cxgb2.c | 14 -- 1 file changed, 14 deletions(-) --- chelsio-t2.orig/drivers/n

Re: Generic Netlink HOW-TO based on Jamal's original doc

2006-11-17 Thread jamal
On Fri, 2006-17-11 at 08:05 -0500, jamal wrote: > i will review the doc as soon as i am done with that. I glanced at the doc over lunch. I will give you high level views first and later on today or tomorrow i will give you a lot more pointed opinions. #1. I think the content layout has improved

Re: [PATCH wireless-2.6-git] prism54: WPA/RSN support for fullmac cards

2006-11-17 Thread chunkeey
Am Freitag, 17. November 2006 06:42 schrieben Sie: > > > > No, more that my card doesn't successfully associate at all even > > _without_ the patch on unencrypted or WEP APs; I just can't test it, > > since my card seems to be broken... > > FWIW I applied the patch to tonight pull form Linus's tree

Re: [PATCH] IPv6: Fix NULL dereference in ipv6_del_addr()

2006-11-17 Thread Ville Nuorvala
YOSHIFUJI Hideaki wrote: In article <[EMAIL PROTECTED]> (at Fri, 17 Nov 2006 15:26:28 +0200), Ville Nuorvala <[EMAIL PROTECTED]> says: - dst_release(&rt->u.dst); + if (rt) + dst_release(&rt->u.dst); } I disagree. This does NOT fix a

Re: [openib-general] [PATCH 09/13] Core WQE/CQE Types

2006-11-17 Thread Bryan O'Sullivan
Steve Wise wrote: It passes sparse with only a few warnings about calling memset() with a size > 10. You need to pass in CF=-D__CHECK_ENDIAN__ too, on the kernel build command line. Otherwise, the endianness annotations aren't turned on in the kernel headers, and you get this nice false

Re: [openib-general] [PATCH 09/13] Core WQE/CQE Types

2006-11-17 Thread Steve Wise
On Fri, 2006-11-17 at 10:19 -0800, Bryan O'Sullivan wrote: > Steve Wise wrote: > > T3 WQE and CQE structures, defines, etc... > > I notice that none of the fields in these structs seem to be > endianness-annotated, but that there's a lot of cpu_to_be64 and so on > being used to frob values into

Re: [openib-general] [PATCH 04/13] Connection Manager

2006-11-17 Thread Steve Wise
On Fri, 2006-11-17 at 10:07 -0800, Bryan O'Sullivan wrote: > Steve Wise wrote: > > > +static void release_tid(struct t3cdev *tdev, u32 hwtid, struct sk_buff > > *skb) > > +{ > > + struct cpl_tid_release *req; > > + > > + skb = get_skb(skb, sizeof *req, GFP_KERNEL); > > + if (!skb) { > > +

Re: [openib-general] [PATCH 09/13] Core WQE/CQE Types

2006-11-17 Thread Bryan O'Sullivan
Steve Wise wrote: T3 WQE and CQE structures, defines, etc... I notice that none of the fields in these structs seem to be endianness-annotated, but that there's a lot of cpu_to_be64 and so on being used to frob values into them. Please make sure that the driver passes a sparse check, which

Re: [openib-general] [PATCH 04/13] Connection Manager

2006-11-17 Thread Bryan O'Sullivan
Steve Wise wrote: +static void release_tid(struct t3cdev *tdev, u32 hwtid, struct sk_buff *skb) +{ + struct cpl_tid_release *req; + + skb = get_skb(skb, sizeof *req, GFP_KERNEL); + if (!skb) { + return; + } Style micronit: no curlies for single-statement b

Re: [openib-general] [PATCH 02/13] Device Discovery and ULLD Linkage

2006-11-17 Thread Steve Wise
On Fri, 2006-11-17 at 09:53 -0800, Bryan O'Sullivan wrote: > Steve Wise wrote: > > > +static inline void *vzmalloc(int size) > > +{ > > + void *p = vmalloc(size); > > + memset(p, 0, size); > > + return p; > > +} > > This isn't checking the return value from vmalloc. > Oops... > Also, we

Re: [openib-general] [PATCH 02/13] Device Discovery and ULLD Linkage

2006-11-17 Thread Bryan O'Sullivan
Steve Wise wrote: +static inline void *vzmalloc(int size) +{ + void *p = vmalloc(size); + memset(p, 0, size); + return p; +} This isn't checking the return value from vmalloc. Also, we could do with a generic vzalloc and vcalloc, just as we now have kzalloc and kcalloc. Th

Re: [PATCH 3/10][NETLABEL]: Use kmemdup in cipso_ipv4.c

2006-11-17 Thread Paul Moore
Arnaldo Carvalho de Melo wrote: > Code diff stats: > > [EMAIL PROTECTED] net-2.6.20]$ codiff /tmp/cipso_ipv4.o.before > /tmp/cipso_ipv4.o.after > /pub/scm/linux/kernel/git/acme/net-2.6.20/net/ipv4/cipso_ipv4.c: > cipso_v4_cache_add | -46 > 1 function changed, 46 bytes removed > [EMAIL PROTECT

Re: [PATCH 11/13] Core Resource Allocation

2006-11-17 Thread Steve Wise
On Fri, 2006-11-17 at 08:54 -0800, Roland Dreier wrote: > > +static u32 next_random(u32 rand) > > +{ > > + u32 y, ylast; > > + > > + y = rand; > > + ylast = y; > > + y = (y * 69069) & 0x; > > + y = (y & 0x8000) + (ylast & 0x7fff); > > + if ((y & 1)) > > +

[-mm patch] make net/core/skbuff.c:skb_over_panic() static

2006-11-17 Thread Adrian Bunk
skb_over_panic() can now become static. Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> --- Note: This patch depends on net-uninline-skb_put.patch. include/linux/skbuff.h |2 -- net/core/skbuff.c |3 +-- 2 files changed, 1 insertion(+), 4 deletions(-) --- linux-2.6.19-rc5-mm2/incl

Re: [PATCH 09/13] Core WQE/CQE Types

2006-11-17 Thread Steve Wise
On Thu, 2006-11-16 at 20:45 -0800, Roland Dreier wrote: > > +struct t3_send_wr { > > + struct fw_riwrh wrh;/* 0 */ > > + union t3_wrid wrid; /* 1 */ > > + > > + enum t3_rdma_opcode rdmaop:8; > > + u32 reserved:24;/* 2 */ > > Does this do the right thing wrt endianness? I

[2.6 patch] net/ipv6/sit.c: make 2 functions static

2006-11-17 Thread Adrian Bunk
This patch makes two needlessly global functions static. Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> --- include/net/ipip.h |4 net/ipv6/sit.c |4 ++-- 2 files changed, 2 insertions(+), 6 deletions(-) --- linux-2.6.19-rc5-mm2/include/net/ipip.h.old 2006-11-17 16:58:59.0

[PATCH][XFRM]: Convert a few __u8 to proper u8

2006-11-17 Thread jamal
Ok, here it is. 2.6.20 material but dependent on all the other patches I have posted. Ok, this ipsec thing is distracting me from the 2 generic netlink presentations i am trying to get started on for Foss.in (For once i thought i was organized - worse, Harald will kill me if i dont have it done).

Re: [PATCH 11/13] Core Resource Allocation

2006-11-17 Thread Roland Dreier
> +static u32 next_random(u32 rand) > +{ > +u32 y, ylast; > + > +y = rand; > +ylast = y; > +y = (y * 69069) & 0x; > +y = (y & 0x8000) + (ylast & 0x7fff); > +if ((y & 1)) > +y = ylast ^ (y > 1) ^ (2567483615UL); > +else > +

Re: [PATCH 1/2][XFRM]: Sub-policies beautification

2006-11-17 Thread jamal
On Fri, 2006-17-11 at 17:42 +0100, Thomas Graf wrote: > > Could you maybe use u8 instead of the userspace alternative __u8? > Good catch. I think i know how i missed that one - TheLinuxWay;-> theres a few __u8s in there unrelated. So i will send an additional patch that fixes that and the rest

Re: [PATCH 1/2][XFRM]: Sub-policies beautification

2006-11-17 Thread Thomas Graf
* jamal <[EMAIL PROTECTED]> 2006-11-17 11:49 > Good catch. I think i know how i missed that one - TheLinuxWay;-> > theres a few __u8s in there unrelated. So i will send an additional > patch that fixes that and the rest of em. Sounds good? Sure - To unsubscribe from this list: send the line "unsub

Re: [PATCH 1/2][XFRM]: Sub-policies beautification

2006-11-17 Thread Thomas Graf
* jamal <[EMAIL PROTECTED]> 2006-11-17 09:10 > First one > > cheers, > jamal > [XFRM]: Make copy_to_user_policy_type take a type > Make copy_to_user_policy_type take a type instead a policy and > fix its users to pass the type > > Signed-off-by: Jamal Hadi Salim <[EMAIL PROTECTED]> > > --- > co

Re: [PATCH 3/3] NetXen: 64-bit memory fixes, driver cleanup

2006-11-17 Thread Stephen Hemminger
On Fri, 17 Nov 2006 07:36:03 -0800 "Linsys Contractor Amit S. Kale" <[EMAIL PROTECTED]> wrote: > NetXen: 1G/10G Ethernet Driver updates > - These fixes take care of driver on machines with >4G memory > - Driver cleanup > > Signed-off-by: Amit S. Kale <[EMAIL PROTECTED]> > > netxen_n

[PATCH 3/3] NetXen: 64-bit memory fixes, driver cleanup

2006-11-17 Thread Linsys Contractor Amit S. Kale
NetXen: 1G/10G Ethernet Driver updates - These fixes take care of driver on machines with >4G memory - Driver cleanup Signed-off-by: Amit S. Kale <[EMAIL PROTECTED]> netxen_nic.h | 41 ++ netxen_nic_ethtool.c | 19 ++-- netxen_nic_hw.c | 10 +- netxe

[PATCH 8/10][DECNET]: Use kmemdup

2006-11-17 Thread Arnaldo Carvalho de Melo
Code diff stats: [EMAIL PROTECTED] net-2.6.20]$ codiff /tmp/decnet.ko.before /tmp/decnet.ko.after /pub/scm/linux/kernel/git/acme/net-2.6.20/net/decnet/dn_dev.c: dn_dev_sysctl_register | -51 1 function changed, 51 bytes removed [EMAIL PROTECTED] net-2.6.20]$ Signed-off-by: Arnaldo Carvalho de

[PATCH 5/10][TCP] minisocks: Use kmemdup and LIMIT_NETDEBUG

2006-11-17 Thread Arnaldo Carvalho de Melo
Code diff stats: [EMAIL PROTECTED] net-2.6.20]$ codiff /tmp/tcp_minisocks.o.before /tmp/tcp_minisocks.o.after /pub/scm/linux/kernel/git/acme/net-2.6.20/net/ipv4/tcp_minisocks.c: tcp_check_req | -44 1 function changed, 44 bytes removed [EMAIL PROTECTED] net-2.6.20]$ Signed-off-by: Arnaldo Car

[PATCH 1/3] NetXen: Fixed /sys mapping between device and driver

2006-11-17 Thread Linsys Contractor Amit S. Kale
Signed-off-by: Amit S. Kale <[EMAIL PROTECTED]> netxen_nic_main.c |3 ++- 1 files changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/netxen/netxen_nic_main.c b/drivers/net/netxen/netxen_nic_main.c index 145bf47..a055208 100644 --- a/drivers/net/netxen/netxen_nic_main.c +++ b/d

[PATCH 3/10][NETLABEL]: Use kmemdup in cipso_ipv4.c

2006-11-17 Thread Arnaldo Carvalho de Melo
Code diff stats: [EMAIL PROTECTED] net-2.6.20]$ codiff /tmp/cipso_ipv4.o.before /tmp/cipso_ipv4.o.after /pub/scm/linux/kernel/git/acme/net-2.6.20/net/ipv4/cipso_ipv4.c: cipso_v4_cache_add | -46 1 function changed, 46 bytes removed [EMAIL PROTECTED] net-2.6.20]$ Signed-off-by: Arnaldo Carvalh

[PATCH 9/10][AX25]: Use kmemdup

2006-11-17 Thread Arnaldo Carvalho de Melo
Code diff stats: [EMAIL PROTECTED] net-2.6.20]$ codiff /tmp/ax25.ko.before /tmp/ax25.ko.after /pub/scm/linux/kernel/git/acme/net-2.6.20/net/ax25/ax25_out.c: ax25_send_frame | -8 1 function changed, 8 bytes removed /pub/scm/linux/kernel/git/acme/net-2.6.20/net/ax25/ax25_route.c: ax25_rt_aut

[PATCH 4/10][IPV4]: Use kmemdup in net/ipv4/devinet.c

2006-11-17 Thread Arnaldo Carvalho de Melo
Code diff stats: [EMAIL PROTECTED] net-2.6.20]$ codiff /tmp/devinet.o.before /tmp/devinet.o.after /pub/scm/linux/kernel/git/acme/net-2.6.20/net/ipv4/devinet.c: devinet_sysctl_register | -38 1 function changed, 38 bytes removed [EMAIL PROTECTED] net-2.6.20]$ Signed-off-by: Arnaldo Carvalho de

[PATCH 6/10][IPV6]: Use kmemdup

2006-11-17 Thread Arnaldo Carvalho de Melo
Code diff stats: [EMAIL PROTECTED] net-2.6.20]$ codiff /tmp/ipv6.ko.before /tmp/ipv6.ko.after /pub/scm/linux/kernel/git/acme/net-2.6.20/net/ipv6/ip6_output.c: ip6_output | -52 ip6_append_data | +2 2 functions changed, 2 bytes added, 52 bytes removed /pub/scm/linux/kernel/git/acme/net

[PATCH 7/10][DCCP]: Use kmemdup

2006-11-17 Thread Arnaldo Carvalho de Melo
Code diff stats: [EMAIL PROTECTED] net-2.6.20]$ codiff /tmp/dccp.ko.before /tmp/dccp.ko.after /pub/scm/linux/kernel/git/acme/net-2.6.20/net/dccp/feat.c: __dccp_feat_init | -16 dccp_feat_change_recv | -55 dccp_feat_clone | -56 3 functions changed, 127 bytes removed [EMAIL PROTE

[PATCH 10/10][NETROM]: Use kmemdup

2006-11-17 Thread Arnaldo Carvalho de Melo
Signed-off-by: Arnaldo Carvalho de Melo <[EMAIL PROTECTED]> --- net/netrom/nr_route.c | 12 +++- 1 files changed, 7 insertions(+), 5 deletions(-) diff --git a/net/netrom/nr_route.c b/net/netrom/nr_route.c index c11737f..0096105 100644 --- a/net/netrom/nr_route.c +++ b/net/netrom/nr_rout

[PATCH 2/10][TCP_IPV4]: Use kmemdup where appropriate

2006-11-17 Thread Arnaldo Carvalho de Melo
Also use a variable to avoid the longish tp->md5sig_info-> use in tcp_v4_md5_do_add. Code diff stats: [EMAIL PROTECTED] net-2.6.20]$ codiff /tmp/tcp_ipv4.o.before /tmp/tcp_ipv4.o.after /pub/scm/linux/kernel/git/acme/net-2.6.20/net/ipv4/tcp_ipv4.c: tcp_v4_md5_do_add | -62 tcp_v4_syn_recv

[PATCH 0/3] NetXen: 1G/10G Ethernet Driver updates

2006-11-17 Thread Linsys Contractor Amit S. Kale
Thanks Jeff, We have rebased last sent patches wrt current upstream branch. I will be sending them shortly. --Amit - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH 1/10][TCP_IPV4]: CodingStyle cleanups, no code change

2006-11-17 Thread Arnaldo Carvalho de Melo
Mostly related to CONFIG_TCP_MD5SIG recent merge. Signed-off-by: Arnaldo Carvalho de Melo <[EMAIL PROTECTED]> --- net/ipv4/tcp_ipv4.c | 143 +++ 1 files changed, 75 insertions(+), 68 deletions(-) diff --git a/net/ipv4/tcp_ipv4.c b/net/ipv4/tcp_ipv

[PATCHES 0/10][NET] use kmemdup + some cleanups

2006-11-17 Thread Arnaldo Carvalho de Melo
Hi David, Please consider pulling from: master.kernel.org:/pub/scm/linux/kernel/git/acme/net-2.6.20.git - Arnaldo - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-inf

Re: [PATCH] IPv6: Fix NULL dereference in ipv6_del_addr()

2006-11-17 Thread YOSHIFUJI Hideaki / 吉藤英明
In article <[EMAIL PROTECTED]> (at Fri, 17 Nov 2006 15:26:28 +0200), Ville Nuorvala <[EMAIL PROTECTED]> says: > - dst_release(&rt->u.dst); > + if (rt) > + dst_release(&rt->u.dst); > } I disagree. This does NOT fix any bugs. (void *)&rt->u.dst

[PATCH 2/2][XFRM]: Sub-policies beautification

2006-11-17 Thread jamal
Second one .. cheers, jamal [XFRM]: Make flush notifier prettier when subpolicy used Might as well make flush notifier prettier when subpolicy used Signed-off-by: Jamal Hadi Salim <[EMAIL PROTECTED]> --- commit eb52e3df145c2f8676da51a21cbe664d7794949c tree d51daecf0feb1119f7c00bf9949b255a94

[PATCH 0/2] [XFRM]Sub-policies beautification

2006-11-17 Thread jamal
Ga-Dang. Ok, since i am on a row ... Might as well kill a few ifdefs. This is more than likely 2.6.20 material but depends on the previous two patches i sent earlier. cheers, jamal - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED]

[PATCH 1/2][XFRM]: Sub-policies beautification

2006-11-17 Thread jamal
First one cheers, jamal [XFRM]: Make copy_to_user_policy_type take a type Make copy_to_user_policy_type take a type instead a policy and fix its users to pass the type Signed-off-by: Jamal Hadi Salim <[EMAIL PROTECTED]> --- commit 5e6a47d1e7baabd38cca9d01f3d78ae1319db535 tree cb4b19b38076cdf545a

[PATCH][XFRM]: nlmsg length not computed correctly in the presence of subpolicies

2006-11-17 Thread jamal
Another one in the same spirit as before. Compiles. I dont have a good test case, but looks right. Nakamura-san please ACK and Dave (as before this goes in as a bug-fix). cheers, jamal [XFRM]: nlmsg length not computed correctly in the presence of subpolicies I actually dont have a test case for

[[PATCH][XFRM]: Sub-policies broke policy events

2006-11-17 Thread jamal
Found the cause of my problems. Dave, this is against Linus tree because it is bug fix. Nakamura-san please ACK. cheers, jamal [XFRM]: Sub-policies broke policy events XFRM policy events are broken when sub-policy feature is turned on. A simple test to verify this: run ip xfrm mon on one wind

[PATCH] IPv6: Fix NULL dereference in ipv6_del_addr()

2006-11-17 Thread Ville Nuorvala
>From 07ed0369cca6ef51013a63664b09ef402e79af9e Mon Sep 17 00:00:00 2001 From: Ville Nuorvala <[EMAIL PROTECTED]> Date: Fri, 17 Nov 2006 14:05:45 +0200 Subject: [PATCH] IPv6: Fix NULL dereference in ipv6_del_addr() Signed-off-by: Ville Nuorvala <[EMAIL PROTECTED]> --- net/ipv6/addrconf.c |3

Re: [PATCH]: bcm43xx-d80211: fix hwcrypto issues (mcast)

2006-11-17 Thread Paul TBBle Hampson
On Fri, Nov 17, 2006 at 11:35:54AM +0100, Andreas Schwab wrote: > Benjamin Herrenschmidt <[EMAIL PROTECTED]> writes: >> Well, the latest "released" version (fwcutter-005) contains a huge list >> of ... v3 URLs :-) Only 2 v4 in there. I'll check SVN. > Still the same. One of them does not exist,

Re: Generic Netlink HOW-TO based on Jamal's original doc

2006-11-17 Thread jamal
On Mon, 2006-13-11 at 15:06 -0500, Paul Moore wrote: > jamal wrote: > > On Mon, 2006-13-11 at 09:08 -0500, Paul Moore wrote: > > > >>I want to give Jamal a little bit longer to reply. > > > > Sorry, family emergency - still ongoing today, so havent looked at > > anything (including presentation t

Re: [PATCH]: bcm43xx-d80211: fix hwcrypto issues (mcast)

2006-11-17 Thread Andreas Schwab
Johannes Berg <[EMAIL PROTECTED]> writes: > Try these: > > Support for bcmwl5.sys v4.80.53.0 added. > ftp://downloads.netgear.com/files/wn511b_sw_3_28_3_8_setup.zip > (bcmwl5.sys is renamed to wn511b.sys) No supported files in there. > Support for bcmwl5(64).sys v4.100.15.5 added. > from the lat

  1   2   >