[PATCH] bonding: fix deadlock on high loads in bond_alb_monitor()

2006-09-29 Thread Jay Vosburgh
From: Karsten Keil <[EMAIL PROTECTED]> In bond_alb_monitor the bond->curr_slave_lock write lock is taken and then dev_set_promiscuity maybe called which can take some time, depending on the network HW. If a network IRQ for this card come in the softirq handler maybe try to deliver more packets wh

Re: Is TCP over IPsec broken in 2.6.18?

2006-09-29 Thread James Morris
On Sat, 30 Sep 2006, James Morris wrote: > I've just seen something similar and can recreate it with static keying > via setkey. It's SELinux related. Things work when the one system in this setup with SELinux enabled is changed to permissive mode. No audit messages or AVCs, and it's not the

Re: Is TCP over IPsec broken in 2.6.18?

2006-09-29 Thread James Morris
I've just seen something similar and can recreate it with static keying via setkey. The symptom was that ping was only working in one direction, and I quintuple-checked the configs and that they have the same kernels etc., then ran a bunch of tcpdumps on each and and a router in the middle with

Re: 2.6.18-mm2 - oops in cache_alloc_refill()

2006-09-29 Thread Valdis . Kletnieks
On Fri, 29 Sep 2006 18:33:48 PDT, Jean Tourrilhes said: > On Fri, Sep 29, 2006 at 06:20:08PM -0700, Andrew Morton wrote: > > On Fri, 29 Sep 2006 20:01:54 -0400 > > > > > > Here's the traceback I got: > > > > > > slab error in verify_redzone_free(): cache `size-32': memory outside > > > object wa

Re: Offloading features in VLAN interfaces

2006-09-29 Thread Stephen Hemminger
On Fri, 29 Sep 2006 17:25:35 -0700 "Olivier Crameri" <[EMAIL PROTECTED]> wrote: > Same thing but with the patch this time. > > Sorry about that, > Olivier Crameri > > On 9/29/06, Olivier Crameri <[EMAIL PROTECTED]> wrote: > > Hi, > > > > after running some experiments, we realised that using VLA

Re: 2.6.18-mm2 - oops in cache_alloc_refill()

2006-09-29 Thread Valdis . Kletnieks
On Fri, 29 Sep 2006 18:40:43 PDT, Jean Tourrilhes said: > On Fri, Sep 29, 2006 at 06:20:08PM -0700, Andrew Morton wrote: > > On Fri, 29 Sep 2006 20:01:54 -0400 > > > > > > A quick strace of gkrellm finds these likely ioctl's causing the problem: > > > > > > % grep ioctl /tmp/foo2 | sort -u | more

Re: [RFC] cfg80211 and nl80211

2006-09-29 Thread Michael Wu
On Thursday 28 September 2006 05:23, Johannes Berg wrote: > * why should there be configuration per device? The user can only >be operating in one country at a time... I think that information >should just be available inside cfg80211 in a global structure >for use by drivers whenever

Re: [RFC] cfg80211 and nl80211

2006-09-29 Thread Michael Wu
On Friday 29 September 2006 17:10, James Ketrenos wrote: > Johannes Berg wrote: > > * Should the userspace daemon be allowed to unilaterally update the > >regulatory information if it learns something new (via the user)? > > Many countries forbid users (root is still a user) being enabled to >

Re: [PATCH 6/6]: powerpc/cell spidernet refine locking

2006-09-29 Thread Andrew Morton
On Fri, 29 Sep 2006 18:29:11 -0500 [EMAIL PROTECTED] (Linas Vepstas) wrote: > The transmit side of the spider ethernet driver currently > places locks around some very large chunks of code. This > results in a fair amount of lock contention is some cases. > This patch makes the locks much more fi

Makefile for linux modules

2006-09-29 Thread x z
Hi I have a makefile to make several driver modules: obj-$(CONFIG_FUSION_SPI)+= mptbase.o mptscsih.o mptspi.o obj-$(CONFIG_FUSION_FC) += mptbase.o mptscsih.o mptfc.o obj-m += mptbase.o mptscsih.o mptsas.o obj-$(CONFIG_FUSION_LAN)+= mptlan.o obj-m

Makefile for linux modules

2006-09-29 Thread x z
Hi I have a makefielt to make several driver modules: obj-$(CONFIG_FUSION_SPI)+= mptbase.o mptscsih.o mptspi.o obj-$(CONFIG_FUSION_FC) += mptbase.o mptscsih.o mptfc.o obj-m += mptbase.o mptscsih.o mptsas.o obj-$(CONFIG_FUSION_LAN)+= mptlan.o obj-

Re: 2.6.18-mm2 - oops in cache_alloc_refill()

2006-09-29 Thread Jean Tourrilhes
On Fri, Sep 29, 2006 at 06:20:08PM -0700, Andrew Morton wrote: > On Fri, 29 Sep 2006 20:01:54 -0400 > > > > A quick strace of gkrellm finds these likely ioctl's causing the problem: > > > > % grep ioctl /tmp/foo2 | sort -u | more > > ioctl(13, SIOCGIWESSID, 0xbfbcdb9c) = 0 > > ioctl(13, SIOCG

Re: 2.6.18-mm2 - oops in cache_alloc_refill()

2006-09-29 Thread Jean Tourrilhes
On Fri, Sep 29, 2006 at 06:20:08PM -0700, Andrew Morton wrote: > On Fri, 29 Sep 2006 20:01:54 -0400 > > > > Here's the traceback I got: > > > > slab error in verify_redzone_free(): cache `size-32': memory outside object > > was overwritten > > [] dump_trace+0x64/0x1cd > > [] show_trace_log_lvl+0

Re: 2.6.18-mm2 - oops in cache_alloc_refill()

2006-09-29 Thread Andrew Morton
On Fri, 29 Sep 2006 20:01:54 -0400 [EMAIL PROTECTED] wrote: > On Fri, 29 Sep 2006 12:45:58 PDT, Andrew Morton said: > > (Adding a bunch of people to the cc: list now that I have a clue what is > going on) > > > I'd expect it's the same bug - slab data structures have gone bad. > > *bing*! W

Re: [PATCH][BNX2]: Disable MSI on 5706 if AMD 8132 bridge is present

2006-09-29 Thread David Miller
From: Jeff Garzik <[EMAIL PROTECTED]> Date: Fri, 29 Sep 2006 20:38:07 -0400 > David, rejoin reality. You are either arguing with a fictionalized Jeff > Garzik in your head, or constructing a classical strawman. > > Let me say it for the cheap seats: AT NO TIME DID I PROPOSE ACTION OF > ANY KI

Re: [PATCH][BNX2]: Disable MSI on 5706 if AMD 8132 bridge is present

2006-09-29 Thread Jeff Garzik
David Miller wrote: From: Jeff Garzik <[EMAIL PROTECTED]> Date: Fri, 29 Sep 2006 19:15:14 -0400 It was completely vague as to why this incompatibility was specific to the 5706, when -- as the description noted -- the behavior is legal. Re-read the patch. At no time does it say 5706 was in th

Offloading features in VLAN interfaces

2006-09-29 Thread Olivier Crameri
Hi, after running some experiments, we realised that using VLAN support in Linux caused some overhead. It turned out to be that the offloading features of our NIC (tso, sg, checksum offloading) were not beeing used. After digging a little bit in the code, we realised that the VLAN code did not s

Re: Offloading features in VLAN interfaces

2006-09-29 Thread Olivier Crameri
Same thing but with the patch this time. Sorry about that, Olivier Crameri On 9/29/06, Olivier Crameri <[EMAIL PROTECTED]> wrote: Hi, after running some experiments, we realised that using VLAN support in Linux caused some overhead. It turned out to be that the offloading features of our NIC (

Re: [PATCH 8/8][ATM]: [lec] use refcnt to protect lec_arp_entries outside lock

2006-09-29 Thread David Miller
From: "chas williams - CONTRACTOR" <[EMAIL PROTECTED]> Date: Fri, 29 Sep 2006 12:45:26 -0400 > please consider for 2.6.19 -- thanks! > > [ATM]: [lec] use refcnt to protect lec_arp_entries outside lock > > Signed-off-by: Chas Williams <[EMAIL PROTECTED]> Applied. - To unsubscribe from this list:

Re: sky2 (was Re: 2.6.18-mm2)

2006-09-29 Thread Matthias Hentges
Hello Stephen, Am Donnerstag, den 28.09.2006, 16:19 -0700 schrieb Stephen Hemminger: [...] > Here is the debug patch I sent to the first reporter of the problem. > I know what the offset is supposed to be, so if the PCI subsystem is > wrong, this will show. > > --- sky2.orig/drivers/net/sky2.c

Re: [PATCH][BNX2]: Disable MSI on 5706 if AMD 8132 bridge is present

2006-09-29 Thread Roland Dreier
Jeff> The patch and description provided no information about Jeff> whether or not it would be better to blacklist 8132 Jeff> globally, as we have already done with the 8131. 8131 and 8132 are quite different: AMD 8131 simply did not implement MSI at all, so any attempt to use MSI by a

Re: [PATCH 7/8][ATM]: [lec] add reference counting to lec_arp entries

2006-09-29 Thread David Miller
From: "chas williams - CONTRACTOR" <[EMAIL PROTECTED]> Date: Fri, 29 Sep 2006 12:45:01 -0400 > please consider for 2.6.19 -- thanks! > > [ATM]: [lec] add reference counting to lec_arp entries > > Signed-off-by: Chas Williams <[EMAIL PROTECTED]> Applied. - To unsubscribe from this list: send the

Re: [PATCH 2/8][ATM]: [lec] indent, comment and whitespace cleanup [continued]

2006-09-29 Thread David Miller
From: "chas williams - CONTRACTOR" <[EMAIL PROTECTED]> Date: Fri, 29 Sep 2006 12:38:23 -0400 > please consider for 2.6.19 -- thanks! > > [ATM]: [lec] indent, comment and whitespace cleanup [continued] > > Signed-off-by: Chas Williams <[EMAIL PROTECTED]> Applied. - To unsubscribe from this list:

Re: [PATCH 5/8][ATM]: [lec] old_close is no longer used

2006-09-29 Thread David Miller
From: "chas williams - CONTRACTOR" <[EMAIL PROTECTED]> Date: Fri, 29 Sep 2006 12:43:43 -0400 > please consider for 2.6.19 -- thanks! > > [ATM]: [lec] old_close is no longer used > > Signed-off-by: Chas Williams <[EMAIL PROTECTED]> Applied. - To unsubscribe from this list: send the line "unsubsc

Re: [PATCH 1/1] NetLabel: audit fixups due to delayed feedback

2006-09-29 Thread David Miller
From: Steve Grubb <[EMAIL PROTECTED]> Date: Fri, 29 Sep 2006 20:00:42 -0400 > On Friday 29 September 2006 18:39, [EMAIL PROTECTED] wrote: > > This should make NetLabel more consistent with other kernel > > generated audit messages specifying configuration changes. > > OK, this looks better. We ma

Re: [PATCH 3/8][ATM]: [lec] header indent, comment and whitespace cleanup

2006-09-29 Thread David Miller
From: "chas williams - CONTRACTOR" <[EMAIL PROTECTED]> Date: Fri, 29 Sep 2006 12:39:40 -0400 > please consider for 2.6.19 -- thanks! > > [ATM]: [lec] header indent, comment and whitespace cleanup > > Signed-off-by: Chas Williams <[EMAIL PROTECTED]> Applied. - To unsubscribe from this list: send

Re: [PATCH 2/4] [SCTP]: Include sk_buff overhead while updating the peer's receive window.

2006-09-29 Thread David Miller
From: Sridhar Samudrala <[EMAIL PROTECTED]> Date: Fri, 29 Sep 2006 13:00:20 -0700 > [SCTP]: Include sk_buff overhead while updating the peer's receive window. > > Currently if the sender is sending small messages, it can cause a receiver > to run out of receive buffer space even when the advertis

Re: 2.6.18-mm2 - oops in cache_alloc_refill()

2006-09-29 Thread Valdis . Kletnieks
On Fri, 29 Sep 2006 12:45:58 PDT, Andrew Morton said: (Adding a bunch of people to the cc: list now that I have a clue what is going on) > I'd expect it's the same bug - slab data structures have gone bad. *bing*! We have a winner. A quick check showed the kernel wasn't built with slab debu

Re: [PATCH][BNX2]: Disable MSI on 5706 if AMD 8132 bridge is present

2006-09-29 Thread David Miller
From: "Michael Chan" <[EMAIL PROTECTED]> Date: Fri, 29 Sep 2006 14:07:32 -0700 > [BNX2]: Disable MSI on 5706 if AMD 8132 bridge is present. Applied thanks. We can back this out if we come up with a sceme to do this at a generic level, or we find other faults in this AMD chipset such that added t

Re: [PATCH 1/8][ATM]: [lec] indent, comment and whitespace cleanup

2006-09-29 Thread David Miller
From: "chas williams - CONTRACTOR" <[EMAIL PROTECTED]> Date: Fri, 29 Sep 2006 12:37:26 -0400 > [ATM]: [lec] indent, comment and whitespace cleanup > > Signed-off-by: Chas Williams <[EMAIL PROTECTED]> Applied, thanks. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body

Re: [PATCH 1/4] [SCTP]: Enable Nagle algorithm by default.

2006-09-29 Thread David Miller
From: Sridhar Samudrala <[EMAIL PROTECTED]> Date: Fri, 29 Sep 2006 13:00:03 -0700 > [SCTP]: Enable Nagle algorithm by default. > > This allows more aggressive bundling of chunks when sending small > messages. > > Signed-off-by: Sridhar Samudrala <[EMAIL PROTECTED]> Applied, thanks. - To unsubsc

Re: [PATCH 3/4] [SCTP]: Use correct mask when disabling PMTUD.

2006-09-29 Thread David Miller
From: Sridhar Samudrala <[EMAIL PROTECTED]> Date: Fri, 29 Sep 2006 13:00:29 -0700 > [SCTP]: Use correct mask when disabling PMTUD. > > Signed-off-by: Vlad Yasevich <[EMAIL PROTECTED]> > Signed-off-by: Sridhar Samudrala <[EMAIL PROTECTED]> Applied, thanks. - To unsubscribe from this list: send th

Re: [PATCH 6/8][ATM]: [lec] use work queue instead of timer for lec arp expiry

2006-09-29 Thread David Miller
From: "chas williams - CONTRACTOR" <[EMAIL PROTECTED]> Date: Fri, 29 Sep 2006 12:44:35 -0400 > please consider for 2.6.19 -- thanks! > > [ATM]: [lec] use work queue instead of timer for lec arp expiry > > Signed-off-by: Chas Williams <[EMAIL PROTECTED]> Applied. - To unsubscribe from this list:

Re: [PATCH 4/4] [SCTP]: Do not timestamp every SCTP packet.

2006-09-29 Thread David Miller
From: Sridhar Samudrala <[EMAIL PROTECTED]> Date: Fri, 29 Sep 2006 13:00:37 -0700 > [SCTP]: Do not timestamp every SCTP packet. > > We only need the timestamp on COOKIE-ECHO chunks, so instead of always > timestamping every SCTP packet, let common code timestamp if the socket > option is set. Fo

Re: [PATCH 4/8][ATM]: [lec] convert lec_arp_table to hlist

2006-09-29 Thread David Miller
From: "chas williams - CONTRACTOR" <[EMAIL PROTECTED]> Date: Fri, 29 Sep 2006 12:40:47 -0400 > please consider for 2.6.19 -- thanks! > > [ATM]: [lec] convert lec_arp_table to hlist > > Signed-off-by: Chas Williams <[EMAIL PROTECTED]> Applied. - To unsubscribe from this list: send the line "unsu

Re: [PATCH 1/1] NetLabel: audit fixups due to delayed feedback

2006-09-29 Thread Steve Grubb
On Friday 29 September 2006 18:39, [EMAIL PROTECTED] wrote: > This should make NetLabel more consistent with other kernel > generated audit messages specifying configuration changes. OK, this looks better. We may fine tune the messages later after we try it out, but all the issues I saw are fixed

Re: [PATCH][BNX2]: Disable MSI on 5706 if AMD 8132 bridge is present

2006-09-29 Thread Rick Jones
It absolutely was not vague, it gave an explicit description of what the problem was, down to the transaction type being used by 5706 and what the stated rules are in the PCI spec, and it also gave a clear indication that the 5706 was in the wrong and that this was believed to be a unique situatio

Re: [PATCH][BNX2]: Disable MSI on 5706 if AMD 8132 bridge is present

2006-09-29 Thread Michael Chan
On Fri, 2006-09-29 at 19:15 -0400, Jeff Garzik wrote: > It was completely vague as to why this incompatibility was specific to > the 5706, when -- as the description noted -- the behavior is legal. > The description is a bit vague in that one aspect that Jeff pointed out, but otherwise very com

Re: [PATCH][BNX2]: Disable MSI on 5706 if AMD 8132 bridge is present

2006-09-29 Thread David Miller
From: Jeff Garzik <[EMAIL PROTECTED]> Date: Fri, 29 Sep 2006 19:15:14 -0400 > It was completely vague as to why this incompatibility was specific to > the 5706, when -- as the description noted -- the behavior is legal. > > Re-read the patch. At no time does it say 5706 was in the wrong. True,

[PATCH 6/6]: powerpc/cell spidernet refine locking

2006-09-29 Thread Linas Vepstas
The transmit side of the spider ethernet driver currently places locks around some very large chunks of code. This results in a fair amount of lock contention is some cases. This patch makes the locks much more fine-grained, protecting only the cirtical sections. One lock is used to protect thre

Re: Network problem with 2.6.18-mm1 ?

2006-09-29 Thread Eric W. Biederman
"Jesse Brandeburg" <[EMAIL PROTECTED]> writes: > On 9/28/06, Sukadev Bhattiprolu <[EMAIL PROTECTED]> wrote: >> $ cat /proc/interrupts >> >>CPU0 CPU1 >> 28: 0 0 IO-APIC-fasteoi eth0 >> NMI: 96 35 >> LOC: 18251 18524 >> ERR:

[PATCH 5/6]: powerpc/cell spidernet ethtool -i version number

2006-09-29 Thread Linas Vepstas
Jim, as the official maintainer, you should explicitly ack this patch. --linas This patch moves transmit queue cleanup code out of the interrupt context, and into the NAPI polling routine. Signed-off-by: Linas Vepstas <[EMAIL PROTECTED]> Cc: James K Lewis <[EMAIL PROTECTED]> Cc: Arnd Bergmann <

[PATCH 4/6]: powerpc/cell spidernet ethtool -i version number info.

2006-09-29 Thread Linas Vepstas
This patch adds version information as reported by ethtool -i to the Spidernet driver. From: James K Lewis <[EMAIL PROTECTED]> Signed-off-by: James K Lewis <[EMAIL PROTECTED]> Signed-off-by: Linas Vepstas <[EMAIL PROTECTED]> Cc: Arnd Bergmann <[EMAIL PROTECTED]> drivers/net/spider_net.c

[PATCH 3/6]: powerpc/cell spidernet stop error printing patch.

2006-09-29 Thread Linas Vepstas
Turn off mis-interpretation of the queue-empty interrupt status bit as an error. This bit is set as a part of the previous low-watermark patch. Signed-off-by: Linas Vepstas <[EMAIL PROTECTED]> Signed-off-by: James K Lewis <[EMAIL PROTECTED]> Cc: Arnd Bergmann <[EMAIL PROTECTED]> drivers/n

[PATCH 2/6]: powerpc/cell spidernet low watermark patch.

2006-09-29 Thread Linas Vepstas
Implement basic low-watermark support for the transmit queue. Hardware low-watermarks allow a properly configured kernel to continously stream data to a device and not have to handle any interrupts at all in doing so. Correct zero-interrupt operation can be actually observed for this driver, when

Re: [PATCH][BNX2]: Disable MSI on 5706 if AMD 8132 bridge is present

2006-09-29 Thread Jeff Garzik
David Miller wrote: From: Jeff Garzik <[EMAIL PROTECTED]> Date: Fri, 29 Sep 2006 19:00:15 -0400 The patch and description provided no information about whether or not it would be better to blacklist 8132 globally, as we have already done with the 8131. It absolutely was not vague, it gave an

[PATCH 1/6]: powerpc/cell spidernet burst alignment patch.

2006-09-29 Thread Linas Vepstas
This patch increases the Burst Address alignment from 64 to 1024 in the Spidernet driver. This improves transmit performance for large packets. From: James K Lewis <[EMAIL PROTECTED]> Signed-off-by: James K Lewis <[EMAIL PROTECTED]> Signed-off-by: Linas Vepstas <[EMAIL PROTECTED]> Cc: Arnd Bergma

Re: [PATCH][BNX2]: Disable MSI on 5706 if AMD 8132 bridge is present

2006-09-29 Thread David Miller
From: Jeff Garzik <[EMAIL PROTECTED]> Date: Fri, 29 Sep 2006 19:00:15 -0400 > The patch and description provided no information about whether or not > it would be better to blacklist 8132 globally, as we have already done > with the 8131. It absolutely was not vague, it gave an explicit descrip

[PATCH 0/6]: powerpc/cell spidernet ethernet patches

2006-09-29 Thread Linas Vepstas
Please apply and forward upstream as appropriate. Although these patches have not been baking in any -mm tree, they have been tested and are generally available as a part of the Cell SDK 2.0 overseen by Arnd Bergmann. (Arnd, if you want to lend a voice of authority here, or to correct me, plea

Re: [PATCH][BNX2]: Disable MSI on 5706 if AMD 8132 bridge is present

2006-09-29 Thread Jeff Garzik
David Miller wrote: From: "Michael Chan" <[EMAIL PROTECTED]> Date: Fri, 29 Sep 2006 14:39:23 -0700 On Fri, 2006-09-29 at 17:28 -0400, Jeff Garzik wrote: Michael Chan wrote: AMD believes this incompatibility is unique to the 5706, and prefers to locally disable MSI rather than globally disabli

Re: [PATCH][BNX2]: Disable MSI on 5706 if AMD 8132 bridge is present

2006-09-29 Thread David Miller
From: "Michael Chan" <[EMAIL PROTECTED]> Date: Fri, 29 Sep 2006 14:39:23 -0700 > On Fri, 2006-09-29 at 17:28 -0400, Jeff Garzik wrote: > > Michael Chan wrote: > > > AMD believes this incompatibility is unique to the 5706, and > > > prefers to locally disable MSI rather than globally disabling it >

[PATCH 0/1] NetLabel audit fixup

2006-09-29 Thread paul . moore
This patch is against the current net-2.6 tree and should address the issues that Steve Grubb had with the original patch. Please consider this for the 2.6.19 release. Dave - you may want to wait until Steve explicitly ACKs this ... Steve - can you please explicitly ACK (or complain) about this

[PATCH 1/1] NetLabel: audit fixups due to delayed feedback

2006-09-29 Thread paul . moore
Fix some issues Steve Grubb had with the way NetLabel was using the audit subsystem. This should make NetLabel more consistent with other kernel generated audit messages specifying configuration changes. Signed-off-by: Paul Moore <[EMAIL PROTECTED]> --- include/linux/audit.h | 11

Re: [MLSXFRM] Fix mis-labelling of child sockets

2006-09-29 Thread Paul Moore
James Morris wrote: > On Fri, 29 Sep 2006, David Woodhouse wrote: > > >>Accepted connections of types other than AF_INET, AF_INET6, AF_UNIX >>won't have an appropriate label derived from the peer, so don't use it. >> >>Signed-off-by: David Woodhouse <[EMAIL PROTECTED]> >>Acked-by: Stephen Smalle

Re: [RFC] cfg80211 and nl80211

2006-09-29 Thread James Ketrenos
Johannes Berg wrote: > * Should the userspace daemon be allowed to unilaterally update the >regulatory information if it learns something new (via the user)? Many countries forbid users (root is still a user) being enabled to override the parameters set up by the hardware vendor as tested fo

Re: [PATCH 0/3] myri10ge Large Receive Offload

2006-09-29 Thread Brice Goglin
Jeff Garzik a écrit : > Brice Goglin wrote: >> This is a complete rework of the myri10ge receive path. The first >> patch converts skb allocation to use physical pages. The second one >> adds a software implementation of Large Receive Offload. The third >> one updates the driver version to 1.1.0. >

RE: [PATCH 7/7] secid reconciliation-v03: Enforcement for SELinux

2006-09-29 Thread Venkat Yekkirala
> It seems more of a pain to actually > prevent their use at the same time and/or explain > strange/unnatural > behavior. > >>> > >>>Agreed, the solution that we agreed upon is much easier to > implement and > >>>explain than a lot of the alternatives. > >> > >>Ok, can you please expl

RE: [PATCH 7/7] secid reconciliation-v03: Enforcement for SELinux

2006-09-29 Thread Venkat Yekkirala
> Venkat, > > With xfrm labeling, the external packets are always going to > be protocol > ESP or AH, and we can't connection track the inner protocols. So, Are you sure? This doesn't compare to what my limited testing seems to have turned up (normal netfiltering of inner protos followed by x

[PATCH] b44: fix multicast with >32 groups

2006-09-29 Thread Bill Helfinstine
The b44 driver has a bug where if there are more than B44_MCAST_TABLE_SIZE groups in the dev->mc_list, it will only listen to the first B44_MCAST_TABLE_SIZE that it sees. This patch makes the driver go into RXCONFIG_ALLMULTI mode if there are more than B44_MCAST_TABLE_SIZE groups being subsc

Re: [PATCH 1/1] NetLabel: secid reconciliation support

2006-09-29 Thread Paul Moore
Venkat Yekkirala wrote: >>@@ -3672,16 +3674,20 @@ static int selinux_skb_flow_in(struct sk >> if (err) >> goto out; >> >>- if (xfrm_sid) { >>- err = security_transition_sid(xfrm_sid, skb->secmark, >>- >>SECCLASS_PACKET,

Re: [PATCH][BNX2]: Disable MSI on 5706 if AMD 8132 bridge is present

2006-09-29 Thread Michael Chan
On Fri, 2006-09-29 at 17:28 -0400, Jeff Garzik wrote: > Michael Chan wrote: > > AMD believes this incompatibility is unique to the 5706, and > > prefers to locally disable MSI rather than globally disabling it > > using pci_msi_quirk. > > Why is it unique to the 5706? Is this just a guess on AMD

Re: [MLSXFRM] Fix mis-labelling of child sockets

2006-09-29 Thread James Morris
On Fri, 29 Sep 2006, David Woodhouse wrote: > Accepted connections of types other than AF_INET, AF_INET6, AF_UNIX > won't have an appropriate label derived from the peer, so don't use it. > > Signed-off-by: David Woodhouse <[EMAIL PROTECTED]> > Acked-by: Stephen Smalley <[EMAIL PROTECTED]> Acke

Re: [PATCH 1/1] NetLabel: add audit support for configuration changes

2006-09-29 Thread David Miller
From: Paul Moore <[EMAIL PROTECTED]> Date: Fri, 29 Sep 2006 16:28:36 -0400 > I think Steve and I have agreed on a solution, I'll put together a patch > right now based on what is currently in net-2.6 (i.e. the existing > NetLabel audit patch) and submit it to the lists in a few hours. Great, I'll

Re: rewriting skb->truesize... good or bad idea

2006-09-29 Thread David Miller
From: Vlad Yasevich <[EMAIL PROTECTED]> Date: Fri, 29 Sep 2006 14:16:57 -0400 > I've attached the patch, in case people want to look at the code. > > However, we question if this is a good idea or if this is going to break > things... Modification of skb->truesize is very dangerous and is only l

Re: [PATCH][BNX2]: Disable MSI on 5706 if AMD 8132 bridge is present

2006-09-29 Thread Jeff Garzik
Michael Chan wrote: AMD believes this incompatibility is unique to the 5706, and prefers to locally disable MSI rather than globally disabling it using pci_msi_quirk. Why is it unique to the 5706? Is this just a guess on AMD and Broadcom's part? Jeff - To unsubscribe from this lis

Re: Bcm43xx softMac Driver in 2.6.18

2006-09-29 Thread Ray Lee
(re-adding linux-kernel.) Larry Finger wrote: > Would you please test the attached patch that should be applied to a > vanilla 2.6.18? I'm currently running it, but only for a few minutes. It > comes up fine and I ran it through several ifdown/ifup cycles without > any problem. Okay, this is far

Re: [PATCH] tcp-lp: prevent chance for oops

2006-09-29 Thread David Miller
From: "Wong Edison" <[EMAIL PROTECTED]> Date: Sat, 30 Sep 2006 03:27:00 +0800 > I do this since i have a sourceforge homepage for it. I update the > CVS version there, test, and then submit to netdev. As I sync code > in both side, this $Id$ is keeped. May you just let it be? I think > it will le

What's new in wireless-dev today? (29 September 2006)

2006-09-29 Thread John W. Linville
Here is today's batch -- I'm still playing "catch-up" in the wireless-dev tree. Please bear with me... --- The following changes since commit 0888451bf4108fbaa07b221649b1289d8f79ef0f: John W. Linville: Merge branch 'from-linus' are found in the git repository at: git://git.kernel.o

RE: [PATCH 1/1] NetLabel: secid reconciliation support

2006-09-29 Thread Venkat Yekkirala
> @@ -3672,16 +3674,20 @@ static int selinux_skb_flow_in(struct sk > if (err) > goto out; > > - if (xfrm_sid) { > - err = security_transition_sid(xfrm_sid, skb->secmark, > - > SECCLASS_PACKET, &trans_sid); > -

[MLSXFRM] Fix mis-labelling of child sockets

2006-09-29 Thread David Woodhouse
Accepted connections of types other than AF_INET, AF_INET6, AF_UNIX won't have an appropriate label derived from the peer, so don't use it. Signed-off-by: David Woodhouse <[EMAIL PROTECTED]> Acked-by: Stephen Smalley <[EMAIL PROTECTED]> --- linux-2.6.18.ppc/security/selinux/hooks.c~ 2006-09-28

[PATCH][BNX2]: Disable MSI on 5706 if AMD 8132 bridge is present

2006-09-29 Thread Michael Chan
[BNX2]: Disable MSI on 5706 if AMD 8132 bridge is present. MSI is defined to be 32-bit write. The 5706 does 64-bit MSI writes with byte enables disabled on the unused 32-bit word. This is legal but causes problems on the AMD 8132 which will eventually stop responding after a while. Without this

[PATCH 0/1] NetLabel: patch against Venkat's secid patchset

2006-09-29 Thread paul . moore
The following patch is against this morning's net-2.6 tree with Venkat's secid patches applied. You may notice some differences as I had to fuzz/fix-up Venkat's patches in a few places. This patch provides the missing NetLabel support for the secid reconciliation patches based on the discussio

Re: [PATCH 1/1] NetLabel: add audit support for configuration changes

2006-09-29 Thread Paul Moore
Dave, I think Steve and I have agreed on a solution, I'll put together a patch right now based on what is currently in net-2.6 (i.e. the existing NetLabel audit patch) and submit it to the lists in a few hours. Steve Grubb wrote: > On Friday 29 September 2006 14:09, Paul Moore wrote: > >>>type f

[PATCH 1/1] NetLabel: secid reconciliation support

2006-09-29 Thread paul . moore
This patch provides the missing NetLabel support to the secid reconciliation patchset. Signed-off-by: Paul Moore <[EMAIL PROTECTED]> --- security/selinux/hooks.c| 51 security/selinux/include/objsec.h |1 security/selinux/include/s

[PATCH 1/4] [SCTP]: Enable Nagle algorithm by default.

2006-09-29 Thread Sridhar Samudrala
Dave, Please consider the following 4 SCTP patches for 2.6.19. Thanks Sridhar [SCTP]: Enable Nagle algorithm by default. This allows more aggressive bundling of chunks when sending small messages. Signed-off-by: Sridhar Samudrala <[EMAIL PROTECTED]> --- net/sctp/socket.c |4 ++-- 1 files

[PATCH 4/4] [SCTP]: Do not timestamp every SCTP packet.

2006-09-29 Thread Sridhar Samudrala
[SCTP]: Do not timestamp every SCTP packet. We only need the timestamp on COOKIE-ECHO chunks, so instead of always timestamping every SCTP packet, let common code timestamp if the socket option is set. For COOKIE-ECHO, simply get the time of day if we don't have a timestamp. This introduces a sm

[PATCH 3/4] [SCTP]: Use correct mask when disabling PMTUD.

2006-09-29 Thread Sridhar Samudrala
[SCTP]: Use correct mask when disabling PMTUD. Signed-off-by: Vlad Yasevich <[EMAIL PROTECTED]> Signed-off-by: Sridhar Samudrala <[EMAIL PROTECTED]> --- net/sctp/input.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/net/sctp/input.c b/net/sctp/input.c index 03f65de..4

[PATCH 2/4] [SCTP]: Include sk_buff overhead while updating the peer's receive window.

2006-09-29 Thread Sridhar Samudrala
[SCTP]: Include sk_buff overhead while updating the peer's receive window. Currently if the sender is sending small messages, it can cause a receiver to run out of receive buffer space even when the advertised receive window is still open and results in packet drops and retransmissions. Including

Re: [PATCH 7/7] secid reconciliation-v03: Enforcement for SELinux

2006-09-29 Thread James Morris
On Fri, 29 Sep 2006, Paul Moore wrote: > > ... or related packet doesn't match ... > > Not sure what you mean by "related packet", A related packet with conntrack would be an FTP data packet related to a specific FTP control session (where the conntrack is initialized, and has a secmark saved

Re: [PATCH 7/7] secid reconciliation-v03: Enforcement for SELinux

2006-09-29 Thread Paul Moore
James Morris wrote: > On Fri, 29 Sep 2006, Paul Moore wrote: >>>... or you get no CIPSO label (e.g. ICMP from intermediate router) ... >> >>If there is no packet label that NetLabel recognizes and NetLabel is >>configured to allow unlabeled traffic then the NetLabel SID generated in >>step #1 above

Re: [PATCH 7/7] secid reconciliation-v03: Enforcement for SELinux

2006-09-29 Thread Paul Moore
James Morris wrote: > On Fri, 29 Sep 2006, Paul Moore wrote: > > >>>Say that the SA is labeled "secret" and you have two FTP clients >>>connecting to a server via xinetd on this SA. Each client additionally >>>labels their packets via CIPSO as secret:c1 and secret:c2 respectively. >>>xinetd

Re: [PATCH 7/7] secid reconciliation-v03: Enforcement for SELinux

2006-09-29 Thread James Morris
On Fri, 29 Sep 2006, Paul Moore wrote: > > Say that the SA is labeled "secret" and you have two FTP clients > > connecting to a server via xinetd on this SA. Each client additionally > > labels their packets via CIPSO as secret:c1 and secret:c2 respectively. > > xinetd launches an FTP server

Re: [PATCH] tcp-lp: prevent chance for oops

2006-09-29 Thread Wong Edison
I do this since i have a sourceforge homepage for it. I update the CVS version there, test, and then submit to netdev. As I sync code in both side, this $Id$ is keeped. May you just let it be? I think it will let my maintenance become more simple... On 9/29/06, David Miller <[EMAIL PROTECTED]> w

Re: [PATCH 7/7] secid reconciliation-v03: Enforcement for SELinux

2006-09-29 Thread Paul Moore
Venkat Yekkirala wrote: While I don't see any explicit mention of it in the documentation or your comments, I assume we would want a flow_out check for NetLabel here as well? >>> >>> >>>I don't believe we do. By this time, the packet is or >> >>should already be >> >>>carrying th

Re: [PATCH 7/7] secid reconciliation-v03: Enforcement for SELinux

2006-09-29 Thread Paul Moore
James Morris wrote: > On Fri, 29 Sep 2006, Paul Moore wrote: > >>James Morris wrote: >> >>>Ok, can you please explain it further? >>> >>>i.e. show me what the policy looks like, exactly what the user is trying >>>to achieve, and explain what happens to each packet exactly in terms of >>>labeling

RE: [PATCH 7/7] secid reconciliation-v03: Enforcement for SELinux

2006-09-29 Thread Venkat Yekkirala
> >>While I don't see any explicit mention of it in the documentation or > >>your comments, I assume we would want a flow_out check for > >>NetLabel here > >>as well? > > > > I don't believe we do. By this time, the packet is or > should already be > > carrying the CIPSO/NetLabel option which s

Re: [PATCH 7/7] secid reconciliation-v03: Enforcement for SELinux

2006-09-29 Thread James Morris
On Fri, 29 Sep 2006, Paul Moore wrote: > James Morris wrote: > > Ok, can you please explain it further? > > > > i.e. show me what the policy looks like, exactly what the user is trying > > to achieve, and explain what happens to each packet exactly in terms of > > labeling on the input and outp

rewriting skb->truesize... good or bad idea

2006-09-29 Thread Vlad Yasevich
Hi Folks I was looking at SCTP performance problem that is a result of receive buffer exhaustion and found the we severely overcharge the receive buffer when multiple data chunks are bundled together. This bundling usually happens at retransmit time which penalizes us even more. Here is what happ

Re: [PATCH 1/1] NetLabel: add audit support for configuration changes

2006-09-29 Thread Paul Moore
Steve Grubb wrote: > On Thursday 28 September 2006 14:03, [EMAIL PROTECTED] wrote: >>@@ -381,21 +380,35 @@ static int netlbl_cipsov4_add(struct sk_ >> >> { >> int ret_val = -EINVAL; >>- u32 map_type; >>+ u32 type; >>+ u32 doi; >>+ const char *type_str = "(unknown)"; >>+ str

Re: Network problem with 2.6.18-mm1 ?

2006-09-29 Thread Jesse Brandeburg
On 9/28/06, Sukadev Bhattiprolu <[EMAIL PROTECTED]> wrote: $ cat /proc/interrupts CPU0 CPU1 28: 0 0 IO-APIC-fasteoi eth0 NMI: 96 35 LOC: 18251 18524 ERR: 0 you should be getting an interrupt every two seconds from the et

Re: mii-tool gigabit support.

2006-09-29 Thread Rick Jones
2) develop some style of register description definition type of text file, maybe XML, maybe INI style or something stored in /etc/ethtool as .conf or something like that. This way, ethtool doesn't have to be changed/updated/patched/likely-bug-added for every single device known to man. Just

Re: [PATCH 7/7] secid reconciliation-v03: Enforcement for SELinux

2006-09-29 Thread Paul Moore
James Morris wrote: > On Fri, 29 Sep 2006, James Morris wrote: > > >>On Fri, 29 Sep 2006, Paul Moore wrote: >> >> It seems more of a pain to actually prevent their use at the same time and/or explain strange/unnatural behavior. >>> >>>Agreed, the solution that we agreed upon is much e

Re: [PATCH 7/7] secid reconciliation-v03: Enforcement for SELinux

2006-09-29 Thread Paul Moore
James Morris wrote: > On Fri, 29 Sep 2006, Paul Moore wrote: > >>>It seems more of a pain to actually >>>prevent their use at the same time and/or explain strange/unnatural >>>behavior. >> >>Agreed, the solution that we agreed upon is much easier to implement and >>explain than a lot of the altern

Re: [PATCH 7/7] secid reconciliation-v03: Enforcement for SELinux

2006-09-29 Thread Paul Moore
Venkat Yekkirala wrote: >>>+static int selinux_skb_flow_out(struct sk_buff *skb, u32 nf_secid) >>>+{ >>>+u32 trans_sid; >>>+int err; >>>+ >>>+if (selinux_compat_net) >>>+return 1; >>>+ >>>+if (!skb->secmark) { >>>+u32 xfrm_sid; >>>+ >>>+selinux_sk

Re: [PATCH 7/7] secid reconciliation-v03: Enforcement for SELinux

2006-09-29 Thread James Morris
On Fri, 29 Sep 2006, James Morris wrote: > On Fri, 29 Sep 2006, Paul Moore wrote: > > > > It seems more of a pain to actually > > > prevent their use at the same time and/or explain strange/unnatural > > > behavior. > > > > Agreed, the solution that we agreed upon is much easier to implement and

RE: [PATCH 7/7] secid reconciliation-v03: Enforcement for SELinux

2006-09-29 Thread Venkat Yekkirala
> > +static int selinux_skb_flow_in(struct sk_buff *skb, > unsigned short family) > > +{ > > + u32 xfrm_sid, trans_sid; > > + int err; > > + > > + if (selinux_compat_net) > > + return 1; > > + > > + /* xfrm/cipso inapplicable for loopback traffic */ > > + if (skb->dev == &loopb

Re: mii-tool gigabit support.

2006-09-29 Thread Stephen Hemminger
On Fri, 29 Sep 2006 12:12:58 -0400 David Hollis <[EMAIL PROTECTED]> wrote: > On Wed, 2006-09-27 at 12:32 -0700, Auke Kok wrote: > > dumping registers in readable format is an extension that needs to be > > implemented per driver. Not all nics have done this - we just did it > > ourselves > > for

Re: [PATCH 7/7] secid reconciliation-v03: Enforcement for SELinux

2006-09-29 Thread James Morris
On Fri, 29 Sep 2006, Paul Moore wrote: > > It seems more of a pain to actually > > prevent their use at the same time and/or explain strange/unnatural > > behavior. > > Agreed, the solution that we agreed upon is much easier to implement and > explain than a lot of the alternatives. Ok, can you

[PATCH 8/8][ATM]: [lec] use refcnt to protect lec_arp_entries outside lock

2006-09-29 Thread chas williams - CONTRACTOR
please consider for 2.6.19 -- thanks! [ATM]: [lec] use refcnt to protect lec_arp_entries outside lock Signed-off-by: Chas Williams <[EMAIL PROTECTED]> --- commit 74391472d01cdd483714b807c9417a0279ed75d5 tree a191d09973b569f0562d9d433c324bbe80a08560 parent 397725689277192a899da4009cd078bab8f6ee2d

[PATCH 7/8][ATM]: [lec] add reference counting to lec_arp entries

2006-09-29 Thread chas williams - CONTRACTOR
please consider for 2.6.19 -- thanks! [ATM]: [lec] add reference counting to lec_arp entries Signed-off-by: Chas Williams <[EMAIL PROTECTED]> --- commit 397725689277192a899da4009cd078bab8f6ee2d tree 3bba44e1549229947ed332bb6263c704cabd55c7 parent 0152dcfb9d42e203ff26d1619158c9664cfbf2d9 author c

  1   2   >