Re: proposal for new wireless configuration API

2006-08-15 Thread Johannes Berg
On Tue, 2006-08-15 at 12:29 -0400, Dan Williams wrote: > We might want to take the time to fix up a few of the ambiguities of > WEXT that we've encountered over the past few years: Yes, I definitely agree. > o Separate attributes for signal strength units; signed integer type for > dBm, unsigned

Re: bonding: cannot remove certain named devices

2006-08-15 Thread Giacomo A. Catenazzi
David Miller wrote: > From: Bodo Eggert <[EMAIL PROTECTED]> > Date: Wed, 16 Aug 2006 02:02:03 +0200 > >> Stephen Hemminger <[EMAIL PROTECTED]> wrote: >> >>> IMHO idiots who put space's in filenames should be ignored. As long as the >>> bonding code doesn't throw a fatal error, it has every right t

Re: [PATCH 1/1] network memory allocator.

2006-08-15 Thread Evgeniy Polyakov
On Tue, Aug 15, 2006 at 10:52:37PM -0400, Bill Fink ([EMAIL PROTECTED]) wrote: > > Let's main system works only with TCP for simplicity. > > Let's maximum allowed memory is limited by 1mb (it is 768k on machine > > with 1gb of ram). > > The maximum amount of memory available for TCP on a system wi

Re: [E1000-devel] e1000: ethtool -p + cable pull = system wedges hard

2006-08-15 Thread Jay Vosburgh
Auke Kok <[EMAIL PROTECTED]> wrote: >Auke Kok wrote: >> Jay Vosburgh wrote: >>> Running both 2.6.17.6 plus the e1000 7.2.7 from sourceforge, or >>> the e1000 in netdev-2.6#upstream (7.1.9-k4). >>> >>> Starting up "ethtool -p ethX" then unplugging the cable >>> connected to the identified p

Re: [PATCH] eth: docbook comments

2006-08-15 Thread Randy.Dunlap
On Tue, 15 Aug 2006, Stephen Hemminger wrote: > Acked-by: Randy Dunlap <[EMAIL PROTECTED]> > --- > net/ethernet/eth.c | 90 > + > 1 file changed, 64 insertions(+), 26 deletions(-) > > --- net-2.6.19.orig/net/ethernet/eth.c > +++ net-2.6.19

Re: [PATCH 7/7] [I/OAT] Add entries to MAINTAINERS for the DMA memcpy subsystem and ioatdma

2006-08-15 Thread Randy.Dunlap
On Tue, 15 Aug 2006, Chris Leech wrote: > Signed-off-by: Chris Leech <[EMAIL PROTECTED]> > --- > > MAINTAINERS | 10 ++ > 1 files changed, 10 insertions(+), 0 deletions(-) > > diff --git a/MAINTAINERS b/MAINTAINERS > index 21116cc..9ae73c9 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS

DEBUG_LOCKS_WARN_ON triggered by bcm43xx-SoftMAC

2006-08-15 Thread Larry Finger
Using vanilla wireless-2.6 from Linville's tree as updated today, I get a warning generated by the statement if (DEBUG_LOCKS_WARN_ON(!irqs_disabled())) in kernel.lockdep.c. This warning only occurs when my wireless interface is inserted and bcm43xx-softmac is activated. For that reason I h

Re: hard_start_xmit conext

2006-08-15 Thread Herbert Xu
kiran kandi <[EMAIL PROTECTED]> wrote: > > In what context hard_start_xmit function is called. Is it called in soft > irq or a processes context. softirq > Also can you call kfree_skb in soft irq context. Yes. Don't do it in hard irq context though. Cheers, -- Visit Openswan at http://ww

Re: Fw: [Bugme-new] [Bug 7009] New: possible recursive locking detected

2006-08-15 Thread Herbert Xu
Andrew Morton <[EMAIL PROTECTED]> wrote: > > = > [ INFO: possible recursive locking detected ] > - > java/3069 is trying to acquire lock: > (slock-AF_INET6){-+..}, at: [] sk_clone+0xcc/0x341 > > but task is al

Re: [PATCH 09/16] [IPv6] address: Convert address notification to use rtnl_notify()

2006-08-15 Thread Herbert Xu
On Wed, Aug 16, 2006 at 12:58:28PM +1000, Herbert Xu wrote: > > I'm not comfortable with that change since it implies the message > originated from a user-space process. > > The netlink header pid is really akin to sadb_msg_pid from RFC 2367. > IMHO it should always be zero if the kernel is the o

Re: [E1000-devel] e1000: ethtool -p + cable pull = system wedges hard

2006-08-15 Thread Auke Kok
Auke Kok wrote: Jay Vosburgh wrote: Running both 2.6.17.6 plus the e1000 7.2.7 from sourceforge, or the e1000 in netdev-2.6#upstream (7.1.9-k4). Starting up "ethtool -p ethX" then unplugging the cable connected to the identified port is causing my system to completely freeze; ev

Re: [PATCH][IPSEC]: Aggregate make_jiffies

2006-08-15 Thread jamal
On Wed, 2006-16-08 at 12:33 +1000, Herbert Xu wrote: > On Tue, Aug 15, 2006 at 09:58:19PM -0400, jamal wrote: > > +static inline unsigned long make_jiffies(long secs) > > +{ > > + if (secs >= (MAX_SCHEDULE_TIMEOUT-1)/HZ) > > + return MAX_SCHEDULE_TIMEOUT-1; > > + else > > +

Re: [PATCH 09/16] [IPv6] address: Convert address notification to use rtnl_notify()

2006-08-15 Thread Herbert Xu
Thomas Graf <[EMAIL PROTECTED]> wrote: > > IPv4 address notifications originating from a netlink request now > carry the netlink pid of the request instead of 0. I'm not comfortable with that change since it implies the message originated from a user-space process. The netlink header pid is reall

Re: [PATCH 1/1] network memory allocator.

2006-08-15 Thread Bill Fink
On Tue, 15 Aug 2006, Evgeniy Polyakov wrote: > On Tue, Aug 15, 2006 at 03:49:28PM +0200, Peter Zijlstra ([EMAIL PROTECTED]) > wrote: > > > It could if you can provide adequate detection of memory pressure and > > fallback to a degraded mode within the same allocator/stack and can > > guarantee l

Re: [PATCH] keep track of network interface renaming

2006-08-15 Thread Patrick McHardy
Olaf Hering wrote: > Keep track about which network interface names were renamed after the > network device driver printed its banner. Previous kernel names will > be reused when new interfaces get registerd. > Recent udev scripts implement a stable kernel device name for network > interfaces. > Th

Re: [PATCH][IPSEC]: Aggregate make_jiffies

2006-08-15 Thread Herbert Xu
On Tue, Aug 15, 2006 at 09:58:19PM -0400, jamal wrote: > > diff --git a/include/net/xfrm.h b/include/net/xfrm.h > index 8123d49..05444dd 100644 > --- a/include/net/xfrm.h > +++ b/include/net/xfrm.h > @@ -619,6 +619,14 @@ xfrm_state_addr_cmp(struct xfrm_tmpl *tm > return !0; > } > > +static

[PATCH][IPSEC]: Aggregate make_jiffies

2006-08-15 Thread jamal
make_jiffies definition is repeated in xfrm_state and xfrm_policy. Aggregate in header instead. Against Dave's last perf improvement patches. signed-off-by: Jamal Hadi Salim<[EMAIL PROTECTED]> diff --git a/include/net/xfrm.h b/include/net/xfrm.h index 8123d49..05444dd 100644 --- a/include/net/

[PATCH] Restore antenna selection settings after port reset

2006-08-15 Thread Pavel Roskin
From: Pavel Roskin <[EMAIL PROTECTED]> Intersil firmware 1.7.4 (and possibly others) loses the antenna selection settings when the port is reset. Signed-off-by: David Acker <[EMAIL PROTECTED]> Signed-off-by: Pavel Roskin <[EMAIL PROTECTED]> --- drivers/net/wireless/hostap/hostap_hw.c |3 +++

Re: [Bug 6936] BUG: warning at net/core/dev.c:1171/skb_checksum_help()

2006-08-15 Thread Herbert Xu
On Tue, Aug 15, 2006 at 11:29:59AM -0700, [EMAIL PROTECTED] wrote: > http://bugzilla.kernel.org/show_bug.cgi?id=6936 It's actually a bug in the bridging code :) [BRIDGE]: Disable SG/GSO if TX checksum is off When the bridge recomputes features, it does not maintain the constraint that SG/GSO mus

Re: e1000: ethtool -p + cable pull = system wedges hard

2006-08-15 Thread Auke Kok
Jay Vosburgh wrote: Running both 2.6.17.6 plus the e1000 7.2.7 from sourceforge, or the e1000 in netdev-2.6#upstream (7.1.9-k4). Starting up "ethtool -p ethX" then unplugging the cable connected to the identified port is causing my system to completely freeze; even sysrq is unres

RE: [PATCH 4/6] ehea: header files

2006-08-15 Thread Michael Ellerman
On Tue, 2006-08-15 at 13:07 +0200, Christoph Raisch wrote: > > "Jenkins, Clive" wrote on 15.08.2006 12:53:05: > > > > > You mean the eHEA has its own concept of page size? Separate from > > the > > > > page size used by the MMU? > > > > > > > > > > yes, the eHEA currently supports only 4K pages f

[PATCH 6/7] [I/OAT] Add documentation for the tcp_dma_copybreak sysctl

2006-08-15 Thread Chris Leech
Signed-off-by: Chris Leech <[EMAIL PROTECTED]> --- Documentation/networking/ip-sysctl.txt |6 ++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/Documentation/networking/ip-sysctl.txt b/Documentation/networking/ip-sysctl.txt index d46338a..841d61e 100644 --- a/Documentatio

[PATCH 5/7] [I/OAT] Remove the use of writeq from the ioatdma driver

2006-08-15 Thread Chris Leech
There's only one now anyway, and it's not in a performance path, so make it behave the same on 32-bit and 64-bit CPUs. Signed-off-by: Chris Leech <[EMAIL PROTECTED]> --- drivers/dma/ioatdma.c | 10 -- 1 files changed, 4 insertions(+), 6 deletions(-) diff --git a/drivers/dma/ioatdma.c

[PATCH 7/7] [I/OAT] Add entries to MAINTAINERS for the DMA memcpy subsystem and ioatdma

2006-08-15 Thread Chris Leech
Signed-off-by: Chris Leech <[EMAIL PROTECTED]> --- MAINTAINERS | 10 ++ 1 files changed, 10 insertions(+), 0 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index 21116cc..9ae73c9 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -881,6 +881,11 @@ M: [EMAIL PROTECTED] L: linux-ker

[PATCH 4/7] [I/OAT] Remove the wrappers around read(bwl)/write(bwl) in ioatdma

2006-08-15 Thread Chris Leech
Signed-off-by: Chris Leech <[EMAIL PROTECTED]> --- drivers/dma/ioatdma.c| 60 +++ drivers/dma/ioatdma_io.h | 118 -- 2 files changed, 28 insertions(+), 150 deletions(-) diff --git a/drivers/dma/ioatdma.c b/drivers/dma/ioatdma

[PATCH 2/7] [I/OAT] Only offload copies for TCP when there will be a context switch

2006-08-15 Thread Chris Leech
The performance wins come with having the DMA copy engine doing the copies in parallel with the context switch. If there is enough data ready on the socket at recv time just use a regular copy. Signed-off-by: Chris Leech <[EMAIL PROTECTED]> --- net/ipv4/tcp.c | 10 +++--- 1 files changed,

[PATCH 3/7] [I/OAT] Don't offload copies for loopback traffic

2006-08-15 Thread Chris Leech
Local traffic (loopback) is generally in cache anyway, and the overhead cost of offloading the copy is worse than just doing it with the CPU. Signed-off-by: Chris Leech <[EMAIL PROTECTED]> --- net/ipv4/tcp.c |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/net/ipv4/tcp

[PATCH 1/7] [I/OAT] Push pending transactions to hardware more frequently

2006-08-15 Thread Chris Leech
Every 20 descriptors turns out to be to few append commands with newer/faster CPUs. Pushing every 4 still cuts down on MMIO writes to an acceptable level without letting the DMA engine run out of work. Signed-off-by: Chris Leech <[EMAIL PROTECTED]> --- drivers/dma/ioatdma.c |4 ++-- 1 files

[PATCH 1/2] orinoco: Don't use "extern inline" on locking functions

2006-08-15 Thread Pavel Roskin
From: Pavel Roskin <[EMAIL PROTECTED]> SPARC architecture has been fixed, so it's no longer needed. Signed-off-by: Pavel Roskin <[EMAIL PROTECTED]> --- drivers/net/wireless/orinoco.h |8 ++-- 1 files changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/net/wireless/orinoco.h b

[PATCH 2/2] Don't rely on linux/if_arp.h being included by other headers

2006-08-15 Thread Pavel Roskin
From: Pavel Roskin <[EMAIL PROTECTED]> --- drivers/net/wireless/orinoco.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/drivers/net/wireless/orinoco.c b/drivers/net/wireless/orinoco.c index 317ace7..1174ff5 100644 --- a/drivers/net/wireless/orinoco.c +++ b/drivers/net

[PATCH] spectrum_cs: Fix incorrect use of pcmcia_dev_present()

2006-08-15 Thread Pavel Roskin
From: Pavel Roskin <[EMAIL PROTECTED]> This bug was introduced during the PCMCIA API conversion and broke spectrum_cs completely. Tracked down by Fredrik Tolf <[EMAIL PROTECTED]> Signed-off-by: Pavel Roskin <[EMAIL PROTECTED]> --- This patch should go to 2.6.18 and 2.6.17.y. --- drivers/net/w

e1000: ethtool -p + cable pull = system wedges hard

2006-08-15 Thread Jay Vosburgh
Running both 2.6.17.6 plus the e1000 7.2.7 from sourceforge, or the e1000 in netdev-2.6#upstream (7.1.9-k4). Starting up "ethtool -p ethX" then unplugging the cable connected to the identified port is causing my system to completely freeze; even sysrq is unresponsive. I'm running

Re: [PATCH 4/4]: powerpc/cell spidernet ethtool -i version number info.

2006-08-15 Thread Michael Ellerman
On Tue, 2006-08-15 at 14:05 -0500, Olof Johansson wrote: > On Fri, Aug 11, 2006 at 01:50:19PM -0500, James K Lewis wrote: > > Hi Olof, > > > > There are several reasons why an Ethernet driver should have an up to > > date version number: > > > > 1. Customers like to see they are really gettin

Re: bonding: cannot remove certain named devices

2006-08-15 Thread David Miller
From: Bodo Eggert <[EMAIL PROTECTED]> Date: Wed, 16 Aug 2006 02:02:03 +0200 > Stephen Hemminger <[EMAIL PROTECTED]> wrote: > > > IMHO idiots who put space's in filenames should be ignored. As long as the > > bonding code doesn't throw a fatal error, it has every right to return > > "No such devic

Re: bonding: cannot remove certain named devices

2006-08-15 Thread Bodo Eggert
Stephen Hemminger <[EMAIL PROTECTED]> wrote: > IMHO idiots who put space's in filenames should be ignored. As long as the > bonding code doesn't throw a fatal error, it has every right to return > "No such device" to the fool. Maybe you should limit device names to eight uppercase characters and

[PATCH] Re: Possible leak of multicast source filter sctructure

2006-08-15 Thread David Stevens
Here's a patch to fix source filter leakage when a device is removed and a process leaves the group thereafter. (2nd part of prior discussion) This patch also includes corresponding fixes for IPv6 multicast source filters on device removal (1st & 2nd parts of prior discussion, for IPv6).

[PATCH] WAN: fix C101 card carrier handling

2006-08-15 Thread Krzysztof Halasa
Hi, One of my recent changes broke C101 carrier handling, this patch fixes it. Also fixes an old TX underrun checking bug. 2.6.18 material. Please apply. Thanks. Signed-off-by: Krzysztof Halasa <[EMAIL PROTECTED]> diff --git a/drivers/net/wan/c101.c b/drivers/net/wan/c101.c index 435e91e..6b63b

bcm43xx-softmac maintainer

2006-08-15 Thread Larry Finger
As of today, I have taken on the duties of maintaining the bcm43xx-softmac code. I thank Michael Buesch for the heroic job that he has done. He ruffled a few feathers ;-) now and then, but he probably exhibited more patience than many would have. Michael will be concentrating on the bcm43xx-dsca

Re: [PATCH] Use __always_inline in orinoco_lock()/orinoco_unlock()

2006-08-15 Thread David Miller
From: Pavel Roskin <[EMAIL PROTECTED]> Date: Tue, 15 Aug 2006 19:14:32 -0400 > On Tue, 2006-08-15 at 15:54 -0700, David Miller wrote: > > > > /* These functions *must* be inline or they will break horribly on > > > > - * SPARC, due to its weird semantics for save/restore flags. extern > > > >

Re: bonding: cannot remove certain named devices

2006-08-15 Thread Stephen Hemminger
On Tue, 15 Aug 2006 15:56:12 -0700 (PDT) David Miller <[EMAIL PROTECTED]> wrote: > From: Stephen Hemminger <[EMAIL PROTECTED]> > Date: Tue, 15 Aug 2006 15:44:44 -0700 > > > IMHO idiots who put space's in filenames should be ignored. As long > > as the bonding code doesn't throw a fatal error, it

Re: bonding: cannot remove certain named devices

2006-08-15 Thread Mitch Williams
On Tue, 15 Aug 2006, David Miller wrote: > > I agree that whitespace in device names push the limits of sanity. > > But if we believe that, we should enforce it in dev_valid_name(). > > Does anyone really mind if I add the whitespace check there? > I have no objections. It would certainly make

Re: New driver questions: Attansic L1 gigabit NIC

2006-08-15 Thread Jay Cliburn
Stephen Hemminger wrote: On Sun, 13 Aug 2006 19:11:42 -0500 Jay Cliburn <[EMAIL PROTECTED]> wrote: ...snip... I've read the LKML FAQ regarding new driver submissions, but it implies that the submitter be willing to maintain the driver, which I'm not qualified to do. I haven't contacted Attansi

Re: [PATCH] Use __always_inline in orinoco_lock()/orinoco_unlock()

2006-08-15 Thread Pavel Roskin
On Tue, 2006-08-15 at 15:54 -0700, David Miller wrote: > > > /* These functions *must* be inline or they will break horribly on > > > - * SPARC, due to its weird semantics for save/restore flags. extern > > > - * inline should prevent the kernel from linking or module from > > > - * loading if

Re: bonding: cannot remove certain named devices

2006-08-15 Thread David Miller
From: Stephen Hemminger <[EMAIL PROTECTED]> Date: Tue, 15 Aug 2006 15:44:44 -0700 > IMHO idiots who put space's in filenames should be ignored. As long > as the bonding code doesn't throw a fatal error, it has every right > to return "No such device" to the fool. I agree that whitespace in device

Re: [PATCH] Use __always_inline in orinoco_lock()/orinoco_unlock()

2006-08-15 Thread David Miller
From: Dave Jones <[EMAIL PROTECTED]> Date: Tue, 15 Aug 2006 18:50:12 -0400 > On Tue, Aug 15, 2006 at 03:25:58PM -0400, Pavel Roskin wrote: > > > diff --git a/drivers/net/wireless/orinoco.h > b/drivers/net/wireless/orinoco.h > > index 16db3e1..8fd9b32 100644 > > --- a/drivers/net/wireless/orin

Re: [PATCH] Use __always_inline in orinoco_lock()/orinoco_unlock()

2006-08-15 Thread Dave Jones
On Tue, Aug 15, 2006 at 03:25:58PM -0400, Pavel Roskin wrote: > diff --git a/drivers/net/wireless/orinoco.h b/drivers/net/wireless/orinoco.h > index 16db3e1..8fd9b32 100644 > --- a/drivers/net/wireless/orinoco.h > +++ b/drivers/net/wireless/orinoco.h > @@ -135,11 +135,9 @@ extern irqreturn_t

Re: bonding: cannot remove certain named devices

2006-08-15 Thread Stephen Hemminger
On Tue, 15 Aug 2006 15:41:08 -0700 Mitch Williams <[EMAIL PROTECTED]> wrote: > On Tue, 15 Aug 2006, Bill Nottingham wrote: > > > > Stephen Hemminger ([EMAIL PROTECTED]) said: > > > > They're certainly allowed, and the sysfs directory structure, files, > > > > etc. handle it ok. Userspace tends to

Re: bonding: cannot remove certain named devices

2006-08-15 Thread Mitch Williams
On Tue, 15 Aug 2006, Bill Nottingham wrote: > > Stephen Hemminger ([EMAIL PROTECTED]) said: > > > They're certainly allowed, and the sysfs directory structure, files, > > > etc. handle it ok. Userspace tends to break in a variety of ways. > > > > > > I believe the only invalid character in an inter

[PATCH] Add Larry Finger to bcm43xx MAINTAINERS

2006-08-15 Thread Michael Buesch
Hi, I officially drop my maintainance of the bcm43xx-softmac driver now with this mail. Larry will continue with my work on the bcm43xx-softmac driver. I will instead focus on the bcm43xx-d80211 driver and on the implementation of the new v4 specs. So if someone wants to send some bcm43xx-softma

[PATCH] bcm43xx: re-add bcm43xx_rng_init() call

2006-08-15 Thread Michael Buesch
Hi John, Please apply this to wireless-2.6. Please also drop Adrian's patch (If you queued it somewhere): [RFC: -mm patch] bcm43xx_main.c: remove 3 functions -- Calls to bcm43xx_rng_init() and bcm43xx_rng_exit() got lost due to merge trouble. Re-add them. Signed-off-by: Michael Buesch <[EMAIL P

Re: PATCH Fix bonding active-backup behavior for VLAN interfaces

2006-08-15 Thread David Miller
From: Jay Vosburgh <[EMAIL PROTECTED]> Date: Tue, 15 Aug 2006 15:18:13 -0700 > I have successfully reproduced the problem and subsequently > validated this patch against 2.6.17.6. I'm building netdev-2.6#upstream > right now, but I expect it will work as well (and will report back only > if

[PATCH] bcm43xx: >1G and 64bit DMA support

2006-08-15 Thread Michael Buesch
Hi John, Please apply this to wireless-2.6. -- This is a rewrite of the bcm43xx DMA engine. It adds support for >1G of memory (for chips that support the extension bits) and 64-bit DMA (for chips that support it). Signed-off-by: Michael Buesch <[EMAIL PROTECTED]> Index: wireless-2.6/drivers/ne

Re: PATCH Fix bonding active-backup behavior for VLAN interfaces

2006-08-15 Thread Jay Vosburgh
David Miller <[EMAIL PROTECTED]> wrote: [...] >Ok, since __vlan_hwaccel_rx() bypasses the netif_receive_skb() >that would normally occur, we have to duplicate the bonding >drop checks. > >The submitted patch put skb_bond() into if_vlan.h which is >definitely the wrong thing to do. This is a generi

Re: bonding: cannot remove certain named devices

2006-08-15 Thread Bill Nottingham
Stephen Hemminger ([EMAIL PROTECTED]) said: > > They're certainly allowed, and the sysfs directory structure, files, > > etc. handle it ok. Userspace tends to break in a variety of ways. > > > > I believe the only invalid character in an interface name is '/'. > > > > The names "." and ".." are

Re: [PATCH 0/10]: Improve SA insert/delete performance

2006-08-15 Thread jamal
On Tue, 2006-15-08 at 08:15 -0400, jamal wrote: > Very cool ;-> Will test today. > I can see in the range of ~50K SA adds per second ;-> I only went to about 350K SAs. A dual Xeon 2.6Ghz (sadly only with 1G RAM). So a small improvement from just the 5 initial patches; but nevertheless a huge imp

Re: bonding: cannot remove certain named devices

2006-08-15 Thread Stephen Hemminger
On Tue, 15 Aug 2006 16:45:55 -0400 Bill Nottingham <[EMAIL PROTECTED]> wrote: > Mitch Williams ([EMAIL PROTECTED]) said: > > Are spaces allowed in interface names anyway? I can't believe that > > bonding is the only area affected by this. > > They're certainly allowed, and the sysfs directory s

[PATCH] eth: indentation and cleanup (revised)

2006-08-15 Thread Stephen Hemminger
Run ethernet support through Lindent and fix up. Applies after docbook comments patch Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- net-2.6.19.orig/net/ethernet/eth.c +++ net-2.6.19/net/ethernet/eth.c @@ -78,39 +78,37 @@ __setup("ether=", netdev_boot_setup); * in here instead. It i

Re: [PATCH] bcm43xx-d80211: Init, shutdown and restart fixes

2006-08-15 Thread Larry Finger
John W. Linville wrote: Actually, this leads to a bigger question. I noticed Michael pleading his support dilemma w.r.t. supporting both wireless-2.6 and wirless-dev. I'm sure he now regrets the "stunt" of trying to support both at the same time... :-) Anyway, it would seem like many of these

Re: bonding: cannot remove certain named devices

2006-08-15 Thread Bill Nottingham
Mitch Williams ([EMAIL PROTECTED]) said: > Are spaces allowed in interface names anyway? I can't believe that > bonding is the only area affected by this. They're certainly allowed, and the sysfs directory structure, files, etc. handle it ok. Userspace tends to break in a variety of ways. I bel

Re: bonding: cannot remove certain named devices

2006-08-15 Thread Mitch Williams
On Tue, 15 Aug 2006, Bill Nottingham wrote: > 2.6.17-rc4+. > > Trivial example: > > # modprobe bonding (creates bond0) > # ip link set bond0 name "a b" > # echo "-a b" > /sys/class/net/bonding_masters > bonding: unable to delete non-existent bond a > bash: echo: write error: No such device > Yuc

Re: [PATCH] eth: indentation and cleanup

2006-08-15 Thread James Morris
On Tue, 15 Aug 2006, Stephen Hemminger wrote: > -__be16 eth_type_trans(struct sk_buff *skb, struct net_device *dev) > +__be16 eth_type_trans(struct sk_buff * skb, struct net_device * dev) Looks fine except for this. - James -- James Morris <[EMAIL PROTECTED]> - To unsubscribe from this list:

Re: proposal for new wireless configuration API

2006-08-15 Thread Dan Williams
On Tue, 2006-08-15 at 21:35 +0200, Michael Buesch wrote: > On Tuesday 15 August 2006 21:27, Simon Barber wrote: > > A further complication happens in Japan with 802.11j, and now in the USA > > too - with 802.11y in the 3.65Ghz band - here there are some new channel > > widths that are possible. Nor

[PATCH] eth: indentation and cleanup

2006-08-15 Thread Stephen Hemminger
Run ethernet support through Lindent and fix up. Applies after docbook comments patch Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- net/ethernet/eth.c | 98 + 1 file changed, 47 insertions(+), 51 deletions(-) --- net-2.6.19.orig/n

Re: proposal for new wireless configuration API

2006-08-15 Thread Dan Williams
On Tue, 2006-08-15 at 21:13 +0200, Michael Buesch wrote: > On Tuesday 15 August 2006 20:14, Dan Williams wrote: > > On Tue, 2006-08-15 at 18:38 +0200, Michael Buesch wrote: > > > On Tuesday 15 August 2006 18:29, Dan Williams wrote: > > > > o Separate attributes for channel and frequency > > > > >

[PATCH] eth: docbook comments

2006-08-15 Thread Stephen Hemminger
Add docbook style comments to ethernet support. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- net/ethernet/eth.c | 90 + 1 file changed, 64 insertions(+), 26 deletions(-) --- net-2.6.19.orig/net/ethernet/eth.c +++ net-2.6.19/net/e

[PATCH] neighbour: reduce exports

2006-08-15 Thread Stephen Hemminger
There are several symbols only used by rtnetlink and since it can not be a module, there is no reason to export them. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- net/core/neighbour.c |6 +- 1 file changed, 1 insertion(+), 5 deletions(-) --- net-2.6.19.orig/net/core/neighbo

bonding: cannot remove certain named devices

2006-08-15 Thread Bill Nottingham
2.6.17-rc4+. Trivial example: # modprobe bonding (creates bond0) # ip link set bond0 name "a b" # echo "-a b" > /sys/class/net/bonding_masters bonding: unable to delete non-existent bond a bash: echo: write error: No such device Bill - To unsubscribe from this list: send the line "unsubscribe n

Re: proposal for new wireless configuration API

2006-08-15 Thread Michael Buesch
On Tuesday 15 August 2006 21:27, Simon Barber wrote: > A further complication happens in Japan with 802.11j, and now in the USA > too - with 802.11y in the 3.65Ghz band - here there are some new channel > widths that are possible. Normally 802.11 is 20 or 22Mhz wide (20Mhz for > OFDM modulations -

Re: [RFC][PATCH 0/9] Network receive deadlock prevention for NBD

2006-08-15 Thread Pavel Machek
Hi! > Recently, Peter Zijlstra and I have been busily collaborating on a > solution to the memory deadlock problem described here: > >http://lwn.net/Articles/144273/ >"Kernel Summit 2005: Convergence of network and storage paths" > > We believe that an approach very much like today's pat

RE: proposal for new wireless configuration API

2006-08-15 Thread Simon Barber
A further complication happens in Japan with 802.11j, and now in the USA too - with 802.11y in the 3.65Ghz band - here there are some new channel widths that are possible. Normally 802.11 is 20 or 22Mhz wide (20Mhz for OFDM modulations - 11a/g, 22 for 11b). In Japan's 4.9Ghz band you can run the OF

Re: [2.6 patch] orinoco.h: "extern inline" -> "static __always_inline"

2006-08-15 Thread Pavel Roskin
On Tue, 2006-08-15 at 02:40 +0200, Adrian Bunk wrote: > "extern inline" generates a warning with -Wmissing-prototypes and I'm > currently working on getting the kernel cleaned up for adding this to > the CFLAGS since it will help us to avoid a nasty class of runtime > errors. > > Signed-off-by:

[PATCH] Use __always_inline in orinoco_lock()/orinoco_unlock()

2006-08-15 Thread Pavel Roskin
From: Pavel Roskin <[EMAIL PROTECTED]> This is exactly the case when they are needed. This also fixed a warning with -Wmissing-prototypes Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> Signed-off-by: Pavel Roskin <[EMAIL PROTECTED]> --- drivers/net/wireless/orinoco.h | 12 +--- 1 fil

hard_start_xmit conext

2006-08-15 Thread kiran kandi
Hi all, In what context hard_start_xmit function is called. Is it called in soft irq or a processes context. Also can you call kfree_skb in soft irq context. -- Thanks kiran _ On the road to retirement? Check out MSN Life Eve

Re: proposal for new wireless configuration API

2006-08-15 Thread Michael Buesch
On Tuesday 15 August 2006 20:14, Dan Williams wrote: > On Tue, 2006-08-15 at 18:38 +0200, Michael Buesch wrote: > > On Tuesday 15 August 2006 18:29, Dan Williams wrote: > > > o Separate attributes for channel and frequency > > > > No, channel and freq is the same. It's just another name > > for th

Re: [PATCH 4/4]: powerpc/cell spidernet ethtool -i version number info.

2006-08-15 Thread Olof Johansson
On Fri, Aug 11, 2006 at 01:50:19PM -0500, James K Lewis wrote: > Hi Olof, > > There are several reasons why an Ethernet driver should have an up to > date version number: > > 1. Customers like to see they are really getting a new version. > > 2. It makes it easier for support personnel (me i

Re: [PATCH] mark sk98lin driver for removal

2006-08-15 Thread Michael Stone
On Tue, Aug 15, 2006 at 11:03:40AM -0700, Stephen Hemminger wrote: * driver parameters skge/sky2 don't have many and most are standard across other drivers This driver intentionally does not support configuration via module parameters because it is better done

lockdep: adding bonding device triggers warning

2006-08-15 Thread Bill Nottingham
2.6.17-1.2564.fc6 is 2.6.18rc4+. Happened with 'echo "+bond0" > /sys/class/net/bonding_masters' bonding: bond0 is being created... === [ INFO: possible circular locking dependency detected ] 2.6.17-1.2564.fc6 #1

Re: proposal for new wireless configuration API

2006-08-15 Thread Dan Williams
On Tue, 2006-08-15 at 18:38 +0200, Michael Buesch wrote: > On Tuesday 15 August 2006 18:29, Dan Williams wrote: > > o Separate attributes for channel and frequency > > No, channel and freq is the same. It's just another name > for the same child. I would say we only want to deal with channel numbe

Re: [PATCH] mark sk98lin driver for removal

2006-08-15 Thread Stephen Hemminger
On Tue, 15 Aug 2006 09:18:54 -0400 Michael Stone <[EMAIL PROTECTED]> wrote: > Hopefully the skge driver will be updated to support everything the > sk98lin driver does before it is removed. Among other things, I don't > see any documentation for the skge driver similar to that for the > sk98lin

Re: [patch 24/41] drivers/net/e1000/: possible cleanups

2006-08-15 Thread Auke Kok
[EMAIL PROTECTED] wrote: From: Adrian Bunk <[EMAIL PROTECTED]> - make needlessly global functions static - #if 0 the following unused global functions: - e1000_hw.c: e1000_mc_addr_list_update() - e1000_hw.c: e1000_read_reg_io() - e1000_hw.c: e1000_enable_pciex_master() - e1000_hw.c: e100

Re: [PATCH 1/1] network memory allocator.

2006-08-15 Thread Evgeniy Polyakov
On Tue, Aug 15, 2006 at 07:42:16PM +0200, Peter Zijlstra ([EMAIL PROTECTED]) wrote: > Right, however I just realised that most storage protocols (level 7) > have their own ACK msgs and do not rely on TCP (level 4) ACKs like this. > > So I would like to come back on this, I do need a full data cha

Re: [PATCH 1/1] network memory allocator.

2006-08-15 Thread Peter Zijlstra
On Tue, 2006-08-15 at 19:05 +0400, Evgeniy Polyakov wrote: > > Not sure on the details; but you say: when we reach the threshold all > > following packets will be dropped. So if you provide enough memory to > > exceed the limit, you have some extra. If you then use that extra bit to > > allow ACKs

[PATCH] keep track of network interface renaming

2006-08-15 Thread Olaf Hering
Keep track about which network interface names were renamed after the network device driver printed its banner. Previous kernel names will be reused when new interfaces get registerd. Recent udev scripts implement a stable kernel device name for network interfaces. This printk avoids confusion abo

Fw: [Bugme-new] [Bug 7009] New: possible recursive locking detected

2006-08-15 Thread Andrew Morton
Begin forwarded message: Date: Tue, 15 Aug 2006 09:43:51 -0700 From: [EMAIL PROTECTED] To: [EMAIL PROTECTED] Subject: [Bugme-new] [Bug 7009] New: possible recursive locking detected http://bugzilla.kernel.org/show_bug.cgi?id=7009 Summary: possible recursive locking detected Ker

Re: proposal for new wireless configuration API

2006-08-15 Thread Michael Buesch
On Tuesday 15 August 2006 18:29, Dan Williams wrote: > o Separate attributes for channel and frequency No, channel and freq is the same. It's just another name for the same child. I would say we only want to deal with channel numbers in the API. That's much easier, as we don't have to deal with th

Re: 2.6.18-rc4-mm1: eth0: trigger_send() called with the transmitter busy

2006-08-15 Thread Rafael J. Wysocki
On Tuesday 15 August 2006 17:38, Laurent Riffard wrote: > > Le 15.08.2006 12:10, Rafael J. Wysocki a écrit : > > On Tuesday 15 August 2006 01:01, Laurent Riffard wrote: > >> Le 14.08.2006 23:25, Rafael J. Wysocki a écrit : > >>> On Monday 14 August 2006 22:06, Laurent Riffard wrote: > Le 14.0

Re: proposal for new wireless configuration API

2006-08-15 Thread Dan Williams
On Tue, 2006-08-15 at 17:28 +0200, Johannes Berg wrote: > Hi, > > So I've thought about this all day long... After writing this mail I'll > go home and hope my inbox collects some feedback ;) We might want to take the time to fix up a few of the ambiguities of WEXT that we've encountered over the

Re: proposal for new wireless configuration API

2006-08-15 Thread Luis R. Rodriguez
This all sounds good to me. A few comments here, to give you something to read when you get home. On 8/15/06, Johannes Berg <[EMAIL PROTECTED]> wrote: - we implement a bunch of commands, for example NL80211_CMD_INJECT and _SETATTR, _GETATTR[(attrnumber)] [easy with dumpit()], _GETATTRGRO

Re: [PATCH] bcm43xx-d80211: Init, shutdown and restart fixes

2006-08-15 Thread John W. Linville
On Tue, Aug 15, 2006 at 05:30:25PM +0200, Michael Buesch wrote: > On Tuesday 15 August 2006 17:23, Larry Finger wrote: > > Michael Buesch wrote: > > > This fixes various bugs in the init and shutdown code > > > that would lead to lockups and crashes. > > > This is best reproducable by receiving a

Re: 2.6.18-rc4-mm1: eth0: trigger_send() called with the transmitter busy

2006-08-15 Thread Laurent Riffard
Le 15.08.2006 12:10, Rafael J. Wysocki a écrit : > On Tuesday 15 August 2006 01:01, Laurent Riffard wrote: >> Le 14.08.2006 23:25, Rafael J. Wysocki a écrit : >>> On Monday 14 August 2006 22:06, Laurent Riffard wrote: Le 14.08.2006 19:47, Laurent Riffard a écrit : > Le 14.08.2006 18:50, A

Re: [PATCH] bcm43xx-d80211: Init, shutdown and restart fixes

2006-08-15 Thread Larry Finger
Michael Buesch wrote: On Tuesday 15 August 2006 17:23, Larry Finger wrote: Michael, Michael Buesch wrote: Hi John, Please apply this to wireless-dev. -- This fixes various bugs in the init and shutdown code that would lead to lockups and crashes. This is best reproducable by receiving a tim

Re: [PATCH] bcm43xx-d80211: Init, shutdown and restart fixes

2006-08-15 Thread Michael Buesch
On Tuesday 15 August 2006 17:23, Larry Finger wrote: > Michael, > > Michael Buesch wrote: > > Hi John, > > > > Please apply this to wireless-dev. > > > > -- > > > > This fixes various bugs in the init and shutdown code > > that would lead to lockups and crashes. > > This is best reproducable by

proposal for new wireless configuration API

2006-08-15 Thread Johannes Berg
Hi, So I've thought about this all day long... After writing this mail I'll go home and hope my inbox collects some feedback ;) I've arrived at the following conclusions: * we want to use genetlink * we need an equivalent of the old commit() call, but without all the stupidity * we want to

Re: [PATCH] bcm43xx-d80211: Init, shutdown and restart fixes

2006-08-15 Thread Larry Finger
Michael, Michael Buesch wrote: Hi John, Please apply this to wireless-dev. -- This fixes various bugs in the init and shutdown code that would lead to lockups and crashes. This is best reproducable by receiving a timeout from the netdev watchdog. Is a similar bug likely to be the cause of t

Re: [PATCH 1/1] network memory allocator.

2006-08-15 Thread Evgeniy Polyakov
On Tue, Aug 15, 2006 at 07:05:07PM +0400, Evgeniy Polyakov ([EMAIL PROTECTED]) wrote: > > > So network allocator reserves above megabyte and works with it in a > > > smart way (without too much overhead). > > > Then system goes into OOM and requires to swap a page, which > > > notification was sen

Re: [PATCH 1/1] network memory allocator.

2006-08-15 Thread Evgeniy Polyakov
On Tue, Aug 15, 2006 at 04:48:59PM +0200, Peter Zijlstra ([EMAIL PROTECTED]) wrote: > On Tue, 2006-08-15 at 18:15 +0400, Evgeniy Polyakov wrote: > > > Kevent network AIO is completely different from network tree allocator. > > How can that be? packets still need to be received, yes? Kevent netw

[PATCH 3/3] [IPv4]: Convert route get to new netlink api

2006-08-15 Thread Thomas Graf
Fixes various unvalidated netlink attributes causing memory corruptions when left empty by userspace applications. Signed-off-by: Thomas Graf <[EMAIL PROTECTED]> Index: net-2.6.19.git/include/net/ip_fib.h === --- net-2.6.19.git.orig/

[PATCH 1/3] [IPv4]: FIB configuration using struct fib_config

2006-08-15 Thread Thomas Graf
Introduces struct fib_config replacing the ugly struct kern_rta prone to ordering issues. Avoids creating faked netlink messages for auto generated routes or requests via ioctl. A new interface net/nexthop.h is added to help navigate through nexthop configuration arrays. A new struct nl_info will

[PATCH 2/3] [IPv4]: Convert FIB dumping to use new netlink api

2006-08-15 Thread Thomas Graf
Signed-off-by: Thomas Graf <[EMAIL PROTECTED]> Index: net-2.6.19.git/net/ipv4/fib_semantics.c === --- net-2.6.19.git.orig/net/ipv4/fib_semantics.c +++ net-2.6.19.git/net/ipv4/fib_semantics.c @@ -286,7 +286,7 @@ void rtmsg_fib(int even

[PATCHSET] IPv4 FIB configuration conversions

2006-08-15 Thread Thomas Graf
Replaces the rather ugly struct kern_rta + rtmsg with a new struct fib_config while converting everything to the new netlink api. Simplifies the FIB module interface quite a bit and allows changing internals while keeping a stable netlink interface. Gets rid of things like passing on netlink_skb_p

  1   2   >