Re: [PATCH 4/6] ehea: header files

2006-08-13 Thread Jan-Bernd Themann
Michael Ellerman wrote: On Sat, 2006-08-12 at 07:40 +1000, Anton Blanchard wrote: Hi, drivers/net/ehea/ehea.h| 452 +#define EHEA_DRIVER_NAME "IBM eHEA" You are using this for ethtool get_drvinfo. Im not sure if it should match the module name, and I worry about having a space in the nam

Re: [RFC][PATCH 0/9] Network receive deadlock prevention for NBD

2006-08-13 Thread Evgeniy Polyakov
On Mon, Aug 14, 2006 at 08:45:43AM +0200, Peter Zijlstra ([EMAIL PROTECTED]) wrote: > > Just for clarification - it will be completely impossible to login using > > openssh or some other priveledge separation protocol to the machine due > > to the nature of unix sockets. So you will be unable to

[patch] s390: fix arp_tbl lock usage in qeth

2006-08-13 Thread Heiko Carstens
From: Heiko Carstens <[EMAIL PROTECTED]> qeth: bhs must be disabled when accessing neighbour tables. = [ INFO: inconsistent lock state ] - inconsistent {in-softirq-W} -> {softirq-on-W} usage. modprobe/529 [HC0[0]:SC0[0]:HE1:SE1] take

Re: [RFC][PATCH 2/9] deadlock prevention core

2006-08-13 Thread Peter Zijlstra
On Sun, 2006-08-13 at 22:22 -0700, Andrew Morton wrote: > On Mon, 14 Aug 2006 07:03:55 +0200 > Peter Zijlstra <[EMAIL PROTECTED]> wrote: > > > On Sun, 2006-08-13 at 21:58 -0700, Andrew Morton wrote: > > > On Mon, 14 Aug 2006 06:40:53 +0200 > > > Peter Zijlstra <[EMAIL PROTECTED]> wrote: > > > > >

Re: [RFC][PATCH 0/9] Network receive deadlock prevention for NBD

2006-08-13 Thread Peter Zijlstra
On Mon, 2006-08-14 at 09:13 +0400, Evgeniy Polyakov wrote: > On Sun, Aug 13, 2006 at 01:16:15PM -0700, Daniel Phillips ([EMAIL PROTECTED]) > wrote: > > Indeed. The rest of the corner cases like netfilter, layered protocol and > > so on need to be handled, however they do not need to be handled ri

[PATCH wireless-2.6] ray_cs: Remove dependency on ieee80211

2006-08-13 Thread Michael Wu
(This patch was originally sent as part of the patch series that converted drivers using ieee80211.h to d80211.h. This patch is still valid because ray_cs does not need ieee80211.h - it needs iw_handler.h. The dependency on ieee80211.h was added as part of a build fix patch following the merge o

[take9 2/2] kevent: poll/select() notifications. Timer notifications.

2006-08-13 Thread Evgeniy Polyakov
poll/select() notifications. Timer notifications. This patch includes generic poll/select and timer notifications. kevent_poll works simialr to epoll and has the same issues (callback is invoked not from internal state machine of the caller, but through process awake). Timer notifications can b

[take9 0/2] kevent: Generic event handling mechanism.

2006-08-13 Thread Evgeniy Polyakov
Generic event handling mechanism. Changes from 'take8' patchset: * fixed mmap release bug * use module_init() instead of late_initcall() * use better structures for timer notifications Changes from 'take7' patchset: * new mmap interface (not tested, waiting for other changes to be acked)

[take9 1/2] kevent: Core files.

2006-08-13 Thread Evgeniy Polyakov
Core files. This patch includes core kevent files: - userspace controlling - kernelspace interfaces - initialization - notification state machines Signed-off-by: Evgeniy Polyakov <[EMAIL PROTECTED]> diff --git a/arch/i386/kernel/syscall_table.S b/arch/i386/kernel/syscall_table.S index dd63d

[take8 1/2] kevent: Core files.

2006-08-13 Thread Evgeniy Polyakov
Core files. This patch includes core kevent files: - userspace controlling - kernelspace interfaces - initialization - notification state machines Signed-off-by: Evgeniy Polyakov <[EMAIL PROTECTED]> diff --git a/arch/i386/kernel/syscall_table.S b/arch/i386/kernel/syscall_table.S index dd63d

[take8 0/2] kevent: Generic event handling mechanism.

2006-08-13 Thread Evgeniy Polyakov
Generic event handling mechanism. Changes from 'take7' patchset: * new mmap interface (not tested, waiting for other changes to be acked) - use nopage() method to dynamically substitue pages - allocate new page for events only when new added kevent requres it - do not use

[take8 2/2] kevent: poll/select() notifications. Timer notifications.

2006-08-13 Thread Evgeniy Polyakov
poll/select() notifications. Timer notifications. This patch includes generic poll/select and timer notifications. kevent_poll works simialr to epoll and has the same issues (callback is invoked not from internal state machine of the caller, but through process awake). Timer notifications can b

Re: [RFC][PATCH 2/9] deadlock prevention core

2006-08-13 Thread Andrew Morton
On Mon, 14 Aug 2006 07:03:55 +0200 Peter Zijlstra <[EMAIL PROTECTED]> wrote: > On Sun, 2006-08-13 at 21:58 -0700, Andrew Morton wrote: > > On Mon, 14 Aug 2006 06:40:53 +0200 > > Peter Zijlstra <[EMAIL PROTECTED]> wrote: > > > > > Testcase: > > > > > > Mount an NBD device as sole swap device and

Re: [RFC][PATCH 0/4] VM deadlock prevention -v4

2006-08-13 Thread Evgeniy Polyakov
On Sun, Aug 13, 2006 at 05:42:47PM -0700, Daniel Phillips ([EMAIL PROTECTED]) wrote: > High order allocations are just way too undependable without active > defragmentation, which isn't even on the horizon at the moment. We > just need to treat any network hardware that can't scatter/gather into

Re: [RFC][PATCH 0/9] Network receive deadlock prevention for NBD

2006-08-13 Thread Evgeniy Polyakov
On Sun, Aug 13, 2006 at 01:16:15PM -0700, Daniel Phillips ([EMAIL PROTECTED]) wrote: > Indeed. The rest of the corner cases like netfilter, layered protocol and > so on need to be handled, however they do not need to be handled right now > in order to make remote storage on a lan work properly.

Re: [RFC][PATCH 2/9] deadlock prevention core

2006-08-13 Thread Andrew Morton
On Mon, 14 Aug 2006 06:40:53 +0200 Peter Zijlstra <[EMAIL PROTECTED]> wrote: > Testcase: > > Mount an NBD device as sole swap device and mmap > physical RAM, then > loop through touching pages only once. Fix: don't try to swap over the network. Yes, there may be some scenarios where people have

Re: [RFC][PATCH 2/9] deadlock prevention core

2006-08-13 Thread Peter Zijlstra
On Sun, 2006-08-13 at 21:58 -0700, Andrew Morton wrote: > On Mon, 14 Aug 2006 06:40:53 +0200 > Peter Zijlstra <[EMAIL PROTECTED]> wrote: > > > Testcase: > > > > Mount an NBD device as sole swap device and mmap > physical RAM, then > > loop through touching pages only once. > > Fix: don't try to

Re: skb_shared_info()

2006-08-13 Thread Andi Kleen
> The e1000 issue is just one example of this, another > would be any attempt to consolidate the TCP retransmit > queue data management. Another reason to move it in the sk_buff would be better cache coloring? Currently on large/small MTU packets it will be always on the same colors. -Andi - T

Re: [RFC][PATCH 2/9] deadlock prevention core

2006-08-13 Thread Peter Zijlstra
On Sun, 2006-08-13 at 18:53 -0700, Andrew Morton wrote: > On Sun, 13 Aug 2006 18:31:14 -0700 > Daniel Phillips <[EMAIL PROTECTED]> wrote: > > > But to solve the whole problem > > What problem? Has anyone come up with a testcase which others can > reproduce? Problem: Networked Block devices (NB

Re: [PATCH] fix use after free in netlink_kernel_create()

2006-08-13 Thread David Miller
From: Patrick McHardy <[EMAIL PROTECTED]> Date: Sun, 13 Aug 2006 20:49:06 +0200 > Andrew Morton wrote: > > On Sun, 13 Aug 2006 13:52:58 +0200 > > Patrick McHardy <[EMAIL PROTECTED]> wrote: > > > >>Quite a few users of netlink_kernel_create will panic when creating > >>the socket fails (rtnetlink

Re: Possible leak of multicast source filter sctructure

2006-08-13 Thread David Miller
From: "Michal Ruzicka" <[EMAIL PROTECTED]> Date: Fri, 11 Aug 2006 12:04:53 +0100 > You are absolutely right, I just failed to notice that -ENODEV return value > from ip_mc_del_src()/ip_mc_leave_src() is ignored. > Here comes the patch: ... > > Also, ip_mc_leave_group() has the same issue;

Re: rename *MEMALLOC flags

2006-08-13 Thread Nick Piggin
Paul Jackson wrote: Daniel wrote: Inventing a new name for an existing thing is very poor taste on grounds of grepability alone. I wouldn't say 'very poor taste' -- just something that should be done infrequently, with good reason, and with reasonable concensus, especially from the key maint

Re: [PATCH 4/6] ehea: header files

2006-08-13 Thread Michael Ellerman
On Sat, 2006-08-12 at 07:40 +1000, Anton Blanchard wrote: > Hi, > > > drivers/net/ehea/ehea.h| 452 > > > +#define EHEA_DRIVER_NAME "IBM eHEA" > > You are using this for ethtool get_drvinfo. Im not sure if it should > match the module name, and I worry about having a space in the name. A

Re: [2.6.17.8] NFS stall / BUG in UDP fragment processing / SKB trimming

2006-08-13 Thread David Miller
From: Herbert Xu <[EMAIL PROTECTED]> Date: Sun, 13 Aug 2006 22:59:11 +1000 > On Sat, Aug 12, 2006 at 09:19:19PM +, Nix wrote: > > > > The kernel log showed a heap of BUGs from somewhere inside the skb > > management layer, somewhere in UDP fragment processing while > > handling NFS requests.

Re: [RFC][PATCH 2/9] deadlock prevention core

2006-08-13 Thread Andrew Morton
On Sun, 13 Aug 2006 18:31:14 -0700 Daniel Phillips <[EMAIL PROTECTED]> wrote: > But to solve the whole problem What problem? Has anyone come up with a testcase which others can reproduce? - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTE

Re: [RFC][PATCH 2/9] deadlock prevention core

2006-08-13 Thread Daniel Phillips
David Miller wrote: I think there is more profitability from a solution that really does something about "network memory", and doesn't try to say "these devices are special" or "these sockets are special". Special cases generally suck. We already limit and control TCP socket memory globally in

Re: [RFC][PATCH 2/9] deadlock prevention core

2006-08-13 Thread Daniel Phillips
David Miller wrote: From: Daniel Phillips <[EMAIL PROTECTED]> David Miller wrote: The reason is that there is no refcounting performed on these devices when they are attached to the skb, for performance reasons, and thus the device can be downed, the module for it removed, etc. long before the

Re: 2.6.18-rc3-mm2 (+ hotfixes): GPF related to skge on suspend

2006-08-13 Thread Keith Owens
Andrew Morton (on Sun, 13 Aug 2006 18:06:02 -0700) wrote: >On Mon, 14 Aug 2006 10:54:21 +1000 >Keith Owens wrote: > >> >Code: 44 8b 28 c7 45 d0 00 00 00 00 45 85 ed 0f 89 29 fb ff ff e9 >> >Error (Oops_bfd_perror): /tmp/ksymoops.0lrVNY Invalid bfd target >> > >> >box:/home/akpm> rpm -qi ksymoops

Re: 2.6.18-rc3-mm2 (+ hotfixes): GPF related to skge on suspend

2006-08-13 Thread Andrew Morton
On Mon, 14 Aug 2006 10:54:21 +1000 Keith Owens wrote: > >Code: 44 8b 28 c7 45 d0 00 00 00 00 45 85 ed 0f 89 29 fb ff ff e9 > >Error (Oops_bfd_perror): /tmp/ksymoops.0lrVNY Invalid bfd target > > > >box:/home/akpm> rpm -qi ksymoops > >Name: ksymoops Relocations: (not r

Re: rename *MEMALLOC flags

2006-08-13 Thread Paul Jackson
Daniel wrote: > Inventing a new name for an existing thing is very poor taste on grounds of > grepability alone. I wouldn't say 'very poor taste' -- just something that should be done infrequently, with good reason, and with reasonable concensus, especially from the key maintainers in the affected

Re: [RFC][PATCH 0/9] Network receive deadlock prevention for NBD

2006-08-13 Thread Daniel Phillips
Evgeniy Polyakov wrote: One must receive a packet to determine if that packet must be dropped until tricky hardware with header split capabilities or MMIO copying is used. Peter uses special pool to get data from when system is in OOM (at least in his latest patchset), so allocations are separate

Re: 2.6.18-rc3-mm2 (+ hotfixes): GPF related to skge on suspend

2006-08-13 Thread Keith Owens
Andrew Morton (on Sun, 13 Aug 2006 17:35:03 -0700) wrote: >On Mon, 14 Aug 2006 10:21:55 +1000 >Keith Owens wrote: > >> ksymoops -VKLMO -t elf64-x86-64 -a i386:x86-64 > >box:/home/akpm> ksymoops -VKLMO -t elf64-x86-64 -a i386:x86-64 < x >ksymoops 2.4.11 on x86_64 2.6.17-rc5. Options used > -V

Re: [RFC][PATCH 0/4] VM deadlock prevention -v4

2006-08-13 Thread Daniel Phillips
Peter Zijlstra wrote: On Sat, 2006-08-12 at 20:16 +0200, Indan Zupancic wrote: What was missing or wrong in the old approach? Can't you use the new approach, but use alloc_pages() instead of SROG? Sorry if I bug you so, but I'm also trying to increase my knowledge here. ;-) I'm almost sorry I

Re: 2.6.18-rc3-mm2 (+ hotfixes): GPF related to skge on suspend

2006-08-13 Thread Andrew Morton
On Mon, 14 Aug 2006 10:21:55 +1000 Keith Owens wrote: > ksymoops -VKLMO -t elf64-x86-64 -a i386:x86-64 box:/home/akpm> ksymoops -VKLMO -t elf64-x86-64 -a i386:x86-64 < x ksymoops 2.4.11 on x86_64 2.6.17-rc5. Options used -V (specified) -K (specified) -L (specified) -O (speci

Re: 2.6.18-rc3-mm2 (+ hotfixes): GPF related to skge on suspend

2006-08-13 Thread Keith Owens
Chuck Ebbert (on Sun, 13 Aug 2006 04:53:09 -0400) wrote: >In-Reply-To: <[EMAIL PROTECTED]> > >On Sat, 12 Aug 2006 05:28:53 -0700, Andrew Morton wrote: > >> > Code: 44 8b 28 c7 45 d0 00 00 00 00 45 85 ed 0f 89 29 fb ff ff e9 >> >> ksymoops says: >> >> Code; 88107287 <_end+7ac9287/7efc2000>

New driver questions: Attansic L1 gigabit NIC

2006-08-13 Thread Jay Cliburn
I recently purchased an Asus M2V socket AM2 motherboard that comes with an onboard Attansic L1 Gigabit Ethernet Controller. The CD that came with the motherboard contains GPL'd driver source for the NIC. The driver builds, installs, and functions cleanly in Fedora Core 5. Despite the clear asser

Re: rename *MEMALLOC flags

2006-08-13 Thread Daniel Phillips
Peter Zijlstra wrote: Jeff Garzik in his infinite wisdom spake thusly: Peter Zijlstra wrote: Index: linux-2.6/include/linux/gfp.h === --- linux-2.6.orig/include/linux/gfp.h 2006-08-12 12:56:06.0 +0200 +++ linux-2.6/includ

Re: [RFC][PATCH 2/9] deadlock prevention core

2006-08-13 Thread David Miller
From: Daniel Phillips <[EMAIL PROTECTED]> Date: Sun, 13 Aug 2006 15:05:25 -0700 > By the way, another way to avoid impact on the normal case is an > experimental option such as CONFIG_PREVENT_NETWORK_BLOCKIO_DEADLOCK. That would just make the solution look more like a hack, and "bolted on" rather

Re: [RFC][PATCH 2/9] deadlock prevention core

2006-08-13 Thread David Miller
From: Daniel Phillips <[EMAIL PROTECTED]> Date: Sun, 13 Aug 2006 14:22:31 -0700 > David Miller wrote: > > The reason is that there is no refcounting performed on these devices > > when they are attached to the skb, for performance reasons, and thus > > the device can be downed, the module for it r

Re: [RFC][PATCH 2/9] deadlock prevention core

2006-08-13 Thread Daniel Phillips
Rik van Riel wrote: Thomas Graf wrote: skb->dev is not guaranteed to still point to the "allocating" device once the skb is freed again so reserve/unreserve isn't symmetric. You'd need skb->alloc_dev or something. There's another consequence of this property of the network stack. Every networ

Re: [RFC][PATCH 2/9] deadlock prevention core

2006-08-13 Thread Daniel Phillips
David Miller wrote: From: Peter Zijlstra <[EMAIL PROTECTED]> Hmm, what does sk_buff::input_dev do? That seems to store the initial device? You can run grep on the tree just as easily as I can which is what I did to answer this question. It only takes a few seconds of your time to grep the sou

[-mm patch] net/decnet/: cleanups

2006-08-13 Thread Adrian Bunk
On Sun, Aug 13, 2006 at 01:24:54AM -0700, Andrew Morton wrote: >... > Changes since 2.6.18-rc3-mm2: >... > git-net.patch >... > git trees >... This patch contains the following cleanups: - make the following needlessly global functions static: - dn_fib.c: dn_fib_sync_down() - dn_fib.c: dn_fi

[-mm patch] net/ipv6/ip6_fib.c: make code static

2006-08-13 Thread Adrian Bunk
On Sun, Aug 13, 2006 at 01:24:54AM -0700, Andrew Morton wrote: >... > Changes since 2.6.18-rc3-mm2: >... > git-net.patch >... > git trees >... This patch makes the following needlessly global code static: - fib6_walker_lock - struct fib6_walker_list - fib6_walk_continue() - fib6_walk() Signed-o

Re: [RFC][PATCH 0/9] Network receive deadlock prevention for NBD

2006-08-13 Thread Daniel Phillips
Peter Zijlstra wrote: On Wed, 2006-08-09 at 16:54 -0700, David Miller wrote: People are doing I/O over IP exactly for it's ubiquity and flexibility. It seems a major limitation of the design if you cancel out major components of this flexibility. We're not, that was a bit of my own frustratio

Re: [RFC][PATCH 8/9] 3c59x driver conversion

2006-08-13 Thread Jeff Garzik
Daniel Phillips wrote: That is why it has not yet been submitted upstream. Respectfully, I do not think that jgarzik has yet put in the work to know if this anti deadlock technique is reasonable or not, and he was only commenting on some superficial blemish. I still don't get his point, if ther

[PATCH wireless-dev] d80211: switch status codes, reason codes, and EIDs to enums

2006-08-13 Thread Michael Wu
d80211: switch status codes, reason codes, and EIDs to enums This patch converts the status code, reason code, and EID defines in d80211_mgmt.h to enums. It also adds some status and reason codes, fixes some typos (DENOED, QUITE), and uses the ieee80211.h version of the name where reasonable.

Re: [RFC][PATCH 8/9] 3c59x driver conversion

2006-08-13 Thread Daniel Phillips
David Miller wrote: I think he's saying that he doesn't think your code is yet a reasonable way to solve the problem, and therefore doesn't belong upstream. That is why it has not yet been submitted upstream. Respectfully, I do not think that jgarzik has yet put in the work to know if this ant

Re: [PATCH] fix use after free in netlink_kernel_create()

2006-08-13 Thread Patrick McHardy
Andrew Morton wrote: > On Sun, 13 Aug 2006 13:52:58 +0200 > Patrick McHardy <[EMAIL PROTECTED]> wrote: > >>Quite a few users of netlink_kernel_create will panic when creating >>the socket fails (rtnetlink for example, which is always present), >>so you might as well call panic here directly. > >

Re: [2.6.17.8] NFS stall / BUG in UDP fragment processing / SKB trimming

2006-08-13 Thread Nix
On Sun, 13 Aug 2006, Herbert Xu suggested tentatively: > Oops, I missed this code path when I disallowed skb_trim from operating > on a paged skb. This patch should fix the problem. > > Greg, we need this for 2.6.17 stable as well if Dave is OK with it. > > [INET]: Use pskb_trim_unique when trim

Re: [PATCH] fix use after free in netlink_kernel_create()

2006-08-13 Thread Andrew Morton
On Sun, 13 Aug 2006 13:52:58 +0200 Patrick McHardy <[EMAIL PROTECTED]> wrote: > Akinobu Mita wrote: > > This patch invalidates nl_table by setting NULL when netlink > > initialization failed. Otherwise netlink_kernel_create() would > > access nl_table which has already been freed. > > > Quite a

Re: 2.6.18-rc3-mm2 (+ hotfixes): GPF related to skge on suspend

2006-08-13 Thread Andrew Morton
On Sun, 13 Aug 2006 04:53:09 -0400 Chuck Ebbert <[EMAIL PROTECTED]> wrote: > > > Code: 44 8b 28 c7 45 d0 00 00 00 00 45 85 ed 0f 89 29 fb ff ff e9 > > > RIP [] :skge:skge_poll+0x547/0x570 > > > RSP > > > > ksymoops says: > > > > Code; 88107287 <_end+7ac9287/7efc2000> > > <_EI

Re: [PATCH 3/6] ehea: queue management

2006-08-13 Thread Anton Blanchard
Hi, > I agree, stubbs were removed. Thanks. What is going to be done about the debug infrastructure in the ehea driver? The entry and exit traces really need to go, and any other debug you think is important to users needs to go into debugfs or something similar. I see a similar issue in the e

Re: [PATCH 1/4] [NETLINK]: Handle NLM_F_ECHO in netlink_rcv_skb()

2006-08-13 Thread Alexey Kuznetsov
Hello! > So we do something like this: Yes, exactly. Actually, there was a function with similar functionality: rtnetlink_send(). net/sched/* used it, older net/ipv4/ still did this directly. Alexey - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to

Re: [PATCH] cleanup of the NETIF_F_* flag definitions

2006-08-13 Thread Herbert Xu
Jeff Garzik <[EMAIL PROTECTED]> wrote: > Peter Zijlstra wrote: >> Cleanup the NETIF_F_ flag definitions >> >> Signed-off-by: Peter Zijlstra <[EMAIL PROTECTED]> > > If you are going to do a cleanup here, you should use the form that > makes it _immediately_ obvious which bit(s) are being used: A

Re: skb_shared_info()

2006-08-13 Thread Alexey Kuznetsov
Hello! > E1000 wants 16K buffers for jumbo MTU settings. > > The reason is that the chip can only handle power-of-2 buffer > sizes, and next hop from 9K is 16K. Let it use pages. Someone should start. :-) High order allocations are disaster in any case. > If we store raw kmalloc buffers, we c

Re: [2.6.17.8] NFS stall / BUG in UDP fragment processing / SKB trimming

2006-08-13 Thread Herbert Xu
On Sat, Aug 12, 2006 at 09:19:19PM +, Nix wrote: > > The kernel log showed a heap of BUGs from somewhere inside the skb > management layer, somewhere in UDP fragment processing while > handling NFS requests. It starts like this: > > Aug 12 21:31:08 hades warning: kernel: BUG: warning at > in

Re: [2.6.17.8] NFS stall / BUG in UDP fragment processing / SKB trimming

2006-08-13 Thread Nix
On 12 Aug 2006, [EMAIL PROTECTED] wrote: > On 12 Aug 2006, [EMAIL PROTECTED] mused: >> Then the build froze. I couldn't very well ignore *that*. Perhaps I >> couldn't blame XEmacs after all. > > It just happened again. It's reproducibly triggered, at least on this > system, by the ocaml-3.09.02 co

[PATCH 16/16] [CRYPTO] cipher: Remove obsolete block cipher operations

2006-08-13 Thread Herbert Xu
[CRYPTO] cipher: Remove obsolete block cipher operations This patch removes obsolete block operations from the simple cipher type. All block operations are now performed through the new block cipher type. It also changes crypto_cipher into a proper type so that type checking is done at compile ti

[PATCH 15/16] [CRYPTO] drivers: Remove obsolete block cipher operations

2006-08-13 Thread Herbert Xu
[CRYPTO] drivers: Remove obsolete block cipher operations This patch removes obsolete block operations of the simple cipher type from drivers. These were preserved so that existing users can make a smooth transition. Now that the transition is complete, they are no longer needed. Signed-off-by:

[PATCH 14/16] [CRYPTO] users: Use block ciphers where applicable

2006-08-13 Thread Herbert Xu
[CRYPTO] users: Use block ciphers where applicable This patch converts all remaining users to use the new block cipher type where applicable. It also changes all simple cipher operations to use the new encrypt_one/decrypt_one interface. Signed-off-by: Herbert Xu <[EMAIL PROTECTED]> --- drivers

[PATCH 7/16] [CRYPTO] s390: Added block cipher versions of CBC/ECB

2006-08-13 Thread Herbert Xu
[CRYPTO] s390: Added block cipher versions of CBC/ECB This patch adds block cipher algorithms for S390. Once all users of the old cipher type have been converted the existing CBC/ECB non-block cipher operations will be removed. Signed-off-by: Herbert Xu <[EMAIL PROTECTED]> --- arch/s390/crypto

[PATCH 3/16] [CRYPTO] scatterwalk: Prepare for block ciphers

2006-08-13 Thread Herbert Xu
[CRYPTO] scatterwalk: Prepare for block ciphers This patch prepares the scatterwalk code for use by the new block cipher type. Firstly it halves the size of scatter_walk on 32-bit platforms. This is important as we allocate at least two of these objects on the stack for each block cipher operati

[PATCH 5/16] [CRYPTO] cipher: Added block ciphers for CBC/ECB

2006-08-13 Thread Herbert Xu
[CRYPTO] cipher: Added block ciphers for CBC/ECB This patch adds two block cipher algorithms, CBC and ECB. These are implemented as templates on top of existing single-block cipher algorithms. They invoke the single-block cipher through the new encrypt_one/decrypt_one interface. Signed-off-by:

[PATCH 10/16] [BLOCK] dm-crypt: Use block ciphers where applicable

2006-08-13 Thread Herbert Xu
[BLOCK] dm-crypt: Use block ciphers where applicable This patch converts dm-crypt to use the new block cipher type where applicable. It also changes simple cipher operations to use the new encrypt_one/decrypt_one interface. Signed-off-by: Herbert Xu <[EMAIL PROTECTED]> --- drivers/md/dm-crypt.

[PATCH 4/16] [CRYPTO] cipher: Added block cipher type

2006-08-13 Thread Herbert Xu
[CRYPTO] cipher: Added block cipher type This patch adds the new type of block ciphers. Unlike current cipher algorithms which operate on a single block at a time, block ciphers operate on an arbitrarily long linear area of data. As it is block-based, it will skip any data remaining at the end w

[PATCH 12/16] [IPSEC] ESP: Use block ciphers where applicable

2006-08-13 Thread Herbert Xu
[IPSEC] ESP: Use block ciphers where applicable This patch converts IPSec/ESP to use the new block cipher type where applicable. Similar to the HMAC conversion, existing algorithm names have been kept for compatibility. Signed-off-by: Herbert Xu <[EMAIL PROTECTED]> --- include/net/esp.h|

[PATCH 9/16] [BLOCK] cryptoloop: Use block ciphers where applicable

2006-08-13 Thread Herbert Xu
[BLOCK] cryptoloop: Use block ciphers where applicable This patch converts cryptoloop to use the new block cipher type where applicable. As a result the ECB-specific and CBC-specific transfer functions have been merged. Signed-off-by: Herbert Xu <[EMAIL PROTECTED]> --- drivers/block/cryptoloop

[PATCH 13/16] [SUNRPC] GSS: Use block ciphers where applicable

2006-08-13 Thread Herbert Xu
[SUNRPC] GSS: Use block ciphers where applicable This patch converts SUNRPC/GSS to use the new block cipher type where applicable. Signed-off-by: Herbert Xu <[EMAIL PROTECTED]> --- include/linux/sunrpc/gss_krb5.h | 19 +-- include/linux/sunrpc/gss_spkm3.h |4 +- net/sun

[PATCH 11/16] [IPSEC]: Add compatibility algorithm name support

2006-08-13 Thread Herbert Xu
[IPSEC]: Add compatibility algorithm name support This patch adds a compatibility name field for each IPsec algorithm. This is needed when parameterised algorithms are used. For example, "md5" will become "hmac(md5)", and "aes" will become "cbc(aes)". Signed-off-by: Herbert Xu <[EMAIL PROTECTED

[PATCH 8/16] [CRYPTO] tcrypt: Use block ciphers where applicable

2006-08-13 Thread Herbert Xu
[CRYPTO] tcrypt: Use block ciphers where applicable This patch converts tcrypt to use the new block cipher type where applicable. Signed-off-by: Herbert Xu <[EMAIL PROTECTED]> --- crypto/tcrypt.c | 439 +--- 1 files changed, 261 insertions(+)

[PATCH 2/16] [CRYPTO] cipher: Added encrypt_one/decrypt_one

2006-08-13 Thread Herbert Xu
[CRYPTO] cipher: Added encrypt_one/decrypt_one This patch adds two new operations for the simple cipher that encrypts or decrypts a single block at a time. This will be the main interface after the existing block operations have moved over to the new block ciphers. It also adds the crypto_cipher

[PATCH 6/16] [CRYPTO] padlock: Added block cipher versions of CBC/ECB

2006-08-13 Thread Herbert Xu
[CRYPTO] padlock: Added block cipher versions of CBC/ECB This patch adds block cipher algorithms for cbc(aes) and ecb(aes) for the PadLock device. Once all users to the old cipher type have been converted the old cbc/ecb PadLock operations will be removed. Signed-off-by: Herbert Xu <[EMAIL PROTE

[PATCH 1/16] [CRYPTO] api: Added crypto_type support

2006-08-13 Thread Herbert Xu
[CRYPTO] api: Added crypto_type support This patch adds the crypto_type structure which will be used for all new crypto algorithm types, beginning with block ciphers. The primary purpose of this abstraction is to allow different crypto_type objects for crypto algorithms of the same type, in parti

[0/16] Add block cipher operations

2006-08-13 Thread Herbert Xu
Hi: Dave, please don't apply this series of patches as it's going into cryptodev-2.6 :) This series of patches adds a new type of operations (the existing ones are cipher, digest and compress). The idea is to differentiate between block chaining ciphers versus simple block ciphers from both a us

Re: [PATCH] fix use after free in netlink_kernel_create()

2006-08-13 Thread Patrick McHardy
Akinobu Mita wrote: > This patch invalidates nl_table by setting NULL when netlink > initialization failed. Otherwise netlink_kernel_create() would > access nl_table which has already been freed. Quite a few users of netlink_kernel_create will panic when creating the socket fails (rtnetlink for e

Re: [PATCH v2] zd1211rw: Convert installer CDROM device into WLAN device

2006-08-13 Thread Michael Buesch
On Sunday 13 August 2006 13:15, Daniel Drake wrote: > Some devices identify themselves as a virtual USB CDROM drive. The virtual CD > includes the windows driver. We aren't interested in this, so we eject the > virtual CDROM and then the real wireless device appears. > > Patch fixed over the earli

[PATCH v2] zd1211rw: Convert installer CDROM device into WLAN device

2006-08-13 Thread Daniel Drake
Some devices identify themselves as a virtual USB CDROM drive. The virtual CD includes the windows driver. We aren't interested in this, so we eject the virtual CDROM and then the real wireless device appears. Patch fixed over the earlier version to not leak cmd, thanks to Michael Buesch for spott

[PATCH] fix use after free in netlink_kernel_create()

2006-08-13 Thread Akinobu Mita
This patch invalidates nl_table by setting NULL when netlink initialization failed. Otherwise netlink_kernel_create() would access nl_table which has already been freed. CC: "David S. Miller" <[EMAIL PROTECTED]> Signed-off-by: Akinobu Mita <[EMAIL PROTECTED]> net/netlink/af_netlink.c | 11

Re: [RFC][PATCH 0/9] Network receive deadlock prevention for NBD

2006-08-13 Thread Evgeniy Polyakov
On Sun, Aug 13, 2006 at 01:06:21PM +0400, Evgeniy Polyakov ([EMAIL PROTECTED]) wrote: > On Sat, Aug 12, 2006 at 05:46:07PM -0700, David Miller ([EMAIL PROTECTED]) > wrote: > > From: Evgeniy Polyakov <[EMAIL PROTECTED]> > > Date: Sat, 12 Aug 2006 13:37:06 +0400 > > > > > Does it? I though it is p

Re: [PATCH] zd1211rw: cleanups

2006-08-13 Thread Ulrich Kunitz
On 06-08-13 11:24 Michael Buesch wrote: > On Saturday 12 August 2006 19:00, Daniel Drake wrote: > > --- linux-2.6.orig/drivers/net/wireless/zd1211rw/zd_mac.c > > +++ linux-2.6/drivers/net/wireless/zd1211rw/zd_mac.c > > @@ -127,11 +127,9 @@ out: > > > > void zd_mac_clear(struct zd_mac *mac) > >

Re: [PATCH] zd1211rw: Convert installer CDROM device into WLAN device

2006-08-13 Thread Michael Buesch
On Saturday 12 August 2006 18:59, Daniel Drake wrote: > +static int eject_installer(struct usb_interface *intf) > +{ > + struct usb_device *udev = interface_to_usbdev(intf); > + struct usb_host_interface *iface_desc = &intf->altsetting[0]; > + struct usb_endpoint_descriptor *endpoint; >

Re: [PATCH] zd1211rw: cleanups

2006-08-13 Thread Michael Buesch
On Saturday 12 August 2006 19:00, Daniel Drake wrote: > --- linux-2.6.orig/drivers/net/wireless/zd1211rw/zd_mac.c > +++ linux-2.6/drivers/net/wireless/zd1211rw/zd_mac.c > @@ -127,11 +127,9 @@ out: > > void zd_mac_clear(struct zd_mac *mac) > { > - /* Aquire the lock. */ > - spin_lock(&ma

Re: [RFC][PATCH 0/9] Network receive deadlock prevention for NBD

2006-08-13 Thread Evgeniy Polyakov
On Sat, Aug 12, 2006 at 05:46:07PM -0700, David Miller ([EMAIL PROTECTED]) wrote: > From: Evgeniy Polyakov <[EMAIL PROTECTED]> > Date: Sat, 12 Aug 2006 13:37:06 +0400 > > > Does it? I though it is possible to only have 64k of working sockets per > > device in TCP. > > Where does this limit come

Re: [take8 1/2] kevent: Core files.

2006-08-13 Thread Evgeniy Polyakov
On Sat, Aug 12, 2006 at 05:51:41PM -0700, Jeff Carr ([EMAIL PROTECTED]) wrote: > On 08/11/06 01:40, Evgeniy Polyakov wrote: > > > +/* > > + * Inode events. > > + */ > > +#defineKEVENT_INODE_CREATE 0x1 > > +#defineKEVENT_INODE_REMOVE 0x2 > > It would be useful to have gnome/kde not

Re: 2.6.18-rc3-mm2 (+ hotfixes): GPF related to skge on suspend

2006-08-13 Thread Chuck Ebbert
In-Reply-To: <[EMAIL PROTECTED]> On Sat, 12 Aug 2006 05:28:53 -0700, Andrew Morton wrote: > > general protection fault: [1] PREEMPT > > last sysfs file: > > /devices/pci:00/:00:0a.0/:02:02.0/subsystem_device > > CPU 0 > > Modules linked in: ide_cd cdrom usbserial asus_acpi therm