Re: [RFC] SECMARK 1.1

2006-05-14 Thread Patrick McHardy
James Morris wrote: > On Mon, 15 May 2006, Patrick McHardy wrote: > > >>But if you don't specify --track, the module loader will still have to >>resolve the symbol, so it gets loaded anyway, before your code will >>even run. Just look at need_conntrack(): > > > Doh. It should be try_module_get

Re: [RFC] SECMARK 1.1

2006-05-14 Thread James Morris
On Mon, 15 May 2006, James Morris wrote: > > Doh. It should be try_module_get(). Sound ok? Of course, I mean request_module(). -- James Morris <[EMAIL PROTECTED]> - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo

Re: [RFC] SECMARK 1.1

2006-05-14 Thread James Morris
On Mon, 15 May 2006, Patrick McHardy wrote: > But if you don't specify --track, the module loader will still have to > resolve the symbol, so it gets loaded anyway, before your code will > even run. Just look at need_conntrack(): Doh. It should be try_module_get(). Sound ok? - James -- James

Re: [RFC] SECMARK 1.1

2006-05-14 Thread Patrick McHardy
James Morris wrote: > On Mon, 15 May 2006, Patrick McHardy wrote: > > >>>Not sure what you mean: it will cause ip_conntrack to be loaded, which >>>is needed when you specify the track flag. >> >> >>Yes, but the reason why it is loaded is because the module loader needs >>to resolve the symbol, n

Re: [RFC] SECMARK 1.1

2006-05-14 Thread James Morris
On Mon, 15 May 2006, Patrick McHardy wrote: > > Not sure what you mean: it will cause ip_conntrack to be loaded, which > > is needed when you specify the track flag. > > > Yes, but the reason why it is loaded is because the module loader needs > to resolve the symbol, not because of anything do

ipv6 routing broken in 2.6.17-rc3,4

2006-05-14 Thread Meelis Roos
On my home 6to4 gw, ipv6 routing seems to be broken and everything is sent to 6to4 tunnel (the default route). It worked with fine for a long time and with 2.6.17-rc2-g4d5c34ec and it's broken with vmlinuz-2.6.17-rc3-g3cd73eed and 2.6.17-rc4-g9be2f7c3 (yesterdays kernel). Example (I add an un

Re: [RFC] SECMARK 1.1

2006-05-14 Thread Patrick McHardy
James Morris wrote: > On Mon, 15 May 2006, Patrick McHardy wrote: > > This will load the conntrack modules even if the track flag is not set. >>> >>> >>>I guess need_conntrack() could be moved to checkentry() and only called >>>if the track flag is set. >> >> >>That won't help, the function

Re: [RFC] SECMARK 1.1

2006-05-14 Thread James Morris
On Mon, 15 May 2006, Patrick McHardy wrote: > >>This will load the conntrack modules even if the track flag is not set. > > > > > > I guess need_conntrack() could be moved to checkentry() and only called > > if the track flag is set. > > > That won't help, the function itself does nothing, it

Re: [RFC] SECMARK 1.1

2006-05-14 Thread Patrick McHardy
James Morris wrote: > On Sun, 14 May 2006, Patrick McHardy wrote: > > >>James Morris wrote: >> >>>@@ -135,6 +175,9 @@ static int __init xt_secmark_init(void) >>> { >>> int err; >>> >>>+if (tracking_enabled()) >>>+need_conntrack(); >>>+ >> >>This will load the conntrack module

Re: Linux v2.6.17-rc4

2006-05-14 Thread Alistair John Strachan
On Sunday 14 May 2006 08:57, Ayaz Abdulla wrote: > Alistair John Strachan wrote: [snip] > > There's been just a single commit since -rc3: > > > > forcedeth: fix multi irq issues > > ebf34c9b6fcd22338ef764b039b3ac55ed0e297b > > > > However, it could have just been hidden since before -rc3, so I'll t

Re: [RFC] SECMARK 1.1

2006-05-14 Thread James Morris
On Sun, 14 May 2006, Patrick McHardy wrote: > James Morris wrote: > > @@ -135,6 +175,9 @@ static int __init xt_secmark_init(void) > > { > > int err; > > > > + if (tracking_enabled()) > > + need_conntrack(); > > + > > This will load the conntrack modules even if the track flag i

Re: Linux v2.6.17-rc4

2006-05-14 Thread Ayaz Abdulla
Alistair John Strachan wrote: On Friday 12 May 2006 00:44, Linus Torvalds wrote: Ok, I've let the release time between -rc's slide a bit too much again, but -rc4 is out there, and this is the time to hunker down for 2.6.17. If you know of any regressions, please holler now, so that we don't

Re: SIOCSIWESSID + SIOCSIWAP behaviour

2006-05-14 Thread Dan Williams
On Mon, 2006-05-15 at 00:29 +0100, Daniel Drake wrote: > Hi Jean, > > I'd just like to check my understanding (and softmacs implementation) > of SIWESSID and SIWAP behaviour, for managed mode. > > When SIWESSID happens, softmac drops association/authentication with the > current network and the

[PATCH] pcnet32.c: modify RX ring size through module parameter

2006-05-14 Thread Wen Hsin Chang
This patch is created from pcnet32.c v1.32. it will allow users to specify RX ring size upon module insertion via module parameter 'rx_log_size'. This is needed in some cases where too small the rx ring size will cause RX errors upon remote installation via pcnet32 NIC card. Signed-off-by: Wen

SIOCSIWESSID + SIOCSIWAP behaviour

2006-05-14 Thread Daniel Drake
Hi Jean, I'd just like to check my understanding (and softmacs implementation) of SIWESSID and SIWAP behaviour, for managed mode. When SIWESSID happens, softmac drops association/authentication with the current network and then starts a scan for the requested SSID. When found, softmac authen

Re: [PATCH] tcpdump may trace some outbound packets twice.

2006-05-14 Thread David S. Miller
From: Andrew Morton <[EMAIL PROTECTED]> Date: Sun, 14 May 2006 03:10:34 -0700 > It's a bit sad to be taking a clone of a clone like this. > Avoidable? Besides, clones of clones are illegal, if it's already a clone you must make a copy. - To unsubscribe from this list: send the line "unsubscribe n

Re: [RFC] SECMARK 1.1

2006-05-14 Thread Patrick McHardy
James Morris wrote: > @@ -135,6 +175,9 @@ static int __init xt_secmark_init(void) > { > int err; > > + if (tracking_enabled()) > + need_conntrack(); > + This will load the conntrack modules even if the track flag is not set. Wouldn't it be better to put everything related

Re: iptables broken on ppc (ptrace too?) (2.6.17-rc3)

2006-05-14 Thread Patrick McHardy
Meelis Roos wrote: > Iptables seems to be broken on ppc for me. Kernel 2.6.17-rc3 (currently > compiling rc4+git). 32-bit ppc, ARCH=ppc with PReP target. Iptables > userland binary is from the latest Debian unstable (1.3.3-2). > > The symptoms: iptables usually just tells Invalid Argument on any >

attempt to make via-velocity work on big-endian hosts

2006-05-14 Thread Lennert Buytenhek
Hi, Attached below is an attempt I made, for a friend of mine, to make via-velocity work on big-endian hosts. It doesn't quite work, however, and since I don't have the hardware myself, it's kind of cumbersome to debug it. Maybe someone here has an interest? cheers, Lennert Index: linux-2.6.

Re: [PATCH] tcpdump may trace some outbound packets twice.

2006-05-14 Thread Ranjit Manomohan
Thank you for the comments. Incorporated feedback into current version. -Thanks, Ranjit --- linux-2.6/net/sched/sch_generic.c 2006-05-10 12:34:52.0 -0700 +++ linux/net/sched/sch_generic.c 2006-05-14 08:53:33.0 -0700 @@ -136,8 +136,12 @@ if (!netif

iptables broken on ppc (ptrace too?) (2.6.17-rc3)

2006-05-14 Thread Meelis Roos
Iptables seems to be broken on ppc for me. Kernel 2.6.17-rc3 (currently compiling rc4+git). 32-bit ppc, ARCH=ppc with PReP target. Iptables userland binary is from the latest Debian unstable (1.3.3-2). The symptoms: iptables usually just tells Invalid Argument on any modification attempt. I'm

Re: [Bugme-new] [Bug 6548] New: MPPE Encrypt Decrypt module bug.

2006-05-14 Thread Andrew Morton
[EMAIL PROTECTED] wrote: > > http://bugzilla.kernel.org/show_bug.cgi?id=6548 I cc'ed the developers. Please use reply-to-all henceforth on this bug and don't make updates via the bugzilla web interface, thanks. >Summary: MPPE Encrypt Decrypt module bug. > Kernel Version: 2.6.16.

Re: [PATCH] tcpdump may trace some outbound packets twice.

2006-05-14 Thread Andrew Morton
Ranjit Manomohan <[EMAIL PROTECTED]> wrote: > > This patch fixes the problem where tcpdump shows duplicate packets > while tracing outbound packets on drivers which support lockless > transmit. The patch changes the current behaviour to tracing the > packets only on a successful transmit. > There