Re: Fw: Bug: PPP dropouts in >=2.6.16 - updates

2006-04-29 Thread Nuri Jawad
Some more info: - turning off Hyper Threading and using a uniprocessor kernel did not improve things - so didn't using 2.6.17rc3, in fact the bug manifested after only 4 minutes with a 43 seconds gap - those kernel debug watchdog routines don't detect anything Going to try kernel PPPoE next

[PATCH] Interface Stat Clearing Framework, skge support, ethtool support

2006-04-29 Thread Phil Dibowitz
Hey folks, A few months back I posted an in-progress patch for adding a clear_stats framework similar to the get_stats framework and implimenting support for it in the skge driver (the one NIC I have access to), as well as adding the ethtool support for it. While a few people said they didn't see

tw32_f() in tg3_write_mem()

2006-04-29 Thread David S. Miller
At least for the TG3PCI_MEM_WIN_DATA register, I don't know how safe it is to use tw32_f() there. Reads from a location can have side effects, so doing a forced readback after a write could be dangerous. And it isn't needed, as the tw32_f() done as we set the TG3PCI_MEM_WIN_BASE_ADDR back to zer

Re: [PATCH 6/6] tg3: Update version and reldate

2006-04-29 Thread David S. Miller
From: "Michael Chan" <[EMAIL PROTECTED]> Date: Fri, 28 Apr 2006 16:36:30 -0700 > Update version to 3.57. > > Signed-off-by: Michael Chan <[EMAIL PROTECTED]> Applied. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo i

Re: [PATCH 5/6] tg3: Fix bug in nvram write

2006-04-29 Thread David S. Miller
From: "Michael Chan" <[EMAIL PROTECTED]> Date: Fri, 28 Apr 2006 16:36:21 -0700 > Fix bug in nvram write function. If the starting nvram address offset > happens to be the last dword of the page, the NVRAM_CMD_LAST bit will > not get set in the existing code. This patch fixes the bug by changing >

Re: [PATCH 4/6] tg3: Add reset_phy parameter to chip reset functions

2006-04-29 Thread David S. Miller
From: "Michael Chan" <[EMAIL PROTECTED]> Date: Fri, 28 Apr 2006 16:36:08 -0700 > Add a reset_phy parameter to tg3_reset_hw() and tg3_init_hw(). With > the full chip reset during MAC address change, the automatic PHY reset > during chip reset will cause a link down and bonding will not work > prope

Re: [PATCH 3/6] tg3: Reset chip when changing MAC address

2006-04-29 Thread David S. Miller
From: "Michael Chan" <[EMAIL PROTECTED]> Date: Fri, 28 Apr 2006 16:35:35 -0700 > Do the full chip reset when changing MAC address if ASF is enabled. > > ASF sometimes uses a different MAC address than the driver. Without > the reset, the ASF MAC address may be overwritten when the driver's > MAC

Re: [PATCH 2/6] tg3: Add phy workaround

2006-04-29 Thread David S. Miller
From: "Michael Chan" <[EMAIL PROTECTED]> Date: Fri, 28 Apr 2006 16:35:19 -0700 > Add some PHY workaround code to reduce jitter on some PHYs. > > Signed-off-by: Michael Chan <[EMAIL PROTECTED]> Applied, thanks. It really bugs me that all of this indirect addressing into the DSP is done with magi

Re: [PATCH 1/6] tg3: Call netif_carrier_off() during phy reset

2006-04-29 Thread David S. Miller
From: "Michael Chan" <[EMAIL PROTECTED]> Date: Fri, 28 Apr 2006 16:35:06 -0700 > Add netif_carrier_off() call during tg3_phy_reset(). This is needed > to properly track the netif_carrier state in cases where we do a > PHY reset with interrupts disabled. The SerDes code will not run > properly if t

Re: [ROSE] Fix routing table locking in rose_remove_neigh.

2006-04-29 Thread Bernard Pidoux
Ralf Baechle wrote: The locking rule for rose_remove_neigh() are that the called needs to hold rose_neigh_list_lock, so we better don't take it yet again in rose_neigh_list_lock. Signed-off-by: Ralf Baechle <[EMAIL PROTECTED]> All ROSE and HZ patches applied to kernel 2.6.16 Many thanks Ralf

Re: e1000_down and tx_timeout worker race cleaning the transmit buffers

2006-04-29 Thread Shaw Vrana
Hi Auke, On 4/26/06, Auke Kok <[EMAIL PROTECTED]> wrote: > I'm concerned about the addition of the netif_running check to > e1000_down. While something like this is needed, I'm not familiar > enough w/ the code to know if this is okay. > All explanations and comments are greatly appreciated. W

Re: IP1000 gigabit nic driver

2006-04-29 Thread Pekka Enberg
Hi David, On Sat, 2006-04-29 at 14:21 +0200, David Gómez wrote: > I already had it modified, just needed to create the patch... Anyway, > have you submitted it to netdev? No, I haven't. I don't have the hardware, so I can't test the driver. Furthermore, there's plenty of stuff to fix before it's

Re: [PATCH 2/3] rt2x00 drivers: rt61pci

2006-04-29 Thread Ivo van Doorn
On Saturday 29 April 2006 18:10, Francois Romieu wrote: > Ivo van Doorn <[EMAIL PROTECTED]> : > [...] > > Not sure about that either. I usually choose the type of the counter > > depending on the max size of that counter. > > It is not arch-neutral. powerpc favors unsigned int over int but I am >

[AX.25] Move AX.25 symbol exports

2006-04-29 Thread Ralf Baechle
Move AX.25 symbol exports to next to their definitions where they're supposed to be these days. Signed-off-by: Ralf Baechle <[EMAIL PROTECTED]> net/ax25/af_ax25.c| 20 ++-- net/ax25/ax25_addr.c |9 + net/ax25/ax25_iface.c | 13 + net/ax25/ax25_ip.

[ROSE] Fix routing table locking in rose_remove_neigh.

2006-04-29 Thread Ralf Baechle
The locking rule for rose_remove_neigh() are that the called needs to hold rose_neigh_list_lock, so we better don't take it yet again in rose_neigh_list_lock. Signed-off-by: Ralf Baechle <[EMAIL PROTECTED]> net/rose/rose_route.c |5 - 1 file changed, 5 deletions(-) Index: linux-net.git/

[PATCH 3/3] Eleminate HZ from ROSE kernel interfaces

2006-04-29 Thread Ralf Baechle
Convert all ROSE sysctl time values from jiffies to ms as units. Signed-off-by: Ralf Baechle <[EMAIL PROTECTED]> -- include/net/rose.h | 14 +++--- net/rose/af_rose.c | 10 +- net/rose/rose_link.c |6 -- 3 files changed, 16 insertions(+), 14 deletions(-) Index:

[PATCH 1/3] Eleminate HZ from AX.25 kernel interfaces

2006-04-29 Thread Ralf Baechle DL5RB
Convert all AX.25 sysctl time values from jiffies to ms as units. Signed-off-by: Ralf Baechle <[EMAIL PROTECTED]> -- include/net/ax25.h | 10 +++--- net/ax25/af_ax25.c | 73 + net/ax25/ax25_ds_timer.c |3 + net/ax25/sysctl_ne

[PATCH 2/3] Eleminate HZ from NET/ROM kernel interfaces

2006-04-29 Thread Ralf Baechle
Convert all NET/ROM sysctl time values from jiffies to ms as units. Signed-off-by: Ralf Baechle <[EMAIL PROTECTED]> -- include/net/netrom.h |8 net/netrom/af_netrom.c | 15 ++- 2 files changed, 14 insertions(+), 9 deletions(-) Index: linux-net.git/include/net/netro

[HAMRADIO] Remove remaining SET_MODULE_OWNER calls from hamradio drivers.

2006-04-29 Thread Ralf Baechle DL5RB
Signed-off-by: Ralf Baechle DL5RB <[EMAIL PROTECTED]> -- drivers/net/hamradio/dmascc.c |1 - drivers/net/hamradio/scc.c|1 - drivers/net/hamradio/yam.c|1 - 3 files changed, 3 deletions(-) Index: linux-net.git/drivers/net/hamradio/dmascc.c ===

[AX.25] Spelling fix

2006-04-29 Thread Ralf Baechle DL5RB
Signed-off-by: Ralf Baechle <[EMAIL PROTECTED]> --- net/ax25/ax25_route.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Index: linux-net.git/net/ax25/ax25_route.c === --- linux-net.git.orig/net/ax25/ax25_route.c2006-0

[AX25, ROSE] Remove useless SET_MODULE_OWNER calls.

2006-04-29 Thread Ralf Baechle DL5RB
Signed-off-by: Ralf Baechle <[EMAIL PROTECTED]> -- net/netrom/nr_dev.c |1 - net/rose/rose_dev.c |1 - 2 files changed, 2 deletions(-) Index: linux-net.git/net/netrom/nr_dev.c === --- linux-net.git.orig/net/netrom/nr_dev.c

[PATCH 0/3] Eleminate HZ from AX.25, NETROM and ROSE kernel interfaces

2006-04-29 Thread Ralf Baechle
AX.25, NET/ROM and ROSE unfortunately still use jiffies as the unit of time for all their timeouts that can be configured through sysctl and it's procfs equivalents. This did result in a change of these kernel interfaces going from Linux 2.4 to 2.6 for anybody who was unlucky enough to use an affe

[ROSE] Remove useless prototype for rose_remove_neigh().

2006-04-29 Thread Ralf Baechle
Signed-off-by: Ralf Baechle <[EMAIL PROTECTED]> net/rose/rose_route.c |2 -- 1 file changed, 2 deletions(-) Index: linux-net.git/net/rose/rose_route.c === --- linux-net.git.orig/net/rose/rose_route.c2006-04-29 14:18:02.0

Re: [PATCH 0/5] sky2: version 1.2

2006-04-29 Thread Bertrand Jacquin
Le Tue, 25 Apr 2006 10:58:49 -0700, Stephen Hemminger <[EMAIL PROTECTED]> m'a avoué: > Update to sky2 driver. Mostly fixes to try and handle users > stuck with edge-triggered interrupts. Also, some minor cleanups. > > Patches apply onto 1.1 version in 2.6.17-rc2 Hi, I've just testing patches a

Re: [PATCH 2/3] rt2x00 drivers: rt61pci

2006-04-29 Thread Francois Romieu
Ivo van Doorn <[EMAIL PROTECTED]> : [...] > Not sure about that either. I usually choose the type of the counter > depending on the max size of that counter. It is not arch-neutral. powerpc favors unsigned int over int but I am too lazy to check if the size matters. [...] > Perhaps, but I prefer

Re: [PATCH 2/3] rt2x00 drivers: rt61pci

2006-04-29 Thread Ivo van Doorn
On Saturday 29 April 2006 16:58, Francois Romieu wrote: > Ivo van Doorn <[EMAIL PROTECTED]> : > > From: Ivo van Doorn <[EMAIL PROTECTED]> > > > > This adds the rt61pci driver to the tree > > > > Signed-off-by: Ivo van Doorn <[EMAIL PROTECTED]> > > > > Available on server: > > http://mendiosus.n

Re: [PATCH 2/3] rt2x00 drivers: rt61pci

2006-04-29 Thread Francois Romieu
Ivo van Doorn <[EMAIL PROTECTED]> : > From: Ivo van Doorn <[EMAIL PROTECTED]> > > This adds the rt61pci driver to the tree > > Signed-off-by: Ivo van Doorn <[EMAIL PROTECTED]> > > Available on server: > http://mendiosus.nl/rt2x00/rt61pci.diff It is nice that you are doing this work but I still

Re: [PATCH 1/3] Rough VJ Channel Implementation - vj_core.patch

2006-04-29 Thread Evgeniy Polyakov
On Fri, Apr 28, 2006 at 03:00:56PM -0700, David S. Miller ([EMAIL PROTECTED]) wrote: > From: Evgeniy Polyakov <[EMAIL PROTECTED]> > Date: Fri, 28 Apr 2006 23:59:30 +0400 > > > kevent can be used as poll without any changes to the socket code. > > There are two types of network related kevents - s

[TCP]: Fix sock_orphan dead lock

2006-04-29 Thread Herbert Xu
On Sat, Apr 29, 2006 at 09:15:07PM +1000, herbert wrote: > > Unfortunately this is only true for TCP. All of the connectionless > protocols use the callback lock without the socket lock so it does > still serve a purpose. > > I'd be happy to see your patch included. I've just changed my mind :)

Re: IP1000 gigabit nic driver

2006-04-29 Thread David Vrabel
Pekka Enberg wrote: I ended up doing most of them myself [1]. Sorry :-) Are the datasheets public by the way? http://www.icplus.com.tw/Data/Datasheet/IP1000A-DS-R08-07052005.pdf 1. http://www.cs.helsinki.fi/u/penberg/linux/ip1000-driver.patch - To unsubscribe from this list: send the line

Re: IP1000 gigabit nic driver

2006-04-29 Thread David Gómez
Hi Pekka, On Apr 29 at 01:29:26, Pekka Enberg wrote: > I ended up doing most of them myself [1]. Sorry :-) Are the datasheets > public by the way? I already had it modified, just needed to create the patch... Anyway, have you submitted it to netdev? About the datasheets, i don't think so. The ic

wireless-dev: warnings while removing bcm43xx-d80211

2006-04-29 Thread Johannes Berg
This didn't look too good to me, maybe someone can investigate? [24070.841580] Badness in remove_proc_entry at fs/proc/generic.c:732 [24070.841593] Call Trace: [24070.841598] [E9A87C30] [C00081E8] show_stack+0x50/0x190 (unreliable) [24070.841618] [E9A87C60] [C000E4EC] program_check_exception+0x454

Re: IP1000 gigabit nic driver

2006-04-29 Thread Arjan van de Ven
On Sat, 2006-04-29 at 13:29 +0300, Pekka Enberg wrote: > On Fri, 28 Apr 2006, David Gómezz wrote: > > > Ok, i could take care of that, and it's a good way of getting my hands > > > dirty with kernel programming ;). David, if it's ok to you i'll do the > > > cleanup thing. > > On Fri, 2006-04-28 at

Re: IP1000 gigabit nic driver

2006-04-29 Thread Pekka Enberg
On Fri, 28 Apr 2006, David Gómezz wrote: > > Ok, i could take care of that, and it's a good way of getting my hands > > dirty with kernel programming ;). David, if it's ok to you i'll do the > > cleanup thing. On Fri, 2006-04-28 at 14:59 +0300, Pekka J Enberg wrote: > Here are some suggestions for

[PATCH 2/3] rt2x00 drivers: rt61pci

2006-04-29 Thread Ivo van Doorn
From: Ivo van Doorn <[EMAIL PROTECTED]> This adds the rt61pci driver to the tree Signed-off-by: Ivo van Doorn <[EMAIL PROTECTED]> Available on server: http://mendiosus.nl/rt2x00/rt61pci.diff pgpo4nqgz53ZX.pgp Description: PGP signature

[PATCH 1/3] rt2x00 drivers: Makefile & CRC

2006-04-29 Thread Ivo van Doorn
From: Ivo van Doorn <[EMAIL PROTECTED]> Change Makefile and KConfig file to add the rt61pci and rt73usb drivers to the list. The firmware needs to be validated by CRC, for this a crc header has been added to the tree as well. Signed-off-by: Ivo van Doorn <[EMAIL PROTECTED]> diff -uprN wireless-

[PATCH 0/3] rt2x00 drivers

2006-04-29 Thread Ivo van Doorn
Hi, These patches are for the wireless-dev tree and will add the rt61pci and rt73usb drivers into the tree. I have split them up into patches: [PATCH 1/3] rt2x00 drivers: Makefile & CRC [PATCH 2/3] rt2x00 drivers: rt61pci [PATCH 3/3] rt2x00 drivers: rt73usb IvD pgpICUMxspSst.pgp Description:

[PATCH 3/3] rt2x00 drivers: rt73usb

2006-04-29 Thread Ivo van Doorn
From: Ivo van Doorn <[EMAIL PROTECTED]> This adds the rt73usb driver to the tree Signed-off-by: Ivo van Doorn <[EMAIL PROTECTED]> Available on server: http://mendiosus.nl/rt2x00/rt73usb.diff pgpcCyH4xNgwq.pgp Description: PGP signature

[PATCH RESEND] rt2x00: Compile fix and kernel version cleanup

2006-04-29 Thread Ivo van Doorn
From: Ivo van Doorn <[EMAIL PROTECTED]> During CVS merge I noticed several compilation errors have sneaked into the git version of rt2x00. - PRIO_ENTRIES define has been removed, TX_ENTRIES should be used - poll_delay module argument is of the type short - Remove LINUX_VERSION_CODE checks. - Fix m

Re: [PATCH] rt2x00: Compile fix and kernel version cleanup

2006-04-29 Thread Ivo van Doorn
On Friday 28 April 2006 20:52, Ivo van Doorn wrote: > From: Ivo van Doorn <[EMAIL PROTECTED]> > > During CVS merge I noticed several compilation errors have sneaked > into the git version of rt2x00. > - PRIO_ENTRIES define has been removed, TX_ENTRIES should be used > - poll_delay module argument