Herbert, as you may have noticed we found some missing
locking in sk_stream_rfree(). It could explain the
"!sk_forward_alloc" BUG() we thought was caused by e1000's
TSO implementation and the Intel folks have provided enough
datapoints to prove that it is indeed not an e1000 specific
problem.
sk
From: Jesse Brandeburg <[EMAIL PROTECTED]>
Date: Fri, 14 Apr 2006 15:55:10 -0700 (Pacific Daylight Time)
> I'm trying to isolate more of a reproduction case, I'll be sure to
> post if I can find anything with more detail.
I think I see the bug.
If tbench with large numbers of clients is part of
On Fri, 14 Apr 2006, David S. Miller wrote:
> > they are not accounted for in the skb yet. the way e1000 works is it
> > pre-allocates all its 128 byte receive buffers using skb_alloc, and then
> > chains in any pages that are used for receive packets.
>
> Ok so you allocate the base skb->dat
From: Jesse Brandeburg <[EMAIL PROTECTED]>
Date: Fri, 14 Apr 2006 16:04:21 -0700 (Pacific Daylight Time)
> On Fri, 14 Apr 2006, David S. Miller wrote:
>
> > From: Jesse Brandeburg <[EMAIL PROTECTED]>
> > Date: Fri, 14 Apr 2006 15:43:02 -0700 (Pacific Daylight Time)
> >
> > > Please help me under
On Fri, 14 Apr 2006, David S. Miller wrote:
> From: Jesse Brandeburg <[EMAIL PROTECTED]>
> Date: Fri, 14 Apr 2006 15:43:02 -0700 (Pacific Daylight Time)
>
> > Please help me understand how you think it should work when we have a
> > device that wants to receive a packet using header in the skb->
From: Samuel Ortiz <[EMAIL PROTECTED]>
Date: Fri, 14 Apr 2006 13:16:18 +0300
> Hi David,
>
> This patch enables support for ALi ISA bridges when we run the smcinit code.
> It is needed to properly configure some Toshiba laptops.
>
> Patch from Linus Walleij <[EMAIL PROTECTED]>
> Signed-off-by: S
From: Samuel Ortiz <[EMAIL PROTECTED]>
Date: Fri, 14 Apr 2006 13:16:07 +0300
> Hi David,
>
> In the STIR421x case, when the firmware upload fails, we need to
> unregister_netdev. Otherwise we hit a BUG on free_netdev(), if sysfs is
> enabled.
>
> Signed-off-by: Samuel Ortiz <[EMAIL PROTECTED]
Ignore my previous email, I tried to apply it to the wrong
tree :-)
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
From: Stephen Hemminger <[EMAIL PROTECTED]>
Date: Thu, 13 Apr 2006 15:22:24 -0700
> Run CLIP driver through Lindent script to fix formatting.
>
> Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]>
These no longer apply after putting in the two CLIP
bug fixes.
Please respin, thanks.
-
To unsub
On Fri, 14 Apr 2006, David S. Miller wrote:
> From: Jesse Brandeburg <[EMAIL PROTECTED]>
> Date: Fri, 14 Apr 2006 15:46:31 -0700 (Pacific Daylight Time)
>
> > sure, thats fine, but we just reproduced it in two seperate systems
> > without the e1000 driver loaded, using the instructions as mentio
From: Stephen Hemminger <[EMAIL PROTECTED]>
Date: Wed, 12 Apr 2006 15:42:14 -0700
> By inspection, the clip idle timer code is racy on SMP.
> Here is a safe version of timer management.
> Untested, I don't have ATM hardware.
>
> Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]>
Applied, thank
From: Jesse Brandeburg <[EMAIL PROTECTED]>
Date: Fri, 14 Apr 2006 15:46:31 -0700 (Pacific Daylight Time)
> sure, thats fine, but we just reproduced it in two seperate systems
> without the e1000 driver loaded, using the instructions as mentioned in a
> previous email. We used a 5704 with TSO en
From: Jesse Brandeburg <[EMAIL PROTECTED]>
Date: Fri, 14 Apr 2006 15:43:02 -0700 (Pacific Daylight Time)
> Please help me understand how you think it should work when we have a
> device that wants to receive a packet using header in the skb->data, and
> application data in the ->frags[]?
If yo
On Fri, 14 Apr 2006, David S. Miller wrote:
> From: Jesse Brandeburg <[EMAIL PROTECTED]>
> Date: Fri, 14 Apr 2006 15:32:55 -0700 (Pacific Daylight Time)
>
> > well there was one of them here, but the tg3 bit may actually be due to
> > the 2.6.14 problems.
> >
> > http://bugzilla.kernel.org/show
On Fri, 14 Apr 2006, David S. Miller wrote:
> From: Jesse Brandeburg <[EMAIL PROTECTED]>
> Date: Fri, 14 Apr 2006 15:13:31 -0700 (Pacific Daylight Time)
>
> > in the old driver we indicate a packet with truesize = 128, which has 1000
> > bytes of data in it. normally (for everyone using only
From: Jesse Brandeburg <[EMAIL PROTECTED]>
Date: Fri, 14 Apr 2006 15:32:55 -0700 (Pacific Daylight Time)
> well there was one of them here, but the tg3 bit may actually be due to
> the 2.6.14 problems.
>
> http://bugzilla.kernel.org/show_bug.cgi?id=6279
There are 2 e1000 gigabit devices in that
On Fri, 14 Apr 2006, David S. Miller wrote:
> From: Jesse Brandeburg <[EMAIL PROTECTED]>
> Date: Fri, 14 Apr 2006 13:28:10 -0700
>
> > We also have some new data from the last couple of days. First, I think
> > that this problem is likely not just E1000's fault. We have multiple
> > reports
From: Jesse Brandeburg <[EMAIL PROTECTED]>
Date: Fri, 14 Apr 2006 15:13:31 -0700 (Pacific Daylight Time)
> in the old driver we indicate a packet with truesize = 128, which has 1000
> bytes of data in it. normally (for everyone using only an skb) skb->len,
> and skb->truesize are updated by skb
On Fri, 14 Apr 2006, Jeff Garzik wrote:
> Kok, Auke wrote:
> > diff --git a/drivers/net/e1000/e1000_main.c b/drivers/net/e1000/e1000_main.c
> > index 2cc9955..7ba1b16 100644
> > --- a/drivers/net/e1000/e1000_main.c
> > +++ b/drivers/net/e1000/e1000_main.c
> > @@ -3770,6 +3770,7 @@ e1000_clean_rx_i
From: Stephen Hemminger <[EMAIL PROTECTED]>
Date: Wed, 12 Apr 2006 14:52:54 -0700
> If Classical IP over ATM module is loaded, its neighbor table gets
> populated when permanent neighbor entries are created; but these entries
> are not flushed when the device is removed. Since the entry never gets
From: jamal <[EMAIL PROTECTED]>
Date: Thu, 13 Apr 2006 09:00:08 -0400
> There is dependency on the previous patch i sent since the issue that
> patch fixes is assumed in this text description. It would be a good
> idea to apply at the same time as the other.
Applied, after fixing 28 lines contain
From: jamal <[EMAIL PROTECTED]>
Date: Thu, 13 Apr 2006 08:55:58 -0400
> Finally got an opportunity to test this. I have incorporated all the
> feedback and it passes all the scenarios i know.
>
> Dave, please apply to Linus tree since this is a bug fix.
Applied, thanks.
-
To unsubscribe from thi
From: Pavel Roskin <[EMAIL PROTECTED]>
The original code was doing arithmetics on a little-endian value.
Reported by Stelios Koroneos <[EMAIL PROTECTED]>
Signed-off-by: Pavel Roskin <[EMAIL PROTECTED]>
---
drivers/net/wireless/hostap/hostap_ioctl.c |4 ++--
1 files changed, 2 insertions(+),
Kok, Auke wrote:
diff --git a/drivers/net/e1000/e1000_main.c b/drivers/net/e1000/e1000_main.c
index 2cc9955..7ba1b16 100644
--- a/drivers/net/e1000/e1000_main.c
+++ b/drivers/net/e1000/e1000_main.c
@@ -3770,6 +3770,7 @@ e1000_clean_rx_irq_ps(struct e1000_adapt
ps_page->ps_
David S. Miller wrote:
From: David Acker <[EMAIL PROTECTED]>
Date: Fri, 14 Apr 2006 09:15:54 -0400
David S. Miller wrote:
> I think this really belongs in a portable header file
> in glibc somewhere.
David, while I can try to work with the glibc folks, I don't understand
how this patch would
From: Jesse Brandeburg <[EMAIL PROTECTED]>
Date: Fri, 14 Apr 2006 13:28:10 -0700
> We also have some new data from the last couple of days. First, I think
> that this problem is likely not just E1000's fault. We have multiple
> reports both in bugzilla.kernel.org and from a distro that show th
From: David Acker <[EMAIL PROTECTED]>
Date: Fri, 14 Apr 2006 09:15:54 -0400
> David S. Miller wrote:
> > I think this really belongs in a portable header file
> > in glibc somewhere.
>
> David, while I can try to work with the glibc folks, I don't understand
> how this patch would be different
Boris B. Zhmurov wrote:
Hello, Jesse Brandeburg.
On 06.04.2006 04:42 you said the following:
I built and tested the driver with patches on 2.6.16, with pci-x
adapters. I removed some workarounds for PCIe adapters, but I dont
think anyone having this problem has a PCIe adapter anyway. I saw
Jouni Malinen wrote:
The maximum power would be quite useful--I would say required--part of
regulatory domain information.. In other words, I would like to see the
groups created in a way that would take differences in power limits into
account. Without this, the groups will need to be re-created
Jeff Garzik wrote:
Kok, Auke wrote:
01/10: [FIX] Remove PM warning DPRINTKs breaking 2.4.x kernels
02/10: [FIX] Esb2 wol link cycle bug and uninitialized registers
03/10: [PATCH] De-inline functions to benefit from compiler smartness
04/10: [PATCH] Made an adapter struct variable into a local (t
Kok, Auke wrote:
Hi,
This patch series implements two fixes, a series of cleanups and
two optimization patches.
The version of the driver was bumped to 7.0.38-k2. Year changes to 2006.
As I'm taking over patch duties from Jeff Kirsher, I added myself
to the MAINTAINERS file.
These changes are
Add the sourceforge project mailinglist to the contact information.
Bump version to 7.0.38-k2
Update copyright string with the new year.
Signed-off-by: Auke Kok <[EMAIL PROTECTED]>
Signed-off-by: John Ronciak <[EMAIL PROTECTED]>
---
drivers/net/e1000/Makefile|1 +
drivers/net/e10
Remove multi-descriptor support from legacy recieve path
Add memory usage efficiency by using more correct size descriptors for
small MTU sizes and optimize using LPE for <= 1522 byte frame sizes
An extra performance fix that effected our TCP window size growth
as a receiver. Set our initial bu
This adds Auke Kok to the list of maintainers for the Intel NICs.
Signed-off-by: Auke Kok <[EMAIL PROTECTED]>
Signed-off-by: John Ronciak <[EMAIL PROTECTED]>
---
MAINTAINERS |6 ++
1 files changed, 6 insertions(+), 0 deletions(-)
diff --git a/MAINTAINERS b/MAINTAINERS
index d00dea5..6
Implement more efficient locking (avoid the lock) when checking for
a stopped queue. Also don't wake the queue unless the threshold is
reached to avoid queue on/off thrash.
Signed-off-by: Jesse Brandeburg <[EMAIL PROTECTED]>
Signed-off-by: Auke Kok <[EMAIL PROTECTED]>
Signed-off-by: John Roncia
Removal of unused rx_dropped counter.
Removed reference to E1000_CTRL_EXT_CANC which is no longer valid,
replaced with E1000_CTRL_EXT_INT_TIMER_CLR
Signed-off-by: Jesse Brandeburg <[EMAIL PROTECTED]>
Signed-off-by: Auke Kok <[EMAIL PROTECTED]>
Signed-off-by: John Ronciak <[EMAIL PROTECTED]>
---
Hi,
This patch series implements two fixes, a series of cleanups and
two optimization patches.
The version of the driver was bumped to 7.0.38-k2. Year changes to 2006.
As I'm taking over patch duties from Jeff Kirsher, I added myself
to the MAINTAINERS file.
These changes are available through
Esb2 link didn't return after wol disable. The code previously assumed
that writing reset to PHY_CTRL phy register turned the phy back on.
In the ESB2 phy case that didn't occur.
Add ESB2 to acquire/release_hw functions upon review it was
discovered that esb2 was skipped on these functions
Sign
Made an adapter struct variable into a local (txb2b)
Signed-off-by: Jesse Brandeburg <[EMAIL PROTECTED]>
Signed-off-by: Auke Kok <[EMAIL PROTECTED]>
Signed-off-by: John Ronciak <[EMAIL PROTECTED]>
---
drivers/net/e1000/e1000.h |1 -
drivers/net/e1000/e1000_main.c | 10 +-
2
On Fri, Apr 14, 2006 at 11:28:53AM -0700, Stephen Hemminger wrote:
> Has this been tested?
-ENOHARDWARE, so no.
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
remove DPRINTKs that were printing warnings about power management on
2.4 kernels. Since we really don't react differently these printk
statements are not needed. This code was originally added to fix
some compile time warnings that got fixed by newer kernels.
Signed-off-by: Jesse Brandeburg <
Update skb with the real packet size.
Signed-off-by: Jesse Brandeburg <[EMAIL PROTECTED]>
Signed-off-by: Auke Kok <[EMAIL PROTECTED]>
Signed-off-by: John Ronciak <[EMAIL PROTECTED]>
---
drivers/net/e1000/e1000_main.c |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/driv
De-inline functions to benefit from compiler smartness
Signed-off-by: Jesse Brandeburg <[EMAIL PROTECTED]>
Signed-off-by: Auke Kok <[EMAIL PROTECTED]>
Signed-off-by: John Ronciak <[EMAIL PROTECTED]>
---
drivers/net/e1000/e1000_main.c | 30 +++---
1 files changed, 15 i
Has this been tested?
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Signed-off-by: Christoph Hellwig <[EMAIL PROTECTED]>
Index: linux-2.6/drivers/net/irda/stir4200.c
===
--- linux-2.6.orig/drivers/net/irda/stir4200.c 2006-04-14 20:12:37.0
+0200
+++ linux-2.6/drivers/net/irda/stir4200.c
On Fri, Apr 14, 2006 at 08:20:15PM +0200, Christoph Hellwig wrote:
> sir_kthread.c pretty much duplicates the workqueue functionality.
> Switch it to use a workqueue instead. It could probably use
> schedule_work/schedule_delayed_work instead of having it's own
> waitqueue, but I'd rather leave th
sir_kthread.c pretty much duplicates the workqueue functionality.
Switch it to use a workqueue instead. It could probably use
schedule_work/schedule_delayed_work instead of having it's own
waitqueue, but I'd rather leave that to the maintainer. The file
should probably get a name that still makes
On Fri, Apr 14, 2006 at 10:59:13AM -0700, Randy.Dunlap wrote:
> On Fri, 14 Apr 2006 10:47:26 -0700 Jean Tourrilhes wrote:
>
> > Hi John,
> >
> > I've just realised that the RtNetlink code does not check the
> > permission for SIOCGIWENCODE and SIOCGIWENCODEEXT, which means that
> > any us
On Fri, Apr 14, 2006 at 10:59:13AM -0700, Randy.Dunlap wrote:
> On Fri, 14 Apr 2006 10:47:26 -0700 Jean Tourrilhes wrote:
>
> > Hi John,
> >
> > I've just realised that the RtNetlink code does not check the
> > permission for SIOCGIWENCODE and SIOCGIWENCODEEXT, which means that
> > any us
Begin forwarded message:
Date: Fri, 14 Apr 2006 14:32:39 +0200
From: Laurent CARON <[EMAIL PROTECTED]>
To: linux-kernel@vger.kernel.org
Subject: Openswan, iptables (fiaif) and 2.6.16 kernel
Hi,
I'm running an openswan gateway for quite a long time now.
I have used 2.4.X and 2.6.X kernels wit
On Fri, 14 Apr 2006 10:47:26 -0700 Jean Tourrilhes wrote:
> Hi John,
>
> I've just realised that the RtNetlink code does not check the
> permission for SIOCGIWENCODE and SIOCGIWENCODEEXT, which means that
> any user can read the encryption keys. The fix is trivial and should
> go in 2
Hi John,
I've just realised that the RtNetlink code does not check the
permission for SIOCGIWENCODE and SIOCGIWENCODEEXT, which means that
any user can read the encryption keys. The fix is trivial and should
go in 2.6.17 alonside the two other patch I sent you last week.
Fu
On Fri, Apr 14, 2006 at 09:42:03AM -0700, Jean Tourrilhes wrote:
> Hi,
Hi Jean,
> You now need to send those patches to :
> [EMAIL PROTECTED]
Samuel, please send a patch to update MAINTAINERS.
> Personally, I don't see what this patch buy us...
It makes the ker
Hi,
You now need to send those patches to :
[EMAIL PROTECTED]
Personally, I don't see what this patch buy us...
Jean
On Fri, Apr 14, 2006 at 01:44:46PM +0200, Adrian Bunk wrote:
> This patch removes the following unused EXPORT_SYMBOL's:
> - irias_f
On Fri, 14 Apr 2006 13:18:31 +0800
Zhu Yi <[EMAIL PROTECTED]> wrote:
> On Thu, 2006-04-13 at 10:30 -0700, Stephen Hemminger wrote:
> > Please get rid of the debug config option. Make the debug code, default
> > off and be low enough impact that everyone can ship with it.
>
> This patch is exactly
Jean Tourrilhes <[EMAIL PROTECTED]> wrote:
>
>We have the message interface (through a Wireless Events,
> since WE-14). However, netlink is highly undesirable in embedded space
> for bloat reason.
Why is that? I've seen many embedded applications using netlink
for either routing or IPsec.
Had this happen this morning on my gateway box. Any
o via rhine net device (eth1) and 8139too for eth0.
o kernel Linux bama.hardrock.org 2.6.16-1.2069_FC4 #1 Tue Mar 28 12:19:10 EST
2006 i686 athlon i386 GNU/Linux
o FC4 with all current patches, no binary modules in the kernel
o UP
If there's an
On Thu, Apr 13, 2006 at 07:59:21PM -0500, Larry Finger wrote:
> I am planning on writing a new routine to be added to
> net/ieee80211/ieee80211_geo.c that will populate an ieee80211_geo object
> given a country code. The new routine will eliminate the need for each
> driver to do their own.
>
David Acker wrote:
From Dave Acker <[EMAIL PROTECTED]>
The purpose is to allow a user space program to use the vlan_ethhdr
structure when directly handling 802.1Q packets. This can be done
by using a raw socket like:
int s = socket(PF_PACKET, SOCK_RAW, htons(ETH_P_ALL));
This socket should see
Ulrich Kunitz wrote:
> For the 802.11a frequencies, there are three bands:
>
> Annex 3 Band B 5150-5250 MHz for indoor use (36-48)
> Annex 3 Band C 5250-5350 MHz for indoor use (52-64)
> Annex 3 Band D 5470-5725 MHz for outdoor use (100-140)
>
> However these bands are not available in all Europ
This patch removes the following unused EXPORT_SYMBOL's:
- irias_find_attrib
- irias_new_string_value
- irias_new_octseq_value
Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]>
---
net/irda/irias_object.c |3 ---
1 file changed, 3 deletions(-)
--- linux-2.6.17-rc1-mm2-full/net/irda/irias_obje
Larry,
the CISCO list is not correct. For Europe the detailed information
can be found in the recommendation ERC/REC 70-03 of the European
Radiocommunications Office. It is downloadable from this page:
http://www.ero.dk/documentation/docs/doccategory.asp?catid=2&catname=ECC/ERC/ECTRA%20Recommenda
On Fri, Apr 14, 2006 at 12:32:02PM +0200, Adrian Bunk ([EMAIL PROTECTED]) wrote:
> On Thu, Apr 13, 2006 at 01:26:03PM -0700, David S. Miller wrote:
> > From: Adrian Bunk <[EMAIL PROTECTED]>
> > Date: Thu, 13 Apr 2006 18:27:10 +0200
> >
> > > This patch contains the following possible cleanups plus
On Thu, Apr 13, 2006 at 01:26:03PM -0700, David S. Miller wrote:
> From: Adrian Bunk <[EMAIL PROTECTED]>
> Date: Thu, 13 Apr 2006 18:27:10 +0200
>
> > This patch contains the following possible cleanups plus changes related
> > to them:
> > - make the following needlessly global functions static:
Hi David,
This patch enables support for ALi ISA bridges when we run the smcinit code.
It is needed to properly configure some Toshiba laptops.
Patch from Linus Walleij <[EMAIL PROTECTED]>
Signed-off-by: Samuel Ortiz <[EMAIL PROTECTED]>
diff --git a/drivers/net/irda/smsc-ircc2.c b/drivers/net/ir
Hi David,
In the STIR421x case, when the firmware upload fails, we need to
unregister_netdev. Otherwise we hit a BUG on free_netdev(), if sysfs is enabled.
Signed-off-by: Samuel Ortiz <[EMAIL PROTECTED]>
diff --git a/drivers/net/irda/irda-usb.c b/drivers/net/irda/irda-usb.c
index 606243d..96bd
Erik Mouw wrote:
> On Thu, Apr 13, 2006 at 10:29:19AM -0700, Stephen Hemminger wrote:
> > Shouldn't compiler have gagged on this?
>
> Apparently not. At least the compiler I use doesn't warn about it (gcc
> version 3.3.5 (Debian 1:3.3.5-13)).
>
> Linus, this might be be something for sparse to ch
On Thu, Apr 13, 2006 at 10:29:19AM -0700, Stephen Hemminger wrote:
> On Thu, 13 Apr 2006 15:02:27 +0200
> Erik Mouw <[EMAIL PROTECTED]> wrote:
>
> > The room for the names in bcm43xx_priv_wx_args[] are IFNAMSIZ long and
> > IFNAMSIZ is defined as 16, so the names in bcm43xx_priv_wx_args should
> >
From: Greg KH <[EMAIL PROTECTED]>
Date: Thu, 13 Apr 2006 15:45:29 -0700
> On Thu, Apr 13, 2006 at 03:22:24PM -0700, Stephen Hemminger wrote:
> > Run CLIP driver through Lindent script to fix formatting.
>
> That's well and good, but really not a -stable thing. In fact, I don't
> see any of these
69 matches
Mail list logo
