Re: [PATCH] shutting down an interface should remove ipv4 addresses

2006-04-11 Thread Herbert Xu
David S. Miller <[EMAIL PROTECTED]> wrote: > > I agree, it should behave just like ipv4. AOL That would've made quite a few races that we had to fix non-existant by definition :) -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <[EMAIL PROTECTED]> Home Page: http://gond

[PATCH 1/2] mv643xx_eth: Always free completed tx descs on tx interrupt

2006-04-11 Thread netdev-owner
From: Brent Cook <[EMAIL PROTECTED]> Fix the tx interrupt handler to free completed tx descriptors even when NAPI is enabled. Otherwise, the tx queue would fill up resulting in poor performance and "NETDEV WATCHDOG: : transmit timed out" messages. Signed-off-by: Brent Cook <[EMAIL PROTECTED]> Si

[PATCH 2/2] mv643xx_eth: Fix tx_timeout to only conditionally wake tx queue

2006-04-11 Thread Dale Farnsworth
From: Dale Farnsworth <[EMAIL PROTECTED]> After resetting the hardware on a tx_timeout, call netif_wake_queue() only if we have free tx descriptors. Also, attempt to recover if mv643xx_eth_start_xmit() is called when there are fewer free tx descriptors than expected. The BUG_ON() call we are rep

Re: 2.6.17 regression: Very slow net transfer from some hosts

2006-04-11 Thread John Heffner
Daniel Drake wrote: Stephen Hemminger wrote: This is very familiar, and I just found the article I was thinking of: http://lwn.net/Articles/92727/ I was also hit by that bug, on the same collection of websites, but that particular problem was fixed for 2.6.8 or so. So I guess it is extremely

Re: 2.6.17 regression: Very slow net transfer from some hosts

2006-04-11 Thread John Heffner
Daniel Drake wrote: Stephen Hemminger wrote: Turn off TCP window scaling, your performance will be limited but about as good as you can get with a corrupting firewall in between. [snip] For anyone else interested, the ISP is NTL (UK). The fix: echo "409616384 131072 " > /proc/sys/

Re: [PATCH 1/3] eth: use constant size address

2006-04-11 Thread David S. Miller
From: Stephen Hemminger <[EMAIL PROTECTED]> Date: Tue, 11 Apr 2006 11:10:54 -0700 > Change the ethernet support routines to use constant address size. > This generates smaller faster code. > > Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> Ok, but perhaps rework this to have a: BUG_ON

Re: 2.6.17 regression: Very slow net transfer from some hosts

2006-04-11 Thread Stephen Hemminger
On Wed, 12 Apr 2006 01:06:09 +0100 Daniel Drake <[EMAIL PROTECTED]> wrote: > Stephen Hemminger wrote: > >> This is very familiar, and I just found the article I was thinking of: > >> http://lwn.net/Articles/92727/ > >> > >> I was also hit by that bug, on the same collection of websites, but that

Re: 2.6.17 regression: Very slow net transfer from some hosts

2006-04-11 Thread Daniel Drake
Stephen Hemminger wrote: This is very familiar, and I just found the article I was thinking of: http://lwn.net/Articles/92727/ I was also hit by that bug, on the same collection of websites, but that particular problem was fixed for 2.6.8 or so. So I guess it is extremely likely that my ISP h

Re: [RFC/PATCH] remove unneeded check in bcm43xx

2006-04-11 Thread Benjamin Herrenschmidt
On Wed, 2006-04-12 at 00:30 +0200, Benoit Boissinot wrote: > On Wed, Apr 12, 2006 at 08:21:17AM +1000, Benjamin Herrenschmidt wrote: > > > > > I still think we shouldn't reward shit hardware by complicating > > > up our DMA mappings internals. :-) > > > > BTW. In the meantime, can't that driver w

Re: 2.6.17 regression: Very slow net transfer from some hosts

2006-04-11 Thread Stephen Hemminger
On Tue, 11 Apr 2006 23:20:42 +0100 Daniel Drake <[EMAIL PROTECTED]> wrote: > John Heffner wrote: > > This is almost certainly due to a buggy firewall that doesn't understand > > TCP window scaling. I've usually seen this in the past with OpenBSD > > firewalls. Do you have one of these in your

Re: [RFC/PATCH] remove unneeded check in bcm43xx

2006-04-11 Thread Benoit Boissinot
On Wed, Apr 12, 2006 at 08:21:17AM +1000, Benjamin Herrenschmidt wrote: > > > I still think we shouldn't reward shit hardware by complicating > > up our DMA mappings internals. :-) > > BTW. In the meantime, can't that driver work in PIO only mode ? yes, I think you just have to have the pci_set_

Re: [RFC/PATCH] remove unneeded check in bcm43xx

2006-04-11 Thread Benjamin Herrenschmidt
On Tue, 2006-04-11 at 14:34 -0700, David S. Miller wrote: > I still think we shouldn't reward shit hardware by complicating > up our DMA mappings internals. :-) Heh, it's a good point but in that specific case, it's a bit difficult to tell that to users who don't have a choice of what card to put

Re: [RFC/PATCH] remove unneeded check in bcm43xx

2006-04-11 Thread Benjamin Herrenschmidt
> I still think we shouldn't reward shit hardware by complicating > up our DMA mappings internals. :-) BTW. In the meantime, can't that driver work in PIO only mode ? Ben. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More maj

Re: 2.6.17 regression: Very slow net transfer from some hosts

2006-04-11 Thread Daniel Drake
John Heffner wrote: This is almost certainly due to a buggy firewall that doesn't understand TCP window scaling. I've usually seen this in the past with OpenBSD firewalls. Do you have one of these in your path? At home I'm behind a Linux gateway box currently running 2.6.15-rc6 - I am conne

Re: [PATCH] shutting down an interface should remove ipv4 addresses

2006-04-11 Thread David S. Miller
From: David Stevens <[EMAIL PROTECTED]> Date: Tue, 11 Apr 2006 14:33:38 -0700 > > > Addresses are owned by the "host" not a particular device, even > > > though they are assosciated with a particular interface. > > > > > > Linux defaults to using the host based addressing model instead of the > >

Re: [RFC/PATCH] remove unneeded check in bcm43xx

2006-04-11 Thread David S. Miller
From: Benjamin Herrenschmidt <[EMAIL PROTECTED]> Date: Wed, 12 Apr 2006 06:49:00 +1000 > I would tend to agree... except that the broadcom is _the_ wireless > card shipped by Apple with all of their machines for the last few > years, and thus, the problem will be hit by pretty much any G5 user > t

[PATCH] bcm43 wireless: fix printk format warnings

2006-04-11 Thread Randy.Dunlap
From: Randy Dunlap <[EMAIL PROTECTED]> Fix printk format warnings: drivers/net/wireless/bcm43xx/bcm43xx_debugfs.c:456: warning: format ‘%u’ expects type ‘unsigned int’, but argument 3 has type ‘size_t’ drivers/net/wireless/bcm43xx/bcm43xx_debugfs.c:460: warning: format ‘%08x’ expects type ‘unsig

[PATCH] bcm43: fix config menu alignment

2006-04-11 Thread Randy.Dunlap
From: Randy Dunlap <[EMAIL PROTECTED]> Use "depends on" to make all bcm43 driver options be listed at the same level. Signed-off-by: Randy Dunlap <[EMAIL PROTECTED]> --- drivers/net/wireless/bcm43xx/Kconfig |3 +++ 1 files changed, 3 insertions(+) --- linux-2617-rc1g5.orig/drivers/net/wirel

Re: [PATCH] shutting down an interface should remove ipv4 addresses

2006-04-11 Thread David Stevens
> > Addresses are owned by the "host" not a particular device, even > > though they are assosciated with a particular interface. > > > > Linux defaults to using the host based addressing model instead of the > > interface based addressing model. > It is true for IPv4, but IPv6 addresses are removed

Re: [PATCH] shutting down an interface should remove ipv4 addresses

2006-04-11 Thread Jean-Mickael Guerin
Addresses are owned by the "host" not a particular device, even though they are assosciated with a particular interface. Linux defaults to using the host based addressing model instead of the interface based addressing model. It is true for IPv4, but IPv6 addresses are removed when interface g

Re: 2.6.17 regression: Very slow net transfer from some hosts

2006-04-11 Thread John Heffner
This is almost certainly due to a buggy firewall that doesn't understand TCP window scaling. I've usually seen this in the past with OpenBSD firewalls. Do you have one of these in your path? Thanks, -John - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a m

Re: [RFC/PATCH] remove unneeded check in bcm43xx

2006-04-11 Thread Benjamin Herrenschmidt
> I think allowing DMA mask range limiting in the IOMMU layer is going > to set a very bad precedence, just don't do it. > > It's 2006, we should be way past the era of not putting the full 32 > PCI DMA address bits in devices. In this day and age it is simply > inexscusable. > > Maybe we could

Re: 2.6.17 regression: Very slow net transfer from some hosts

2006-04-11 Thread Daniel Drake
John Heffner wrote: tcp_wmem: 409616384 131072 tcp_rmem: 409687380 174760 tcp_mem: 98304 131072 196608 These are (I assume) with the patch reversed. What are the values with the patch applied? Yes- that was on a good kernel, with the patch reversed. On a bad kernel, with the

Re: 2.6.17 regression: Very slow net transfer from some hosts

2006-04-11 Thread John Heffner
Daniel Drake wrote: John Heffner wrote: I'm not seeing this behavior myself. What are the values of /proc/sys/net/ipv4/tcp_wmem, tcp_rmem, and tcp_mem? How much memory does this system have? (A binary tcpdump might be good, too.) tcp_wmem: 409616384 131072 tcp_rmem: 409687380 1

Re: [LARTC] Re: created new q_disc, inserted module, tc tells me unknown qdisc

2006-04-11 Thread George P Nychis
I am getting closer... I added debugging, and noticed that it looks for: snprintf(buf, sizeof(buf), "%s_qdisc_util", str); However in q_xcp.c it had: struct qdisc_util xcp_util = { so I changed that to xcp_qdisc_util, and now i run tc: lanthanum-ini tc # tc qdisc add dev ath0 root

Re: 2.6.17 regression: Very slow net transfer from some hosts

2006-04-11 Thread Daniel Drake
John Heffner wrote: I'm not seeing this behavior myself. What are the values of /proc/sys/net/ipv4/tcp_wmem, tcp_rmem, and tcp_mem? How much memory does this system have? (A binary tcpdump might be good, too.) tcp_wmem: 409616384 131072 tcp_rmem: 409687380 174760 tcp_mem: 98304

Re: created new q_disc, inserted module, tc tells me unknown qdisc

2006-04-11 Thread George P Nychis
> On Mon, 10 Apr 2006 21:41:39 -0400 (EDT) "George P Nychis" > <[EMAIL PROTECTED]> wrote: > >> Hi, >> >> I am trying to install a proprietary qdisc made for research, it is not >> publically released yet, however its been used several times so i know >> it works. >> >> The files included are: q_

Re: 2.6.17 regression: Very slow net transfer from some hosts

2006-04-11 Thread John Heffner
Daniel Drake wrote: Hi, Since sometime after 2.6.16, some websites have been very slow to load. Examples include: http://zd1211.ath.cx http://developer.osdl.org/shemminger/blog/ http://www.reactivated.net/weblog On a good kernel, "wget http://zd1211.ath.cx"; says: 20:23:38 (90.44 KB/s) - `i

Re: 2.6.17 regression: Very slow net transfer from some hosts

2006-04-11 Thread Stephen Hemminger
On Tue, 11 Apr 2006 20:30:46 +0100 Daniel Drake <[EMAIL PROTECTED]> wrote: > Hi, > > Since sometime after 2.6.16, some websites have been very slow to load. > Examples include: > > http://zd1211.ath.cx > http://developer.osdl.org/shemminger/blog/ > http://www.reactivated.net/weblog > > On a

2.6.17 regression: Very slow net transfer from some hosts

2006-04-11 Thread Daniel Drake
Hi, Since sometime after 2.6.16, some websites have been very slow to load. Examples include: http://zd1211.ath.cx http://developer.osdl.org/shemminger/blog/ http://www.reactivated.net/weblog On a good kernel, "wget http://zd1211.ath.cx"; says: 20:23:38 (90.44 KB/s) - `index.html' saved [208

Re: [RFC: 2.6 patch] the overdue removal of ip{,6}_queue

2006-04-11 Thread Harald Welte
On Tue, Apr 11, 2006 at 04:42:50PM +0200, Patrick McHardy wrote: > > Maybe we should add a printk ('app foo is using obsolete ip_queue > > system'). > > Good idea, that will probably help speed it up. But I still think > we need to give them at least another six month. ok. I'll prepare a patch fo

Re: created new q_disc, inserted module, tc tells me unknown qdisc

2006-04-11 Thread Stephen Hemminger
On Mon, 10 Apr 2006 21:41:39 -0400 (EDT) "George P Nychis" <[EMAIL PROTECTED]> wrote: > Hi, > > I am trying to install a proprietary qdisc made for research, it is not > publically released yet, however its been used several times so i know it > works. > > The files included are: > q_xcp.c: >

[PATCH 2/3] eth: indentation and whitespace

2006-04-11 Thread Stephen Hemminger
Run the ethernet common code through indent, and fix other whitespace issues. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- net-2.6.orig/net/ethernet/eth.c 2006-04-11 10:07:37.0 -0700 +++ net-2.6/net/ethernet/eth.c 2006-04-11 10:18:37.0 -0700 @@ -66,55 +66,46 @@ _

[PATCH 0/3] eth.c cleanups for 2.6.18

2006-04-11 Thread Stephen Hemminger
Minor optimizations and cleanups to the common ethernet header routines. -- - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH 3/3] eth: dont use __constant_htons

2006-04-11 Thread Stephen Hemminger
Don't need to use __constant_htons here. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- net-2.6.orig/net/ethernet/eth.c 2006-04-11 10:18:37.0 -0700 +++ net-2.6/net/ethernet/eth.c 2006-04-11 10:21:40.0 -0700 @@ -208,7 +208,7 @@ eth = (struct ethhdr *)

[PATCH 1/3] eth: use constant size address

2006-04-11 Thread Stephen Hemminger
Change the ethernet support routines to use constant address size. This generates smaller faster code. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- net-2.6.orig/net/ethernet/eth.c 2006-04-11 09:43:40.0 -0700 +++ net-2.6/net/ethernet/eth.c 2006-04-11 10:07:37.0 -0

[RFC] selective ethtool diagnostic test method

2006-04-11 Thread Cureington, Tony
I have searched the netdev archives and have not found any RFC like this. This proposal is to add selective diag/test modes to ethtool with minimal overhead/bloat. Please provide feedback on the proposal. This proposed selective test mode is being requested more and more from our Linux users, so

Re: [RFT] dlink pci cards using wrong driver

2006-04-11 Thread Jeff Garzik
Stephen Hemminger wrote: This patch fixes the problem of some Dlink cards picking the wrong driver. It looks like these cards use Yukon 1 chipset, not Yukon 2. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- sky2-2.6.17.orig/drivers/net/skge.c 2006-03-24 09:56:05.0 -0800 +++ s

[RFT] dlink pci cards using wrong driver

2006-04-11 Thread Stephen Hemminger
This patch fixes the problem of some Dlink cards picking the wrong driver. It looks like these cards use Yukon 1 chipset, not Yukon 2. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- sky2-2.6.17.orig/drivers/net/skge.c 2006-03-24 09:56:05.0 -0800 +++ sky2-2.6.17/drivers/net/skge

Re: [PATCH] bridge: receive link-local on disabled ports.

2006-04-11 Thread Vlad Drukker
On Mon, 2006-04-10 at 16:39 -0700, David S. Miller wrote: > From: Stephen Hemminger <[EMAIL PROTECTED]> > Date: Mon, 10 Apr 2006 16:24:29 -0700 > > > This change allows link local packets (like 802.3ad and Spanning Tree > > Protocol) to be processed even when the bridge is not using the port. > >

Re: bcm43xx symbol clash problems

2006-04-11 Thread Johannes Berg
On Tue, 2006-04-11 at 18:35 +0200, Michael Buesch wrote: > Sure. I would probably say that both m should conflict, too. Nah, you probably want both m for testing. > And one y and the other m, too. Yeah that should conflict too. > This can be done with ugly "depends" statements. I have no idea

Re: Qdisc peek operation

2006-04-11 Thread Patrick McHardy
jamal wrote: > On Thu, 2006-06-04 at 18:29 +0200, Patrick McHardy wrote: > [..] > > >>There are basically two possibilities how to implement this. The less >>intrusive, but IMO more hackish one is to just handle this inside the >>qdiscs that require this operation by not requeueing the packet to

tc actions like pass,drop executed at a given percentage, not every nth

2006-04-11 Thread pfer
Hi all! Can you give me some guideline about how and where netrand ... influences an action in the tc sources? (I've also tried LARTC mailing list, but did not get any response) When I last checked, iproute2 sources had a tc gact module with 2 statistical netrand methods: - random - determ

Re: [RFC: 2.6 patch] the overdue removal of ip{,6}_queue

2006-04-11 Thread Patrick McHardy
Harald Welte wrote: > On Sun, Apr 09, 2006 at 08:40:05PM +0200, Patrick McHardy wrote: > >>I think this is too early, none of the distributions seem to have >>picked up the compat library already. I believe (not sure, Harald?) >>that it requires at least recompilation of programs using libipq, >>s

Re: Broadcast ARP packets on link local addresses (Version2).

2006-04-11 Thread David Daney
Freek Dijkstra wrote: It seems the discussion has died. How is this to move forward? I'm not sure who is responsible for this part of the kernel. There are a few options: 1. Broadcast ARP by checking the IP range in kernel (current patch) 2. Broadcast ARP if the "scope" parameter is "link" 3. Br

Re: [PATCH] deinline a few large functions in vlan code v2

2006-04-11 Thread Dave Dillow
On Tue, 2006-04-11 at 10:28 +0300, Denis Vlasenko wrote: > > > > > block? For example, typhoon.c: > > > > > > > > > > spin_lock(&tp->state_lock); > > > > > +#if defined(CONFIG_VLAN_8021Q) || defined (CONFIG_VLAN_8021Q_MODULE) > > > > > if(tp->vlgrp != NULL && rx->rx

Re: [PATCH] deinline a few large functions in vlan code v2

2006-04-11 Thread Ingo Oeser
Hi Denis, Denis Vlasenko wrote: > On Tuesday 11 April 2006 12:49, Ingo Oeser wrote: > > #if defined(CONFIG_VLAN_8021Q) || defined(CONFIG_VLAN_8021Q_MODULE) > > static inline has_vlan_group(...) { > > /* get VLAN group */ > > } > > #else > > static inline has_vlan_group(...) {return 0;} > > #en

Re: linux-source-2.6.16: inconsistent device detetion: eth0<=>eth1

2006-04-11 Thread Michal Schmidt
josh wrote: I have two ethernet cards on my box, an onboard SiS 7012 and a pci ne-2k compatible. When I boot the system, sometimes the SiS is detected as eth0 and the pci as eth1, and sometimes the SiS is eth1 and the pci eth0, *without my changing anything*. I just reboot and it's different. Y

Re: [XFRM] Restore aevent timer

2006-04-11 Thread KOVACS Krisztian
Hi, On Tuesday 11 April 2006 05.02, jamal wrote: > Ok, if both you can provide feedback on the attached patch (untested but > compiles) I will make any necessary changes, test and push this + > documentation to Dave. Looks ok, although I only had a quick look at it. -- Regards, Krisztia

[patch 2/3] softmac: dont send out packets while scanning

2006-04-11 Thread johannes
Seems we forgot to stop the queue while scanning. Better do that so we don't transmit packets all the time during background scanning. Signed-off-by: Johannes Berg <[EMAIL PROTECTED]> --- wireless-2.6.orig/net/ieee80211/softmac/ieee80211softmac_scan.c 2006-04-11 10:09:53.0 +0200 +++

[patch 3/3] softmac: handle iw_mode properly

2006-04-11 Thread johannes
Below patch allows using iw_mode auto with softmac. bcm43xx forces managed so this bug wasn't noticed earlier, but this was one of the problems why zd1211 didn't work earlier. Signed-off-by: Johannes Berg <[EMAIL PROTECTED]> --- wireless-2.6.orig/net/ieee80211/softmac/ieee80211softmac_io.c

[patch 1/3] softmac: return -EAGAIN from getscan while scanning

2006-04-11 Thread johannes
Below patch was developed after discussion with Daniel Drake who mentioned to me that wireless tools expect an EAGAIN return from getscan so that they can wait for the scan to finish before printing out the results. Signed-off-by: Johannes Berg <[EMAIL PROTECTED]> --- wireless-2.6.orig/net/ieee80

[patch 0/3] softmac patches

2006-04-11 Thread johannes
Here are a few patches to softmac for issues that came up in discussions with Daniel and others. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 3/3] deinline a few large functions in vlan code - v3

2006-04-11 Thread Denis Vlasenko
On Tuesday 11 April 2006 11:36, David S. Miller wrote: > From: Denis Vlasenko <[EMAIL PROTECTED]> > Date: Tue, 11 Apr 2006 11:11:12 +0300 > > > Ok, one last try. Would you like this smallish patch instead? > > It takes care of those BIG inlines. > > You're putting vlan stuff into a net/core/*.c f

Re: [PATCH] net drivers: fix section attributes for gcc

2006-04-11 Thread Sam Ravnborg
Is this pending in your tree Jeff? It fixes compile regressions with HOTPLUG disabled. Sam On Mon, Apr 03, 2006 at 04:28:46PM -0700, Randy.Dunlap wrote: > From: Randy Dunlap <[EMAIL PROTECTED]> > > If CONFIG_HOTPLUG=n, gcc doesn't like some __initdata to be > const (rodata) and o

Re: [XFRM] Restore aevent timer

2006-04-11 Thread Herbert Xu
Hi Jamal: On Mon, Apr 10, 2006 at 11:02:06PM -0400, jamal wrote: > > Ok, if both you can provide feedback on the attached patch (untested but > compiles) I will make any necessary changes, test and push this + > documentation to Dave. Looks good to me. > diff --git a/net/xfrm/xfrm_state.c b/net

linux-source-2.6.16: inconsistent device detetion: eth0<=>eth1

2006-04-11 Thread josh
Subject: linux-source-2.6.16: inconsistent device detetion: eth0<=>eth1 Package: linux-source-2.6.16 Version: 2.6.16-2 Severity: normal I have two ethernet cards on my box, an onboard SiS 7012 and a pci ne-2k compatible. When I boot the system, sometimes the SiS is detected as eth0 and the pci as

Re: [e1000 debug] KERNEL: assertion (!sk_forward_alloc) failed...

2006-04-11 Thread Michal Feix
Maybe it's unrelated to this problem, but it is interesting observation, at least for me. All boxes running for two weeks now and spitting these assert messages have about 1,5GB of slab size allocated, with skbuff_head_cache entry being the largest entry. After rebooting, it is all nice and sm

Re: [PATCH] deinline a few large functions in vlan code v2

2006-04-11 Thread Ingo Oeser
Hi Denis, Denis Vlasenko wrote: > +#if defined(CONFIG_VLAN_8021Q) || defined(CONFIG_VLAN_8021Q_MODULE) > if(vlan_tx_tag_present(skb)) { > first_txd->processFlags |= > TYPHOON_TX_PF_INSERT_VLAN | TYPHOON_TX_PF_VLAN_PRIORITY; > @@ -844,6 +849,7 @@ typhoon_start_

Re: Broadcast ARP packets on link local addresses (Version2).

2006-04-11 Thread Freek Dijkstra
It seems the discussion has died. How is this to move forward? I'm not sure who is responsible for this part of the kernel. There are a few options: 1. Broadcast ARP by checking the IP range in kernel (current patch) 2. Broadcast ARP if the "scope" parameter is "link" 3. Broadcast ARP if a new (to

Re: [PATCH] forcedeth: suggested cleanups

2006-04-11 Thread Ingo Oeser
Hi Manfred, Manfred Spraul wrote: > I think the patch should wait until 0.57 is merged: There are 4 patches > on their way to Jeff. > These patches contain several bugfixes, they should have the higher > priority. Fine with me. Will resubmit after next week. > Apart from that: looks good. Ma

Re: [RFC: 2.6 patch] the overdue removal of ip{,6}_queue

2006-04-11 Thread Harald Welte
On Sun, Apr 09, 2006 at 08:40:05PM +0200, Patrick McHardy wrote: > Adrian Bunk wrote: > > This patch contains the overdue removal of ip{,6}_queue. > > I think this is too early, none of the distributions seem to have > picked up the compat library already. I believe (not sure, Harald?) > that it r

Re: [PATCH 3/3] deinline a few large functions in vlan code - v3

2006-04-11 Thread David S. Miller
From: Denis Vlasenko <[EMAIL PROTECTED]> Date: Tue, 11 Apr 2006 11:11:12 +0300 > Ok, one last try. Would you like this smallish patch instead? > It takes care of those BIG inlines. You're putting vlan stuff into a net/core/*.c file, that is not correct. If we're not going to do the ifdef mess, f

Re: [PATCH] shutting down an interface should remove ipv4 addresses

2006-04-11 Thread David S. Miller
From: Matyas Koszik <[EMAIL PROTECTED]> Date: Tue, 11 Apr 2006 10:08:01 +0200 (CEST) > Then it maybe shouldn't affect the flow of packets while the > interface is down - or is it also something people depend on? Yes, people probably do depend upon it. Addresses are owned by the "host" not a part

Re: [PATCH 3/3] deinline a few large functions in vlan code - v3

2006-04-11 Thread Denis Vlasenko
On Tuesday 11 April 2006 10:58, David S. Miller wrote: > This is not very nice, there is no way I'm applying these patches. > > I think the current situation is far better than the large pile of > ifdefs these patches are adding to the tree. > > Let's just leave things the way they are ok? :( O

Re: [PATCH] shutting down an interface should remove ipv4 addresses

2006-04-11 Thread Matyas Koszik
On Tue, 11 Apr 2006, David S. Miller wrote: > From: Matyas Koszik <[EMAIL PROTECTED]> > Date: Tue, 11 Apr 2006 09:44:55 +0200 (CEST) > > > ... but it doesn't, so those addresses are treated as local which is bad. > > No, shutting down an interface should not remove ipv4 addresses. The > user mus

Re: [PATCH] deinline a few large functions in vlan code v2

2006-04-11 Thread David S. Miller
From: Denis Vlasenko <[EMAIL PROTECTED]> Date: Tue, 11 Apr 2006 10:28:54 +0300 > But it saves some text (~5k total in all network drivers) > and removes a branch on rx path on non-VLAN enabled kernels... It removes "5K total" when you build every single networking driver statically into the main

Re: [PATCH 3/3] deinline a few large functions in vlan code - v3

2006-04-11 Thread David S. Miller
From: Denis Vlasenko <[EMAIL PROTECTED]> Date: Tue, 11 Apr 2006 10:47:36 +0300 > On Tuesday 11 April 2006 10:44, Denis Vlasenko wrote: > On Tuesday 11 April 2006 10:43, Denis Vlasenko wrote: > > These patches exclude VLAN code from netdevice drivers > > and from bonding module, and even remove vla

Re: [PATCH] shutting down an interface should remove ipv4 addresses

2006-04-11 Thread David S. Miller
From: Matyas Koszik <[EMAIL PROTECTED]> Date: Tue, 11 Apr 2006 09:44:55 +0200 (CEST) > ... but it doesn't, so those addresses are treated as local which is bad. No, shutting down an interface should not remove ipv4 addresses. The user must explicitly remove them. This behavior has been around l

[PATCH 3/3] deinline a few large functions in vlan code - v3

2006-04-11 Thread Denis Vlasenko
On Tuesday 11 April 2006 10:44, Denis Vlasenko wrote: On Tuesday 11 April 2006 10:43, Denis Vlasenko wrote: > These patches exclude VLAN code from netdevice drivers > and from bonding module, and even remove vlan-related > members of struct netdevice if VLAN is not configured. > > Compile tested o

[PATCH 2/3] deinline a few large functions in vlan code - v3

2006-04-11 Thread Denis Vlasenko
On Tuesday 11 April 2006 10:43, Denis Vlasenko wrote: > These patches exclude VLAN code from netdevice drivers > and from bonding module, and even remove vlan-related > members of struct netdevice if VLAN is not configured. > > Compile tested on allyesconfig kernel with CONFIG_8021Q=y,m,n. This o

[PATCH 1/3] deinline a few large functions in vlan code - v3

2006-04-11 Thread Denis Vlasenko
Hi, After davem and Dave Dillow comments I realized that a lot of drivers try to do VLAN-related things even on non-VLAN-enabled kernels. These patches exclude VLAN code from netdevice drivers and from bonding module, and even remove vlan-related members of struct netdevice if VLAN is not configu

[PATCH] shutting down an interface should remove ipv4 addresses

2006-04-11 Thread Matyas Koszik
... but it doesn't, so those addresses are treated as local which is bad. This problem doesn't exist with ipv6 and the patch is based on the solution found there. --- linux-2.4.32.orig/net/ipv4/devinet 2004-08-08 01:26:06.0 +0200 +++ linux-2.4.32/net/ipv4/devinet.c 2006-04-11 06:21

Re: [PATCH] deinline a few large functions in vlan code v2

2006-04-11 Thread Denis Vlasenko
> > > > block? For example, typhoon.c: > > > > > > > > spin_lock(&tp->state_lock); > > > > +#if defined(CONFIG_VLAN_8021Q) || defined (CONFIG_VLAN_8021Q_MODULE) > > > > if(tp->vlgrp != NULL && rx->rxStatus & TYPHOON_RX_VLAN) > > > > vlan_hwac