Re: [e1000 debug] KERNEL: assertion (!sk_forward_alloc) failed...

2006-04-04 Thread Michal Feix
Maybe it's unrelated to this problem, but it is interesting observation, at least for me. All boxes running for two weeks now and spitting these assert messages have about 1,5GB of slab size allocated, with skbuff_head_cache entry being the largest entry. After rebooting, it is all nice and sm

Re: [PATCH 2/9] NetXen 1G/10G driver

2006-04-04 Thread Amit Kale
Thanks. We'll implement these along with the changes suggested by others and post this driver again. -Amit On Tuesday 04 Apr 2006 1:11 am, Francois Romieu wrote: > Linsys Contractor Amit S. Kale <[EMAIL PROTECTED]> : > > diff -Naru linux-2.6.16_orig/drivers/net/netxen/netxen_nic_ethtool.c > > lin

Re: [PATCH 1.1/9] NetXen 1G/10G driver

2006-04-04 Thread Amit Kale
Hi Stephen, Thanks for your feedback. We'll implement these and post the driver again. -Amit On Monday 03 Apr 2006 10:19 pm, Stephen Hemminger wrote: > On > > > +#undef NetXen_LOOPBACK > > +#undef SINGLE_DMA_BUF > > +#define NetXen_NIC_HW_CSUM > > +#define NetXen_NIC_NAPI > > +// #undef NetXen_NI

Re: vlan net_device features flag is 0?

2006-04-04 Thread Ben Greear
Andrew Gallatin wrote: I'm working on a driver for a 10GbE nic. I've just gotten to the point where I am verifying that 802.1q vlans work without hardware vlan offload. It seems like the netdev features flags (NETIF_F_SG|NETIF_F_IP_CSUM|NETIF_F_TSO) are not being inherited by the vlan device.

Collisions statistics seem odd with -17-rc1

2006-04-04 Thread Brent Cook
I just upgraded my local tree to 2.6.17-rc1 and see odd things with interface statistics, namely the collisions stat appears to be uninitialized. I'm just wondering if anyone else is seeing this; it may be a busybox bug too. This is on a 32-bit ppc system. [EMAIL PROTECTED]:~$ ifconfig lo

[patch 24/26] hostap: Fix EAPOL frame encryption

2006-04-04 Thread gregkh
Fixed encrypted of EAPOL frames from wlan#ap interface (hostapd). This was broken when moving to use new frame control field defines in net/ieee80211.h. hostapd uses Protected flag, not protocol version (which was cleared in this function anyway). This fixes WPA group key handshake and re-authentic

Re: magical 552 mtu

2006-04-04 Thread Rick Jones
Mark Butler wrote: Rick Jones wrote: Again from RFC 791: Every internet destination must be able to receive a datagram of 576 octets either in one piece or in fragments to be reassembled. Hence the minimum IPv4 MTU of 68 bytes. Makes sense to me. Does a similar argument apply

Re: magical 552 mtu

2006-04-04 Thread Mark Butler
Rick Jones wrote: Again from RFC 791: Every internet destination must be able to receive a datagram of 576 octets either in one piece or in fragments to be reassembled. Hence the minimum IPv4 MTU of 68 bytes. Makes sense to me. Does a similar argument apply the IPv6 "minimum" MT

[PATCH 2.6.17-rc1] Revert NET_RADIO Kconfig title change

2006-04-04 Thread Jean Tourrilhes
Hi, 2.6.17-rc1 changed the title for the entry CONFIG_NET_RADIO. I personally disagree with this change and want it reverted. Patch for 2.6.17-rc1. Rationale : WIRELESS_EXT is an invisible option. Therefore, the only way for a user to enable it is via NET_RADIO. Some users

[PATCH 2.6.17-rc1] Fix IWENCODEEXT security permissions

2006-04-04 Thread Jean Tourrilhes
Hi, Check the permissions when user-space try to read the encryption parameters via SIOCGIWENCODEEXT. This is trivial and probably should go in 2.6.17... Bug was found by Brian Eaton <[EMAIL PROTECTED]>, thanks ! Have fun... Jean Signed-off-by: Jean Tourr

Re: Sun RIO Gem xmit underrun problem...

2006-04-04 Thread BRM
> Mar 15 15:39:25 tsdfft1 NETDEV WATCHDOG: eth0: > transmit timed out > Mar 15 15:39:25 tsdfft1 eth0: transmit timed out, > resetting > Mar 15 15:39:25 tsdfft1 eth0: > TX_STATE[003ffc05:0001:0019] > Mar 15 15:39:25 tsdfft1 eth0: > RX_STATE[0100c805:0001:0021] > Mar 15 15:39:25 tsdff

Re: [stable] [PATCH 2/2] hostap: Fix EAPOL frame encryption

2006-04-04 Thread Greg KH
On Fri, Mar 24, 2006 at 09:24:55PM -0800, Jouni Malinen wrote: > Fixed encrypted of EAPOL frames from wlan#ap interface (hostapd). This > was broken when moving to use new frame control field defines in > net/ieee80211.h. hostapd uses Protected flag, not protocol version > (which was cleared in thi

Re: [3/*] [INET]: Move no-tunnel ICMP error to tunnel4/tunnel6

2006-04-04 Thread David S. Miller
From: Herbert Xu <[EMAIL PROTECTED]> Date: Sun, 2 Apr 2006 19:56:01 +1000 > This patch moves the sending of ICMP messages when there are no IPv4/IPv6 > tunnels present to tunnel4/tunnel6 respectively. Please note that for now > if xfrm4_tunnel/xfrm6_tunnel is loaded then no ICMP messages will eve

Re: [NETFILTER]: Fix fragmentation issues with bridge netfilter

2006-04-04 Thread David S. Miller
From: Patrick McHardy <[EMAIL PROTECTED]> Date: Mon, 03 Apr 2006 15:43:13 +0200 > Fix a regression from the netfilter/IPsec patches with bridging. > Bart, please review this patch, if everything is fine I think it > should also go in -stable. Applied, thanks Patrick. Please submit this to -stabl

[PATCH 4/4] forcedeth: fix multi irq issues

2006-04-04 Thread Ayaz Abdulla
This patch fixes the issues with multiple irqs. I am resending based on feedback. I decoupled the dma mask for consistent memory and fixed leak with multiple irq in error path. Thanks to Manfred for catching the spin lock problem. Signed-Off-By: Ayaz Abdulla <[EMAIL PROTECTED]>

[PATCH 3/4] forcedeth: fix initialization (current)

2006-04-04 Thread Ayaz Abdulla
This patch fixes the nic initialization. If the nic was in low power mode, it brings it back to normal power. Also, it utilizes a new hardware reset during the init. I am resending based on feedback, I corrected the register size mapping and delay after posted write. Signed-Off-By: Ayaz Abdul

Re: [PATCH 2/4] forcedeth: fix initialization

2006-04-04 Thread Ayaz Abdulla
Ignore this...the patch number is wrong...I am resending it. Sorry for the confusion, Ayaz Abdulla wrote: This patch fixes the nic initialization. If the nic was in low power mode, it brings it back to normal power. Also, it utilizes a new hardware reset during the init. I am resending based o

Re: magical 552 mtu

2006-04-04 Thread Rick Jones
Can anyone explain the magical 552 ip_rt_min_pmtu? I've seen fielded equipment that was setting mtu to 512 and causing linux to set the mtu on the route to 552 thus causing fragments. Why can't we honor the 512 mtu? I suspect it is a long-standing bug based misunderstanding about IP minimum M

[PATCH 2/4] forcedeth: fix initialization

2006-04-04 Thread Ayaz Abdulla
This patch fixes the nic initialization. If the nic was in low power mode, it brings it back to normal power. Also, it utilizes a new hardware reset during the init. I am resending based on feedback, I corrected the register size mapping and delay after posted write. Signed-Off-By: Ayaz Abdul

Re: fib_trie leaf freeing [PATCH]

2006-04-04 Thread David S. Miller
From: Robert Olsson <[EMAIL PROTECTED]> Date: Tue, 4 Apr 2006 10:38:36 +0200 > Seems like leaf (end-nodes) has been freed by __tnode_free_rcu and not by > __leaf_free_rcu. This fixes the problem. Only tnode_free is now used which > checks for appropriate node type. free_leaf can be removed. > >

Re: [IPSEC]: Check x->encap before dereferencing it

2006-04-04 Thread David S. Miller
From: Herbert Xu <[EMAIL PROTECTED]> Date: Tue, 4 Apr 2006 09:17:04 +1000 > [IPSEC]: Check x->encap before dereferencing it > > We need to dereference x->encap before dereferencing it for encap_type. > If it's absent then the encap_type is zero. > > Signed-off-by: Herbert Xu <[EMAIL PROTECTED]>

[2.6 patch] drivers/net/tg3.c: fix a memory leak

2006-04-04 Thread Adrian Bunk
This patch fixes a memory leak (buf wasn't freed) spotted by the Coverity checker. Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> --- drivers/net/tg3.c | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) --- linux-2.6.17-rc1-mm1-full/drivers/net/tg3.c.old 2006-04-04 19:53:

[2.6 patch] net/core/net-sysfs.c: fix an off-by-21-or-49 error

2006-04-04 Thread Adrian Bunk
This patch fixes an off-by-21-or-49 error ;-) spotted by the Coverity checker. Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> --- linux-2.6.17-rc1-mm1-full/net/core/net-sysfs.c.old 2006-04-04 20:36:32.0 +0200 +++ linux-2.6.17-rc1-mm1-full/net/core/net-sysfs.c 2006-04-04 20:36:49.

[RFC] ibmveth buffer pool sizes

2006-04-04 Thread Santiago Leon
The current ibmveth driver has a fixed number of buffers per buffer pool and under certain workloads, it's running out of buffers. So I would like to be able to change the number of buffers in each pool at runtime. The way most drivers do it is with ethtool -G and/or module parameters. Howeve

[2.6 patch] bcm43xx_phy.c: fix a memory leak

2006-04-04 Thread Adrian Bunk
This patch fixes a memory leak spotted by the Coverity checker. Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> --- drivers/net/wireless/bcm43xx/bcm43xx_phy.c |1 + 1 file changed, 1 insertion(+) --- linux-2.6.17-rc1-mm1-full/drivers/net/wireless/bcm43xx/bcm43xx_phy.c.old 2006-04-04 19:

bcm43xx_sysfs.c: strange code

2006-04-04 Thread Adrian Bunk
The Coverity checker spotted the following strange code: <-- snip --> static ssize_t bcm43xx_attr_interfmode_show(struct device *dev, struct device_attribute *attr, char *buf) { ... err = 0;

bcm43xx_power.c: uninitialized variable used

2006-04-04 Thread Adrian Bunk
The Coverity checker found this case where the variable "tmp" is used uninitialized: <-- snip --> ... static int bcm43xx_pctl_clockfreqlimit(struct bcm43xx_private *bcm, int get_max) { int limit = 0; int divisor; int selection;

Re: [PATCH 2/4] forcedeth: add support for configuration

2006-04-04 Thread Ayaz Abdulla
Ayaz Abdulla wrote: Manfred Spraul wrote: Ayaz Abdulla wrote: This patch adds support for configuration of various parameters. This includes module parameters and ethtool commands. + +if (netif_running(dev)) { +nv_start_rx(dev); +nv_start_tx(dev); +nv_enabl

Re: [RFC: 2.6 patch] remove drivers/net/hydra.h

2006-04-04 Thread Geert Uytterhoeven
On Tue, 4 Apr 2006, Adrian Bunk wrote: > On Tue, Apr 04, 2006 at 03:27:59PM +0200, Ciaran Farrell wrote: > > We were discussing this topic again and thought it should be reported here. > > As > > you are probably aware, the file > > > > linux-2.6.16.tar.bz2/linux-2.6.16/drivers/net/hydra.h > >

[2.6 patch] net/ipv4/: possible cleanups

2006-04-04 Thread Adrian Bunk
This patch contains the following possible cleanups: - make the following needlessly global function static: - arp.c: arp_rcv() - remove the following unused EXPORT_SYMBO's: - devinet.c: devinet_ioctl - fib_frontend.c: ip_rt_ioctl - inet_hashtables.c: inet_bind_bucket_create - inet_hashta

[Patch] convert drivers/net to kzalloc/kcalloc

2006-04-04 Thread Eric Sesterhenn
hi, this patch converts drivers/net to kzalloc and kcalloc usage. Compile tested with allyesconfig on i386 Signed-off-by: Eric Sesterhenn <[EMAIL PROTECTED]> --- linux-2.6.17-rc1/drivers/net/bonding/bond_main.c.orig 2006-04-04 12:12:12.0 +0200 +++ linux-2.6.17-rc1/drivers/net/bond

[RFC: 2.6 patch] remove drivers/net/hydra.h

2006-04-04 Thread Adrian Bunk
On Tue, Apr 04, 2006 at 03:27:59PM +0200, Ciaran Farrell wrote: > We were discussing this topic again and thought it should be reported here. > As > you are probably aware, the file > > linux-2.6.16.tar.bz2/linux-2.6.16/drivers/net/hydra.h > > contains a BSD 4 license. >... The interesting p

[2.6 patch] drivers/net/via-rhine.c: make a function static

2006-04-04 Thread Adrian Bunk
This patch makes the needlessly global rhine_set_carrier() static. Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> --- linux-2.6.17-rc1-mm1-full/drivers/net/via-rhine.c.old 2006-04-04 17:41:16.0 +0200 +++ linux-2.6.17-rc1-mm1-full/drivers/net/via-rhine.c 2006-04-04 17:41:29.0

Re: Wireless tap device

2006-04-04 Thread Mike Kershaw
On Tue, Apr 04, 2006 at 03:43:03PM +0200, Marcus Better wrote: > Hi developers, > > is there a convenient way to inject 802.11 frames into the stack from > user-space? I am thinking about something analogous to the tap device for > Ethernet. That is, a "virtual" wireless device that would receive

Wireless tap device

2006-04-04 Thread Marcus Better
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi developers, is there a convenient way to inject 802.11 frames into the stack from user-space? I am thinking about something analogous to the tap device for Ethernet. That is, a "virtual" wireless device that would receive frames from user-space. I

Re: [PATCH] softmac uses Wiress Ext.

2006-04-04 Thread John W. Linville
On Mon, Apr 03, 2006 at 04:20:22PM -0700, Randy.Dunlap wrote: > > I still get this on 2.6.17-rc1... > Did anyone on netdev pick it up last week? I've got the patch...will get it merged "soon". Thanks! John - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a mess

fib_trie leaf freeing [PATCH]

2006-04-04 Thread Robert Olsson
Hello! Seems like leaf (end-nodes) has been freed by __tnode_free_rcu and not by __leaf_free_rcu. This fixes the problem. Only tnode_free is now used which checks for appropriate node type. free_leaf can be removed. Signed-off-by: Robert Olsson <[EMAIL PROTECTED]> Cheers.

Re: ipsec tunnel asymmetrical mtu

2006-04-04 Thread Marco Berizzi
Herbert Xu wrote: Marco Berizzi <[EMAIL PROTECTED]> wrote: > > Running 'tcpdump -p -n -v ip net 10.16.24.117' on mimosa > resolves the problem: sapgui clients can connect to sap > servers while tcpdump is running on mimosa. > Is this a bug? Very strange. Could you perhaps move the tcpdump to a