Re: [PATCH] IPv6: Cleanup of net/ipv6/reassambly.c

2006-03-11 Thread Ingo Oeser
Hi, On Sunday, 12. March 2006 00:49, Ingo Oeser wrote: > From: Ingo Oeser <[EMAIL PROTECTED]> > > Two minor cleanups: > > 1. Using kzalloc() in fraq_alloc_queue() >saves the memset() in ipv6_frag_create(). > > 2. Invert sense of if-statements to streamline code. >Inverts the comment, t

[patch 1/2] git-net: ebtables fix

2006-03-11 Thread akpm
From: Andrew Morton <[EMAIL PROTECTED]> net/bridge/netfilter/ebtables.c:1481: warning: initialization makes pointer from integer without a cast Note that the compat functions aren't implemented? Signed-off-by: Andrew Morton <[EMAIL PROTECTED]> --- net/bridge/netfilter/ebtables.c | 10

[patch 2/2] git-net: br_netfilter warning fixes

2006-03-11 Thread akpm
From: Andrew Morton <[EMAIL PROTECTED]> net/bridge/br_netfilter.c: In function `br_nf_pre_routing': net/bridge/br_netfilter.c:427: warning: unused variable `vhdr' net/bridge/br_netfilter.c:445: warning: unused variable `vhdr' Signed-off-by: Andrew Morton <[EMAIL PROTECTED]> --- net/bridge/br_

Re: [PATCH]: Wrong return value corrupts free object in e1000 driver

2006-03-11 Thread Jesse Brandeburg
On 3/10/06, David S. Miller <[EMAIL PROTECTED]> wrote: > > For some reason, E1000's ->hard_start_xmit() routine returns -EFAULT > instead of one of the NETDEV_TX_* error codes. In fact, it frees up > the SKB before returning this. This makes the queueing layer think > the packet should be requeue

Re: Linux v2.6.16-rc6

2006-03-11 Thread David S. Miller
From: "Michal Piotrowski" <[EMAIL PROTECTED]> Date: Sun, 12 Mar 2006 02:51:40 +0100 > I have noticed this warnings > TCP: Treason uncloaked! Peer 82.113.55.2:11759/50967 shrinks window > 148470938:148470943. Repaired. > TCP: Treason uncloaked! Peer 82.113.55.2:11759/50967 shrinks window > 14847093

Re: Linux v2.6.16-rc6

2006-03-11 Thread Michal Piotrowski
Hi, On 12/03/06, Linus Torvalds <[EMAIL PROTECTED]> wrote: > > Ok, we're getting closer, although the 2.6.16 release certainly seems to > drag out more than it should have. > I have noticed this warnings TCP: Treason uncloaked! Peer 82.113.55.2:11759/50967 shrinks window 148470938:148470943. Repa

Re: [patch 05/12] drivers/net/e1000/: proper prototypes

2006-03-11 Thread Jeff Garzik
[EMAIL PROTECTED] wrote: From: Adrian Bunk <[EMAIL PROTECTED]> This patch moves prototypes of global variables and functions to a header file. Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> Acked-by: John Ronciak <[EMAIL PROTECTED]> Signed-off-by: Andrew Morton <[EMAIL PROTECTED]> request res

Re: [ethtool-3] UFO patch

2006-03-11 Thread Jeff Garzik
Ananda Raju wrote: Hi, Kernel version 2.6.15 onwards provides UDP Fragmentation Offload (UFO) This patch to ethtool provides UFO (UDP Fragmentation Offload) on/off support using -K option similar to feature TSO. To find out whether UFO is enabled or not use #ethtool -k eth3 Offload paramete

[PATCH] IPv6: Cleanup of net/ipv6/reassambly.c

2006-03-11 Thread Ingo Oeser
From: Ingo Oeser <[EMAIL PROTECTED]> Two minor cleanups: 1. Using kzalloc() in fraq_alloc_queue() saves the memset() in ipv6_frag_create(). 2. Invert sense of if-statements to streamline code. Inverts the comment, too. Signed-off-by: Ingo Oeser <[EMAIL PROTECTED]> --- Hi, I first did t

[PATCH] Nearly complete kzalloc cleanup for net/ipv6

2006-03-11 Thread Ingo Oeser
From: Ingo Oeser <[EMAIL PROTECTED]> Stupidly use kzalloc() instead of kmalloc()/memset() everywhere where this is possible in net/ipv6/*.c . Signed-off-by: Ingo Oeser <[EMAIL PROTECTED]> --- Hi, I'm going to refactor some of the simple cases to reduce code duplication which will depend on thi

[git patches] net driver fixes

2006-03-11 Thread Jeff Garzik
Please pull from 'upstream-fixes' branch of master.kernel.org:/pub/scm/linux/kernel/git/jgarzik/netdev-2.6.git to receive the following updates: drivers/net/3c509.c| 13 - drivers/net/Kconfig|3 ++- drivers/net/de620.c|2 +- drivers/net/

Re: [PATCH netdev-2.6] e1000: driver update

2006-03-11 Thread Jeff Garzik
Jeff Kirsher wrote: On 3/8/06, Jeff Kirsher <[EMAIL PROTECTED]> wrote: The series only contains one patch. Sorry for the cover email, I was trying to edit the patch email and did not intend to create cover email. The one patch in this series is a fix for mii-tool. This patch was created us

Re: [PATCH netdev-2.6 ] e100: Fix eeh on pseries during ethtool -t

2006-03-11 Thread Jeff Garzik
Jeff Kirsher wrote: This patch was diff'd against the latest 'upstream' branch from Garzik's tree. This patch can be pulled from the following location: git://198.78.49.142/linux-2.6.git e100-upstream Jeff - should a patch be made for 2.6.16 also? Yes, since this is a small fix and there ar

Re: [PATCH 7/9] sky2: smarter irq handling

2006-03-11 Thread Jeff Garzik
Francois Romieu wrote: Stephen Hemminger <[EMAIL PROTECTED]> : On Thu, 9 Mar 2006 00:06:33 +0100 Francois Romieu <[EMAIL PROTECTED]> wrote: [...] So instead of #1..#6 from 07/03/2006, #1..#3 from 08/03/2003 which actually cover (with minor differences) #4..#6 from 07/03/2006 should be push

Re: [PATCH] TC: bug fixes to the "sample" clause

2006-03-11 Thread jamal
On Sun, 2006-12-03 at 00:49 +1000, Russell Stuart wrote: > However, assuming you are referring to the hashing function > here - as it happens the 2.4 and 2.6 functions always > hash to the same thing when you are hashing one byte. > They differ when you hash two or more non-zero bytes. > Right -

Re: [PATCH] dl2k: DMA freeing error

2006-03-11 Thread Jon Mason
On Sat, Mar 11, 2006 at 02:44:16PM +0100, Francois Romieu wrote: > Jon Mason <[EMAIL PROTECTED]> : > [...] > > diff -r c698c94ff82e drivers/net/dl2k.c > > --- a/drivers/net/dl2k.cThu Mar 9 15:03:49 2006 > > +++ b/drivers/net/dl2k.cFri Mar 10 08:48:50 2006 > [...] > > @@ -765,7 +765,7 @@ >

Re: [Bugme-new] [Bug 6177] New: Java remote debugging is slow due to apparent networking bug

2006-03-11 Thread Eric Molitor
You are correct, the format is as follows. Command Packet * Header o length (4 bytes) o id (4 bytes) o flags (1 byte) o command set (1 byte) o command (1 byte) * data (Variable) Reply Packet * Header

Re: [PATCH] TC: bug fixes to the "sample" clause

2006-03-11 Thread Russell Stuart
On Sat, 2006-03-11 at 09:01 -0500, jamal wrote: > > sample never worked 100% of the time with that hash. It works _most_ of > > the time with 256 buckets. Infact it will work some of the time as it is > > right now with 2.6.x. Can you post the output of tc -s filter ls on 2.6 > > with and without y

Re: [PATCH] TC: bug fixes to the "sample" clause

2006-03-11 Thread jamal
On Sat, 2006-11-03 at 08:11 -0500, jamal wrote: > sample never worked 100% of the time with that hash. It works _most_ of > the time with 256 buckets. Infact it will work some of the time as it is > right now with 2.6.x. Can you post the output of tc -s filter ls on 2.6 > with and without your use

Re: [PATCH] dl2k: DMA freeing error

2006-03-11 Thread Francois Romieu
Jon Mason <[EMAIL PROTECTED]> : [...] > diff -r c698c94ff82e drivers/net/dl2k.c > --- a/drivers/net/dl2k.c Thu Mar 9 15:03:49 2006 > +++ b/drivers/net/dl2k.c Fri Mar 10 08:48:50 2006 [...] > @@ -765,7 +765,7 @@ > break; > skb = np->tx_skbuff[entry]; >

Re: [UPDATED PATCH] Re: [Lse-tech] Re: [Patch 7/7] Generic netlink interface (delay accounting)

2006-03-11 Thread jamal
On Fri, 2006-10-03 at 22:09 +0530, Balbir Singh wrote: > On Fri, Mar 10, 2006 at 09:53:53AM -0500, jamal wrote: > > On kernel->user (in the case of response to #a or async notifiation as > > in #b) you really dont need to specify the TG/PID since they appear in > > the STATS etc. > > I see your

Re: [PATCH] TC: bug fixes to the "sample" clause

2006-03-11 Thread jamal
Hi there, I took out lartc because it keeps bouncing me. On Fri, 2006-10-02 at 12:33 +1000, Russell Stuart wrote: > PATCH 1 > === > > On my machine tc does not parse filter "sample" for the u32 > filter. Eg: > > tc filter add dev eth2 parent 1:0 protocol ip prio 1 u32 ht 801: \ > class

Re: [PATCH 8/8] [I/OAT] TCP recv offload to I/OAT

2006-03-11 Thread Andrew Morton
Chris Leech <[EMAIL PROTECTED]> wrote: > > Locks down user pages and sets up for DMA in tcp_recvmsg, then calls > dma_async_try_early_copy in tcp_v4_do_rcv All those ifdefs are still there. They really do put a maintenance burden on, of all places, net/ipv4/tcp.c. Please find a way of abstracti

Re: [PATCH 3/8] [I/OAT] Setup the networking subsystem as a DMA client

2006-03-11 Thread Andrew Morton
Chris Leech <[EMAIL PROTECTED]> wrote: > > +#ifdef CONFIG_NET_DMA > +#include > +#endif There are still a number of instances of this in the patch series. Did you decide to keep the ifdefs in there for some reason? - To unsubscribe from this list: send the line "unsubscribe netdev" in the bod

Re: [PATCH 3/8] [I/OAT] Setup the networking subsystem as a DMA client

2006-03-11 Thread Andrew Morton
Chris Leech <[EMAIL PROTECTED]> wrote: > There seems to be a small race here. > +static void net_dma_rebalance(void) > +{ > +unsigned int cpu, i, n; > +struct dma_chan *chan; > + > +lock_cpu_hotplug(); > + > +if (net_dma_count == 0) { > +for_each_online_cpu(cpu

Re: [PATCH 1/8] [I/OAT] DMA memcpy subsystem

2006-03-11 Thread Andrew Morton
Chris Leech <[EMAIL PROTECTED]> wrote: > > +void dma_async_device_cleanup(struct kref *kref); > Declarations go in header files, please. Or give it static scope. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info