On Friday 24 February 2006 06:22, Jeff Garzik wrote:
> Please pull from 'upstream-fixes' branch of
> master.kernel.org:/pub/scm/linux/kernel/git/jgarzik/netdev-2.6.git
>
> [...]
> Stephen Hemminger:
> sky2: yukon-ec-u chipset initialization
> sky2: limit coalescing values to ring size
>
Please pull from 'upstream-fixes' branch of
master.kernel.org:/pub/scm/linux/kernel/git/jgarzik/netdev-2.6.git
to receive the following updates:
drivers/net/r8169.c | 189
drivers/net/skge.c | 75
drivers/net/skge.h
Hi,
Updated as per Herbert's comment.
Catherine
---
From: [EMAIL PROTECTED]
This patch implements an application of the LSM-IPSec networking
controls whereby an application can determine the label of the
security association its TCP or UDP sockets are currently connected to
via getsockopt and
Michael Richardson wrote:
>
>
>>>"Patrick" == Patrick McHardy <[EMAIL PROTECTED]> writes:
>
> Patrick> The normal way to display masks is with a "/". Also I think
> Patrick> it shouldn't display the default mask to avoid breaking
> Patrick> scripts that parse the output.
>
> I
Michael Richardson wrote:
>
>
>>>"Patrick" == Patrick McHardy <[EMAIL PROTECTED]> writes:
>
> >> #define RTA_FWMARK RTA_PROTOINFO +#define RTA_FWMARK_MASK
> >> RTA_CACHEINFO
>
> Patrick> Please introduce a new attribute for this instead of
> Patrick> overloading RTA_CACHEINF
Chinh Nguyen wrote:
> Patrick McHardy wrote:
>
>>Netfilter recalculates the checksum when NATing it.
>
>
> The NATing is not done by netfilter but by the NAT device between the IPsec
> peers.
I see, so the TCP checksum includes the wrong IPs.
> [Linux ipsec client C] -- [NAT device] -
On 2/21/06, David S. Miller <[EMAIL PROTECTED]> wrote:
> From: Rick Jones <[EMAIL PROTECTED]>
> Date: Tue, 21 Feb 2006 17:21:30 -0800
>
> > My point (perhaps not as well expressed as the one on the top of my
> > head :) was that if 2.4 is "OK" with extending the window beyond
> > 32767 without addi
Under IPv4, when I send a UDP packet with invalid checksum, kernel used
udp_rcv() to up packet to UDP layer, application used udp_recvmsg to
receive message. So if one UDP packet with invalid checksum is arrived
to host, UDP_MIB_INDATAGRAMS will be increased 1, UDP_MIB_INERRORS
should be increased
Refer to RFC2012, tcpAttemptFails is defined as following:
tcpAttemptFails OBJECT-TYPE
SYNTAX Counter32
MAX-ACCESS read-only
STATUS current
DESCRIPTION
"The number of times TCP connections have made a direct
transition to the CLOSED s
Francois Romieu wrote:
Stephen Hemminger <[EMAIL PROTECTED]> :
Bug fix patches to skge driver that need to go in 2.6.16.
Some of them are in -mm and some have already been sent (and ignored).
#1..#3 Applied to branch 'for-jeff' at
git://electric-eye.fr.zoreil.com/home/romieu/linux-2.6.git
S
Hi,
The included patch fixes ip6_tunnel to release the cached dst entry
when the tunnel parameters (such as tunnel endpoints) are changed so
they are used immediatly for the next encapsulated packets.
Signed-off-by: Hugo Santos <[EMAIL PROTECTED]>
--- linux-2.6.16-rc4/net/ipv6/ip6_tunnel.c
From: Robert Olsson <[EMAIL PROTECTED]>
Date: Wed, 22 Feb 2006 19:47:13 +0100
>
> Jesse Brandeburg writes:
> >
> > I looked quickly at this on a couple different machines and wasn't
> > able to reproduce, so don't let me block the patch. I think its a
> > good patch FWIW
>
> OK!
> We as
From: Luiz Fernando Capitulino <[EMAIL PROTECTED]>
Date: Mon, 23 Jan 2006 13:44:19 -0200
>
> This patch is not in-lined because it's 120K bytes long, you can found it at:
>
> http://www.cpu.eti.br/patches/pktgen_lindent_1.patch
Not found:
[EMAIL PROTECTED]:~/src/GIT/net-2.6.17$ wget
http://w
From: YOSHIFUJI Hideaki <[EMAIL PROTECTED]>
Date: Fri, 24 Feb 2006 00:23:51 +0900 (JST)
> David, please apply. Thank you.
Can you please resend the patch with a full changelog
entry and Signed-off-by lines for me? Thank you.
This is for net-2.6 right? Or net-2.6.17?
Thanks again.
-
To unsubs
Hi,
ip6_tunnel keeps a cached dst (dst_cache in ip6_tnl) per tunnel
instance. This cached dst is re-used while it's not marked obsolete. A
change of the tunnel's parameters (via SIOCCHGTUNNEL) does not
invalidate the dst_cache directly, which results on it being used by
ip6ip6_tnl_xmit afte
On 2/23/06, Arnaldo Carvalho de Melo <[EMAIL PROTECTED]> wrote:
> On 2/23/06, Andrew Morton <[EMAIL PROTECTED]> wrote:
>
> > Starting from 2.6.14, defer_accept is moved to request_sock_queue structure,
> > which is re-initialized in inet_csk_listen_start().
>
> Oops, looking into it...
culprit:
ht
From: jamal <[EMAIL PROTECTED]>
Date: Tue, 21 Feb 2006 08:31:49 -0500
> Ok. Patch attached against net-2617
>
> Yoshfuji-san you should probably write a little doc that should be
> available in the Doc/ directory.
If we write this, please ask Andi Kleen to review it.
His arch has the most proble
From: jamal <[EMAIL PROTECTED]>
Date: Thu, 23 Feb 2006 10:06:46 -0500
> Ok, patch attached. Dave this also is needed for 2.6.16-rcXX.
>
> Tested against a standard eth device (e1000) and tuntap.
Applied to net-2.6, thanks a lot.
-
To unsubscribe from this list: send the line "unsubscribe netdev"
From: "Michael Chan" <[EMAIL PROTECTED]>
Date: Thu, 23 Feb 2006 13:12:38 -0800
> On Fri, 2006-02-24 at 11:48 +1300, Ian McDonald wrote:
>
> > Thinking out loud here without reading source... - can you check the
> > version of the firmware and make noise if they have a version like
> > this one?
>
On Fri, 2006-02-24 at 11:48 +1300, Ian McDonald wrote:
> Thinking out loud here without reading source... - can you check the
> version of the firmware and make noise if they have a version like
> this one?
>
Probably yes. Will put this on my queue if there is no other objection.
-
To unsubscrib
On 2/24/06, Michael Chan <[EMAIL PROTECTED]> wrote:
> This is a known problem caused by ASF or IPMI firmware overwriting the
> promiscuous mode bit. I will have someone contact you to get the
> firmware upgraded.
>
> Thanks.
>
Thinking out loud here without reading source... - can you check the
ver
On Thu, 2006-02-23 at 14:31 -0800, Jim Westfall wrote:
> I am seeing the following issue on only the first onboard nic on each of
> the servers. If the nic is put into promisc mode too soon after the nic
> is brought up, the promisc bit in the rx_mode register is somehow getting
> reset to 0;
Hi
I have a number of ibm x336 servers that have the following 2 onboard
nics (eth0/1 are 2 other bcm57xx nics on a PCIX card). kernel version is
2.6.15.4, though I have tried 2.4.32/2.6.14-rc4 and they both have the
issue below.
ACPI: PCI Interrupt :06:00.0[A] -> GSI 16 (level, low) ->
Stephen Hemminger <[EMAIL PROTECTED]> :
> Bug fix patches to skge driver that need to go in 2.6.16.
> Some of them are in -mm and some have already been sent (and ignored).
#1..#3 Applied to branch 'for-jeff' at
git://electric-eye.fr.zoreil.com/home/romieu/linux-2.6.git
Shortlog
$ git re
From: Jörn Engel <[EMAIL PROTECTED]>
Date: Thu, 23 Feb 2006 13:52:59 +0100
> +void kfree_skb(struct sk_buff *skb);
> extern void __kfree_skb(struct sk_buff *skb);
If you wish to contribute to a software project, you should adhere to
the coding style and conventions of that project when s
Patrick McHardy wrote:
> Chinh Nguyen wrote:
>
>>Patrick McHardy wrote:
>>
>>
>>>What values does skb->ip_summed have before that?
>>
>>
>>the skb->ip_summed value before the checksum check in tcp_v4_rcv is
>>CHECKSUM_NONE. Hence tcp_v4_rcv checks its value, which is incorrect because
>>the
>>che
On Thu, Feb 23, 2006 at 02:21:46PM +0100, Sven Schuster wrote:
>
> static inline void kfree_skb(struct sk_buff *skb)
> {
> if (unlikely(!skb))
> return;
> _kfree_skb(skb);
> }
>
> This way the kernel with the new inlined kfree_skb should still become
> smaller while not
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
> "Patrick" == Patrick McHardy <[EMAIL PROTECTED]> writes:
Patrick> The normal way to display masks is with a "/". Also I think
Patrick> it shouldn't display the default mask to avoid breaking
Patrick> scripts that parse the output.
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
> "Patrick" == Patrick McHardy <[EMAIL PROTECTED]> writes:
>> #define RTA_FWMARK RTA_PROTOINFO +#define RTA_FWMARK_MASK
>> RTA_CACHEINFO
Patrick> Please introduce a new attribute for this instead of
Patrick> overloading RTA_CACHEI
On 2/23/06, Andrew Morton <[EMAIL PROTECTED]> wrote:
> Starting from 2.6.14, defer_accept is moved to request_sock_queue structure,
> which is re-initialized in inet_csk_listen_start().
Oops, looking into it...
- Arnaldo
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the
Begin forwarded message:
Date: Thu, 23 Feb 2006 07:26:28 -0800
From: [EMAIL PROTECTED]
To: [EMAIL PROTECTED]
Subject: [Bugme-new] [Bug 6121] New: TCP_DEFER_ACCEPT is reset on listen() call
http://bugzilla.kernel.org/show_bug.cgi?id=6121
Summary: TCP_DEFER_ACCEPT is reset on listen(
A recent patch attempted to enable more efficient memory usage by using
only 2kB descriptors for jumbo frames. The method used to implement this
has since been commented upon as "illegal" and in recent kernels even
causes a BUG when receiving ip fragments while using jumbo frames. This
patch s
Chinh Nguyen wrote:
> Patrick McHardy wrote:
>
>>What values does skb->ip_summed have before that?
>
>
> the skb->ip_summed value before the checksum check in tcp_v4_rcv is
> CHECKSUM_NONE. Hence tcp_v4_rcv checks its value, which is incorrect because
> the
> checksum is with regards to the pri
On 2/22/06, Simon Kirby <[EMAIL PROTECTED]> wrote:
> Of course, now it doesn't send as fast. Hrmph. :) On this older Xeon
> 2.4 Ghz w/533 FSB and e1000 & tg3 @ PCI-X 133 Mhz 64 bit, SMP kernel,
> single pktgen thread, I'm only seeing:
>
> clone_skb=0, 802.1Q tagging, 60 byte:
> e1000: 558526pps 2
On Thursday 23 February 2006 17:17, you wrote:
> In reviewing the ieee80211 stack in order to add additional geographic
> support for wireless drivers,
> I have studied all the in-kernel wireless drivers for their interactions with
> the routines in
> ieee80211_geo.c. As clearly stated in the c
In reviewing the ieee80211 stack in order to add additional geographic support for wireless drivers,
I have studied all the in-kernel wireless drivers for their interactions with the routines in
ieee80211_geo.c. As clearly stated in the comments, ipw2200.c duplicates most of those routines,
even
On Thu, 2006-23-02 at 17:41 +0300, Alexey Kuznetsov wrote:
> After some thinking I suspect the deletion of this chunk could change
> behaviour
> of some parts which do not use neighbour cache f.e. packet socket.
>
Thanks Alexey, this was what i was worried about ;->
>
> I think safer approach
Patrick McHardy wrote:
> Chinh Nguyen wrote:
>
>>I discovered that the "bug" is in the function tcp_v4_rcv for kernel
>>2.6.16-rc1.
>>
>>After the ESP packet is decapped and decrypted in xfrm4_rcv_encap_finish, the
>>unencrypted packet is pushed back through ip_local_deliver. For a UDP packet,
>
Hello!
> All devices including loopback pass a daddr. loopback in fact passes
> a 0 all the time ;->
> This means i can delete the check totaly or i can remove the IFF_NOARP
...
> Anyone knows the history?
I think, it was me who did this crap. It was so long ago I do not remember
why it was made
This drove me nuts this morning and i find it hard to believe that
no-one has reported this before because i went back as far back
as 2.4.2 and it is there ;->. I am ccing the three people who may
possibly have made this change (no records whatsoever in git);->
When you turn off ARP on a netdevic
Hello,
> --- kfree_skb/include/linux/skbuff.h~kfree_skb_uninline_null 2006-02-23
> 13:35:05.0 +0100
> +++ kfree_skb/include/linux/skbuff.h 2006-02-23 13:36:23.0 +0100
> @@ -306,6 +306,7 @@ struct sk_buff {
>
> #include
>
> +void kfree_skb(struct sk_buff *skb);
> extern v
On Thu, 23 February 2006 02:00:50 -0800, David S. Miller wrote:
>
> > This breaks socket buffer accounting.
>
> That's why he's dropping the SKB sans the data.
There doesn't appear to be any fundamental opposition. David, should
I turn this mess into a decent patch, convert one driver, do some
On Thu, 23 February 2006 22:26:01 +1100, Herbert Xu wrote:
> On Thu, Feb 23, 2006 at 12:22:31PM +0100, J?rn Engel wrote:
> >
> > Should I merge the two patches into one and resend?
>
> Sounds good.
Here it is.
Jörn
--
Fancy algorithms are buggier than simple ones, and they're much harder
to im
On Thu, 23 February 2006 13:52:59 +0100, Jörn Engel wrote:
>
> +void kfree_skb(struct sk_buff *skb);
> extern void __kfree_skb(struct sk_buff *skb);
> extern struct sk_buff *__alloc_skb(unsigned int size,
And while we're in the area...is there a good reason why all function
declaration
On Thu, Feb 23, 2006 at 12:22:31PM +0100, J?rn Engel wrote:
>
> Should I merge the two patches into one and resend?
Sounds good.
--
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <[EMAIL PROTECTED]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.ap
On Thu, 23 February 2006 03:11:12 -0800, David S. Miller wrote:
>
> > Now there's a good idea. After all, the great majority of callers
> > of kfree_skb expect to free the skb. Dave, what do you think?
>
> Absolutely.
Should I merge the two patches into one and resend?
Jörn
--
If you're wil
From: Herbert Xu <[EMAIL PROTECTED]>
Date: Thu, 23 Feb 2006 21:55:43 +1100
> Now there's a good idea. After all, the great majority of callers
> of kfree_skb expect to free the skb. Dave, what do you think?
Absolutely.
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the b
On Thu, Feb 23, 2006 at 11:50:41AM +0100, J?rn Engel wrote:
>
> For my kernel, there would be 92 removals if the condition at the
> price of 135 bytes of extra object code. Some of the removals would
> be in modules, so the numbers are not exactly fair.
IMHO source saving is cheap while binary b
On Thu, 23 February 2006 21:10:37 +1100, Herbert Xu wrote:
> On Thu, Feb 23, 2006 at 10:54:46AM +0100, J?rn Engel wrote:
> >
> > Wrt. the binary, you have a point. For source code, my patch does not
> > any new bloat and allows removal of the existing. Lemme do a quick
>
> Well I just did a gre
On Thu, Feb 23, 2006 at 10:54:46AM +0100, J?rn Engel wrote:
>
> Wrt. the binary, you have a point. For source code, my patch does not
> any new bloat and allows removal of the existing. Lemme do a quick
Well I just did a grep in net/*/*.c and it seems that the number of
calls to kfree_skb prece
From: Lennert Buytenhek <[EMAIL PROTECTED]>
Date: Thu, 23 Feb 2006 10:55:21 +0100
> This breaks socket buffer accounting.
That's why he's dropping the SKB sans the data.
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordom
On Thu, 23 February 2006 19:28:49 +1100, Herbert Xu wrote:
> On Thu, Feb 23, 2006 at 07:53:36AM +0100, J?rn Engel wrote:
> >
> > How is that argument special for kfree_skb? Both libc free and kfree
> > ignore NULL arguments and do so for good reasons.
>
> Well with kfree there is actually a slig
On Thu, 23 February 2006 10:55:21 +0100, Lennert Buytenhek wrote:
> On Thu, Feb 23, 2006 at 08:00:32AM +0100, Jörn Engel wrote:
>
> > > I am assuming the real goal is avoiding interrupts when
> > > transmit completions can be reported without them on a
> > > reasonably periodic basis.
> >
> > Not
On Thu, Feb 23, 2006 at 08:00:32AM +0100, Jörn Engel wrote:
> > I am assuming the real goal is avoiding interrupts when
> > transmit completions can be reported without them on a
> > reasonably periodic basis.
>
> Not necessarily on a periodic basis. For some network driver I once
> worked on, t
On Mon, 20 Feb 2006 20:39:16 +0100, Carlos Martin <[EMAIL PROTECTED]> wrote:
> diff --git a/drivers/net/wireless/prism54usb/isl_sm.h
> b/drivers/net/wireless/prism54usb/isl_sm.h
> index 9e41587..c39bb48 100644
> --- a/drivers/net/wireless/prism54usb/isl_sm.h
> +++ b/drivers/net/wireless/prism54us
On Wednesday 22 February 2006 16:19, Robert Love wrote:
> e100 or e1000?
8139cp here. Seems to have picked up this behaviour since SL10.1beta2 or so,
still in beta4.
See https://bugzilla.novell.com/show_bug.cgi?id=151892
> `carrier' returns EINVAL if the device is not UP. It might be a bug in
From: Wei Yongjun <[EMAIL PROTECTED]>
Date: Thu, 23 Feb 2006 16:03:18 -0500
> IPv4 UDP does not discard the datagram with invalid checksum. UDP can
> validate UDP checksums correctly only when socket filtering instructions
> is set. If socket filtering instructions is not set, datagram with
> inva
On Thu, Feb 23, 2006 at 07:53:36AM +0100, J?rn Engel wrote:
>
> How is that argument special for kfree_skb? Both libc free and kfree
> ignore NULL arguments and do so for good reasons.
Well with kfree there is actually a slight gain in that you are doing
the check in one place.
kfree_skb on the
58 matches
Mail list logo
