Re: [PATCH]ip_options_fragment() has no effect on fragmentation

2006-01-29 Thread David S. Miller
From: "Wei Yongjun" <[EMAIL PROTECTED]> Date: Fri, 27 Jan 2006 09:35:02 -0800 > [1]Summary of the problem: > ip_options_fragment() has no effect on fragmentation > > [2]Full description of the problem: > When I send IPv4 packet(contain Record Route Option) which need to be > fragmented to the rou

Re: [PATCH]Enhancements of ip_options_fragment()

2006-01-29 Thread David S. Miller
From: "Wei Yongjun" <[EMAIL PROTECTED]> Date: Mon, 30 Jan 2006 16:29:18 -0800 > I think this problem should not occurred because the patch make the > ipv4 header of a 32 bit alignment. I still think the complicated new code is not justified. Show a real life example where this results in breakag

Re: [PATCH]Enhancements of ip_options_fragment()

2006-01-29 Thread Wei Yongjun
I think this problem should not occurred because the patch make the ipv4 header of a 32 bit alignment. [Please put new lines every 80 characters in your mails] On Monday 30 January 2006 22:44, Wei Yongjun wrote: [1]Summary of the problem: Kernel does not delete the space of the options which

Re: [Acx100-devel] [PATH] acxsm: Move WEP code into softmac

2006-01-29 Thread Denis Vlasenko
On Sunday 29 January 2006 16:26, Carlos Martín wrote: > Hi, > > This patch moves the WEP handling code to use the softmac layer and > implements acx_e_ieee80211_set_security(), based on the rt2x00 project's one. Applied, thanks! > I do have a couple of questions though: > > 1) adev->wep_res

Re: [PATCH]Enhancements of ip_options_fragment()

2006-01-29 Thread Andi Kleen
[Please put new lines every 80 characters in your mails] On Monday 30 January 2006 22:44, Wei Yongjun wrote: > [1]Summary of the problem: > Kernel does not delete the space of the options which not allowed in > fragments. > > [2]Full description of the problem: > ip_options_fragment() just fill

Re: net-2.6.17.git crashes

2006-01-29 Thread David S. Miller
From: Andrew Morton <[EMAIL PROTECTED]> Date: Sat, 28 Jan 2006 17:22:40 -0800 > David, your tree > git+ssh://master.kernel.org/pub/scm/linux/kernel/git/davem/net-2.6.17.git > is oopsing all over the place. Reverting "[NET]: Do not lose accepted > socket when -ENFILE/-EMFILE." makes it stop: I ju

[PATCH]Enhancements of ip_options_fragment()

2006-01-29 Thread Wei Yongjun
[1]Summary of the problem: Kernel does not delete the space of the options which not allowed in fragments. [2]Full description of the problem: ip_options_fragment() just fill options which not allowed in fragments with NOOPs, does not delete the space of the options, following patch has corrected

Re: net-2.6.17.git crashes

2006-01-29 Thread David S. Miller
From: Andrew Morton <[EMAIL PROTECTED]> Date: Sat, 28 Jan 2006 17:22:40 -0800 > David, your tree > git+ssh://master.kernel.org/pub/scm/linux/kernel/git/davem/net-2.6.17.git > is oopsing all over the place. Reverting "[NET]: Do not lose accepted > socket when -ENFILE/-EMFILE." makes it stop: Ok,

net/tipc/bcast.c:tipc_bcbearer_send() stack usage

2006-01-29 Thread Adrian Bunk
>From net/tipc/bcast.c: <-- snip --> ... int tipc_bcbearer_send(struct sk_buff *buf, struct tipc_bearer *unused1, struct tipc_media_addr *unused2) { static int send_count = 0; struct node_map remains; struct node_map remains

[PATCH 4/4] pktgen: Fix Initialization fail leak.

2006-01-29 Thread Luiz Fernando Capitulino
Even if pktgen's thread initialization fails for all CPUs, the module will be successfully loaded. This patch changes that behaivor, by returning error on module load time, and also freeing all the resources allocated. It also prints a warning if a thread initialization has failed. Signed-off-

[PATCH 3/4] pktgen: Fix kernel_thread() fail leak.

2006-01-29 Thread Luiz Fernando Capitulino
Leak fix: free all the alocated resources if kernel_thread() call fails. Signed-off-by: Luiz Capitulino <[EMAIL PROTECTED]> --- net/core/pktgen.c | 11 +-- 1 files changed, 9 insertions(+), 2 deletions(-) 59115e7981073430cfcbcde20840ec926cca diff --git a/net/core/pktgen.c b/ne

[PATCH 2/4] pktgen: Ports thread list to Kernel list implementation.

2006-01-29 Thread Luiz Fernando Capitulino
Ports the thread list to use the Linux Kernel linked list implementation. The final result is a simpler and smaller code. Note that I'm adding a new member in the struct pktgen_thread called 'removed'. The reason is that I didn't find a better wait condition to be used in the place of the repla

[PATCH 1/4] pktgen: Lindent run.

2006-01-29 Thread Luiz Fernando Capitulino
This patch is not in-lined because it's 120K bytes long, you can found it at: http://www.cpu.eti.br/patches/0001-pktgen-Lindent-run.patch -- Luiz Fernando N. Capitulino - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majord

[PATCH 0/4] - pktgen: refinements and small fixes (V2).

2006-01-29 Thread Luiz Fernando Capitulino
Hi! I'm sending again the following patches for pktgen: [PATCH 1/4] pktgen: Lindent run. [PATCH 2/4] pktgen: Ports thread list to Kernel list implementation. [PATCH 3/4] pktgen: Fix kernel_thread() fail leak. [PATCH 4/4] pktgen: Fix Initialization fail leak. The changes from V1 are: 1.

[PATCH 2/5] RT2x00: rt2x00.h

2006-01-29 Thread Ivo van Doorn
Add rt2x00.h header which contains all global defines and structures for the Ralink drivers. Signed-off-by: Ivo van Doorn <[EMAIL PROTECTED]> diff -U 3 -H -w -E -d -r -N -- wireless-2.6/drivers/net/wireless/rt2x00/rt2x00.h wireless-2.6-rt2x00/drivers/net/wireless/rt2x00/rt2x00.h --- wireless-2.

[PATCH 1/5] RT2x00: Makefile + Kconfig

2006-01-29 Thread Ivo van Doorn
Change + add Kconfig & Makefile files to fit the rt2x00 driver into the kernel. Signed-off-by: Ivo van Doorn <[EMAIL PROTECTED]> diff -U 3 -H -w -E -d -r -N -- wireless-2.6/drivers/net/wireless/Kconfig wireless-2.6-rt2x00/drivers/net/wireless/Kconfig --- wireless-2.6/drivers/net/wireless/Kconfig

[PATCH 0/5] RT2x00

2006-01-29 Thread Ivo van Doorn
Hi John, Here is the current code of the rt2x00 project currently containing the drivers for the Ralink devices: rt2400pci, rt2500pci and rt2500usb. rt61 is still in early development, so it is not worth sending those empty files yet. ;) The drivers are not ready for real use yet, since they are

[TEXTSEARCH] Fix broken good shift array calculation in Boyer-Moore

2006-01-29 Thread Pablo Neira Ayuso
Hi Dave, This patch fixes a problem in the Boyer-Moore textsearch strategy. Please apply. -- Pablo [TEXTSEARCH] Fix broken good shift array calculation in Boyer-Moore The current logic does not calculate correctly the good shift array: Let x be the pattern that is being searched. Let y be the b

[PATCH] Add MWI workaround for DC21143

2006-01-29 Thread Peter Horton
This patch works around the MWI bug on the DC21143 rev 65 Tulip by ensuring that the receive buffers don't end on a cache line boundary (as documented in the errata). This patch is required for the MIPs based Cobalt Qube/RaQ as supporting the extra PCI commands seems to reduce the chance of a hard

Re: [Patch 1/6] IPSEC: core updates

2006-01-29 Thread KOVACS Krisztian
Hi, On Saturday 28 January 2006 13:45, jamal wrote: > > > +extern u32 sysctl_xfrm_aevent_etime; > > > +extern u32 sysctl_xfrm_aevent_rseqth; > > > > Why do we need these defaults? I'd rather see these be removed and > > just have the user-space KM always set the values (if it needs > > aevent).

Re: [PATCH] Move meth.o upwards in Makefile since it's built-in and should be eth0

2006-01-29 Thread Stephen Hemminger
On Sat, 28 Jan 2006 20:31:18 -0800 "Ilya A. Volynets-Evenbakh" <[EMAIL PROTECTED]> wrote: > How does one enfrce eth device ordering at run time, when drivers are > compiled in? > Don't depend on the name! Use tools that use the MAC address. Several distro's do that, and you can but logical names

Re: sis900 wake-on-lan code

2006-01-29 Thread Daniele Venzano
Il giorno 29/gen/06, alle ore 20:36, Lennert Buytenhek ha scritto: On Sun, Jan 29, 2006 at 06:54:54PM +0100, Daniele Venzano wrote: + if (wol->wolopts == 0) { + pci_read_config_dword(sis_priv->pci_dev, CFGPMCSR, &cfgpmcsr); + cfgpmcsr |= ~PME_EN; "cfgpmcsr &

Re: [PATCH] sis900: remove cfgpmcsr I/O space register define

2006-01-29 Thread Daniele Venzano
Il giorno 29/gen/06, alle ore 20:33, Lennert Buytenhek ha scritto: sis900 defines 'cfgpmcsr' as an I/O space register, but CFGPMCSR is in fact a config space register, and there is no register at offset 0x44 in I/O space, so delete the enum. Signed-off-by: Lennert Buytenhek <[EMAIL PROTECTED]>

Re: [patch 3/4] net: Percpufy frequently used variables -- proto.sockets_allocated

2006-01-29 Thread Benjamin LaHaise
On Sun, Jan 29, 2006 at 07:54:09AM +0100, Eric Dumazet wrote: > Well, I think that might be doable, maybe RCU magic ? > > 1) local_t are not that nice on all archs. It is for the users that matter, and the hooks are there if someone finds it to be a performance problem. > 2) The consolidation p

Re: sis900 wake-on-lan code

2006-01-29 Thread Lennert Buytenhek
On Sun, Jan 29, 2006 at 06:54:54PM +0100, Daniele Venzano wrote: > >>+/* Power management capabilities bits */ > >>+enum sis900_cfgpmc_register_bits { > >>+ PMVER = 0x0007, > >>+ DSI = 0x0010, > >>+ PMESP = 0xf800 > >>+}; > >>+ > >>+enum sis900_pmesp_bits { > >>+ PME_D0 = 0x1,

Re: sis900 wake-on-lan code

2006-01-29 Thread Lennert Buytenhek
On Sun, Jan 29, 2006 at 06:54:54PM +0100, Daniele Venzano wrote: > >>+ if (wol->wolopts == 0) { > >>+ pci_read_config_dword(sis_priv->pci_dev, CFGPMCSR, > >>&cfgpmcsr); > >>+ cfgpmcsr |= ~PME_EN; > > > >"cfgpmcsr &= ~PME_EN;" ? > > Since cfgpmcsr is initialized as 0 I don'

[PATCH] sis900: remove cfgpmcsr I/O space register define

2006-01-29 Thread Lennert Buytenhek
sis900 defines 'cfgpmcsr' as an I/O space register, but CFGPMCSR is in fact a config space register, and there is no register at offset 0x44 in I/O space, so delete the enum. Signed-off-by: Lennert Buytenhek <[EMAIL PROTECTED]> --- linux-2.6.16-rc1/drivers/net/sis900.h.orig 2006-01-29 20:29:47.0

Re: sis900 wake-on-lan code

2006-01-29 Thread Daniele Venzano
Il giorno 29/gen/06, alle ore 14:16, Lennert Buytenhek ha scritto: I found some fishy-looking things while backporting sis900 wake-on-lan support. + /* Detect Wake on Lan support */ + ret = inl(CFGPMC & PMESP); "ret = (inl(net_dev->base_addr + CFGPMC) & PMESP) >> 27;" ? You're r

Re: sis900 wake-on-lan code

2006-01-29 Thread Daniele Venzano
Il giorno 29/gen/06, alle ore 14:23, Lennert Buytenhek ha scritto: One more thing: I'm still checking the other mail, but this is easier, so I'll just reply first... @@ -33,6 +33,7 @@ enum sis900_registers { rxcfg=0x34, //Receive Configuration Register flctrl=0x38, //Flow Con

[PATH] acxsm: Move WEP code into softmac

2006-01-29 Thread Carlos Martín
Hi, This patch moves the WEP handling code to use the softmac layer and implements acx_e_ieee80211_set_security(), based on the rt2x00 project's one. I do have a couple of questions though: 1) adev->wep_restricted = 0 is the same as an open auth system, and adev->wep_restricted = 1 is the sa

Re: TCP slow start

2006-01-29 Thread Saurabh Jain
I am posting this again. I would really appreciate if somebody can answer this. I am beating myself with no success in getting to the root of this mystery. TCP still stays in slow start even though snd_cwnd >= snd_ssthresh and moves to CA only when there has been a packet loss. Can anybody confirm

Re: sis900 wake-on-lan code

2006-01-29 Thread Lennert Buytenhek
On Sun, Jan 29, 2006 at 02:16:00PM +0100, Lennert Buytenhek wrote: > I found some fishy-looking things while backporting sis900 wake-on-lan > support. One more thing: @@ -33,6 +33,7 @@ enum sis900_registers { rxcfg=0x34, //Receive Configuration Register flctrl=0x38, //Flow Contro

sis900 wake-on-lan code

2006-01-29 Thread Lennert Buytenhek
Hello! I found some fishy-looking things while backporting sis900 wake-on-lan support. > + /* Detect Wake on Lan support */ > + ret = inl(CFGPMC & PMESP); "ret = (inl(net_dev->base_addr + CFGPMC) & PMESP) >> 27;" ? > + if (wol->wolopts == 0) { > + pci_read_config_dwor

Re: [GIT PULL] bcm43xx update

2006-01-29 Thread Michael Buesch
On Friday 27 January 2006 18:42, you wrote: > Please do a > git pull git://bu3sch.de/bcm43xx.git master-upstream > to pull the bcm43xx-softmac branch. > > Please do a > git pull git://bu3sch.de/bcm43xx.git dscape-upstream > to pull the bcm43xx-dscape branch. Did you already pull? I did not see it

Re: the dreaded oom-killer (reproducable in 2.6.11 - 2.6.16-rc1) :(

2006-01-29 Thread mki
On Mon, Jan 23, 2006 at 11:21:57PM -0800, Andrew Morton wrote: > > We have a set of machines that have been usually hanging seconds > > after reporting an oom-killer: gfp_mask=0xd1, order=0. We've tried > > variations of kernels from 2.6.11 through 2.6.16-rc1, with and > > without PAE enabled, all