Re: [PATCH] Change sk_run_filter()'s return type in net/core/filter.c

2006-01-05 Thread Kris Katterjohn
> Whoops! Here you go: Whoops again. Screwed that last patch up. I gotta stop doing this stuff when I'm tired and I need to check myself :) Sorry. Again. --- x/net/core/filter.c 2006-01-05 12:27:17.0 -0600 +++ y/net/core/filter.c 2006-01-05 17:02:32.0 -0600 @@ -75,7 +75,7 @@ stat

Re: [2.6 patch] fix ipvs compilation

2006-01-05 Thread Joe
On 1/5/06, Adrian Bunk <[EMAIL PROTECTED]> wrote: > I don't know which change broke it, but I'm getting the following > compile error in Linus' tree: > > <-- snip --> > > ... > CC net/ipv4/ipvs/ip_vs_sched.o > net/ipv4/ipvs/ip_vs_sched.c: In function 'ip_vs_sched_getbyname': > net/ipv4/ipv

State of the Union: Wireless

2006-01-05 Thread Jeff Garzik
State of the Union - Wireless January 5, 2006 Another banner year has passed, with Linux once again proving its superiority in the area of crappy wireless (WiFi) support. Linux oldsters love the current state of wireless, because it hearkens back to the hea

Re: IPv6 priority in TC filter

2006-01-05 Thread jamal
On Thu, 2006-05-01 at 16:39 -0800, David S. Miller wrote: > From: Devanshu Mehta <[EMAIL PROTECTED]> > Date: Tue, 03 Jan 2006 13:58:09 -0500 > > > From f_u32.c: > > > >if (strcmp(*argv, "priority") == 0) { > >NEXT_ARG(); > >res = parse_u8(&argc, &argv, sel,

Re: [2.6 patch] fix ipvs compilation

2006-01-05 Thread Horms
On Thu, Jan 05, 2006 at 05:08:23PM +0100, Roberto Nibali wrote: > >>Sidenote: At first I was a bit confused as to why this broke since my > >>local copy of IPVS still works. But to be honest, I would like to clean > >>up the IPVS headers in general. I believe we can cut short maybe half of > >>the

Re: [2.6 patch] fix ipvs compilation

2006-01-05 Thread Horms
On Thu, Jan 05, 2006 at 03:34:09PM +0100, Roberto Nibali wrote: > [trimmed recipients a bit] > > >> CC net/ipv4/ipvs/ip_vs_sched.o > >>net/ipv4/ipvs/ip_vs_sched.c: In function 'ip_vs_sched_getbyname': > >>net/ipv4/ipvs/ip_vs_sched.c:110: warning: implicit declaration of > >>function 'local_b

Re: [PATCH] Change sk_run_filter()'s return type in net/core/filter.c

2006-01-05 Thread Kris Katterjohn
From: David S. Miller Sent: 1/5/2006 4:31:32 PM > sk_filter() thinks the return value is an int, and applies that > signed value to skb_trim(), yikes! > > Can you fix that up too and respin your patch? > > Thanks. Whoops! Here you go: --- x/net/core/filter.c 2006-01-05 12:27:17.0 -0600

Re: IPv6 priority in TC filter

2006-01-05 Thread David S. Miller
From: Devanshu Mehta <[EMAIL PROTECTED]> Date: Tue, 03 Jan 2006 13:58:09 -0500 > From f_u32.c: > >if (strcmp(*argv, "priority") == 0) { >NEXT_ARG(); >res = parse_u8(&argc, &argv, sel, 0, 0); >goto done; >} ... > I believe, the code

Re: [PATCH] Change 1500 to ETH_DATA_LEN in some files

2006-01-05 Thread David S. Miller
From: "Kris Katterjohn" <[EMAIL PROTECTED]> Date: Wed, 4 Jan 2006 20:24:10 -0800 > These patches add the header linux/if_ether.h and change 1500 to > ETH_DATA_LEN in some files. > > Signed-off-by: Kris Katterjohn <[EMAIL PROTECTED]> Applied, thanks Kris. - To unsubscribe from this list: send the

Re: [PATCH] Change sk_run_filter()'s return type in net/core/filter.c

2006-01-05 Thread David S. Miller
From: "Kris Katterjohn" <[EMAIL PROTECTED]> Date: Thu, 5 Jan 2006 15:25:13 -0800 > Zero all ready gets returned if an error occurs, and net/packet/af_packet.c > treats the return type as unsigned anyway. For some reason, under the BPF RET > statements, fentry->k and A were cast to unsigned when A

[PATCH] skge: fix dma mask setup.

2006-01-05 Thread Stephen Hemminger
There are a couple of problems in the DMA setup code for skge. * In the 64 bit case, it doesn't set the consistent mask. * In the 32 bit case, the error check is backwards! It likely will only be visible as a bug on 64 bit platforms. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- skge-

[PATCH] Change sk_run_filter()'s return type in net/core/filter.c

2006-01-05 Thread Kris Katterjohn
This changes sk_run_filter()'s return type from int to unsigned. Signed-off-by: Kris Katterjohn <[EMAIL PROTECTED]> Zero all ready gets returned if an error occurs, and net/packet/af_packet.c treats the return type as unsigned anyway. For some reason, under the BPF RET statements, fentry->k and A

[PATCH 3/3] sky2: version 0.12

2006-01-05 Thread Stephen Hemminger
Version update. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- netdev-2.6.orig/drivers/net/sky2.c +++ netdev-2.6/drivers/net/sky2.c @@ -57,7 +57,7 @@ #include "sky2.h" #define DRV_NAME "sky2" -#define DRV_VERSION"0.11" +#define DRV_VERSION"0.12"

[PATCH 0/3] sky2: 0.12 fixes

2006-01-05 Thread Stephen Hemminger
Update to sky2 to fix (ignore previous post) * DMA alignment when CONFIG_DEBUG_SLAB * pci_set_consistent_dma_mask -- - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majo

[PATCH 1/3] sky2: receive buffer alignment

2006-01-05 Thread Stephen Hemminger
Need to make sure that sky2 receive buffers are 64 bit aligned. Also, don't need to start off with GFP_ATOMIC on initial setup. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- netdev-2.6.orig/drivers/net/sky2.c +++ netdev-2.6/drivers/net/sky2.c @@ -75,6 +75,7 @@ #define RX_LE_BYTES

[PATCH 2/3] sky2: need to set_consistent_dma_mask

2006-01-05 Thread Stephen Hemminger
Index: netdev-2.6/drivers/net/sky2.c === --- netdev-2.6.orig/drivers/net/sky2.c +++ netdev-2.6/drivers/net/sky2.c @@ -3054,13 +3054,17 @@ static int __devinit sky2_probe(struct p goto err_out_free_regions; } -

[PATCH 2/3] sky2: call pci_set_consistent_dma_mask

2006-01-05 Thread Stephen Hemminger
Need to call pci_set_consistent_dma_mask in the case of 64 bit DMA. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- netdev-2.6.orig/drivers/net/sky2.c +++ netdev-2.6/drivers/net/sky2.c @@ -3054,13 +3054,17 @@ static int __devinit sky2_probe(struct p goto err_out_free_reg

[PATCH 3/3] sky2: version 0.12

2006-01-05 Thread Stephen Hemminger
Index: netdev-2.6/drivers/net/sky2.c === --- netdev-2.6.orig/drivers/net/sky2.c +++ netdev-2.6/drivers/net/sky2.c @@ -57,7 +57,7 @@ #include "sky2.h" #define DRV_NAME "sky2" -#define DRV_VERSION"0.11" +#de

[PATCH 1/3] sky2: ensure receive buffer alignment

2006-01-05 Thread Stephen Hemminger
Index: netdev-2.6/drivers/net/sky2.c === --- netdev-2.6.orig/drivers/net/sky2.c +++ netdev-2.6/drivers/net/sky2.c @@ -75,6 +75,7 @@ #define RX_LE_BYTES(RX_LE_SIZE*sizeof(struct sky2_rx_le)) #define RX_MAX_PENDING

[RFC: 2.6 patch] drivers/net/wireless/hostap/hostap_main.c shouldn't #include C files

2006-01-05 Thread Adrian Bunk
This patch contains an attempt to properly build hostap.o without #incude'ing C files. Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> --- Now that hostap_main.c renaming is in Linus' tree, this patch applies against Linus' tree. drivers/net/wireless/hostap/Makefile |3 drivers/

[2.6 patch] drivers/net/s2io.c: make code static

2006-01-05 Thread Adrian Bunk
This patch makes some needlessly global code static. Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> --- drivers/net/s2io.c | 22 +++--- drivers/net/s2io.h | 17 +++-- 2 files changed, 18 insertions(+), 21 deletions(-) --- linux-2.6.15-mm1-full/drivers/net/s2io.

Re: [RFC: 2.6 patch] remove drivers/net/eepro100.c

2006-01-05 Thread Lennert Buytenhek
On Thu, Jan 05, 2006 at 01:57:07PM -0500, Jeff Garzik wrote: > >This patch removes the obsolete drivers/net/eepro100.c driver. > > > >Is there any known problem in e100 still preventing us from removing > >this driver (it seems noone was able anymore to verify the ARM problem)? > > Still waiting

Re: [RFC: 2.6 patch] remove drivers/net/eepro100.c

2006-01-05 Thread Jeff Garzik
Adrian Bunk wrote: This patch removes the obsolete drivers/net/eepro100.c driver. Is there any known problem in e100 still preventing us from removing this driver (it seems noone was able anymore to verify the ARM problem)? Still waiting to see if e100 in -mm works on ARM. Jeff -

Re: [2.6 patch] fix ipvs compilation

2006-01-05 Thread Roberto Nibali
Sidenote: At first I was a bit confused as to why this broke since my local copy of IPVS still works. But to be honest, I would like to clean up the IPVS headers in general. I believe we can cut short maybe half of the includes in the various ip_vs* modules. Cool, if nobody beats me to it I'll e

[PATCH] gianfar mii: Use proper resource for MII memory region

2006-01-05 Thread Kumar Gala
We can now have the gianfar mii platform device have a proper resource for the IO memory region for its registers. Previously we passed this information that the platform_data structure because we couldn't handle overlapping memory regions for platform devices. Signed-off-by: Kumar Gala <[EMAIL P

[PATCH] gianfar: Use new PHY_ID_FMT macro

2006-01-05 Thread Kumar Gala
Make the driver produce the string used by phy_connect and have board specific code pass the integer mii bus id and phy device id for the specific controller instance. Signed-off-by: Kumar Gala <[EMAIL PROTECTED]> --- commit 2b67fe22e3c88ad9941c9e9f7b668d0fe661be88 tree 9fb376123d3cf4bc335b98b0f9

[PATCH] gfar: fix compile error

2006-01-05 Thread Kumar Gala
Missing include of to get definition of IPPROTO_UDP. Signed-off-by: Kumar Gala <[EMAIL PROTECTED]> --- commit 1a6720f78a7fb69451983e6b73723b57594ecac1 tree c8772f20a27fd82d28e78c342782297afb35c580 parent 7b5d230825fc228414dce7dc2bfdace4ecea4613 author Kumar Gala <[EMAIL PROTECTED]> Thu, 05 Jan 2

[PATCH] phy: Added a macro to represent the string format used to match a phy device

2006-01-05 Thread Kumar Gala
Add the PHY_ID_FMT macro to ensure that the format of the id string used by a driver to match to its specific phy is consistent between the mdio_bus and the driver. Signed-off-by: Kumar Gala <[EMAIL PROTECTED]> --- commit 470500bb2f548d79e8981e4b1d9841f3d01dd657 tree 45768e543ada5fae24eaa207d031e

Re: [2.6 patch] fix ipvs compilation

2006-01-05 Thread Arnaldo Carvalho de Melo
On 1/5/06, Roberto Nibali <[EMAIL PROTECTED]> wrote: > [trimmed recipients a bit] > > >> CC net/ipv4/ipvs/ip_vs_sched.o > >>net/ipv4/ipvs/ip_vs_sched.c: In function 'ip_vs_sched_getbyname': > >>net/ipv4/ipvs/ip_vs_sched.c:110: warning: implicit declaration of function > >>'local_bh_disable'

Re: [2.6 patch] fix ipvs compilation

2006-01-05 Thread Roberto Nibali
[trimmed recipients a bit] CC net/ipv4/ipvs/ip_vs_sched.o net/ipv4/ipvs/ip_vs_sched.c: In function 'ip_vs_sched_getbyname': net/ipv4/ipvs/ip_vs_sched.c:110: warning: implicit declaration of function 'local_bh_disable' net/ipv4/ipvs/ip_vs_sched.c:124: warning: implicit declaration of funct

Re: [2.6 patch] fix ipvs compilation

2006-01-05 Thread Arnaldo Carvalho de Melo
On 1/5/06, Adrian Bunk <[EMAIL PROTECTED]> wrote: > I don't know which change broke it, but I'm getting the following > compile error in Linus' tree: > > <-- snip --> > > ... > CC net/ipv4/ipvs/ip_vs_sched.o > net/ipv4/ipvs/ip_vs_sched.c: In function 'ip_vs_sched_getbyname': > net/ipv4/ipv

[2.6 patch] fix ipvs compilation

2006-01-05 Thread Adrian Bunk
I don't know which change broke it, but I'm getting the following compile error in Linus' tree: <-- snip --> ... CC net/ipv4/ipvs/ip_vs_sched.o net/ipv4/ipvs/ip_vs_sched.c: In function 'ip_vs_sched_getbyname': net/ipv4/ipvs/ip_vs_sched.c:110: warning: implicit declaration of function '

Re: [PATCH] hostap: allow flashing firmware

2006-01-05 Thread Stefan Rompf
Am Donnerstag 05 Januar 2006 12:27 schrieb Ingo Oeser: > What about doing it in two steps (first RAM then FLASH)? > [...] > Is this possible or too simple to be true? RAM firmware and flash firmware are different files, so if one works, it's no guarantee that the other will, too. Stefan - To un

Re: [PATCH] hostap: allow flashing firmware

2006-01-05 Thread Henrik Brix Andersen
On Wed, Jan 04, 2006 at 09:18:57PM -0800, Jouni Malinen wrote: > I'm not completely against this change, but that scary comment is there > on purpose and it is not fully obsolete. It is still possible to get > HFA3841 cards into state which require hardware modifications to recover > from (i.e., th

Re: [PATCH] hostap: allow flashing firmware

2006-01-05 Thread Ingo Oeser
Jouni Malinen schrieb: > [...] that scary comment is there > on purpose and it is not fully obsolete. It is still possible to get > HFA3841 cards into state which require hardware modifications to recover > from (i.e., they are as good as dead for most users). Taken into this > account, I would pre