Boardcast address should also be detected by is_multicast_ether_addr().
Otherwise is_valid_ether_addr() is broken.
Signed-off-by: Zhu Yi <[EMAIL PROTECTED]>
---
linux-2.6.13-chuyee/include/linux/etherdevice.h |2 +-
1 files changed, 1 insertion(+), 1 deletion(-)
diff -puN include/linux/eth
From: Stephen Hemminger <[EMAIL PROTECTED]>
Date: Mon, 29 Aug 2005 21:38:30 -0700
> Fix build problem found by compiling driver with DEBUG defined that used
> tcp.h.
> Since pr_debug(arg) expands to printk("<7>" arg) the argument
> needs to be string that can be concatenated.
>
> Signed-off-by:
Please pull from 'upstream-fixes' branch of
master.kernel.org:/pub/scm/linux/kernel/git/jgarzik/netdev-2.6.git
to receive the fix described below.
drivers/net/s2io.h |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
commit 7ef24b69f9ff4858d7242059fbb19477c10e6dd7
Author: Andrew
Fix build problem found by compiling driver with DEBUG defined that used tcp.h.
Since pr_debug(arg) expands to printk("<7>" arg) the argument
needs to be string that can be concatenated.
Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]>
Index: sky2-2.6.13/include/net/inet_connection_sock.h
===
It should propagate to the mirrors shortly.
Thanks everyone!
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
On Mon, 29 Aug 2005 16:18:20 -0700
Frank Filz <[EMAIL PROTECTED]> wrote:
> I have been experimenting with loadable protocol modules, and ran into
> several issues with module reference counting.
>
> The first issue was that __module_get failed at the BUG_ON check at the
> top of the routine (chec
From: Ben Greear <[EMAIL PROTECTED]>
Date: Mon, 29 Aug 2005 16:01:11 -0700
> DaveM: Please let me know what you think about including
> this for 2.6.14.
It'll take me a day or so to get back to this as I'm currently
getting net-2.6.14 merged into Linus's tree (some 240+ patches).
-
To unsubscrib
I have been experimenting with loadable protocol modules, and ran into
several issues with module reference counting.
The first issue was that __module_get failed at the BUG_ON check at the
top of the routine (checking that my module reference count was not zero)
when I created the first socket. W
Latest netdevice ref-count debugging patch is up. The
patch is against 2.6.13:
http://www.candelatech.com/oss/rfcnt.patch
DaveM: Please let me know what you think about including
this for 2.6.14. Also, I was thinking we could probably always
compile for this feature but leave it disabled at
Hi,
Alexey and Herbert - thanks for the replies.
Alexey wrote:
> > similar things on a router - it has died 3 or 4 times (over a period
> > of a few months) with such an error with very little traffic passing
> > through it and a stream of the 'dst cache overflow' errors on the screen.
>
> Act
On Sat, 2005-08-27 at 22:38 +0200, Eric Dumazet wrote:
>
> - [TG3] : tx_lock spinlock is taken in tg3_tx() only when really needed.
>
This is similar to your tx_lock patch for tg3 but takes it one step
further to eliminate the tx_lock in the tx_completion path when the tx
queue is not stopped.
David S. Miller wrote:
> You're taking my suggestion way too far.
>
> Just replicate gem_interrupt() inline into gem_poll_controller(),
> removing the irrelevant bits by hand. You shouldn't need to
> modify gem_poll() at all, just as in your original patch.
>
I found that execution would go gem
Eric Lemoine wrote:
> On 8/27/05, Eric Lemoine <[EMAIL PROTECTED]> wrote:
>
>>On 8/27/05, Eric Lemoine <[EMAIL PROTECTED]> wrote:
>>
>>>On 8/26/05, Geoff Levand <[EMAIL PROTECTED]> wrote:
>>>
This fixes a major bug in the Sun GEM Ether
driver's netpoll implementation. When both polled
>>>
From: Ben Greear <[EMAIL PROTECTED]>
Date: Sun, 28 Aug 2005 22:57:38 -0700
> In the meantime, is there any debugging code relating to neighbor
> objects that I can use to help debug this?
Neighbour table entries are held by routing cache entries.
Adding a leak detection layer for neighbour table
On Sun, 28 Aug 2005 10:51:34 -0700
Jouni Malinen <[EMAIL PROTECTED]> wrote:
> Debug variables and procfs dir should be "ieee80211", not "ipw".
>
> Signed-off-by: Jouni Malinen <[EMAIL PROTECTED]>
>
Or better yet use module_param and sysfs to access and not /proc.
-
To unsubscribe from this list
On Wed, 24 Aug 2005 01:14:23 +0200
Francois Romieu <[EMAIL PROTECTED]> wrote:
> Both revisions share the same PCI device ID and vendor ID but revision 2
> of the device uses SysKonnect's chipset whereas revision 3 of the device
> uses Realtek's 8169 chipset.
>
> Credit goes to Christiaan Lutzer <
Jeff Garzik <[EMAIL PROTECTED]> writes:
> Arnaud Patard wrote:
>> Hi,
>> I was testing the sis190 driver and got an oops. Tests show that the
>> error
>> path is the following : sis190_init_one()
>> -> register_netdev
>>* Userspace sees the new interface and run ethtool ethX.
>>* ethtool
Alexey Kuznetsov <[EMAIL PROTECTED]> wrote:
>
> Really bad overflow happens when lots of entries remain in use, because
> someone forgot to release the references to dst cache entries.
> It is the first thing to check.
Yes. I once had a situation where a buggy user-land program held
many sockets
Hello, developers.
Here is simple no-way-zero-copy support for sendfile
for socket <-> socket connections.
It is quite convenient for programmer to not use
recv/sendfile, but sendfile/sendfile instead.
If this way is usefull and should be cleaned up,
I will finish it and probably implement sendp
Hello!
> similar things on a router - it has died 3 or 4 times (over a period
> of a few months) with such an error with very little traffic passing
> through it and a stream of the 'dst cache overflow' errors on the screen.
Actually, it is quite unusual. The problems with garbage collection
are
Ben Greear wrote:
I was able to reproduce a reference leak with my instrumented code
(plus my regular set of network patches, so problem could still be me).
The reference lost was acquired here:
struct neighbour *neigh_create(struct neigh_table *tbl, const void *pkey,
struct
21 matches
Mail list logo
