Jouni Malinen wrote:
These patches are the not yet applied patches 8 and 9 from the previous
set. Old patch 8 was split into two and rediffed (ipw2200.c had
changed). The new patch 1 is for ieee80211 branch of netdev-2.6 and
patch 2 for ieee80211-wifi. These two need to be applied at the same
tim
Remove backwards compatibility define for WLAN_CAPABILITY_ESS now that
net/ieee80211.h defines this.
Signed-off-by: Jouni Malinen <[EMAIL PROTECTED]>
Index: netdev-2.6/drivers/net/wireless/hostap/hostap_common.h
===
--- netdev-2.6.or
Replace remaining WLAN_FC_* defines with the ones used in ieee80211
header file. This completes the move from hostap version of frame
control field processing to ieee80211 version.
Signed-off-by: Jouni Malinen <[EMAIL PROTECTED]>
Index: netdev-2.6/drivers/net/wireless/hostap/hostap_common.h
=
IEEE 802.11 has a capability field flag called ESS, but ieee80211 had
renamed this to BSS for some reason. hostap has been using
WLAN_CAPABILITY_ESS and since that matches with the standard, lets use
it as the name for this define. Add WLAN_CAPABILITY_BSS as a backwards
compatibility name for the s
These patches are the not yet applied patches 8 and 9 from the previous
set. Old patch 8 was split into two and rediffed (ipw2200.c had
changed). The new patch 1 is for ieee80211 branch of netdev-2.6 and
patch 2 for ieee80211-wifi. These two need to be applied at the same
time. Patch 3 is otherwise
Jouni Malinen wrote:
This set of patches merges a bug fix for the Host AP driver (patch 1),
does some cleanup for different hardware models (patches 2-3), continues
conversion to generic ieee80211 code (patches 4-6), and tests how we can
handle changes that have a dependency to modify ieee80211 a
From: Patrick McHardy <[EMAIL PROTECTED]>
Date: Mon, 15 Aug 2005 02:33:30 +0200
> [NETLINK]: Support dynamic number of multicast groups per netlink family
>
> Signed-off-by: Patrick McHardy <[EMAIL PROTECTED]>
I applied patches 1 -> 7, but I had to stop after that.
This patch here will break ne
Replace temporary HOSTAP_FC_GET_{TYPE,STYPE} macros with the ieee80211
version of WLAN_FC_GET_{TYPE,STYPE}.
Signed-off-by: Jouni Malinen <[EMAIL PROTECTED]>
Index: netdev-2.6/drivers/net/wireless/hostap/hostap.c
===
--- netdev-2.6.or
IEEE 802.11 has a capability field flag called ESS, but ieee80211 had
renamed this to BSS for some reason. hostap has been using
WLAN_CAPABILITY_ESS and since that matches with the standard, lets use
it as the name for this define. Add WLAN_CAPABILITY_BSS as a backwards
compatibility name for the s
Replace hostap-specific struct hostap_ieee80211_hdr with struct
ieee80211_hdr from net/ieee80211.h.
Signed-off-by: Jouni Malinen <[EMAIL PROTECTED]>
Index: netdev-2.6/drivers/net/wireless/hostap/hostap_80211.h
===
--- netdev-2.6.orig
Remove unused defines that are already available from generic kernel
header files.
Signed-off-by: Jouni Malinen <[EMAIL PROTECTED]>
Index: netdev-2.6/drivers/net/wireless/hostap/hostap_wlan.h
===
--- netdev-2.6.orig/drivers/net/wirel
Old AP mode code for power saving was using skb->cb for couple of
flags before the more generic 802.11 TX code started using the same
buffer for struct hostap_skb_tx_data. This resulted in the power save
code corrupting the magic value in beginning of the buffer and TX code
dropping the power saved
Replace remaining WLAN_FC_* defines with the ones used in ieee80211
header file. This completes the move from hostap version of frame
control field processing to ieee80211 version.
Signed-off-by: Jouni Malinen <[EMAIL PROTECTED]>
Index: netdev-2.6/drivers/net/wireless/hostap/hostap_common.h
=
PCI version of Prism2.5/3 has undocumented DMA support for TX/RX data,
but this seems to have some hardware bugs that prevent it from being
used properly for TX. RX side could possibly be made to work reliably.
Even though DMA support would be very useful for saving host CPU (from
about 40% to 5-1
This set of patches merges a bug fix for the Host AP driver (patch 1),
does some cleanup for different hardware models (patches 2-3), continues
conversion to generic ieee80211 code (patches 4-6), and tests how we can
handle changes that have a dependency to modify ieee80211 and hostap
at the same t
IEEE 802.11 frame control has two bits reserved for protocol
version. IEEE80211_FCTL_VERS was not used anywhere, but I would assume
it was supposed to be a mask for the protocol field and as such, it
should be 0x0003, not 0x0002. This matches with WLAN_FC_PVER
definition in hostap.
Signed-off-by:
Replace hardware model specific #ifdef's in struct local_info with
void *hw_priv that is pointing to cs/pci/plx specific data
structure. This removes unneeded #ifdef's and as such, is a step
towards making it possible to share objects for hostap_hw.c and
hostap_download.c with cs/pci/plx drivers wi
From: Herbert Xu <[EMAIL PROTECTED]>
Date: Mon, 15 Aug 2005 10:42:44 +1000
> Well I don't think I understand the new skb->user solution yet :)
>
> For a start, skb->users will prevent the skb->data area from being
> freed as well as the skb itself. We'll also need to audit the TCP
> code paths t
On Sun, Aug 14, 2005 at 05:16:58PM -0700, David S. Miller wrote:
>
> I think the atomic operation will still be cheaper than these
> two function calls. Even though the second one will be "cheap"
> we could be completely done with just one call and not even pay
> the reduced price of the second a
[NETLINK]: Add "groups" argument to netlink_kernel_create
Signed-off-by: Patrick McHardy <[EMAIL PROTECTED]>
---
commit 54c15156b46007c036c80f3df7e5202348b47ff6
tree fc1980ec428fc1d95dca654ab7add443c738f655
parent 8880eca333ef74bc4662f9b1a8b43b4e97135876
author Patrick McHardy <[EMAIL PROTECTED]
[NETLINK]: Add set/getsockopt options to support more than 32 groups
NETLINK_ADD_MEMBERSHIP/NETLINK_DROP_MEMBERSHIP are used to join/leave
groups, NETLINK_PKTINFO is used to enable nl_pktinfo control messages
for received packets to get the extended destination group number.
Signed-off-by: Patri
[NETLINK]: Support dynamic number of multicast groups per netlink family
Signed-off-by: Patrick McHardy <[EMAIL PROTECTED]>
---
commit 68bcf4640f376652194969a64317e13c35371bfc
tree a131b8cd33df58e4679f69b0a50852d4b8ba3120
parent 159b54716bcf5aea4c3141a64072613db7934e11
author Patrick McHardy <[E
[NETLINK]: Return -EPROTONOSUPPORT in netlink_create() if no kernel socket is registered
This is necessary for dynamic number of netlink groups to make sure we know
the number of possible groups before bind() is called. With this change pure
userspace communication using unused netlink protocols
[NETLINK]: Convert netlink users to use group numbers instead of bitmasks
Signed-off-by: Patrick McHardy <[EMAIL PROTECTED]>
---
commit b96b2df4048e0b5fbfc9979d5a5fbcb200211b43
tree 16bd808aaa1a4d1abe7b66715dada313423abdcb
parent ea41e53e0de17bc1079aab5f5342485532473f19
author Patrick McHardy <[
[NETLINK]: Use group numbers instead of bitmasks internally
Using the group number allows increasing the number of groups without
beeing limited by the size of the bitmask. It introduces one limitation
for netlink users: messages can't be broadcasted to multiple groups anymore,
however this featu
[NETLINK]: Fix module refcounting problems
Use-after-free: the struct proto_ops containing the module pointer
is freed when a socket with pid=0 is released, which besides for kernel
sockets is true for all unbound sockets.
Module refcount leak: when the kernel socket is closed before all user
so
[NETLINK]: Remove unused groups member from struct netlink_skb_parms
Signed-off-by: Patrick McHardy <[EMAIL PROTECTED]>
---
commit cac8b0e31deb55b3839460d8d64a48b3d24ea3d9
tree 706a5b6ecec93a86713e9baf7f36043f363686ab
parent 653290b7c92c670ededb396042792b17390942ae
author Patrick McHardy <[EMAIL
[NETLINK]: Fix missing dst_groups initializations in netlink_broadcast users
netlink_broadcast users must initialize NETLINK_CB(skb).dst_groups to the
destination group mask for netlink_recvmsg.
Signed-off-by: Patrick McHardy <[EMAIL PROTECTED]>
---
commit 653290b7c92c670ededb396042792b17390942
[NETLINK]: w1_int.c: fix default netlink group
w1 does not need to multicast its state to several groups at once,
and upcoming netlink changes will not allow bitmask for groups anyway.
Signed-off-by: Evgeniy Polyakov <[EMAIL PROTECTED]>
Signed-off-by: Patrick McHardy <[EMAIL PROTECTED]>
---
com
I discovered a couple of problems in the last patchset, so here is an
updated one. Changes since last posting:
- resolve conflicts with socket monitoring changes
- include selinux in changes, has been missed before
- fix failed BUG_TRAP caused by one of the patches
- include w1 bugfix to dst_grou
From: Patrick McHardy <[EMAIL PROTECTED]>
Date: Sun, 14 Aug 2005 23:23:32 +0200
> [NET]: Store skb->timestamp as offset to a base timestamp
>
> Reduces skb size by 8 bytes.
>
> Signed-off-by: Patrick McHardy <[EMAIL PROTECTED]>
Updated patch applied, thanks Patrick.
-
To unsubscribe from this l
From: Herbert Xu <[EMAIL PROTECTED]>
Date: Mon, 15 Aug 2005 09:52:51 +1000
> 1) When you allocate for fast clones you do two kmem_cache_alloc's
> in a row. You store the second pointer in the shared skb data area.
>
> The fast path within kmem_cache_alloc is good enough that the second
> one sho
From: Thomas Graf <[EMAIL PROTECTED]>
Date: Sun, 14 Aug 2005 02:31:30 +0200
> The disadvantage is that we cannot do "clone resycling" easly
> anymore, that is we allow a fast-clone'able skb to be cloned
> up again if the clone portion was already freed.
I do not see much value in that capability
On Sun, Aug 14, 2005 at 05:02:37PM -0700, David S. Miller wrote:
> Bringing an interface down does not disassosciate the IP addresses
> confiured to that interface from the system.
Yes, but I am not sure if that is the case here, we need more input from the
reporter. It looked more like the down i
From: Bernd Eckenfels <[EMAIL PROTECTED]>
Date: Sun, 14 Aug 2005 19:51:39 +0200
> I have this error report on ifconfig (also a problem with ip link) that a
> down interface receives packets. I remeber this was discussed before but
> cannot find a result of the outcome. Is this a driver problem?
B
Em Sun, Aug 14, 2005 at 07:11:46PM +0200, Patrick McHardy escreveu:
> gcc-4.0.1 (new debian default) emits a couple of warnings in
> the dccp code, this patch silences them.
>
> [DCCP]: Fix compiler warnings
Thanks Patrick, I'm applying this to the dccp-2.6.14.git tree.
- Arnaldo
-
To unsubscri
On Sat, Aug 13, 2005 at 02:10:55PM -0700, David S. Miller wrote:
> Yes, you need an atomic in the fast path, but it's only done
> for fast clones and their parent SKBs, and such an atomic is
> _MUCH_ cheaper than a kmem_cache_alloc especially since it
> touches more cache local state (the atomic co
Evgeniy's patch fixed to apply on top of my netlink changes.
[NETLINK]: w1_int.c: fix default netlink group
w1 does not need to multicast its state to several groups at once,
and upcoming netlink changes will not allow bitmask for groups anyway.
Signed-off-by: Evgeniy Polyakov <[EMAIL PROTECTED]
Fix minor fallout from patch 6/8.
[NETLINK]: Fixed failed BUG_TRAP
I forgot to set groups to NULL after freeing it:
KERNEL: assertion (!nlk_sk(sk)->groups) failed at net/netlink/af_netlink.c (146)
Signed-off-by: Patrick McHardy <[EMAIL PROTECTED]>
---
commit 1018286a3c3542c9926e287811a24bf85e1
Evgeniy Polyakov wrote:
> You've done a good job, thanks Patrick.
>
> One small comment after diagonal patchset review -
> last patch will fail to apply on top of w1 changes :)
> since it already has a group changes to 1.
The w1 changes don't seem to be in mainline yet. I'm going to fix
up your
Ben Greear wrote:
> Patrick McHardy wrote:
>>
>> +static inline void skb_get_timestamp(struct sk_buff *skb, struct
>> timeval *stamp)
>> +{
>> +stamp->tv_sec = skb->tstamp.off_sec;
>> +stamp->tv_usec = skb->tstamp.off_usec;
>> +if (skb->tstamp.off_sec) {
>> +stamp->tv_sec +=
Mitchell Blank Jr wrote:
> Patrick McHardy wrote:
>
>>-static inline const int before48(const u64 seq1, const u64 seq2)
>>+static inline int before48(const u64 seq1, const u64 seq2)
>
> Perhaps "__attribute__ ((const))" is what was meant here?
Doesn't matter for inline functions, the compiler k
Patrick McHardy wrote:
> -static inline const int before48(const u64 seq1, const u64 seq2)
> +static inline int before48(const u64 seq1, const u64 seq2)
Perhaps "__attribute__ ((const))" is what was meant here?
-Mitch
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the bod
(rediff with license on include/linux/if_ppp.h untouched, and I had
named the new flag SC_MUST_COMP not SC_MUST_COMPRESS)
PPP 2.4.3 patch creates the new flag SC_MUST_COMP. This is set on
CCP UP with MPPE enabled, and never cleared. The kernel uses this
flag to drop packets which aren't compress
On Sun, Aug 14, 2005 at 04:31:47PM +0200, Patrick McHardy wrote:
> Patrick McHardy wrote:
> > Matt Domsch wrote:
> >
> >> include/linux/if_ppp.h | 62
> >> +
> >
> >
> > - * 2. Redistributions in binary form must reproduce the above copyright
> >
Hello,
I have this error report on ifconfig (also a problem with ip link) that a
down interface receives packets. I remeber this was discussed before but
cannot find a result of the outcome. Is this a driver problem?
http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=322654
Bernd
--
(OO) --
Patrick McHardy wrote:
David S. Miller wrote:
I just double-checked, and I didn't lose it during the
recent rebasing, as the tree I started with didn't have
the skb->stamp patch either.
Are you sure I did apply it at some point?
Yes, I know it was in your tree before the first rebasing.
E
gcc-4.0.1 (new debian default) emits a couple of warnings in
the dccp code, this patch silences them.
[DCCP]: Fix compiler warnings
may be a false warning if there always is something on ccid3hcrx_hist:
net/dccp/ccids/ccid3.c: In function 'ccid3_hc_rx_packet_recv':
net/dccp/ccids/ccid3.c:1634:
On Sat, Aug 13, 2005 at 02:35:53AM +0200, Patrick McHardy ([EMAIL PROTECTED])
wrote:
> Hi,
>
> besides a small bugfix, this patchset adds support for dynamic number
> of groups to netlink. To support an arbitary number of groups a couple
> of changes had to me made, I'll explain them below. The p
David S. Miller wrote:
I just double-checked, and I didn't lose it during the
recent rebasing, as the tree I started with didn't have
the skb->stamp patch either.
Are you sure I did apply it at some point?
Yes, I know it was in your tree before the first rebasing.
Either way, please resend i
Thanks for the comments.
I'll be mostly on vacation (moving) this week, so I will be getting back
to you after Aug 22.
Regards,
Trent.
Trent Jaeger
IBM T.J. Watson Research Center
19 Skyline Drive, Hawthorne, NY 10532
(914) 784-7225, F
Patrick McHardy wrote:
> Matt Domsch wrote:
>
>> include/linux/if_ppp.h | 62
>> +
>
>
> - * 2. Redistributions in binary form must reproduce the above copyright
> - *notice, this list of conditions and the following disclaimer in
> - *th
Matt Domsch wrote:
> include/linux/if_ppp.h | 62
> +
- * 2. Redistributions in binary form must reproduce the above copyright
- *notice, this list of conditions and the following disclaimer in
- *the documentation and/or other materials p
PPP 2.4.3 patch creates the new flag SC_MUST_COMPRESS. This is set on
CCP UP with MPPE enabled, and never cleared. The kernel uses this
flag to drop packets which aren't compressed/decompressed properly
when MPPE is enabled.
In the existing code, on SIGUSR2, CCP is renegotiated, and with MPPE
en
This patch implements the Microsoft Point-to-Point Tunnelling Protocol
kernel module, with minor changes to ppp_generic to have it drop
packets if they are not compressed/decompressed properly. This adds a
new ppp flag SC_MUST_COMPRESS which will be set by pppd upon CCP UP
with MPPE enabled.
dr
On Fri, Jul 08, 2005 at 09:42:21PM +1000, Paul Mackerras wrote:
> Some comments on the MPPE kernel patch (sorry it's taken me so long):
Likewise, my apologies for the delay in implementing your
suggestions. I do really appreciate your feedback.
> > +static inline struct sk_buff *
> > +pad_comp
Thomas Graf wrote:
> * Patrick McHardy <[EMAIL PROTECTED]> 2005-08-13 02:36
>
>>[NETLINK]: Support dynamic number of multicast groups per netlink family
>>
>>Signed-off-by: Patrick McHardy <[EMAIL PROTECTED]>
>>
>>- if ((err = __netlink_create(sock, protocol) < 0))
>>+ nlk->groups = kmallo
57 matches
Mail list logo
