Some initial comments:
- you should include a description of each patch in the message
- you should use more descriptive subjects, eg
[PATCH 1/8] atheros: Kconfig bits
--
Mathematics is the supreme nostalgia of our time.
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the
I accidentaly posted the patches as MIME attachments... its 5:03 am here
already. Sorry guys.
I can resubmit if you want. I just dont want do that now and not trash
your mailboxes
Mateusz
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROT
diff -uprN -X 'netdev-2.6.git#ieee80211/Documentation/dontdiff' netdev-2.6.git#ieee80211/drivers/net/wireless/atheros/atheros5212/other.c netdev-atheros/drivers/net/wireless/atheros/atheros5212/other.c
--- netdev-2.6.git#ieee80211/drivers/net/wireless/atheros/atheros5212/other.c 1970-01-01 01:00:
diff -uprN -X 'netdev-2.6.git#ieee80211/Documentation/dontdiff' netdev-2.6.git#ieee80211/drivers/net/wireless/atheros/atheros5212/keys.c netdev-atheros/drivers/net/wireless/atheros/atheros5212/keys.c
--- netdev-2.6.git#ieee80211/drivers/net/wireless/atheros/atheros5212/keys.c 1970-01-01 01:00:00.
diff -uprN -X 'netdev-2.6.git#ieee80211/Documentation/dontdiff' netdev-2.6.git#ieee80211/drivers/net/wireless/atheros/atheros5212/ioctl.c netdev-atheros/drivers/net/wireless/atheros/atheros5212/ioctl.c
--- netdev-2.6.git#ieee80211/drivers/net/wireless/atheros/atheros5212/ioctl.c 1970-01-01 01:00:
diff -uprN -X 'netdev-2.6.git#ieee80211/Documentation/dontdiff' netdev-2.6.git#ieee80211/drivers/net/wireless/atheros/atheros5212/init.c netdev-atheros/drivers/net/wireless/atheros/atheros5212/init.c
--- netdev-2.6.git#ieee80211/drivers/net/wireless/atheros/atheros5212/init.c 1970-01-01 01:00:00.
diff -uprN -X 'netdev-2.6.git#ieee80211/Documentation/dontdiff' netdev-2.6.git#ieee80211/drivers/net/wireless/atheros/atheros5212/beacons.c netdev-atheros/drivers/net/wireless/atheros/atheros5212/beacons.c
--- netdev-2.6.git#ieee80211/drivers/net/wireless/atheros/atheros5212/beacons.c 1970-01-01
--- netdev-2.6.git#ieee80211/drivers/net/wireless/Kconfig 2005-08-02 13:18:21.0 +0200
+++ netdev-atheros/drivers/net/wireless/Kconfig 2005-08-05 03:43:32.0 +0200
@@ -459,6 +459,14 @@ config PRISM54
say M here and read . The module
will be called prism54.ko.
+comment "At
Hi list members,
I just post the code for review for anyone interested.
I would be more than pleased to hear some feedback from you on the code.
Im sending a series of 8 patches splitted and diffed as in
SubmittingPatches documentation.
The driver is not yet fully working because I didn't fin
linux 2.6.12.3
net/ipv4/fib_semantics.c:line 679
if (fib_info_cnt >= fib_hash_size) {
unsigned int new_size = fib_hash_size << 1;
struct hlist_head *new_info_hash;
struct hlist_head *new_laddrhash;
unsigned int bytes;
Herbert Xu <[EMAIL PROTECTED]> wrote:
>
> On Thu, Aug 04, 2005 at 04:58:42PM -0700, Andrew Morton wrote:
> >
> > Thanks, Guillaume. Herbert, David is travelling and not able to do a lot
> > of patchmonkeying. Could you please prepare and submit a final patch?
>
> OK, here is the final versi
On Sun, 31 Jul 2005, Herbert Xu wrote:
>
> Anyway, here is a patch to use inetpeer instead of that icky ipc
> structure.? It sure cuts down the size of the patch :)
>
Herbert;
I've been using the updated patch, and I like it. struct inet_peer
is the right place to do this accounting.
I m
On Thu, Aug 04, 2005 at 04:58:42PM -0700, Andrew Morton wrote:
>
> Thanks, Guillaume. Herbert, David is travelling and not able to do a lot
> of patchmonkeying. Could you please prepare and submit a final patch?
OK, here is the final version. It depends on the patch that David
posted earlier o
Guillaume Pelat <[EMAIL PROTECTED]> wrote:
>
> Hi,
>
> Herbert Xu wrote:
> > On Thu, Aug 04, 2005 at 01:33:29PM +1000, herbert wrote:
> >
> >>So I suppose we should reset cwnd_quota after tcp_transmit_skb?
> >
> > Please try this patch to see if this is really the problem or not.
> >
> > Thanks
On Thu, Aug 04, 2005 at 06:49:46AM -0700, David S. Miller wrote:
> From: Harald Welte <[EMAIL PROTECTED]>
> Date: Thu, 4 Aug 2005 00:03:53 +0200
>
> > However, all nfnetlink-based protocols are supposed to be both endian
> > and 32/64 as well as alignment (*) safe. the protocol definitions
> > a
> Unless I'm overlooking something, to the best of my knowledge I don't
> think we could still run into any trouble here.
Still risky.
Here's a different idea. Define a new aligned u64 type and use that
on i386 too.
Like
/* Must be #define because __attribute__ doesn't work on typedefs */
#defi
On Thu, Aug 04, 2005 at 06:50:42AM -0700, David S. Miller wrote:
> From: Andi Kleen <[EMAIL PROTECTED]>
> Subject: Re: [PATCH] add new nfnetlink_log subsystem
> Date: Thu, 4 Aug 2005 00:19:41 +0200
>
> > > no, it hasn't. I am travelling and don't have the space for a
> > > debian/i386 installatio
Whoops:
- return __dev_alloc_skb(length, gfp_mask | __GFP_MEMALLOC);
+ return __dev_alloc_skb(length, GFP_ATOMIC|__GFP_MEMALLOC);
Regards,
Daniel
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at
Hi,
I spent the last day mulling things over and doing research. It seems to me
that the patch as first posted is correct and solves the deadlock, except
that some uses of __GFP_MEMALLOC in __dev_alloc_skb may escape into contexts
where the reserve is not guaranteed to be reclaimed. It may be
Jeff Garzik wrote:
Nothing in that tree has changed the b44 driver...
Ok, so I will try to find out what has changed as soon as I have some
more time
also please ignore forwarded e-mail. I just updated the netdev list address.
Mateusz
-
To unsubscribe from this list: send the line
On Thu, Aug 04, 2005 at 06:48:18AM -0700, David S. Miller wrote:
>
> When you add an SA, you have to place it somewhere, don't you?
> And that "where" (be it one policy template, or many) are
> what you use to decide which policy for which to do the DST
> flush.
Unfortunately, it goes straight in
On Wed, Aug 03, 2005 at 08:53:52PM -0400, Mathieu Chouquet-Stringer wrote:
>
> Moreover I get some weird networking problems which prevent setting up the
> routes (RNETLINK invalid argument messages) when I compile my kernel with
> 4.0.1 while the same kernel, same config works fine compiled with
On Thu, 2005-08-04 at 18:27 +0200, Zoran Dzelajlija wrote:
> I can't get jumbo frames to work for tg3 under 2.6.12.2
> or 2.6.11.7 (no patches added):
>
The 5721 does not support jumbo frames, only 1500 MTU frames.
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body
> -Original Message-
> From: David S. Miller [mailto:[EMAIL PROTECTED]
> Sent: Thursday, August 04, 2005 6:52 AM
> To: Leonid Grossman
> Cc: netdev@vger.kernel.org
> Subject: Re: Super TSO performance drop
>
> From: "Leonid Grossman" <[EMAIL PROTECTED]>
> Date: Wed, 3 Aug 2005 21:07:56
Hi,
I can't get jumbo frames to work for tg3 under 2.6.12.2
or 2.6.11.7 (no patches added):
filestore# ip link set eth1 mtu 9000
SIOCSIFMTU: Invalid argument
filestore# ifconfig eth1 mtu 9000
SIOCSIFMTU: Invalid argument
I've also tried disabling the vlan devices, or setting them first, but no
(resend to netdev@vger.kernel.org, previous email went to [EMAIL PROTECTED])
Hi,
This patch:
- fixes misc. whitespace/comments
- replaces u16 with __le16/__be16 where appropriate
Signed-off-by: Michael Wu <[EMAIL PROTECTED]>
diff --git a/include/net/ieee80211.h b/include/net/ieee80211.h
--- a/i
Hi,
Herbert Xu wrote:
On Thu, Aug 04, 2005 at 01:33:29PM +1000, herbert wrote:
So I suppose we should reset cwnd_quota after tcp_transmit_skb?
Please try this patch to see if this is really the problem or not.
Thanks,
I just applied your patch, and it seems to work :)
2 hours uptime, and
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
KOVACS Krisztian wrote:
> Ulrich, I already have some code which supports per-state
> difference settings, along with optional time limits. I don't know
> whether or not the latter would be necessary or not, but putting
> the per-state diff values wou
Hi,
2005-08-04, cs keltezéssel 12.56-kor Ulrich Weber ezt írta:
> thanks for revising Patrick! Attached is the updated patch.
> Sorry had no time yet to remove the sysctl variables.
> It will follow in a few weeks if I have more time :)
Ulrich, I already have some code which supports per-sta
On Thu, Aug 04, 2005 at 06:49:46AM -0700, David S. Miller wrote:
> From: Harald Welte <[EMAIL PROTECTED]>
> Date: Thu, 4 Aug 2005 00:03:53 +0200
>
> > However, all nfnetlink-based protocols are supposed to be both endian
> > and 32/64 as well as alignment (*) safe. the protocol definitions
> > a
From: "Leonid Grossman" <[EMAIL PROTECTED]>
Date: Wed, 3 Aug 2005 21:07:56 -0400
> We can either provide a remote to the setup, or test incremental patches
> if #16 can be broken in smaller pieces.
I think it would be more productive for you to work on trying
to figure out what about the packet p
Pierre Ossman wrote:
> I'm having problem with the interrupt getting killed after suspend with
> my 8139cp controller. The problem only appears if the cable is connected
> during resume (before suspend is irrelevant) and the interface is down.
>
> Both suspend-to-disk and suspend-to-ram exhibit th
From: Herbert Xu <[EMAIL PROTECTED]>
Date: Thu, 4 Aug 2005 07:32:15 +1000
> On Wed, Aug 03, 2005 at 06:34:38AM -0700, David S. Miller wrote:
> > Therefore, when any SA is added, the assosciated policy is the
> > one for which we flush all matching DST entries.
>
> How do you find the associated p
From: Andi Kleen <[EMAIL PROTECTED]>
Subject: Re: [PATCH] add new nfnetlink_log subsystem
Date: Thu, 4 Aug 2005 00:19:41 +0200
> > no, it hasn't. I am travelling and don't have the space for a
> > debian/i386 installation in addition to the debian/x86_64 on this box,
> > sorry :(
>
> That sounds
From: Harald Welte <[EMAIL PROTECTED]>
Date: Thu, 4 Aug 2005 00:03:53 +0200
> However, all nfnetlink-based protocols are supposed to be both endian
> and 32/64 as well as alignment (*) safe. the protocol definitions
> always use u_intXX_t types, all network byte order, and no kernel pointers
> p
John W. Linville wrote:
>On Mon, Jul 04, 2005 at 12:22:53AM +0200, Pierre Ossman wrote:
>
>
>>After suspend the driver needs to retest link status in case the cable
>>has been inserted or removed during the suspend.
>>
>>Signed-off-by: Pierre Ossman <[EMAIL PROTECTED]>
>>
>>
>
>Please copy n
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
Hi All,
thanks for revising Patrick! Attached is the updated patch.
Sorry had no time yet to remove the sysctl variables.
It will follow in a few weeks if I have more time :)
Best regards
Ulrich
-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.1 (
On Thu, Aug 04, 2005 at 01:33:29PM +1000, herbert wrote:
>
> So I suppose we should reset cwnd_quota after tcp_transmit_skb?
Please try this patch to see if this is really the problem or not.
Thanks,
--
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <[EMAIL PROTECTED]>
Stephen Hemminger writes:
> Convert FIB Trie to use RCU for the normal lookup fast
> path. Use simple spin_lock for updates and dump access.
Hello!
Yes spent some days to get a complete RCU for the trie. Discussed with
Patrick at OLS. This includes your start and also RCU versions of fib
Hello,
Could someone please help me out on this. I am desperately looking out
for
a solution.
Thanks,
Partha
x3025
-Original Message-
From: Partha Chatterjee
Sent: Tuesday, August 02, 2005 5:50 PM
To: Partha Chatterjee; netdev@vger.kernel.org
Subject: RE: ARP entry ageing time
Hello,
40 matches
Mail list logo
