On Fri, Jul 22, 2005 at 04:57:13PM -0700, David S. Miller wrote:
>
> Ok, I rebased the net-2.6.14 GIT tree based upon the
> current net-2.6 tree. It may take a few hours for this
> rebasing to hit the kernel.org mirror system, so please
> be patient :)
>
> You'll have to be careful when resyncin
[NET]: Reduce tc_index/tc_verd to u16
Signed-off-by: Patrick McHardy <[EMAIL PROTECTED]>
---
commit 97d4e0b5dc8578e9839dae473c61c82760a15a29
tree 47f9c319d51825b4afba489bbf9edf50ae72ed5e
parent 5bfc21c2a7b496ae6e4ca9efe9f69f9a14770ff5
author Patrick McHardy <[EMAIL PROTECTED]> Sat, 23 Jul 2005 0
Thomas Graf wrote:
* Patrick McHardy <[EMAIL PROTECTED]> 2005-07-23 06:39
I'm trying to convert tc_index to a u16, which looks OK in all places
but sched_gred. I can't make sense of this code:
/* fix tc_index? --could be controvesial but needed for
requeueing */
skb->tc
* Patrick McHardy <[EMAIL PROTECTED]> 2005-07-23 06:39
> I'm trying to convert tc_index to a u16, which looks OK in all places
> but sched_gred. I can't make sense of this code:
>
> /* fix tc_index? --could be controvesial but needed for
>requeueing */
> skb->tc_index=(
Hi Jamal,
I'm trying to convert tc_index to a u16, which looks OK in all places
but sched_gred. I can't make sense of this code:
/* fix tc_index? --could be controvesial but needed for
requeueing */
skb->tc_index=(skb->tc_index&0xfff0) | t->def;
Why is a mask of 0
Hi David,
> > I found the problem. The hci_usb is using the cb[] by itself and so
> > overwriting the pkt_type value. The attached patch works for me with the
> > hci_usb driver. However I haven't converted all other drivers and
> > checked them. This won't happen until I am back home, because I d
In article <[EMAIL PROTECTED]> (at Thu, 21 Jul 2005 21:44:43 +0100), Andrew
McDonald <[EMAIL PROTECTED]> says:
> I guess the fix would be a matter of changing:
>
> if (sk && ra->sel == sel) {
>
> to:
>
> if (sk && ra->sel == sel &&
> (!sk->sk_bound_dev_if ||
> sk->sk_bound_dev_if == s
Ok, I rebased the net-2.6.14 GIT tree based upon the
current net-2.6 tree. It may take a few hours for this
rebasing to hit the kernel.org mirror system, so please
be patient :)
You'll have to be careful when resyncing to this thing
since all the changesets were redone. I would recommend
pullin
Increase driver version to 0.8
Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]>
Index: skge-netdev/drivers/net/skge.c
===
--- skge-netdev.orig/drivers/net/skge.c
+++ skge-netdev/drivers/net/skge.c
@@ -42,7 +42,7 @@
#include "skg
The code to clear fifo errors was incorrect and sending garbage
to the external phy. Removed the no longer used inline's funcs.
Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]>
Index: skge-netdev/drivers/net/skge.c
===
--- skge-n
Using Genesis board, I get harmless error reports. Rather than console
error, turn it into a error counter.
Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]>
Index: skge-netdev/drivers/net/skge.c
===
--- skge-netdev.orig/drivers/n
Cleanup the phy_lock deadlock because of relocking in the nway_reset path.
Reported by Francois Romieu.
Also, don't need to do irqsave/restore for blink,
just excluding bh is good enough.
Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]>
Index: skge-netdev/drivers/net/skge.c
The check for Yukon lite changes was restricting itself to
rev A3. It turns out that these changes are also true on A4
and later.
Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]>
Index: skge-netdev/drivers/net/skge.c
===
--- skge
During autonegotiation set PHY interrupt mask to ignore
bogus speed change interrupts.
Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]>
Index: skge-netdev/drivers/net/skge.c
===
--- skge-netdev.orig/drivers/net/skge.c
+++ skge-ne
Cleanup code that is used to toggle LED's. Since we
get called from ethtool, can use that thread rather than
setting up a timer.
Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]>
Index: skge-netdev/drivers/net/skge.c
===
--- skge-
Minor whitespace cleanups.
Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]>
Index: skge-netdev/drivers/net/skge.c
===
--- skge-netdev.orig/drivers/net/skge.c
+++ skge-netdev/drivers/net/skge.c
@@ -248,7 +248,7 @@ static int skge_
--
More bug fixes for skge driver. These apply against the latest
netdev git tree.
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
The SK-9E boards use the Marvell Yukon2 chipset which
is not supported by the skge driver. Thanks to Ralph Roesler
for noticing.
Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]>
Index: skge-netdev/drivers/net/skge.c
===
--- skge
Here is a fix for a typo, thanks Eliot Dresselhaus.
Since transmitter not active when device is down, it wasn't really noticed.
Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]>
Index: skge-netdev/drivers/net/skge.c
===
--- skge-n
From: Marcel Holtmann <[EMAIL PROTECTED]>
Date: Fri, 22 Jul 2005 02:26:34 +0200
> I found the problem. The hci_usb is using the cb[] by itself and so
> overwriting the pkt_type value. The attached patch works for me with the
> hci_usb driver. However I haven't converted all other drivers and
> che
From: Patrick McHardy <[EMAIL PROTECTED]>
Date: Fri, 22 Jul 2005 04:59:30 +0200
> We have multiple queue states, one for each hardware TX queue.
> But instead of multiple qdiscs per device we add a "prio"-argument
> to the dequeue-function. The top-level qdisc is dequeued with the
> highest active
From: Thomas Graf <[EMAIL PROTECTED]>
Date: Fri, 22 Jul 2005 22:51:05 +0200
> Yes, currently we have TCF_META_ID_SECURITY still in there
> with a "/* obsolete */" comment so we can remove that
> immediately. Other candidates for removal are indev, realdev,
> and tcverdict so it's not a big problem
> TCP_NODELAY does not control ACK generation, instead it modifies
> the Nagle algorithm behavior when sending data packets.
Looks like RHEL4 had an odd default smb.conf on the server side - the
RedHat smb.conf seems to set SO_RCVBUF and SO_SNDBUF to 8K (reducing
them from their default). This se
This patch fixes the following warning with -Wundef:
<-- snip -->
...
CC drivers/net/ne.o
drivers/net/ne.c:134:7: warning: "CONFIG_PLAT_OAKS32R" is not defined
...
<-- snip -->
Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]>
--- linux-2.6.13-rc3-mm1-full/drivers/net/ne.c.old 20
-Wundef found an (although perhaps harmless) bug:
<-- snip -->
...
CC net/ieee80211/ieee80211_crypt.o
In file included from net/ieee80211/ieee80211_crypt.c:21:
include/net/ieee80211.h:26:5: warning: "WIRELESS_EXT" is not defined
CC net/ieee80211/ieee80211_crypt_wep.o
In file inclu
In article <[EMAIL PROTECTED]> (at Fri, 22 Jul 2005 14:12:27 -0700 (PDT)),
"David S. Miller" <[EMAIL PROTECTED]> says:
> From: YOSHIFUJI Hideaki <[EMAIL PROTECTED]>
> Date: Fri, 22 Jul 2005 17:06:38 -0400 (EDT)
>
> > No, please, please do not break binaries, whenever it is possible.
> > It is de
I started looking at this driver after seeing the following warnings
with -Wundef:
<-- snip -->
...
CC drivers/net/8139too.o
drivers/net/8139too.c:1961:5: warning: "RTL8139_DEBUG" is not defined
drivers/net/8139too.c:2047:5: warning: "RTL8139_DEBUG" is not defined
...
<-- snip -->
From: YOSHIFUJI Hideaki <[EMAIL PROTECTED]>
Date: Fri, 22 Jul 2005 17:06:38 -0400 (EDT)
> No, please, please do not break binaries, whenever it is possible.
> It is definitely much better to have many deaf entries in enums.
That is why we are trying to kill the constants before 2.6.13
gets releas
In article <[EMAIL PROTECTED]> (at Fri, 22 Jul 2005 22:55:14 +0200), Thomas
Graf <[EMAIL PROTECTED]> says:
> * Stephen Hemminger <[EMAIL PROTECTED]> 2005-07-22 13:48
> > I don't see how the ematch iproute2 stuff depends on SKB shrinking.
> > The CVS repository has the latest ematch stuff, just te
* Stephen Hemminger <[EMAIL PROTECTED]> 2005-07-22 13:48
> I don't see how the ematch iproute2 stuff depends on SKB shrinking.
> The CVS repository has the latest ematch stuff, just testing and
> checking before the next drop.
We cannot remove TCF_META_ID_* ids without breaking backwards
compatibi
From: Thomas Graf <[EMAIL PROTECTED]>
Date: Fri, 22 Jul 2005 22:51:05 +0200
> Yes, currently we have TCF_META_ID_SECURITY still in there
> with a "/* obsolete */" comment so we can remove that
> immediately. Other candidates for removal are indev, realdev,
> and tcverdict so it's not a big problem
From: Stephen Hemminger <[EMAIL PROTECTED]>
Date: Fri, 22 Jul 2005 13:48:42 -0700
> I don't see how the ematch iproute2 stuff depends on SKB shrinking.
> The CVS repository has the latest ematch stuff, just testing and
> checking before the next drop.
We're killing SKB members that the ematch stu
> Hopefully we can weed out the unusable ematch bits before 2.6.13 is
> released. Therefore, once 2.6.13 goes out the iproute2 update should
> be OK.
Sounds good.
> I'm hoping that since we're doing the SKB shrinking in parallel in the
> net-2.6.14 tree with the ongoing 2.6.13 bug fixing, we sho
On Fri, 22 Jul 2005 11:49:11 -0700 (PDT)
"David S. Miller" <[EMAIL PROTECTED]> wrote:
> From: Thomas Graf <[EMAIL PROTECTED]>
> Date: Fri, 22 Jul 2005 17:04:00 +0200
>
> > Sure. I was just thinking that maybe we should delay
> > the iproute2 release with the ematch bits until we
> > finished to s
From: Steve French <[EMAIL PROTECTED]>
Date: 22 Jul 2005 14:56:59 -0500
> Noticing that the loopback device (at least on RHEL4) has an unfortunate
> mtu size 16384 (which is about 50 bytes too small for SMB read
> responses), I did try increasing the MTU slightly. Changing that to
> 18000 did avo
From: Harald Welte <[EMAIL PROTECTED]>
Date: Fri, 22 Jul 2005 09:11:30 -0400
> This is a patch for your net-2.6.14 tree (incremental to the
> expect-double-free fix). It adds the ctnetlink code, and all the
> required core conntrack/nat changes that it needs.
Applied and pushed to net-2.6.14
-
T
On 7/22/05, David S. Miller <[EMAIL PROTECTED]> wrote:
> From: Arnaldo Carvalho de Melo <[EMAIL PROTECTED]>
> Date: Thu, 21 Jul 2005 23:02:03 -0300
>
> > The second one again, also at:
> >
> > rsync://rsync.kernel.org/pub/scm/linux/kernel/git/acme/net-2.6.14.git
>
> How is this handling prope
Olof Johansson writes:
Hello!
And thanks for looking into the stuff.
> I unfortunately don't have a good way to regression test this, so a couple
> of eyes on the patch could be a good thing. Or is there a regression
> suite available?
You can do some testing with new the netlink call th
From: Arnaldo Carvalho de Melo <[EMAIL PROTECTED]>
Date: Thu, 21 Jul 2005 23:02:03 -0300
> The second one again, also at:
>
> rsync://rsync.kernel.org/pub/scm/linux/kernel/git/acme/net-2.6.14.git
How is this handling properly the case where sk_prot changes?
Do you remember we had that probl
From: Arnaldo Carvalho de Melo <[EMAIL PROTECTED]>
Date: Fri, 22 Jul 2005 03:00:13 -0300
> CC [M] net/ipv4/netfilter/ip_conntrack_core.o
> net/ipv4/netfilter/ip_conntrack_core.c: In function
> `ip_conntrack_event_cache_init':
> include/linux/netfilter_ipv4/ip_conntrack.h:296: sorry, unimplement
From: Thomas Graf <[EMAIL PROTECTED]>
Date: Fri, 22 Jul 2005 17:04:00 +0200
> Sure. I was just thinking that maybe we should delay
> the iproute2 release with the ematch bits until we
> finished to shrink the skb. Stephen?
Hopefully we can weed out the unusable ematch bits before 2.6.13 is
releas
A lot of the spacing and tabbing has been cleaned up by
Stephen Hemminger, so you might want to patch against
the copy in my 2.6.14 networking it tree at:
rsync://rsync.kernel.org/pub/scm/linux/kernel/git/davem/net-2.6.14.git
Thanks.
-
To unsubscribe from this list: send the line "unsubscrib
Hi,
I started looking at the fib_trie implementation, and it's pretty neat
stuff. However, it's a bit hard to read; the nesting of indentation
is really deep at certain places and CodingStyle hasn't been followed
very closely.
Below is a patch that cleans up some of this. It shouldn't change any
* David S. Miller <[EMAIL PROTECTED]> 2005-07-21 17:07
> Thomas, this kills the TCF_META_ID_REALDEV stuff, so we should
> kill it in 2.6.13-rcX too so that nobody starts using it in
> userspace ok?
Sure. I was just thinking that maybe we should delay
the iproute2 release with the ematch bits until
David S. Miller wrote:
> This probably has nothing to do with why the patch doesn't
> work for you, but the transformation of "incoming" to a "u8"
> from an "int" is not fully correct, because hci_sock.c
> does this:
>
> put_cmsg(msg, SOL_HCI, HCI_CMSG_DIR, sizeof(int),
> &bt_cb(skb)->incom
From: Jay Vosburgh <[EMAIL PROTECTED]>
Date: Thu, 21 Jul 2005 17:35:24 -0700
> FWIW, there have been a couple of proposals floating around
> bonding-devel for a while from people looking to get the skb->real_dev
> in user space (for network manager applications and user-level link
> state mo
From: Ben Greear <[EMAIL PROTECTED]>
Date: Thu, 21 Jul 2005 17:41:55 -0700
> Er, now I feel like an idiot. I am using the real_dev that
> is saved in the vlan device logic, not the thing in the
> skb.
Don't feel bad, that usage confused me as well while working
on this patch :-)
-
To unsubscribe
47 matches
Mail list logo
