Re: [PATCH 1/2] LSM-IPSec Networking Hooks -- authorizing flow_cache_entry's

2005-07-19 Thread Trent Jaeger
I did this in too hurried a manner, sorry. The basic idea that I wanted to convey is that multiple entries may succeed at flow_key_compare, but that only ones that are authorized are returned. Since the cache is scanned sequentially, this approach seems acceptable to me. flow_key_compare is o

Dequeue first or check the xmit_lock first?

2005-07-19 Thread multisyncfe991
Hello, I read the Linux packet xmit function dev_queue_xmit in dev.c. The code works as follows: 1. enqueue a packet to the dsic queue 2. dequeue a packet 3. try to accquire xmi_lock, if available, then pass the packet to the driver otherwise, requeue the packet and let softirq to handle pa

Re: Problems with e1000 and flow control

2005-07-19 Thread Jason L Tibbitts III
> "JB" == Jesse Brandeburg <[EMAIL PROTECTED]> writes: JB> Flow control should be supported, but it is autonegotiated at link JB> time. How do you know it isn't on? Thanks for the response. I'm going on two pieces of information: 1) The switch indicates that flow control is not on 2) UDP N

Re: Problems with e1000 and flow control

2005-07-19 Thread Jesse Brandeburg
On 7/19/05, Jason L Tibbitts III <[EMAIL PROTECTED]> wrote: > I'm having trouble enabling flow control with the e1000 driver. I'm > running Fedora Core 3 (currently a 2.6.11-ish kernel until the new one > doesn't kill SMP machines). The e1000 driver is version > 5.6.10.1-k2-NAPI. The Ethernet po

Re: [2.6 patch] NETCONSOLE must depend on INET

2005-07-19 Thread David S. Miller
From: Adrian Bunk <[EMAIL PROTECTED]> Date: Tue, 19 Jul 2005 20:29:19 +0200 > NETCONSOLE=y and INET=n results in the following compile error: Also applied, thanks Adrian. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordo

Re: [NET]: Make ipip/ip6_tunnel independant of XFRM

2005-07-19 Thread David S. Miller
From: Patrick McHardy <[EMAIL PROTECTED]> Date: Tue, 19 Jul 2005 21:23:55 +0200 > [NET]: Make ipip/ip6_tunnel independant of XFRM > > Signed-off-by: Patrick McHardy <[EMAIL PROTECTED]> Looks good, applied to net-2.6, thanks Patrick. - To unsubscribe from this list: send the line "unsubscribe net

Re: [PATCH] fib_trie whitespace fixes

2005-07-19 Thread David S. Miller
From: Stephen Hemminger <[EMAIL PROTECTED]> Date: Tue, 19 Jul 2005 08:49:17 -0400 > Fix up lots of little whitespace indentation stuff in fib_trie. > > Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> Applied to net-2.6, thanks Stephen. - To unsubscribe from this list: send the line "unsubsc

Re: [2.6 patch] BRIDGE_EBT_ARPREPLY must depend on INET

2005-07-19 Thread David S. Miller
From: Adrian Bunk <[EMAIL PROTECTED]> Date: Tue, 19 Jul 2005 15:55:29 +0200 > BRIDGE_EBT_ARPREPLY=y and INET=n results in the following compile error: Applied, thanks Adrian. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More maj

Re: [IPV4]: Don't select XFRM for ip_gre

2005-07-19 Thread David S. Miller
From: Patrick McHardy <[EMAIL PROTECTED]> Date: Tue, 19 Jul 2005 20:47:18 +0200 > [IPV4]: Don't select XFRM for ip_gre > > Signed-off-by: Patrick McHardy <[EMAIL PROTECTED]> Applied to net-2.6, thanks Patrick. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a m

Re: [NET]: Only build flow.o if CONFIG_XFRM=y

2005-07-19 Thread David S. Miller
From: Patrick McHardy <[EMAIL PROTECTED]> Date: Tue, 19 Jul 2005 20:44:02 +0200 > [NET]: Only build flow.o if CONFIG_XFRM=y > > Signed-off-by: Patrick McHardy <[EMAIL PROTECTED]> Applied to net-2.6, thanks Patrick. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body o

Re: [PATCH 8/8][ATM]: [speedtch] cure atm_printk() macro gcc-2.95 compile error

2005-07-19 Thread David S. Miller
All 8 patches applied, thanks Chas. Chas, please update your address book, [EMAIL PROTECTED] is no longer in service. The current address for the list is netdev@vger.kernel.org Thanks. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECT

Re: netdev TODO list

2005-07-19 Thread Patrick McHardy
David S. Miller schrieb: From: Ben Greear <[EMAIL PROTECTED]> Date: Tue, 19 Jul 2005 10:58:33 -0700 That way, any out-of-tree code that uses skb->stamp will no longer compile (it is much better to fail at compile time than run time). Sure. I'll send a new patch tonight. Regards Patrick - T

[NET]: Make ipip/ip6_tunnel independant of XFRM

2005-07-19 Thread Patrick McHardy
Don't force people to compile in the xfrm stuff if all they want is ipip. [NET]: Make ipip/ip6_tunnel independant of XFRM Signed-off-by: Patrick McHardy <[EMAIL PROTECTED]> --- commit e7c319d6e404febb83e670057adea1f9741369df tree e6ac0a4b084175a7e5f94113459ed4b7b2224ffa parent a263cf11fef8b7a15

Re: [NET]: Kill skb->tc_classid

2005-07-19 Thread David S. Miller
From: Patrick McHardy <[EMAIL PROTECTED]> Date: Tue, 19 Jul 2005 20:29:30 +0200 > Did you also get the patch to kill skb->tc_classid? I can only see > the patch to remove the define in your 2.6.14 tree. I just put it into the tree right now, it should show up on kernel.org in about a half hour.

Re: netdev TODO list

2005-07-19 Thread David S. Miller
From: Ben Greear <[EMAIL PROTECTED]> Date: Tue, 19 Jul 2005 10:58:33 -0700 > That way, any out-of-tree code that uses skb->stamp will no longer > compile (it is much better to fail at compile time than run time). Sure. - To unsubscribe from this list: send the line "unsubscribe netdev" in the bod

[IPV4]: Don't select XFRM for ip_gre

2005-07-19 Thread Patrick McHardy
ip_gre doesn't depend on XFRM, so don't select it. [IPV4]: Don't select XFRM for ip_gre Signed-off-by: Patrick McHardy <[EMAIL PROTECTED]> --- commit a263cf11fef8b7a15ec6c1a6c86cc8cf923e2c3d tree 7d6b81f6c05048d968f7dadc5414dcecc92341e8 parent 7562e025cbd54c2be0b7587f1f02a1b09945e67d author Pat

[NET]: Only build flow.o if CONFIG_XFRM=y

2005-07-19 Thread Patrick McHardy
The flowcache is currently only used by IPsec, but it is always built in. Make it depend on CONFIG_XFRM. [NET]: Only build flow.o if CONFIG_XFRM=y Signed-off-by: Patrick McHardy <[EMAIL PROTECTED]> --- commit 7562e025cbd54c2be0b7587f1f02a1b09945e67d tree 44a02ba744c99e112692a43b57088d1f2cce59bf

Re: [NET]: Kill skb->tc_classid

2005-07-19 Thread Patrick McHardy
David S. Miller wrote: From: Patrick McHardy <[EMAIL PROTECTED]> Date: Mon, 18 Jul 2005 06:39:11 +0200 OK, here's the patch to remove it. Dave, please apply together with the previous patch. Patch applied, thanks. Did you also get the patch to kill skb->tc_classid? I can only see the patch

[2.6 patch] NETCONSOLE must depend on INET

2005-07-19 Thread Adrian Bunk
NETCONSOLE=y and INET=n results in the following compile error: <-- snip --> ... LD .tmp_vmlinux1 net/built-in.o: In function `netpoll_parse_options': : undefined reference to `in_aton' net/built-in.o: In function `netpoll_parse_options': : undefined reference to `in_aton' make: *** [.tm

Re: netdev TODO list

2005-07-19 Thread Ben Greear
Patrick McHardy wrote: David S. Miller wrote: From: Patrick McHardy <[EMAIL PROTECTED]> Date: Tue, 19 Jul 2005 08:22:31 +0200 Here's a first shot. The neighbour part is kind of ugly, but should work. Suggestions for making it nicer are welcome. As for the neighbour uglies, I think you can

Problems with e1000 and flow control

2005-07-19 Thread Jason L Tibbitts III
I'm having trouble enabling flow control with the e1000 driver. I'm running Fedora Core 3 (currently a 2.6.11-ish kernel until the new one doesn't kill SMP machines). The e1000 driver is version 5.6.10.1-k2-NAPI. The Ethernet ports are on the motherboard (a SuperMicro X5DPE): 03:02.0 Ethernet c

8139cp misses interrupts during resume

2005-07-19 Thread Pierre Ossman
I'm having problem with the interrupt getting killed after suspend with my 8139cp controller. The problem only appears if the cable is connected during resume (before suspend is irrelevant) and the interface is down. Both suspend-to-disk and suspend-to-ram exhibit the error. dmesg from suspend-to-

Re: netdev TODO list

2005-07-19 Thread Patrick McHardy
David S. Miller wrote: From: Patrick McHardy <[EMAIL PROTECTED]> Date: Tue, 19 Jul 2005 08:22:31 +0200 Here's a first shot. The neighbour part is kind of ugly, but should work. Suggestions for making it nicer are welcome. As for the neighbour uglies, I think you can safely stick that info in

[2.6 patch] NET_PKTGEN must depend on INET

2005-07-19 Thread Adrian Bunk
NET_PKTGEN=y and INET=n results in the following compile error: <-- snip --> ... LD .tmp_vmlinux1 net/built-in.o: In function `proc_if_write': pktgen.c:(.text+0x18ca9): undefined reference to `in_aton' pktgen.c:(.text+0x19c11): undefined reference to `in_aton' pktgen.c:(.text+0x19ced): u

[2.6 patch] VIA_VELOCITY must depend on INET

2005-07-19 Thread Adrian Bunk
VIA_VELOCITY=y and INET=n results in the following compile error: <-- snip --> ... LD .tmp_vmlinux1 drivers/built-in.o: In function `velocity_register_notifier': via-velocity.c:(.text+0x3462c6): undefined reference to `register_inetaddr_notifier' drivers/built-in.o: In function `velocit

Re: [stable] Re: [05/11] SMP fix for 6pack driver

2005-07-19 Thread Ralf Baechle
On Fri, Jul 15, 2005 at 09:35:56PM +0200, Adrian Bunk wrote: > I do agree with Francois regarding this issue: > > AFAIR, there has been not one 2.6 kernel where this driver was available > for SMP kernels. Eh... That after all is the raison d'etre for this patch :) > It's therefore untested w

[2.6 patch] BRIDGE_EBT_ARPREPLY must depend on INET

2005-07-19 Thread Adrian Bunk
BRIDGE_EBT_ARPREPLY=y and INET=n results in the following compile error: <-- snip --> ... LD .tmp_vmlinux1 net/built-in.o: In function `ebt_target_reply': ebt_arpreply.c:(.text+0x68fb9): undefined reference to `arp_send' make: *** [.tmp_vmlinux1] Error 1 <-- snip --> Signed-off-by: A

[PATCH] fib_trie whitespace fixes

2005-07-19 Thread Stephen Hemminger
Fix up lots of little whitespace indentation stuff in fib_trie. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> Index: tcp/net/ipv4/fib_trie.c === --- tcp.orig/net/ipv4/fib_trie.c +++ tcp/net/ipv4/fib_trie.c @@ -90,14 +90,14 @@

Re: [PATCH 2/2] LSM-IPSec Networking Hooks -- SELinux portion bug fixes

2005-07-19 Thread James Morris
On Mon, 18 Jul 2005, jaegert wrote: > Some bug fixes to the SELinux patch. What were the bugs? - James -- James Morris <[EMAIL PROTECTED]> - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.ker

Re: [PATCH] reduce netfilte sk_buff enlargement

2005-07-19 Thread David S. Miller
From: Jan Engelhardt <[EMAIL PROTECTED]> Date: Tue, 19 Jul 2005 09:18:38 +0200 (MEST) > >but for now I'll eat that one-bit member. > > What is more important? Being as small as possible using bitfields, or being > as fast as possible? (Usage of bitfields is some CPU overhead for their > extract

Re: [PATCH] reduce netfilte sk_buff enlargement

2005-07-19 Thread Jan Engelhardt
>but for now I'll eat that one-bit member. What is more important? Being as small as possible using bitfields, or being as fast as possible? (Usage of bitfields is some CPU overhead for their extraction) - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a messa