Re: [PATCH 1/3] multicast API "join" issues

2005-07-04 Thread YOSHIFUJI Hideaki / 吉藤英明
In article <[EMAIL PROTECTED]> (at Fri, 1 Jul 2005 18:15:50 -0600), David Stevens <[EMAIL PROTECTED]> says: > This patch corrects a few problems with the IP_ADD_MEMBERSHIP > socket option: > 1) The existing code makes an attempt at reference counting joins when > using the ip_mreq

2.6.13-rc1-git - phy_lock taken twice in skge.c ?

2005-07-04 Thread Francois Romieu
static int skge_nway_reset(struct net_device *dev) { struct skge_port *skge = netdev_priv(dev); struct skge_hw *hw = skge->hw; int port = skge->port; if (skge->autoneg != AUTONEG_ENABLE || !netif_running(dev)) return -EINVAL; spin_lock_bh(&h

Re: sendfilev vs. TCP_CORK

2005-07-04 Thread David S. Miller
From: Andrew Grover <[EMAIL PROTECTED]> Subject: sendfilev vs. TCP_CORK Date: Mon, 4 Jul 2005 01:08:56 -0700 > So I was just reading planetsun.org and came across this guy's blog entry: > > http://blogs.sun.com/roller/page/tron?entry=is_the_tcp_cork_socket Sun uses blogs, even from the managemen

[PATCH] orinoco: Sparse fixes

2005-07-04 Thread Peter Hagervall
A few sparse cleanups for orinoco.c Signed-off-by: Peter Hagervall <[EMAIL PROTECTED]> --- diff --git a/drivers/net/wireless/orinoco.c b/drivers/net/wireless/orinoco.c --- a/drivers/net/wireless/orinoco.c +++ b/drivers/net/wireless/orinoco.c @@ -4322,36 +4322,36 @@ static const struct iw_priv_ar

Re: [2.6 patch] fix IP_FIB_HASH kconfig warning

2005-07-04 Thread Roman Zippel
Hi, On Mon, 4 Jul 2005, Adrian Bunk wrote: > --- linux-2.6.13-rc1-mm1-full/net/ipv4/Kconfig.old2005-07-02 > 20:07:25.0 +0200 > +++ linux-2.6.13-rc1-mm1-full/net/ipv4/Kconfig2005-07-02 > 20:13:05.0 +0200 > @@ -58,8 +58,9 @@ > depends on IP_ADVANCED_ROUTER >

Re: [PATCH 4/4] [PKT_SCHED]: Blackhole queueing discipline

2005-07-04 Thread Thomas Graf
* jamal <[EMAIL PROTECTED]> 2005-07-04 09:16 > On Mon, 2005-04-07 at 13:48 +0200, Thomas Graf wrote: > > plain text document attachment (sch_blackhole) > > Useful in combination with classful qdiscs to drop or > > temporary disable certain flows, e.g. one could block > > specific ds flows with dsma

Re: [PATCH] part 1/3 : hashed spinlocks in net/ipv4/route.c

2005-07-04 Thread Robert Olsson
Eric Dumazet writes: > I wonder which part of the patch you think would change the performance ? > There is no change in the fast path. The spinlocks are taken where they were > taken. Was interested in the performance effects of hashed spinlocks... as I didn't see much win with rDoS that

Re: [PATCH 4/4] [PKT_SCHED]: Blackhole queueing discipline

2005-07-04 Thread jamal
On Mon, 2005-04-07 at 13:48 +0200, Thomas Graf wrote: > plain text document attachment (sch_blackhole) > Useful in combination with classful qdiscs to drop or > temporary disable certain flows, e.g. one could block > specific ds flows with dsmark. > > Unlike the noop qdisc it can be controlled by

[PATCH 4/4] [PKT_SCHED]: Blackhole queueing discipline

2005-07-04 Thread Thomas Graf
Useful in combination with classful qdiscs to drop or temporary disable certain flows, e.g. one could block specific ds flows with dsmark. Unlike the noop qdisc it can be controlled by the user and statistic accounting is done. Signed-off-by: Thomas Graf <[EMAIL PROTECTED]> Index: net-2.6/net/sc

[PATCH 3/4] [PKT_SCHED]: Report rate estimator configuration errors during qdisc allocation

2005-07-04 Thread Thomas Graf
Current behaviour is to not report an error if a rate estimator is created together with a qdisc and the configuration of the rate estimator is bogus. This leads to unexpected behaviour because the user is not notified. New behaviour is to report the error and let the whole qdisc creation operatio

[PATCH 2/4] [PKT_SCHED]: Cleanup qdisc creation and alignment macros

2005-07-04 Thread Thomas Graf
Adds qdisc_alloc() to share code between qdisc_create() and qdisc_create_dflt(). Hides the qdisc alignment behind macros and makes use of them. Signed-off-by: Thomas Graf <[EMAIL PROTECTED]> Index: net-2.6/include/net/sch_generic.h =

[PATCH 1/4] [PKT_SCHED]: Move sch_generic.c prototypes to correct header file

2005-07-04 Thread Thomas Graf
Signed-off-by: Thomas Graf <[EMAIL PROTECTED]> Index: net-2.6/include/net/pkt_sched.h === --- net-2.6.orig/include/net/pkt_sched.h +++ net-2.6/include/net/pkt_sched.h @@ -207,8 +207,6 @@ psched_tod_diff(int delta_sec, int bound #en

[PATCHSET] pkt_sched updates

2005-07-04 Thread Thomas Graf
Patches 1-3 should be straight forward. Patch 4 adds a new qdisc implementing a black hole, nothing spectacular but quite useful. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordo

[PATCH 1/2] [NET]: Remove unused security member in sk_buff

2005-07-04 Thread Thomas Graf
Signed-off-by: Thomas Graf <[EMAIL PROTECTED]> Index: net-2.6/include/linux/skbuff.h === --- net-2.6.orig/include/linux/skbuff.h +++ net-2.6/include/linux/skbuff.h @@ -183,7 +183,6 @@ struct skb_shared_info { * @priority: Packet

[PATCH 2/2] [NET]: Reduce size of sk_buff by 4 bytes

2005-07-04 Thread Thomas Graf
Reduce local_df to a bit field and ip_summed to a 2 bits field thus saving 13 bits. Move bit fields, packet type, and protocol into the spare area between the priority and the destructor. Saves 4 bytes on both, 32bit and 64bit architectures. Signed-off-by: Thomas Graf <[EMAIL PROTECTED]> Index: n

[PATCHSET] Save 4 bytes in sk_buff

2005-07-04 Thread Thomas Graf
These patches have been floating around during the enlarge cb[] discussion a few months back but I never had the drive to actually submit them officially. Inspired by dave's skb writings I now do. Further additional ideas to reduce sk_buff in size: o If we can't get rid of mac_len it could at le

sendfilev vs. TCP_CORK

2005-07-04 Thread Andrew Grover
So I was just reading planetsun.org and came across this guy's blog entry: http://blogs.sun.com/roller/page/tron?entry=is_the_tcp_cork_socket Now I'm really not trying to be a troll or anything here (:-) but I was hoping someone had an opinion on if this would be worth the effort to implement on