Re: [REQUEST FOR VOTES] snmpd: Call fclose() after fdopen() but not close()

2020-08-13 Thread Bart Van Assche
On 2020-08-08 16:16, Magnus Fromreide wrote: > That file is a mess. > > Have anyone heard from Alexander Prömel regarding those temporary hard coded > pathnames that should be fixed soon? I think 14 years cover any reasonable > definition of the word 'soon'. > > Why are both the file descriptor a

Re: [REQUEST FOR VOTES] snmpd: Call fclose() after fdopen() but not close()

2020-08-13 Thread Bart Van Assche
On 2020-08-13 18:16, Magnus Fromreide wrote: > Now I have finally gotten around to look more thoroughly into this and found > that your patch is basically good. > > For the agent/snmpd.c part I would like to change my vote to +1. Thanks! > For the pass_persist part you are keeping the fclose of

Re: [REQUEST FOR VOTES] snmpd: Call fclose() after fdopen() but not close()

2020-08-13 Thread Magnus Fromreide
On Sun, Aug 09, 2020 at 01:16:37AM +0200, Magnus Fromreide wrote: > On Sat, Aug 08, 2020 at 11:17:52AM -0700, Bart Van Assche wrote: > > From https://pubs.opengroup.org/onlinepubs/9699919799/functions/fclose.html: > > "The fclose() function shall perform the equivalent of a close() on the file > >

Re: Test failures on V5-8-patches and master

2020-08-13 Thread Magnus Fromreide
On Thu, Aug 13, 2020 at 03:55:31PM -0700, Wes Hardaker via Net-snmp-coders wrote: > Magnus Fromreide writes: > > > I just noticed that T0222snmpv3bulkget_simple depends on SHA authentication > > and AES privacy but fails to check for this so if one builds the agent > > without that support the t

Re: Test failures on V5-8-patches and master

2020-08-13 Thread Wes Hardaker via Net-snmp-coders
Magnus Fromreide writes: > I just noticed that T0222snmpv3bulkget_simple depends on SHA authentication > and AES privacy but fails to check for this so if one builds the agent > without that support the test fails. Is it really just that test? I actually thought that most of the tests were usin

Test failures on V5-8-patches and master

2020-08-13 Thread Magnus Fromreide
Hello! I just noticed that T0222snmpv3bulkget_simple depends on SHA authentication and AES privacy but fails to check for this so if one builds the agent without that support the test fails. Now, I am not certain about exactly what T0222 tests but I think it is about bulkget limits and thus the u