Use `HexFormat.fromHexDigits` in URLDecoder, instead of `Integer.parseInt`.
-
Commit messages:
- Use HexFormat in URLDecoder
Changes: https://git.openjdk.org/jdk/pull/24314/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=24314&range=00
Issue: https://bugs.openjdk.org/brow
On Tue, 1 Apr 2025 00:34:46 GMT, Chen Liang wrote:
> Is there a particular reason for this change? Like is this a significant
> performance bottleneck?
I don't know of a particular bottleneck specifically with `Integer.parseInt` in
`URLDecoder`, however `URLDecoder#decode` is often there in th
On Mon, 31 Mar 2025 14:43:24 GMT, Mikhail Yankelevich
wrote:
> Hi! This commit must refer to an issue. Could you please create one and
> provide some background for the change here. Thank you
I've updated the PR with the associated issue. I provided some background in my
response to the other
On Mon, 7 Apr 2025 09:55:20 GMT, Daniel Fuchs wrote:
>> Use `HexFormat.fromHexDigits` in URLDecoder, instead of `Integer.parseInt`.
>
> Tests came back green - a few unrelated failures.
@dfuch @jaikiran @RogerRiggs Thank you for taking a look at this PR; looks like
I need a sponsor. Would any o
On Sat, 29 Mar 2025 17:27:20 GMT, Patrick Strawderman wrote:
> Use `HexFormat.fromHexDigits` in URLDecoder, instead of `Integer.parseInt`.
This pull request has now been integrated.
Changeset: 03fd43fc
Author: Patrick Strawderman
Committer: Jaikiran Pai
URL:
https://git.openjdk.
On Tue, 1 Apr 2025 17:25:00 GMT, Daniel Fuchs wrote:
> Interesting. Please run tier2 tests.
I've run the tier 2 tests locally and they pass.
-
PR Comment: https://git.openjdk.org/jdk/pull/24314#issuecomment-2773910295
On Thu, 15 May 2025 11:47:08 GMT, Daniel Fuchs wrote:
> Thanks for this fix. The proposed changes LGTM. Did you run tier2 tests?
Yes, I've run tier1 and tier2 tests. There were a few unrelated failures, but
the [test
](https://github.com/openjdk/jdk/blob/master/test/jdk/java/net/HttpURLConnect
Avoid allocating a substring to parse the response code in
HttpURLConnection#getResponseCode, but instead use the Integer.parseInt
overload that accepts String indices.
-
Commit messages:
- Optimize response code parsing in HttpURLConnection
Changes: https://git.openjdk.org/jdk/pu
On Thu, 15 May 2025 05:14:02 GMT, Patrick Strawderman wrote:
> Avoid allocating a substring to parse the response code in
> HttpURLConnection#getResponseCode, but instead use the Integer.parseInt
> overload that accepts String indices.
This pull request has now been integrated.
