Re: RFR: JDK-8314517: some tests fail in case ipv6 is disabled on the machine

2023-08-18 Thread Martin Doerr
On Fri, 18 Aug 2023 06:53:19 GMT, Matthias Baesken wrote: > Some jtreg tests fail with ipv6 disabled on the machine, this should be > improved in the tests (e.g. by using IPSupport.hasIPv6() ). Looks reasonable. - Marked as reviewed by mdoerr (Reviewer). PR Review: https://git.op

Re: RFR: JDK-8313764: Offer JVM HS functionality to shared lib load operations done by the JDK codebase

2023-08-23 Thread Martin Doerr
On Mon, 14 Aug 2023 07:48:00 GMT, Matthias Baesken wrote: > Currently there is a number of functionality that would be interesting to > have for shared lib load operations in the JDK C code. > Some examples : > Events::log_dll_message for hs-err files reporting > JFR event NativeLibraryLoad > Th

Re: RFR: 8315651: Stop hiding AIX specific multicast socket errors via NetworkConfiguration (aix) [v2]

2023-09-06 Thread Martin Doerr
On Wed, 6 Sep 2023 11:24:13 GMT, Thomas Obermeier wrote: >> 8315651: Stop hiding AIX specific multicast socket errors via >> NetworkConfiguration (aix) > > Thomas Obermeier has updated the pull request incrementally with one > additional commit since the last revision: > > remove instead of

Re: RFR: 8308144: Uncontrolled memory consumption in SSLFlowDelegate.Reader [v3]

2024-05-15 Thread Martin Doerr
On Mon, 20 Nov 2023 14:58:05 GMT, Jaikiran Pai wrote: >> Can I please get a review for this change which proposes to fix an issue in >> the JDK's HttpClient implementation, noted in >> https://bugs.openjdk.org/browse/JDK-8308144? >> >> The HttpClient implementation internally uses >> `java.ut

Re: RFR: 8318442: java/net/httpclient/ManyRequests2.java fails intermittently on Linux

2024-11-05 Thread Martin Doerr
On Tue, 5 Nov 2024 12:09:37 GMT, Matthias Baesken wrote: > On Linux ppc64le test machines (RHEL8.5, Ubuntu 22.04) we see intermittent > failures of java/net/httpclient/ManyRequests2.java . > We mostly run fastdebug binaries for our tests on Linux ppc64le; > unfortunately those are very slow an

Re: RFR: 8318442: java/net/httpclient/ManyRequests2.java fails intermittently on Linux [v2]

2024-11-05 Thread Martin Doerr
On Tue, 5 Nov 2024 13:51:45 GMT, Matthias Baesken wrote: >> On Linux ppc64le test machines (RHEL8.5, Ubuntu 22.04) we see intermittent >> failures of java/net/httpclient/ManyRequests2.java . >> We mostly run fastdebug binaries for our tests on Linux ppc64le; >> unfortunately those are very slo

Re: RFR: 8344236: Revisit SecurityManager usage in jdk.net after JEP 486 integration

2024-11-20 Thread Martin Doerr
On Wed, 20 Nov 2024 11:40:01 GMT, Jaikiran Pai wrote: > Can I please get a review of this change which removes the usages of > `SecurityManager` related APIs from the `jdk.net` module? This addresses > https://bugs.openjdk.org/browse/JDK-8344236. > > No new tests have been added and existing t