Re: RFR: 8293810: Remove granting of RuntimePermission("stopThread") from tests

2022-10-05 Thread Mandy Chung
On Wed, 5 Oct 2022 15:01:15 GMT, Alan Bateman wrote: > This is a test only change to remove the granting of > RuntimePermission("stopThread") from the tests. With Thread.stop changed to > throw UOE it means there is nothing that requires this permission. LGTM - Marked as reviewed

Re: RFR: JDK-8300133: Use generalized see and link tags in core libs

2023-01-13 Thread Mandy Chung
On Fri, 13 Jan 2023 21:30:06 GMT, Joe Darcy wrote: > With generalized see and link tags that can refer to anchors (JDK-8200337), > the see and link tags in core libraries should be updated to use this feature > when possible. This PR covers such updates for java.base. src/java.base/share/class

Re: RFR: JDK-8300133: Use generalized see and link tags in core libs [v2]

2023-01-13 Thread Mandy Chung
On Fri, 13 Jan 2023 22:50:53 GMT, Joe Darcy wrote: >> With generalized see and link tags that can refer to anchors (JDK-8200337), >> the see and link tags in core libraries should be updated to use this >> feature when possible. This PR covers such updates for java.base. > > Joe Darcy has updat

RFR: JDK-8301462: Convert Permission files to use lambda after JDK-8076596

2023-02-07 Thread Mandy Chung
A trivial fix. Convert the use of anonymous inner classes in a few Permission classes to lambdas to work around JDK-8076596, which has been resolved. - Commit messages: - JDK-8301462: Convert Permission files to use lambda after JDK-8076596 Changes: https://git.openjdk.org/jdk/pu

Re: RFR: JDK-8301462: Convert Permission files to use lambda after JDK-8076596 [v2]

2023-02-07 Thread Mandy Chung
On Wed, 8 Feb 2023 01:53:02 GMT, Jaikiran Pai wrote: >> Mandy Chung has updated the pull request incrementally with one additional >> commit since the last revision: >> >> update copyright end year > > Hello Mandy, the changes look fine to me. > > Each

Re: RFR: JDK-8301462: Convert Permission files to use lambda after JDK-8076596 [v2]

2023-02-07 Thread Mandy Chung
> A trivial fix. Convert the use of anonymous inner classes in a few > Permission classes to lambdas to work around JDK-8076596, which has been > resolved. Mandy Chung has updated the pull request incrementally with one additional commit since the last revision: update copyright

Re: RFR: JDK-8301462: Convert Permission files to use lambda after JDK-8076596 [v2]

2023-02-08 Thread Mandy Chung
On Wed, 8 Feb 2023 03:42:16 GMT, Mandy Chung wrote: >> A trivial fix. Convert the use of anonymous inner classes in a few >> Permission classes to lambdas to work around JDK-8076596, which has been >> resolved. > > Mandy Chung has updated the pull request increment

Re: RFR: JDK-8301462: Convert Permission files to use lambda after JDK-8076596 [v3]

2023-02-08 Thread Mandy Chung
> A trivial fix. Convert the use of anonymous inner classes in a few > Permission classes to lambdas to work around JDK-8076596, which has been > resolved. Mandy Chung has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev exc

Integrated: JDK-8301462: Convert Permission files to use lambda after JDK-8076596

2023-02-08 Thread Mandy Chung
On Tue, 7 Feb 2023 22:25:43 GMT, Mandy Chung wrote: > A trivial fix. Convert the use of anonymous inner classes in a few > Permission classes to lambdas to work around JDK-8076596, which has been > resolved. This pull request has now been integrated. Changeset: 10dd98d0 Author:

Re: RFR: 8303485: Replacing os.name for operating system customization

2023-03-08 Thread Mandy Chung
The message from this sender included one or more files which could not be scanned for virus detection; do not open these files unless you are certain of the sender's intent. -- On Wed, 8 Mar 2023 19:15:16 GMT, Roger Riggs wrote:

Re: RFR: 8303485: Replacing os.name for operating system customization

2023-03-09 Thread Mandy Chung
On Thu, 9 Mar 2023 16:03:37 GMT, Roger Riggs wrote: >> I would argue that we should keep the replacement string matching the make >> variable its getting the value from. It makes it easier to trace the origin >> of the value. >> >> Using the terms `CURRENT` or `TARGET` inside the java class i

Re: RFR: 8303485: Replacing os.name for operating system customization

2023-03-09 Thread Mandy Chung
On Thu, 9 Mar 2023 17:03:05 GMT, Mandy Chung wrote: >> The symbol has to match the build usage of OPENJDK_TARGET_OS, not the name. > > The one in the template file is independent to the build variables. > I would argue that we should keep the replacement string matching the make

Re: RFR: 8303485: Replacing os.name for operating system customization

2023-03-09 Thread Mandy Chung
On Fri, 10 Mar 2023 02:51:43 GMT, David Holmes wrote: >> Using the naming from the build makes it clearer that there is a dependency >> between the build names and those in the template. > > Don't we have a conditional compilation ability with these template files > such that we can just genera

Re: RFR: 8303485: Replacing os.name for operating system customization

2023-03-10 Thread Mandy Chung
On Fri, 10 Mar 2023 14:01:04 GMT, Alan Bateman wrote: >> Improvements to support OS specific customization for JDK internal use: >> - To select values and code; allowing elimination of unused code and values >> - Optionally evaluated by build processes, compilation, or archiving (i.e. >> CDS)

Re: RFR: JDK-8305206: Add @spec tags in java.base/java.* (part 1) [v2]

2023-03-31 Thread Mandy Chung
On Thu, 30 Mar 2023 20:45:08 GMT, Jonathan Gibbons wrote: >> Please review a change to add `@spec` tags (and remove some equivalent >> `@see` tags) to the main "core-libs" packages in `java.base` module. >> >> This is similar to, and a subset of, PR #11073. That PR was withdrawn, and >> base

Re: RFR: 8308184: Launching java with large number of jars in classpath with java.protocol.handler.pkgs system property set can lead to StackOverflowError [v3]

2023-06-09 Thread Mandy Chung
On Fri, 9 Jun 2023 15:47:54 GMT, Jaikiran Pai wrote: >> Can I please get a review of this change which proposes to fix the issue >> noted in https://bugs.openjdk.org/browse/JDK-8308184? >> >> When an application is launched, the `app` classloader internally uses a >> `jdk.internal.loader.URLCl

Re: RFR: 8304478: Initial nroff manpage generation for JDK 22

2023-06-14 Thread Mandy Chung
On Wed, 14 Jun 2023 04:53:58 GMT, David Holmes wrote: > Updated the version to 22-ea and year to 2024. > > The following unpublished changes will also be included in this update: > - [JDK-8290626](https://bugs.openjdk.org/browse/JDK-8290626): keytool manpage > contains a special character > - [

Re: [jdk21] RFR: 8300937: Update nroff pages in JDK 21 before RC

2023-07-31 Thread Mandy Chung
On Mon, 31 Jul 2023 08:33:07 GMT, David Holmes wrote: > Main changes are to use 21 instead of 21-ea. In addition the following files > contain additional updates from the closed sources: > > - src/java.base/share/man/java.1 > > [JDK-8273131](https://bugs.openjdk.org/browse/JDK-8273131): Updat

Re: RFR: 8338411: Implement JEP 486: Permanently Disable the Security Manager [v2]

2024-10-22 Thread Mandy Chung
On Fri, 18 Oct 2024 19:03:30 GMT, Sean Mullan wrote: >> This is the implementation of JEP 486: Permanently Disable the Security >> Manager. See [JEP 486](https://openjdk.org/jeps/486) for more details. The >> [CSR](https://bugs.openjdk.org/browse/JDK-8338412) describes in detail the >> main ch

Re: RFR: 8338411: Implement JEP 486: Permanently Disable the Security Manager [v6]

2024-10-31 Thread Mandy Chung
On Wed, 30 Oct 2024 19:28:32 GMT, Sean Mullan wrote: >> This is the implementation of JEP 486: Permanently Disable the Security >> Manager. See [JEP 486](https://openjdk.org/jeps/486) for more details. The >> [CSR](https://bugs.openjdk.org/browse/JDK-8338412) describes in detail the >> main ch

Re: RFR: 8338411: Implement JEP 486: Permanently Disable the Security Manager

2024-10-15 Thread Mandy Chung
On Mon, 14 Oct 2024 13:52:24 GMT, Sean Mullan wrote: > This is the implementation of JEP 486: Permanently Disable the Security > Manager. See [JEP 486](https://openjdk.org/jeps/486) for more details. The > [CSR](https://bugs.openjdk.org/browse/JDK-8338412) describes in detail the > main change