On Wed, 6 Jul 2022 05:32:29 GMT, Daniel Jeliński wrote:
>> This patch removes many unused variables and one unused label reported by
>> the compilers when relevant warnings are enabled.
>>
>> The unused code was found by compiling after removing `unused` from the list
>> of disabled warnings
On Tue, 30 Aug 2022 09:31:07 GMT, Alan Bateman wrote:
>> 8294321: Fix typos in files under test/jdk/java, test/jdk/jdk, test/jdk/jni
>
> src/java.base/share/native/libzip/zlib/zlib.h line 756:
>
>> 754:If this is done, the old level and strategy will be applied to the
>> data
>> 755:com
On Mon, 26 Sep 2022 16:51:36 GMT, Michael Ernst wrote:
>> 8294321: Fix typos in files under test/jdk/java, test/jdk/jdk, test/jdk/jni
>
> Michael Ernst has updated the pull request with a new target base due to a
> merge or a rebase. The pull request now contains six commits:
>
> - Reinstate t
On Thu, 10 Nov 2022 01:10:13 GMT, Jonathan Gibbons wrote:
> Please review a "somewhat automated" change to insert `@spec` tags into doc
> comments, as appropriate, to leverage the recent new javadoc feature to
> generate a new page listing the references to all external specifications
> listed
On Mon, 28 Nov 2022 10:02:47 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this change which fixes the typos in the test
>> packages? @mernst submitted this as a separate PR
>> https://github.com/openjdk/jdk/pull/10029 but given the number of areas and
>> files that other PR touches
On Mon, 23 Jan 2023 22:59:22 GMT, David Holmes wrote:
> Please review this simple update to the manpage to set the version to 21-ea.
>
> This change also corrects a typo in javac.1 that was manually introduced by
> JDK-8300591
>
> Thanks.
Marked as reviewed by lancea (Reviewer).
On Tue, 28 Mar 2023 08:06:48 GMT, Jaikiran Pai wrote:
> Can I please get a review of this trivial doc-only change that addresses
> https://bugs.openjdk.org/browse/JDK-8304989?
>
> I ran `make docs-image` with this change and the generated javadocs look fine.
Marked as reviewed by lancea (Revie
On Thu, 30 Mar 2023 20:45:08 GMT, Jonathan Gibbons wrote:
>> Please review a change to add `@spec` tags (and remove some equivalent
>> `@see` tags) to the main "core-libs" packages in `java.base` module.
>>
>> This is similar to, and a subset of, PR #11073. That PR was withdrawn, and
>> base
On Fri, 31 Mar 2023 10:33:50 GMT, Lance Andersen wrote:
> Hi Jon,
>
> This looks fine. I was wondering if we should do the same for java.util.zip
> and the PKWare Zip Spec or where java.sql references the JDBC Spec?
Well, I must need coffee this morning as obviously JDBC is in
On Tue, 4 Apr 2023 19:22:48 GMT, Roger Riggs wrote:
> With the addition of `jdk.internal.util.OperatingSystem` references to the
> system property `os.name` can be replaced.
> This PR exports jdk.internal.util to:
> - java.prefs,
> - java.security.jgss,
> - java.smartcardio,
> - jdk.charsets
On Wed, 14 Jun 2023 04:53:58 GMT, David Holmes wrote:
> Updated the version to 22-ea and year to 2024.
>
> The following unpublished changes will also be included in this update:
> - [JDK-8290626](https://bugs.openjdk.org/browse/JDK-8290626): keytool manpage
> contains a special character
> - [
On Fri, 2 Feb 2024 23:36:41 GMT, Joe Darcy wrote:
> After the "this-escape" lint warning was added to javac (JDK-8015831), the
> base module was not updated to be able to compile with this warning enabled.
> This PR makes the necessary changes to allow the base module to build with
> the warni
On Wed, 9 Oct 2024 17:28:09 GMT, Justin Lu wrote:
> Please review this PR which fixes incorrect usage of `jthrowable
> ExceptionOccurred(JNIEnv *env)` within _java.base_.
>
> This corrects instances where the return value is being treated as a boolean.
> Such occurrences are replaced with `jbo
On Thu, 10 Oct 2024 11:40:27 GMT, Alan Bateman wrote:
> > were left out from the commit for the PR but are listed in the JBS issue so
> > it would be great to include the updates as part of this PR or explain why
> > they were excluded if it was intentional
>
> The original bug report has seve
On Wed, 9 Oct 2024 17:28:09 GMT, Justin Lu wrote:
> Please review this PR which fixes incorrect usage of `jthrowable
> ExceptionOccurred(JNIEnv *env)` within _java.base_.
>
> This corrects instances where the return value is being treated as a boolean.
> Such occurrences are replaced with `jbo
On Tue, 12 Nov 2024 14:44:55 GMT, Sean Mullan wrote:
>> This is the implementation of JEP 486: Permanently Disable the Security
>> Manager. See [JEP 486](https://openjdk.org/jeps/486) for more details. The
>> [CSR](https://bugs.openjdk.org/browse/JDK-8338412) describes in detail the
>> main ch
On Wed, 18 Sep 2024 17:59:40 GMT, Justin Lu wrote:
>> Please review this PR which removes occurrences of 'applet' within the
>> corelibs specification. Applet has been deprecated since JDK9, and may be a
>> confusing term for new Java developers, so it should be removed from the
>> documentati
On Mon, 9 Dec 2024 15:42:57 GMT, Magnus Ihse Bursie wrote:
>> Some files have been modified in 2024, but the copyright year has not been
>> properly updated. This should be fixed.
>>
>> I have located these modified files using:
>>
>> git log --since="Jan 1" --name-only --pretty=format: | sor
On Thu, 13 Feb 2025 16:27:03 GMT, Sean Mullan wrote:
> This change adds an API note to these methods recommending that the caller
> should perform further validation steps on the code signers that signed the
> JAR file, such as validating the code signer's certificate chain, and
> determining
19 matches
Mail list logo
