Re: [jdk20] RFR: 8290919: Update nroff pages in JDK 20 before RC

2023-01-22 Thread Iris Clark
On Mon, 23 Jan 2023 02:59:42 GMT, David Holmes wrote: > There was one missing update in javac.1 from: > > [JDK-8245246](https://bugs.openjdk.org/browse/JDK-8245246): Deprecate > -profile option in javac > > otherwise the change is limited to dropping the "-ea". > > Thanks. Marked as reviewed

Re: RFR: 8290918: Initial nroff manpage generation for JDK 21

2023-01-23 Thread Iris Clark
On Mon, 23 Jan 2023 22:59:22 GMT, David Holmes wrote: > Please review this simple update to the manpage to set the version to 21-ea. > > This change also corrects a typo in javac.1 that was manually introduced by > JDK-8300591 > > Thanks. Marked as reviewed by iris (Reviewer). -

Re: RFR: JDK-8305206: Add @spec tags in java.base/java.* (part 1) [v2]

2023-03-31 Thread Iris Clark
On Thu, 30 Mar 2023 20:45:08 GMT, Jonathan Gibbons wrote: >> Please review a change to add `@spec` tags (and remove some equivalent >> `@see` tags) to the main "core-libs" packages in `java.base` module. >> >> This is similar to, and a subset of, PR #11073. That PR was withdrawn, and >> base

Re: RFR: JDK-8305206: Add @spec tags in java.base/java.* (part 1) [v3]

2023-03-31 Thread Iris Clark
On Fri, 31 Mar 2023 22:07:26 GMT, Jonathan Gibbons wrote: >> Please review a change to add `@spec` tags (and remove some equivalent >> `@see` tags) to the main "core-libs" packages in `java.base` module. >> >> This is similar to, and a subset of, PR #11073. That PR was withdrawn, and >> base

Re: RFR: 8304911: Use OperatingSystem enum in some modules

2023-04-04 Thread Iris Clark
On Tue, 4 Apr 2023 19:22:48 GMT, Roger Riggs wrote: > With the addition of `jdk.internal.util.OperatingSystem` references to the > system property `os.name` can be replaced. > This PR exports jdk.internal.util to: > - java.prefs, > - java.security.jgss, > - java.smartcardio, > - jdk.charsets

Re: RFR: 8304911: Use OperatingSystem enum in some modules [v3]

2023-04-05 Thread Iris Clark
On Wed, 5 Apr 2023 15:48:02 GMT, Roger Riggs wrote: >> With the addition of `jdk.internal.util.OperatingSystem` references to the >> system property `os.name` can be replaced. >> This PR exports jdk.internal.util to: >> - java.prefs, >> - java.security.jgss, >> - java.smartcardio, >> - jdk.c

Re: [jdk21] RFR: 8300937: Update nroff pages in JDK 21 before RC

2023-07-31 Thread Iris Clark
On Mon, 31 Jul 2023 08:33:07 GMT, David Holmes wrote: > Main changes are to use 21 instead of 21-ea. In addition the following files > contain additional updates from the closed sources: > > - src/java.base/share/man/java.1 > > [JDK-8273131](https://bugs.openjdk.org/browse/JDK-8273131): Updat

Re: RFR: 8267174: Many test files have the wrong Copyright header

2023-09-06 Thread Iris Clark
On Tue, 5 Sep 2023 22:49:41 GMT, Erik Joelsson wrote: > There are a number of files in the `test` directory that have an incorrect > copyright header, which includes the "classpath" exception text. This patch > removes that text from all test files that I could find it in. I did this > using a

Re: [jdk22] RFR: 8322066: Update troff manpages in JDK 22 before RC

2024-02-05 Thread Iris Clark
On Sun, 4 Feb 2024 22:43:28 GMT, David Holmes wrote: > This update drops the "ea" from the version string. > > We also propagate the following fixes from the markdown sources to the troff > manpage file: > > JDK-8322478: Update java manpage for multi-file source-code launcher > JDK-8302233: HS

Re: RFR: 8330178: Clean up non-standard use of /** comments in `java.base`

2024-04-18 Thread Iris Clark
On Thu, 18 Apr 2024 20:44:00 GMT, Jonathan Gibbons wrote: > Please review a set of updates to clean up use of `/**` comments in the > vicinity of declarations. > > There are various categories of update: > > * "Box comments" beginning with `/**` > * Misplaced doc comments before package or imp

Re: RFR: 8330178: Clean up non-standard use of /** comments in `java.base` [v2]

2024-04-22 Thread Iris Clark
On Fri, 19 Apr 2024 19:21:13 GMT, Jonathan Gibbons wrote: >> Please review a set of updates to clean up use of `/**` comments in the >> vicinity of declarations. >> >> There are various categories of update: >> >> * "Box comments" beginning with `/**` >> * Misplaced doc comments before package

Re: RFR: 8332181: Deprecate for removal the java.net.MulticastSocket.setTTL/getTTL and the 2-arg send methods [v2]

2024-05-17 Thread Iris Clark
On Fri, 17 May 2024 11:50:15 GMT, Jaikiran Pai wrote: >> Can I please get a review of this change which proposes to deprecate for >> removal 3 methods on `java.net.MulticastSocket`? This addresses >> https://bugs.openjdk.org/browse/JDK-8332181. >> >> As noted in that issue these methods have b

Re: RFR: 8332181: Deprecate for removal the MulticastSocket.send(DatagramPacket, byte) and setTTL/getTTL methods on DatagramSocketImpl and MulticastSocket [v3]

2024-05-20 Thread Iris Clark
On Mon, 20 May 2024 06:02:31 GMT, Jaikiran Pai wrote: >> Can I please get a review of this change which proposes to deprecate for >> removal 3 methods on `java.net.MulticastSocket`? This addresses >> https://bugs.openjdk.org/browse/JDK-8332181. >> >> As noted in that issue these methods have b

Re: RFR: 8330205: Initial troff manpage generation for JDK 24

2024-06-10 Thread Iris Clark
On Mon, 10 Jun 2024 02:31:00 GMT, David Holmes wrote: > Sets the version to 24/24-ea and the copyright year to 2025. > > Content changes related to the start of release (e.g. for removed options in > java.1) are handled separately. > > This initial generation also picks up the unpublished chan

Re: [jdk23] RFR: 8325280: Update troff manpages in JDK 23 before RC

2024-07-19 Thread Iris Clark
On Fri, 19 Jul 2024 05:47:15 GMT, David Holmes wrote: > Before RC we need to update the man pages in the repo from their Markdown > sources. All pages at a minimum have 23-ea replaced with 23, and publication > year set to 2024 if needed. > > This also picks up the unpublished changes to java.

Re: RFR: 8342827: Fix order of @param tags in other modules [v2]

2024-10-25 Thread Iris Clark
On Thu, 24 Oct 2024 12:17:41 GMT, Hannes Wallnöfer wrote: >> Please review a doc-only change to fix the order of javadoc @param tags in >> in various OpenJDK modules. This is the third and last PR to fix the order >> of @param tags in OpenJDK libraries. >> >> We are working on a javadoc featur

Re: RFR: 8339735: Remove references to Applet in core-libs/security APIs [v2]

2024-09-18 Thread Iris Clark
On Wed, 18 Sep 2024 17:59:40 GMT, Justin Lu wrote: >> Please review this PR which removes occurrences of 'applet' within the >> corelibs specification. Applet has been deprecated since JDK9, and may be a >> confusing term for new Java developers, so it should be removed from the >> documentati

Re: RFR: 8344525: Fix leftover ExceptionOccurred in java.base

2024-11-20 Thread Iris Clark
On Wed, 20 Nov 2024 03:02:39 GMT, Justin Lu wrote: > Please review this PR which removes the leftover ocurrences of incorrect JNI > `ExceptionOccurred(env)` usage within _java.base_. > > This PR also includes 9 cases of `if (ExceptionOccurred(env) == NULL)`. While > these occurrences are fine

Re: RFR: 8344056: Use markdown format for man pages [v2]

2024-11-14 Thread Iris Clark
On Thu, 14 Nov 2024 11:11:54 GMT, Magnus Ihse Bursie wrote: >> Currently, the man pages are stored as troff (a text format) in the open >> repo, and a content-wise identical copy is stored as markdown (another text >> format) in the closed repo. >> >> Since markdown is preferred to troff in te

Re: RFR: 8344056: Use markdown format for man pages

2024-11-13 Thread Iris Clark
On Wed, 13 Nov 2024 21:27:02 GMT, David Holmes wrote: >> Currently, the man pages are stored as troff (a text format) in the open >> repo, and a content-wise identical copy is stored as markdown (another text >> format) in the closed repo. >> >> Since markdown is preferred to troff in terms of

Re: RFR: 8344056: Use markdown format for man pages [v4]

2024-11-17 Thread Iris Clark
On Fri, 15 Nov 2024 14:50:21 GMT, Magnus Ihse Bursie wrote: >> Currently, the man pages are stored as troff (a text format) in the open >> repo, and a content-wise identical copy is stored as markdown (another text >> format) in the closed repo. >> >> Since markdown is preferred to troff in te

Re: RFR: 8351897: Extra closing curly brace typos in Javadoc

2025-03-12 Thread Iris Clark
On Thu, 13 Mar 2025 01:21:54 GMT, Archie Cobbs wrote: > This PR fixes minor Javadoc typos in a few `java.base` classes. Extra curly > braces have been sneaking in. src/java.base/share/classes/java/text/MessageFormat.java line 327: > 325: * {@code unit} > 326: * {@link ListFormat#

Re: RFR: 8353641: Deprecate core library permission classes for removal [v3]

2025-04-04 Thread Iris Clark
On Fri, 4 Apr 2025 18:21:29 GMT, Roger Riggs wrote: >> Now that the Security Manager is permanently disabled, the following >> permission classes in the core libraries area can be deprecated for removal >> as they are no longer useful: FilePermission, LinkPermission, >> LoggingPermission, Prop

Re: RFR: 8348967: Deprecate security permission classes for removal [v2]

2025-04-04 Thread Iris Clark
On Fri, 4 Apr 2025 18:04:39 GMT, Sean Mullan wrote: >> Please review this change to terminally deprecate the following security >> related permission classes: `java.security.UnresolvedPermission`, >> `javax.net.ssl.SSLPermission`, `javax.security.auth.AuthPermission`, >> `javax.security.auth.P

Re: RFR: 8353642: Deprecate URL::getPermission method and networking permission classes for removal [v4]

2025-05-08 Thread Iris Clark
On Thu, 8 May 2025 16:10:18 GMT, Daniel Fuchs wrote: >> Please find her a patch that deprecate networking permission classes for >> removal. The method `URL::getPermission` now serves little purpose and is >> also deprecated. That method was overridden in subclasses and specified to >> return