On Wed, 7 May 2025 09:23:45 GMT, Per Minborg wrote:
>> This sketch shows how "Stable Updaters" can be used to create stable
>> computations of `@Stable` fields. Only one updater is needed per class,
>> similar to `AtomicIntegerFieldUpdater`.
>
> Per Minborg has updated the pull request incremen
On Thu, 8 May 2025 13:16:25 GMT, Per Minborg wrote:
>> This sketch shows how "Stable Updaters" can be used to create stable
>> computations of `@Stable` fields. Only one updater is needed per class,
>> similar to `AtomicIntegerFieldUpdater`.
>
> Per Minborg has updated the pull request incremen
Simplifying JavaRuntimeURLConnection to avoid accidentally returning
non-resource data to users.
This change has the following distinct parts:
1. Refactor code to use Node instead of directly accessing low level
ImageLocation type.
2. Remove unnecessary use of "Resource" interface and related UR
On Wed, 18 Jun 2025 12:53:56 GMT, David Beaumont wrote:
> Simplifying JavaRuntimeURLConnection to avoid accidentally returning
> non-resource data to users.
>
> This change has the following distinct parts:
> 1. Refactor code to use Node instead of directly accessing low level
On Wed, 18 Jun 2025 13:37:49 GMT, Alan Bateman wrote:
>> Happy to accept rewording here. I do want to pull out that there *is* a
>> conceptual reason for treating module names like domain authorities though,
>> or just make the code treat the whole path the same.
>> Having unexplained weirdness
On Wed, 18 Jun 2025 13:11:00 GMT, Alan Bateman wrote:
>> Simplifying JavaRuntimeURLConnection to avoid accidentally returning
>> non-resource data to users.
>>
>> This change has the following distinct parts:
>> 1. Refactor code to use Node instead of directly accessing low level
>> ImageLocat
s for the non-resource cases.
> 7. Adding extra test data to check the behaviour with respect to things like
> percent escaping (previously untested).
> 8. Adding TODO comments for things I could do in this PR or later (reviewer
> opinions welcome).
David Beaumont has updated the pull reque
On Wed, 18 Jun 2025 13:54:42 GMT, David Beaumont wrote:
>>> Happy to accept rewording here. I do want to pull out that there _is_ a
>>> conceptual reason for treating module names like domain authorities though,
>>> or just make the code treat the whole path t
s for the non-resource cases.
> 7. Adding extra test data to check the behaviour with respect to things like
> percent escaping (previously untested).
> 8. Adding TODO comments for things I could do in this PR or later (reviewer
> opinions welcome).
David Beaumont has updated the pull requ
On Thu, 19 Jun 2025 15:36:13 GMT, Alan Bateman wrote:
>> David Beaumont has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Reworking comment and adjusting TODOs.
>
> src/java.base/share/cl
On Fri, 20 Jun 2025 10:55:53 GMT, David Beaumont wrote:
>> src/java.base/share/classes/sun/net/www/protocol/jrt/JavaRuntimeURLConnection.java
>> line 50:
>>
>>> 48: private static final ImageReader READER =
>>> ImageReaderFactory.getImageReader();
&g
On Wed, 18 Jun 2025 16:48:45 GMT, David Beaumont wrote:
>> Simplifying JavaRuntimeURLConnection to avoid accidentally returning
>> non-resource data to users.
>>
>> This change has the following distinct parts:
>> 1. Refactor code to use Node instead o
On Sat, 21 Jun 2025 08:51:57 GMT, Alan Bateman wrote:
>> src/java.base/share/classes/sun/net/www/protocol/jrt/JavaRuntimeURLConnection.java
>> line 128:
>>
>>> 126: if (path.indexOf('%') == -1) {
>>> 127: // Nothing to decode (overwhelmingly common case).
>>> 128:
On Tue, 24 Jun 2025 14:48:31 GMT, Alan Bateman wrote:
>> David Beaumont has updated the pull request incrementally with three
>> additional commits since the last revision:
>>
>> - Remove redundant fast-path check.
>> - Change method name.
>> - Feedback
s for the non-resource cases.
> 7. Adding extra test data to check the behaviour with respect to things like
> percent escaping (previously untested).
> 8. Adding TODO comments for things I could do in this PR or later (reviewer
> opinions welcome).
David Beaumont has updated the pull reque
On Wed, 18 Jun 2025 12:53:56 GMT, David Beaumont wrote:
> Simplifying JavaRuntimeURLConnection to avoid accidentally returning
> non-resource data to users.
>
> This change has the following distinct parts:
> 1. Refactor code to use Node instead of directly accessing low level
On Fri, 20 Jun 2025 11:13:12 GMT, David Beaumont wrote:
>> Simplifying JavaRuntimeURLConnection to avoid accidentally returning
>> non-resource data to users.
>>
>> This change has the following distinct parts:
>> 1. Refactor code to use Node instead o
On Sat, 21 Jun 2025 08:47:14 GMT, Alan Bateman wrote:
>> David Beaumont has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Feedback changes and renaming field to match nomenclature of JEP 220.
>
> src/java.
On Sat, 21 Jun 2025 09:03:10 GMT, Alan Bateman wrote:
>> David Beaumont has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Feedback changes and renaming field to match nomenclature of JEP 220.
>
> src/java.
On Fri, 20 Jun 2025 16:20:37 GMT, Roger Riggs wrote:
>> src/java.base/share/classes/sun/net/www/protocol/jrt/JavaRuntimeURLConnection.java
>> line 119:
>>
>>> 117: public long getContentLengthLong() {
>>> 118: try {
>>> 119: return getResourceNode().size();
>>
>> Having
On Sat, 21 Jun 2025 08:50:15 GMT, Alan Bateman wrote:
>> src/java.base/share/classes/sun/net/www/protocol/jrt/JavaRuntimeURLConnection.java
>> line 133:
>>
>>> 131: return ParseUtil.decode(path);
>>> 132: } catch (IllegalArgumentException e) {
>>> 133: throw new
On Mon, 23 Jun 2025 11:01:02 GMT, David Beaumont wrote:
>> src/java.base/share/classes/sun/net/www/protocol/jrt/JavaRuntimeURLConnection.java
>> line 60:
>>
>>> 58:
>>> 59: // The resource node (when connected).
>>> 60: private volatile N
s for the non-resource cases.
> 7. Adding extra test data to check the behaviour with respect to things like
> percent escaping (previously untested).
> 8. Adding TODO comments for things I could do in this PR or later (reviewer
> opinions welcome).
David Beaumont has updated the pull reques
On Fri, 20 Jun 2025 11:13:12 GMT, David Beaumont wrote:
>> Simplifying JavaRuntimeURLConnection to avoid accidentally returning
>> non-resource data to users.
>>
>> This change has the following distinct parts:
>> 1. Refactor code to use Node instead o
On Sat, 21 Jun 2025 08:26:41 GMT, Alan Bateman wrote:
>> These were here explicitly to be discussed in review. If you think it's now
>> covered by JDK-8359949, I can remove them.
>
>> These were here explicitly to be discussed in review. If you think it's now
>> covered by JDK-8359949, I can re
25 matches
Mail list logo
