On Wed, 5 Apr 2023 16:45:06 GMT, Jonathan Gibbons wrote:
>> Please review a doc update to add `@spec` into the rest of the files in
>> `java.base` (compared to those in
>> [JDK-8305206](https://bugs.openjdk.org/browse/JDK-8305206) PR #13248)
>
> Jonathan Gibbons has updated the pull request inc
On Wed, 29 May 2024 15:45:12 GMT, Mark Powers wrote:
> https://bugs.openjdk.org/browse/JDK-4966250
This needs a CSR before pushing.
-
PR Comment: https://git.openjdk.org/jdk/pull/19458#issuecomment-2138078036
> Update and clarify the sample code.
>
> Docs only, no additional testing other than verifying javadoc is correctly
> output.
Bradford Wetmore has updated the pull request incrementally with one additional
commit since the last revision:
Codereview Comments
-
Chan
On Tue, 4 Feb 2025 17:18:09 GMT, Daniel Fuchs wrote:
>> Bradford Wetmore has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Codereview Comments
>
> src/java.base/share/classes/javax/net/ssl/SSLParam
> Update and clarify the sample code.
>
> Docs only, no additional testing other than verifying javadoc is correctly
> output.
Bradford Wetmore has updated the pull request with a new target base due to a
merge or a rebase. The incremental webrev excludes the unrelated changes
b
On Fri, 31 Jan 2025 01:45:47 GMT, Bradford Wetmore wrote:
> Update and clarify the sample code.
>
> Docs only, no additional testing other than verifying javadoc is correctly
> output.
This pull request has now been integrated.
Changeset: 88a84835
Author: Bradford
On Thu, 6 Feb 2025 19:10:04 GMT, Artur Barashev wrote:
>> Bradford Wetmore has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Codereview Comments
>
> src/java.base/share/classes/javax/net/ssl/SSLParam
> Update and clarify the sample code.
>
> Docs only, no additional testing other than verifying javadoc is correctly
> output.
Bradford Wetmore has updated the pull request incrementally with one additional
commit since the last revision:
minor wording tweak
-
Chan
On Wed, 5 Feb 2025 12:03:52 GMT, Daniel Fuchs wrote:
>> src/java.base/share/classes/javax/net/ssl/SSLParameters.java line 672:
>>
>>> 670: * // Also, encode a two byte RFC 8701 GREASE ALPN value
>>> 671: * // e.g. 0x0A, 0x1A, 0x2A...0xFA
>>> 672: * String rfc8701Gr
On Wed, 5 Feb 2025 12:02:26 GMT, Daniel Fuchs wrote:
>> Bradford Wetmore has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Codereview Comments
>
> src/java.base/share/classes/javax/net/ssl/SSLParam
Update and clarify the sample code.
Docs only, no additional testing other than verifying javadoc is correctly
output.
-
Commit messages:
- 8349121: SSLParameters.setApplicationProtocols() ALPN example could be
clarified
Changes: https://git.openjdk.org/jdk/pull/23379/files
Web
Adds the RFC 5705/8446 TLS Key Exporters API/implementation to JSSE/SunJSSE
respectively.
CSR is underway.
Tests include new unit tests for TLSv1-1.3. Will run tier1-2, plus the JCK API
(jck:api/java_security jck:api/javax_crypto jck:api/javax_net
jck:api/javax_security jck:api/org_ietf jck:a
; jck:api/javax_security jck:api/org_ietf jck:api/javax_xml/crypto)
Bradford Wetmore has updated the pull request incrementally with one additional
commit since the last revision:
Moved too fast
-
Changes:
- all: https://git.openjdk.org/jdk/pull/24976/files
- new: https://git.op
; jck:api/javax_security jck:api/org_ietf jck:api/javax_xml/crypto)
Bradford Wetmore has updated the pull request incrementally with one additional
commit since the last revision:
Tweak API to be more KDF like in unextractable case.
-
Changes:
- all: https://git.openjdk.org/jdk/
; jck:api/javax_security jck:api/org_ietf jck:api/javax_xml/crypto)
Bradford Wetmore has updated the pull request incrementally with one additional
commit since the last revision:
Codereview comments.
-
Changes:
- all: https://git.openjdk.org/jdk/pull/24976/files
- new: https://
On Thu, 1 May 2025 18:24:19 GMT, Artur Barashev wrote:
>> Bradford Wetmore has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Moved too fast
>
> test/jdk/javax/net/ssl/ExtendedSSLSession/TLSKeyExpo
On Thu, 1 May 2025 15:18:43 GMT, Weijun Wang wrote:
>> Bradford Wetmore has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Moved too fast
>
> src/java.base/share/classes/sun/security/ssl/SSLSessionI
On Thu, 1 May 2025 18:26:03 GMT, Artur Barashev wrote:
>> Bradford Wetmore has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Moved too fast
>
> test/jdk/javax/net/ssl/ExtendedSSLSession/TLSKeyExpo
On Wed, 7 May 2025 16:28:27 GMT, Weijun Wang wrote:
>> Bradford Wetmore has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Updated to use the upcoming KDF (still in preview) + bits of JDK-8353578
>> for
; jck:api/javax_security jck:api/org_ietf jck:api/javax_xml/crypto)
Bradford Wetmore has updated the pull request incrementally with one additional
commit since the last revision:
More Codereview comments
-
Changes:
- all: https://git.openjdk.org/jdk/pull/24976/files
- new: https://
; jck:api/javax_security jck:api/org_ietf jck:api/javax_xml/crypto)
Bradford Wetmore has updated the pull request with a new target base due to a
merge or a rebase. The pull request now contains 13 commits:
- Merge branch 'master' into JDK-8341346
- Adjustments made for JDK-8350830
- Merg
; jck:api/javax_security jck:api/org_ietf jck:api/javax_xml/crypto)
Bradford Wetmore has updated the pull request incrementally with one additional
commit since the last revision:
More codereview comments
-
Changes:
- all: https://git.openjdk.org/jdk/pull/24976/files
- new: https://
On Mon, 12 May 2025 14:58:07 GMT, Sean Mullan wrote:
>> Bradford Wetmore has updated the pull request with a new target base due to
>> a merge or a rebase. The pull request now contains 13 commits:
>>
>> - Merge branch 'master' into JDK-8341346
>
; jck:api/javax_security jck:api/org_ietf jck:api/javax_xml/crypto)
Bradford Wetmore has updated the pull request incrementally with one additional
commit since the last revision:
Missed one review comment
-
Changes:
- all: https://git.openjdk.org/jdk/pull/24976/files
- new: htt
On Mon, 12 May 2025 15:07:20 GMT, Sean Mullan wrote:
>> Bradford Wetmore has updated the pull request with a new target base due to
>> a merge or a rebase. The pull request now contains 13 commits:
>>
>> - Merge branch 'master' into JDK-8341346
>
; jck:api/javax_security jck:api/org_ietf jck:api/javax_xml/crypto)
Bradford Wetmore has updated the pull request incrementally with one additional
commit since the last revision:
Rework to avoid PKCS11 data extraction problems, and enhanced input
verification and unit testing
-
; jck:api/javax_security jck:api/org_ietf jck:api/javax_xml/crypto)
Bradford Wetmore has updated the pull request incrementally with one additional
commit since the last revision:
Add in the SharedSecrets SecretKeySpec clearing mechanism
-
Changes:
- all: https://git.openjdk.org/jdk/
; jck:api/javax_security jck:api/org_ietf jck:api/javax_xml/crypto)
Bradford Wetmore has updated the pull request incrementally with one additional
commit since the last revision:
Updated to use the upcoming KDF (still in preview) + bits of JDK-8353578 for
compilation)
-
; jck:api/javax_security jck:api/org_ietf jck:api/javax_xml/crypto)
Bradford Wetmore has updated the pull request with a new target base due to a
merge or a rebase. The incremental webrev excludes the unrelated changes
brought in by the merge/rebase. The pull request contains six additional
commits
On Mon, 12 May 2025 15:02:31 GMT, Sean Mullan wrote:
>> Bradford Wetmore has updated the pull request with a new target base due to
>> a merge or a rebase. The pull request now contains 13 commits:
>>
>> - Merge branch 'master' into JDK-8341346
>
On Mon, 12 May 2025 14:45:36 GMT, Sean Mullan wrote:
>> Bradford Wetmore has updated the pull request with a new target base due to
>> a merge or a rebase. The pull request now contains 13 commits:
>>
>> - Merge branch 'master' into JDK-8341346
>
On Sat, 10 May 2025 13:48:05 GMT, Weijun Wang wrote:
>> Bradford Wetmore has updated the pull request with a new target base due to
>> a merge or a rebase. The pull request now contains 13 commits:
>>
>> - Merge branch 'master' into JDK-8341346
>
; jck:api/javax_security jck:api/org_ietf jck:api/javax_xml/crypto)
Bradford Wetmore has updated the pull request with a new target base due to a
merge or a rebase. The pull request now contains 17 commits:
- Merge
- Merge branch 'master' into JDK-8341346
- Missed one review comment
-
; jck:api/javax_security jck:api/org_ietf jck:api/javax_xml/crypto)
Bradford Wetmore has updated the pull request with a new target base due to a
merge or a rebase. The pull request now contains 16 commits:
- Merge branch 'master' into JDK-8341346
- Missed one review comment
- More c
; jck:api/javax_security jck:api/org_ietf jck:api/javax_xml/crypto)
Bradford Wetmore has updated the pull request incrementally with one additional
commit since the last revision:
Updated copyright dates.
-
Changes:
- all: https://git.openjdk.org/jdk/pull/24976/files
- new: https://
On Fri, 16 May 2025 16:50:22 GMT, Sean Mullan wrote:
>> Personally, I would like to give user the chance to specify the algorithm
>> themselves. A "TlsExporterKeyingMaterial" key will not be accepted by an AES
>> cipher. If you are not ready for this, I'd rather only provide the
>> `exportKeyi
On Thu, 8 May 2025 06:03:03 GMT, Bradford Wetmore wrote:
>> src/java.base/share/classes/sun/security/ssl/SSLSessionImpl.java line 1694:
>>
>>> 1692:
>>> 1693: // ...now the final expand.
>>> 1694: SecretKey key = h
On Wed, 7 May 2025 16:21:23 GMT, Weijun Wang wrote:
>> Bradford Wetmore has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Updated to use the upcoming KDF (still in preview) + bits of JDK-8353578
>> for
On Thu, 15 May 2025 04:22:42 GMT, Bradford Wetmore wrote:
>> src/java.base/share/classes/sun/security/ssl/SSLSessionImpl.java line 1650:
>>
>>> 1648: emptyHash = md.digest();
>>> 1649: } catch (NoSuchAlgor
On Fri, 16 May 2025 17:17:04 GMT, Bradford Wetmore wrote:
>> How about adding a `String alg` parameter to `exportKeyingMaterialKey` like
>> in the `KDF.deriveKey` API?
>
> As discussed with @seanjmullan / @wangweij , that is the direction I'll try.
> It's not
On Tue, 13 May 2025 13:07:18 GMT, Weijun Wang wrote:
>> It seems like it should be an exception, whatever you decide to do. The
>> caller is asking for the keying material data, and the provider cannot
>> fulfill that request, so I think explaining why it could not be done would
>> be best rep
; jck:api/javax_security jck:api/org_ietf jck:api/javax_xml/crypto)
Bradford Wetmore has updated the pull request with a new target base due to a
merge or a rebase. The pull request now contains 25 commits:
- Merge branch 'master' into JDK-8341346
- Updated API to include SecretKey t
On Wed, 14 May 2025 19:17:15 GMT, Daniel Jeliński wrote:
>> Bradford Wetmore has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Merged with changes for JDK-8353578
>
> src/java.base/share/classes/sun/securit
; jck:api/javax_security jck:api/org_ietf jck:api/javax_xml/crypto)
Bradford Wetmore has updated the pull request incrementally with one additional
commit since the last revision:
Merged with changes for JDK-8353578
-
Changes:
- all: https://git.openjdk.org/jdk/pull/24
On Tue, 13 May 2025 13:23:16 GMT, Weijun Wang wrote:
>> Bradford Wetmore has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Missed one review comment
>
> src/java.base/share/classes/sun/security/ssl
On Tue, 13 May 2025 21:44:21 GMT, Artur Barashev wrote:
>> Bradford Wetmore has updated the pull request with a new target base due to
>> a merge or a rebase. The pull request now contains 16 commits:
>>
>> - Merge branch 'master' into JDK-8341346
>>
On Wed, 14 May 2025 20:13:36 GMT, Artur Barashev wrote:
>> Bradford Wetmore has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Merged with changes for JDK-8353578
>
> src/java.base/share/classes/sun/securit
On Wed, 14 May 2025 21:42:06 GMT, Bradford Wetmore wrote:
>> src/java.base/share/classes/sun/security/ssl/SSLSessionImpl.java line 329:
>>
>>> 327: */
>>> 328:
>>> 329: SSLSessionImpl(HandshakeContext hc, ByteBuffer buf) throws
>>> I
On Tue, 13 May 2025 13:25:21 GMT, Weijun Wang wrote:
>> Bradford Wetmore has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Missed one review comment
>
> src/java.base/share/classes/sun/security/ssl
On Tue, 13 May 2025 12:16:37 GMT, Sean Mullan wrote:
>> Bradford Wetmore has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Missed one review comment
>
> src/java.base/share/classes/javax/net/ssl/ExtendedSSLSe
On Tue, 13 May 2025 13:37:18 GMT, Weijun Wang wrote:
>> Bradford Wetmore has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Missed one review comment
>
> src/java.base/share/classes/sun/security/ssl
On Thu, 15 May 2025 12:51:16 GMT, Artur Barashev wrote:
>> Sure.
>
> Also, the parentheses are not needed around `context != null`
If there's one things to know about me, it's my liberal use of parens. I want
my code to match my intent.
I plan to update the "missing" parens.
-
P
; jck:api/javax_security jck:api/org_ietf jck:api/javax_xml/crypto)
Bradford Wetmore has updated the pull request incrementally with one additional
commit since the last revision:
Added PKCS11 testing
-
Changes:
- all: https://git.openjdk.org/jdk/pull/24976/files
- new: https://
; jck:api/javax_security jck:api/org_ietf jck:api/javax_xml/crypto)
Bradford Wetmore has updated the pull request incrementally with one additional
commit since the last revision:
Missed one change
-
Changes:
- all: https://git.openjdk.org/jdk/pull/24976/files
- new: https://git.op
; jck:api/javax_security jck:api/org_ietf jck:api/javax_xml/crypto)
Bradford Wetmore has updated the pull request with a new target base due to a
merge or a rebase. The pull request now contains 30 commits:
- Merge branch 'master' into JDK-8341346
- Private Codereview comment: Don'
; jck:api/javax_security jck:api/org_ietf jck:api/javax_xml/crypto)
Bradford Wetmore has updated the pull request incrementally with one additional
commit since the last revision:
Minor bug
-
Changes:
- all: https://git.openjdk.org/jdk/pull/24976/files
- new: https://git.openjdk.
On Mon, 19 May 2025 22:24:52 GMT, Jamil Nimeh wrote:
>> Bradford Wetmore has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> get*() no longer needed, backout error (oops!)
>
> src/java.base/share/classes/sun/se
; jck:api/javax_security jck:api/org_ietf jck:api/javax_xml/crypto)
Bradford Wetmore has updated the pull request with a new target base due to a
merge or a rebase. The pull request now contains 27 commits:
- Merge branch 'master' into JDK-8341346
- Updated copyright dates.
- Merg
On Mon, 19 May 2025 15:06:26 GMT, Hai-May Chao wrote:
>> Bradford Wetmore has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Updated copyright dates.
>
> src/java.base/share/classes/sun/security/ssl/SSLSessio
; jck:api/javax_security jck:api/org_ietf jck:api/javax_xml/crypto)
Bradford Wetmore has updated the pull request incrementally with one additional
commit since the last revision:
get*() no longer needed, backout error (oops!)
-
Changes:
- all: https://git.openjdk.org/jdk/pull/24
On Mon, 19 May 2025 15:13:26 GMT, Hai-May Chao wrote:
>> Bradford Wetmore has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Updated copyright dates.
>
> src/java.base/share/classes/sun/security/ssl
On Thu, 15 May 2025 20:42:39 GMT, Sean Mullan wrote:
>> Bradford Wetmore has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Merged with changes for JDK-8353578
>
> src/java.base/share/classes/javax/net/ssl/Ex
; jck:api/javax_security jck:api/org_ietf jck:api/javax_xml/crypto)
Bradford Wetmore has updated the pull request with a new target base due to a
merge or a rebase. The pull request now contains 23 commits:
- Merge branch 'master' into JDK-8341346
- Minor Codereview comments.
- Codereview
On Tue, 13 May 2025 17:13:03 GMT, Artur Barashev wrote:
>> Bradford Wetmore has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Missed one review comment
>
> test/jdk/javax/net/ssl/ExtendedSSLSession/Expor
; jck:api/javax_security jck:api/org_ietf jck:api/javax_xml/crypto)
Bradford Wetmore has updated the pull request with a new target base due to a
merge or a rebase. The pull request now contains 34 commits:
- Merge branch 'master' into JDK-8341346
- Added PKCS11 testing
- Minor bug
-
; jck:api/javax_security jck:api/org_ietf jck:api/javax_xml/crypto)
Bradford Wetmore has updated the pull request with a new target base due to a
merge or a rebase. The pull request now contains 36 commits:
- Remove TlsExporterKeyingMaterial for now. Can add later if needed.
- Merge branch &
On Tue, 27 May 2025 23:37:45 GMT, Artur Barashev wrote:
>> Bradford Wetmore has updated the pull request with a new target base due to
>> a merge or a rebase. The pull request now contains 36 commits:
>>
>> - Remove TlsExporterKeyingMaterial for now. Can add late
On Thu, 29 May 2025 14:08:10 GMT, Weijun Wang wrote:
>> Bradford Wetmore has updated the pull request with a new target base due to
>> a merge or a rebase. The pull request now contains 37 commits:
>>
>> - Merge branch 'master' into JDK-8341346
>> -
On Thu, 29 May 2025 14:09:38 GMT, Weijun Wang wrote:
>> Bradford Wetmore has updated the pull request with a new target base due to
>> a merge or a rebase. The pull request now contains 37 commits:
>>
>> - Merge branch 'master' into JDK-8341346
>> -
On Thu, 29 May 2025 14:12:47 GMT, Weijun Wang wrote:
>> Bradford Wetmore has updated the pull request with a new target base due to
>> a merge or a rebase. The pull request now contains 37 commits:
>>
>> - Merge branch 'master' into JDK-8341346
>> -
On Wed, 30 Apr 2025 22:39:47 GMT, Bradford Wetmore wrote:
> Adds the RFC 5705/8446 TLS Key Exporters API/implementation to JSSE/SunJSSE
> respectively.
>
> CSR is complete/approved.
>
> Tests include new unit tests for TLSv1-1.3. Have run tier1-2, plus the JCK
> API (
On Thu, 29 May 2025 14:22:16 GMT, Weijun Wang wrote:
>> Bradford Wetmore has updated the pull request with a new target base due to
>> a merge or a rebase. The pull request now contains 37 commits:
>>
>> - Merge branch 'master' into JDK-8341346
>> -
On Thu, 29 May 2025 11:17:50 GMT, Hai-May Chao wrote:
>> Bradford Wetmore has updated the pull request with a new target base due to
>> a merge or a rebase. The pull request now contains 37 commits:
>>
>> - Merge branch 'master' into JDK-8341346
>> -
/javax_net
> jck:api/javax_security jck:api/org_ietf jck:api/javax_xml/crypto)
Bradford Wetmore has updated the pull request with a new target base due to a
merge or a rebase. The pull request now contains 37 commits:
- Merge branch 'master' into JDK-8341346
- Remove TlsExporterKeyingMaterial
On Thu, 29 May 2025 14:42:00 GMT, Weijun Wang wrote:
>> Bradford Wetmore has updated the pull request with a new target base due to
>> a merge or a rebase. The pull request now contains 37 commits:
>>
>> - Merge branch 'master' into JDK-8341346
>> -
/javax_net
> jck:api/javax_security jck:api/org_ietf jck:api/javax_xml/crypto)
Bradford Wetmore has updated the pull request incrementally with one additional
commit since the last revision:
Last minute codereview comments
-
Changes:
- all: https://git.openjdk.org/jdk/pull/24
/javax_net
> jck:api/javax_security jck:api/org_ietf jck:api/javax_xml/crypto)
Bradford Wetmore has updated the pull request with a new target base due to a
merge or a rebase. The pull request now contains 40 commits:
- Merge branch 'master' into JDK-8341346
- Merge branch 'master'
/javax_net
> jck:api/javax_security jck:api/org_ietf jck:api/javax_xml/crypto)
Bradford Wetmore has updated the pull request incrementally with one additional
commit since the last revision:
Resolved Merge Problem
-
Changes:
- all: https://git.openjdk.org/jdk/pull/24976/files
- new:
On Fri, 25 Jul 2025 16:27:42 GMT, Artur Barashev wrote:
> Add a javadoc paragraph to SSLSocket.startHandshake() and
> SSLEngine.beginHandshake() methods explaining behavioral differences between
> TLSv1.3+ and TLSv1.2- versions.
The renegotiation wording should probably updated in both the
SS
On Fri, 1 Aug 2025 15:18:10 GMT, Artur Barashev wrote:
>> Add a javadoc paragraph to SSLSocket.startHandshake() and
>> SSLEngine.beginHandshake() methods explaining behavioral differences between
>> TLSv1.3+ and TLSv1.2- versions.
>
> Artur Barashev has updated the pull request incrementally wi
On Mon, 28 Jul 2025 14:12:12 GMT, Artur Barashev wrote:
>> Add a javadoc paragraph to SSLSocket.startHandshake() and
>> SSLEngine.beginHandshake() methods explaining behavioral differences between
>> TLSv1.3+ and TLSv1.2- versions.
>
> Artur Barashev has updated the pull request incrementally w
On Thu, 31 Jul 2025 18:53:20 GMT, Artur Barashev wrote:
>> Add a javadoc paragraph to SSLSocket.startHandshake() and
>> SSLEngine.beginHandshake() methods explaining behavioral differences between
>> TLSv1.3+ and TLSv1.2- versions.
>
> Artur Barashev has updated the pull request incrementally w
82 matches
Mail list logo
