Re: RFR: JDK-6956385: URLConnection.getLastModified() leaks file handles for jar:file and file: URLs [v3]

2023-05-22 Thread Bernd
On Fri, 19 May 2023 15:46:14 GMT, Jesse Glick wrote: >> [JDK-6956385](https://bugs.openjdk.org/browse/JDK-6956385): >> `JarURLConnection` properly tracks any `InputStream` it itself opened, and >> correspondingly closes the `JarFile` if necessary (when caches are >> disabled). However if its u

Re: RFR: JDK-6956385: URLConnection.getLastModified() leaks file handles for jar:file and file: URLs [v3]

2023-05-22 Thread Bernd
On Mon, 22 May 2023 16:04:10 GMT, Jesse Glick wrote: >> src/java.base/share/classes/sun/net/www/protocol/jar/JarURLConnection.java >> line 97: >> >>> 95: } >>> 96: } finally { >>> 97: if (jarFileURLConnection instanceof >>> FileURLConnect

Re: RFR: 8272215: Add InetAddress methods for parsing IP address literals

2023-09-17 Thread Bernd
On Sun, 17 Sep 2023 23:21:23 GMT, Mark Sheppard wrote: > on further reflection, wrt method name, an overloaded getByAddress(String > literalAddress) method is most appropriate I agree, and it should have both variants, getByAddtess(String literalSddress) throes UHE GetByAdress(String hostname,

Re: RFR: 8272215: Add InetAddress methods for parsing IP address literals

2023-09-18 Thread Bernd
On Mon, 18 Sep 2023 14:14:57 GMT, Daniel Fuchs wrote: > * Inet4Address.ofLiteral("06.07.08.09")==>/6.7.8.9 if we ignore octal encoding, we should document it explicitely. Maybe > The loose IPv4 syntax of partial numbers or hex encoding ("10.0.258", > "0xA000102") is not

Re: RFR: 8272215: Add InetAddress methods for parsing IP address literals

2023-10-16 Thread Bernd
On Sun, 17 Sep 2023 23:21:23 GMT, Mark Sheppard wrote: > on further reflection, wrt method name, an overloaded getByAddress(String > literalAddress) method is most appropriate I agree, and it should have both variants, getByAddtess(String literalAddress) throws UHE getByAdress(String hostnam

Re: RFR: 8272215: Add InetAddress methods for parsing IP address literals

2023-10-16 Thread Bernd
On Mon, 18 Sep 2023 14:14:57 GMT, Daniel Fuchs wrote: > * Inet4Address.ofLiteral("06.07.08.09")==>/6.7.8.9 if we ignore octal encoding, we should document it explicitely. Maybe > The loose IPv4 syntax of partial numbers or hex encoding ("10.0.258", > "0xA000102") is not

Re: RFR: JDK-8323276: StressDirListings.java fails on AIX [v2]

2024-01-11 Thread Bernd
On Thu, 11 Jan 2024 08:50:51 GMT, Varada M wrote: >> The delay in response has caused an incomplete test and timeout error. >> Setting the TCP_NODELAY socket option to 1 by the property >> sun.net.httpserver.nodelay solves the issue. >> >> JBS Issue : [JDK-8323276](https://bugs.openjdk.org/bro

Re: RFR: JDK-8323276: StressDirListings.java fails on AIX [v2]

2024-01-27 Thread Bernd
On Thu, 11 Jan 2024 08:50:51 GMT, Varada M wrote: >> The delay in response has caused an incomplete test and timeout error. >> Setting the TCP_NODELAY socket option to 1 by the property >> sun.net.httpserver.nodelay solves the issue. >> >> JBS Issue : [JDK-8323276](https://bugs.openjdk.org/bro

Re: RFR: 8331195: Improve com.sun.net.httpserver.HttpExchange usability [v3]

2024-05-01 Thread Bernd
On Fri, 26 Apr 2024 15:37:13 GMT, robert engels wrote: >> improve the HttpExchange api with documented constants and convenience >> methods to avoid common bugs > > robert engels has updated the pull request incrementally with one additional > commit since the last revision: > > Update > sr

Re: RFR: 8283795: Add TLSv1.3 and CNSA 1.0 algorithms to implementation requirements

2025-01-02 Thread Bernd
On Thu, 2 Jan 2025 14:41:48 GMT, Sean Mullan wrote: > Periodically, we review the security algorithm requirements to see if new > algorithms should be added or existing ones should be removed. The > requirements are intended to improve interoperability across different SE > implementations by

Re: Dozens of "HttpClient-N-SelectorManager" threads created

2025-01-23 Thread Bernd
You Can take an Heap dump and Check how many selectormanager Instances you have and who own them. Maybe you had close/reconnects or Deal with multiple Class Loaders?GrußBernd-- http://bernd.eckenfels.net  Von: net-dev im Auftrag von Ruslan Ibragimov Gesendet: Donnerstag, Jan

Re: https://bugs.openjdk.org/browse/JDK-8294196

2025-01-28 Thread Bernd
BTW this could also include callbacks for redirects (and maybe even retries?). Gruß,Bernd-- https://bernd.eckenfels.net  Von: net-dev im Auftrag von Jaikiran Pai Gesendet: Dienstag, Januar 28, 2025 3:05 PMAn: net-dev@openjdk.org Betreff: Re: https

Re: RFR: 8351339: WebSocket::sendBinary assume that user supplied buffers are BIG_ENDIAN [v2]

2025-03-13 Thread Bernd
The implementation has to read them because websockets use an odd xor masking, and the implementation has optimized this with longs, which have this endian problem, (yes it’s a bug). Maybe some vector api can replace the handmade procedure in the future without caring for the declared endianess.Gru

Re: RFR: 8353440: Disable FTP fallback for non-local file URLs by default

2025-04-15 Thread Bernd
On Tue, 15 Apr 2025 12:00:10 GMT, Eirik Bjørsnøs wrote: > Please help review this PR which disables the unspecified but long-standing > feature where an `FtpURLConnection` is opened as a fallback for non-local > file URLs. > > Before this change, if a file URL has a non-local host component, s