On Wed, 14 Jun 2023 04:53:58 GMT, David Holmes wrote:
> The following changes, to javac.1, were never applied to the closed sources
> and are "lost" by this update. These changes will need to be re-applied
> directly in JDK 21 and JDK 22
Just curious, since you have access to the secret closed
On Wed, 14 Jun 2023 21:28:01 GMT, David Holmes wrote:
> > Just curious, since you have access to the secret closed sources, can you
> > not backport these changes yourself? Instead of just deleting them and
> > expecting someone else to rescue them from oblivion?
>
> @archiecobbs we (Oracle) w
Please review several fixes and improvements to the `this-escape` lint warning
analyzer.
The goal here is to apply some relatively simple logical fixes that improve the
precision and accuracy of the analyzer, and capture the remaining low-hanging
fruit so we can consider the analyzer relatively
On Wed, 20 Dec 2023 09:03:34 GMT, Daniel Fuchs wrote:
> I assume these were the reason why this-escape analysis had been disabled on
> java.net.http, and I expect the reason why the analysis can be reenabled by
> default is because of point 3 above?
No, the goal here is simply to remove unnece
nce.
>
> In other words, we should be treating "via an outer instance" as just another
> flavor of indirection along with "direct" and "indirect".
>
> As a result, with this patch the `OuterRef` class goes away and a new
> `Indirection` enum has been
nce.
>
> In other words, we should be treating "via an outer instance" as just another
> flavor of indirection along with "direct" and "indirect".
>
> As a result, with this patch the `OuterRef` class goes away and a new
> `Indirection` enum has been
nce.
>
> In other words, we should be treating "via an outer instance" as just another
> flavor of indirection along with "direct" and "indirect".
>
> As a result, with this patch the `OuterRef` class goes away and a new
> `Indirection` enum has been
nce.
>
> In other words, we should be treating "via an outer instance" as just another
> flavor of indirection along with "direct" and "indirect".
>
> As a result, with this patch the `OuterRef` class goes away and a new
> `Indirection` enum has been
On Tue, 16 Apr 2024 18:00:50 GMT, Vicente Romero wrote:
>> Archie Cobbs has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains eight commits:
>>
>> - Merge branch 'master' into JDK-8317376
>>
On Mon, 16 Oct 2023 22:08:53 GMT, Archie Cobbs wrote:
> Please review several fixes and improvements to the `this-escape` lint
> warning analyzer.
>
> The goal here is to apply some relatively simple logical fixes that improve
> the precision and accuracy of the analyzer,
On Sun, 3 Nov 2024 03:11:20 GMT, Archie Cobbs wrote:
>> Please review this patch which removes unnecessary `@SuppressWarnings`
>> annotations.
>
> Archie Cobbs has updated the pull request with a new target base due to a
> merge or a rebase. The incremental webrev e
On Sat, 2 Nov 2024 15:59:58 GMT, Archie Cobbs wrote:
> Please review this patch which removes unnecessary `@SuppressWarnings`
> annotations.
This pull request has now been integrated.
Changeset: f95097cc
Author:Archie Cobbs
URL:
https://git.openjdk.org/jdk/
> Please review this patch which removes unnecessary `@SuppressWarnings`
> annotations.
Archie Cobbs has updated the pull request with a new target base due to a merge
or a rebase. The incremental webrev excludes the unrelated changes brought in
by the merge/rebase. The pull request co
Please review this patch which removes unnecessary `@SuppressWarnings`
annotations.
-
Commit messages:
- Remove unnecessary @SuppressWarnings annotations.
Changes: https://git.openjdk.org/jdk/pull/21856/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=21856&range=00
Issue
> This PR fixes minor Javadoc typos in a few `java.base` classes. Extra curly
> braces have been sneaking in.
Archie Cobbs has updated the pull request incrementally with one additional
commit since the last revision:
Revert accidental file change.
-
Changes:
- all:
On Mon, 24 Mar 2025 13:56:21 GMT, Chen Liang wrote:
>> Archie Cobbs has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Revert accidental file change.
>
> Looks good, these locations in the JDK 24 docs indeed
> This PR fixes minor Javadoc typos in a few `java.base` classes. Extra curly
> braces have been sneaking in.
Archie Cobbs has updated the pull request incrementally with one additional
commit since the last revision:
Apply font fixes per review suggestion.
-
Changes:
On Thu, 13 Mar 2025 01:21:54 GMT, Archie Cobbs wrote:
> This PR fixes minor Javadoc typos in a few `java.base` classes. Extra curly
> braces have been sneaking in.
This pull request has now been integrated.
Changeset: fe03e2ec
Author:Archie Cobbs
URL:
https://git.openjdk.o
On Thu, 13 Mar 2025 01:46:53 GMT, Iris Clark wrote:
> Where's the matching `(`? I'm guessing that the IDE thinks it's the one
> immediately before the `getLocale()`, but I suspect that javadoc won't agree
> with that.
You are correct - the matching `(` is the one preceding `getLocale()`.
I'm
This PR fixes minor Javadoc typos in a few `java.base` classes. Extra curly
braces have been sneaking in.
-
Commit messages:
- Fix minor Javadoc typos.
Changes: https://git.openjdk.org/jdk/pull/24022/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=24022&range=00
Issue: h
On Mon, 24 Mar 2025 05:23:58 GMT, Chen Liang wrote:
> Shouldn't this closing `)` be wrapped in `{@code}` like `{@code )}` to match
> with the code format in `{@code (getLocale()}`?
Yes it should - thanks. The two rows above also have the same problem, i.e., I
was just making this row consisten
21 matches
Mail list logo
