RFR: 8352502: Response message is null if expect 100 assertion fails with non 100

2025-06-26 Thread Darragh Clarke
Currently if a request has set Expect-Continue and receives a non 100 response the `responseMessage` wouldn't be set. This PR sets `responseMessage`, it also updates `getResponseMessage` to check if the message has already been set. This should match the way that `responseCode` is currently han

Re: RFR: 8352502: Response message is null if expect 100 assertion fails with non 100

2025-06-26 Thread Daniel Fuchs
On Thu, 26 Jun 2025 10:48:56 GMT, Darragh Clarke wrote: > Currently if a request has set Expect-Continue and receives a non 100 > response the `responseMessage` wouldn't be set. > > This PR sets `responseMessage`, it also updates `getResponseMessage` to check > if the message has already been

Re: RFR: 8352502: Response message is null if expect 100 assertion fails with non 100

2025-06-26 Thread Daniel Fuchs
On Thu, 26 Jun 2025 10:48:56 GMT, Darragh Clarke wrote: > Currently if a request has set Expect-Continue and receives a non 100 > response the `responseMessage` wouldn't be set. > > This PR sets `responseMessage`, it also updates `getResponseMessage` to check > if the message has already been

Re: RFR: 8349910: Implement JEP 517: HTTP/3 for the HTTP Client API [v8]

2025-06-26 Thread Jaikiran Pai
On Tue, 22 Apr 2025 16:15:29 GMT, Artur Barashev wrote: >> Daniel Fuchs has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 506 commits: >> >> - merge latest changes from master branch >> - http3: update H3InsertionsLimitTest to sta

Re: RFR: 8349910: Implement JEP 517: HTTP/3 for the HTTP Client API [v7]

2025-06-26 Thread Daniel Fuchs
On Thu, 26 Jun 2025 11:04:33 GMT, Daniel Fuchs wrote: >> Thank you Artur. >> >> @dfuch this conversation can be resolved too. > > Done > Hi Jaikiran! Sounds good. It's likely we are going to re-work this code > anyhow when we make QUIC engine public in the next iteration. We had a > discussio

Withdrawn: 8360166: CodeSource.implies(): Wildcard host fails to imply specific host

2025-06-26 Thread Lei Zhu
On Thu, 26 Jun 2025 01:43:51 GMT, Lei Zhu wrote: > Please review this PR which use hostname not cname to check imply. And alse > add test case. > > If there are any problems please let me know and I will correct them promptly. This pull request has been closed without being integrated. --

Re: RFR: 8349910: Implement JEP 517: HTTP/3 for the HTTP Client API [v8]

2025-06-26 Thread Daniel Fuchs
On Thu, 26 Jun 2025 13:22:28 GMT, Jaikiran Pai wrote: >> src/java.base/share/classes/sun/security/ssl/X509Authentication.java line >> 226: >> >>> 224: chc.peerSupportedAuthorities == null ? null : >>> 225: chc.peerSupportedAuthorities.clone(), >>>

Re: RFR: 8349910: Implement JEP 517: HTTP/3 for the HTTP Client API [v9]

2025-06-26 Thread Daniel Fuchs
On Thu, 26 Jun 2025 16:36:40 GMT, Daniel Fuchs wrote: >> Hi, >> >> Please find here a PR for the implementation of [JEP 517: HTTP/3 for the >> HTTP Client API](https://openjdk.org/jeps/517). >> >> The CSR can be viewed at [JDK-8350588: Implement JEP 517: HTTP/3 for the >> HTTP Client API](htt

Re: RFR: 8349910: Implement JEP 517: HTTP/3 for the HTTP Client API [v9]

2025-06-26 Thread Daniel Jeliński
On Thu, 26 Jun 2025 16:57:53 GMT, Daniel Fuchs wrote: >> Daniel Fuchs has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 525 commits: >> >> - merge latest changes from master branch >> - http3: run H3StreamLimitReachedTest.java wit

Re: RFR: 8349910: Implement JEP 517: HTTP/3 for the HTTP Client API [v9]

2025-06-26 Thread Daniel Jeliński
On Tue, 22 Apr 2025 16:21:30 GMT, Artur Barashev wrote: >> Daniel Fuchs has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 525 commits: >> >> - merge latest changes from master branch >> - http3: run H3StreamLimitReachedTest.java w

Re: RFR: 8349910: Implement JEP 517: HTTP/3 for the HTTP Client API [v7]

2025-06-26 Thread Daniel Fuchs
On Thu, 26 Jun 2025 01:04:41 GMT, Jaikiran Pai wrote: >> Hi Jaikiran! Sounds good. It's likely we are going to re-work this code >> anyhow when we make QUIC engine public in the next iteration. We had a >> discussion with Daniel about it today. > > Thank you Artur. > > @dfuch this conversation

Re: RFR: 8349910: Implement JEP 517: HTTP/3 for the HTTP Client API [v9]

2025-06-26 Thread Daniel Fuchs
> Hi, > > Please find here a PR for the implementation of [JEP 517: HTTP/3 for the HTTP > Client API](https://openjdk.org/jeps/517). > > The CSR can be viewed at [JDK-8350588: Implement JEP 517: HTTP/3 for the HTTP > Client API](https://bugs.openjdk.org/browse/JDK-8350588) > > This JEP propose

Re: RFR: 8349910: Implement JEP 517: HTTP/3 for the HTTP Client API [v9]

2025-06-26 Thread Daniel Fuchs
On Thu, 26 Jun 2025 16:36:40 GMT, Daniel Fuchs wrote: >> Hi, >> >> Please find here a PR for the implementation of [JEP 517: HTTP/3 for the >> HTTP Client API](https://openjdk.org/jeps/517). >> >> The CSR can be viewed at [JDK-8350588: Implement JEP 517: HTTP/3 for the >> HTTP Client API](htt

Re: RFR: 8349910: Implement JEP 517: HTTP/3 for the HTTP Client API [v9]

2025-06-26 Thread Daniel Jeliński
On Tue, 22 Apr 2025 16:49:10 GMT, Artur Barashev wrote: >> Daniel Fuchs has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 525 commits: >> >> - merge latest changes from master branch >> - http3: run H3StreamLimitReachedTest.java w

Re: RFR: 8349910: Implement JEP 517: HTTP/3 for the HTTP Client API [v9]

2025-06-26 Thread Daniel Fuchs
On Thu, 26 Jun 2025 17:36:21 GMT, Daniel Jeliński wrote: >> src/java.base/share/classes/jdk/internal/net/quic/QuicTLSContext.java line >> 70: >> >>> 68: if (!(underlyingImpl instanceof SSLContextImpl ssci)) { >>> 69: return false; >>> 70: } >> >> Would there be a wa

Re: RFR: 8349910: Implement JEP 517: HTTP/3 for the HTTP Client API [v9]

2025-06-26 Thread Daniel Fuchs
On Thu, 26 Jun 2025 16:36:40 GMT, Daniel Fuchs wrote: >> Hi, >> >> Please find here a PR for the implementation of [JEP 517: HTTP/3 for the >> HTTP Client API](https://openjdk.org/jeps/517). >> >> The CSR can be viewed at [JDK-8350588: Implement JEP 517: HTTP/3 for the >> HTTP Client API](htt

Re: RFR: 8349910: Implement JEP 517: HTTP/3 for the HTTP Client API [v9]

2025-06-26 Thread Daniel Jeliński
On Thu, 26 Jun 2025 16:36:40 GMT, Daniel Fuchs wrote: >> Hi, >> >> Please find here a PR for the implementation of [JEP 517: HTTP/3 for the >> HTTP Client API](https://openjdk.org/jeps/517). >> >> The CSR can be viewed at [JDK-8350588: Implement JEP 517: HTTP/3 for the >> HTTP Client API](htt

Re: RFR: 8349910: Implement JEP 517: HTTP/3 for the HTTP Client API [v2]

2025-06-26 Thread Daniel Jeliński
On Mon, 28 Apr 2025 18:52:10 GMT, Sean Mullan wrote: >> Daniel Fuchs has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 409 commits: >> >> - merge latest changes from master branch >> - http3: add missing separator to Http3Discove

Re: RFR: 8349910: Implement JEP 517: HTTP/3 for the HTTP Client API [v2]

2025-06-26 Thread Daniel Jeliński
On Fri, 25 Apr 2025 19:42:34 GMT, Artur Barashev wrote: >> Daniel Fuchs has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 409 commits: >> >> - merge latest changes from master branch >> - http3: add missing separator to Http3Disc