> Can I please get a review of this doc-only change which proposes to add a
> `@apiNote` to the `Socket.connect(SocketAddress endpoint, int timeout)`
> method? This addresses https://bugs.openjdk.org/browse/JDK-7116990.
>
> As noted in that issue, users can find it surprising that when the
> `S
On Wed, 11 Jun 2025 18:31:45 GMT, Alan Bateman wrote:
> > The CSR is now ready for review https://bugs.openjdk.org/browse/JDK-8359249
>
> It's okay to have a CSR but no usually needed for API notes.
Noted. For this one, I'll go ahead and finalize the already filed CSR.
-
PR Commen
On Tue, 17 Jun 2025 07:24:37 GMT, Alan Bateman wrote:
>> Jaikiran Pai has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - Mark's suggestion - use "connect timeout" instead of "connection timeout"
>> - Daniel's suggestion for the text
>
>
On Tue, 17 Jun 2025 07:29:23 GMT, Volkan Yazici wrote:
>> Can I please get a review for this change which addresses a regression that
>> was introduced in `HttpURLConnection` in Java 24 when we cleaned up the code
>> by removing the references to SecurityManager APIs.
>>
>> When a HTTP request
On Tue, 17 Jun 2025 08:28:22 GMT, Jaikiran Pai wrote:
> So any unexpected requests from other processes would still allow this test
> to be unaffected by those requests.
Yes, _this test_ will not be affected, but the other test _might_. Consider a
test running in parallel, unexpectedly connect
On Wed, 11 Jun 2025 12:07:51 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this change which proposes to remove the
>> deprecated-for-removal methods from `MulticastSocket` and
>> `DatagramSocketImpl`?
>>
>> The following methods on `java.net.MulticastSocket` and
>> `java.net.Data
On Tue, 17 Jun 2025 06:55:38 GMT, Jaikiran Pai wrote:
> Can I please get a review for this change which addresses a regression that
> was introduced in `HttpURLConnection` in Java 24 when we cleaned up the code
> by removing the references to SecurityManager APIs.
>
> When a HTTP request is is
On Sun, 15 Jun 2025 04:41:22 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this doc-only change which proposes to add a
>> `@apiNote` to the `Socket.connect(SocketAddress endpoint, int timeout)`
>> method? This addresses https://bugs.openjdk.org/browse/JDK-7116990.
>>
>> As noted in
Can I please get a review for this change which addresses a regression that was
introduced in `HttpURLConnection` in Java 24 when we cleaned up the code by
removing the references to SecurityManager APIs.
When a HTTP request is issued through `java.net.HttpURLConnection`, then the
request URL i
> Can I please get a review for this change which addresses a regression that
> was introduced in `HttpURLConnection` in Java 24 when we cleaned up the code
> by removing the references to SecurityManager APIs.
>
> When a HTTP request is issued through `java.net.HttpURLConnection`, then the
> r
On Tue, 17 Jun 2025 14:13:36 GMT, Daniel Fuchs wrote:
>> Jaikiran Pai has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - Volkan's suggestion - use test specific context root for the handler
>> - Daniel's suggestion - use setIfNotSet
>
>
On Tue, 17 Jun 2025 08:40:10 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this doc-only change which proposes to add a
>> `@apiNote` to the `Socket.connect(SocketAddress endpoint, int timeout)`
>> method? This addresses https://bugs.openjdk.org/browse/JDK-7116990.
>>
>> As noted in
On Mon, 9 Jun 2025 07:39:02 GMT, Jaikiran Pai wrote:
> Can I please get a review of this doc-only change which proposes to add a
> `@apiNote` to the `Socket.connect(SocketAddress endpoint, int timeout)`
> method? This addresses https://bugs.openjdk.org/browse/JDK-7116990.
>
> As noted in that
On Tue, 17 Jun 2025 13:53:15 GMT, Jaikiran Pai wrote:
>> Can I please get a review for this change which addresses a regression that
>> was introduced in `HttpURLConnection` in Java 24 when we cleaned up the code
>> by removing the references to SecurityManager APIs.
>>
>> When a HTTP request
On Tue, 17 Jun 2025 13:49:28 GMT, Jaikiran Pai wrote:
>>> So any unexpected requests from other processes would still allow this test
>>> to be unaffected by those requests.
>>
>> Yes, _this test_ will not be affected, but the other test _might_. Consider
>> a test running in parallel, unexpec
On Tue, 17 Jun 2025 08:40:10 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this doc-only change which proposes to add a
>> `@apiNote` to the `Socket.connect(SocketAddress endpoint, int timeout)`
>> method? This addresses https://bugs.openjdk.org/browse/JDK-7116990.
>>
>> As noted in
On Tue, 17 Jun 2025 08:40:10 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this doc-only change which proposes to add a
>> `@apiNote` to the `Socket.connect(SocketAddress endpoint, int timeout)`
>> method? This addresses https://bugs.openjdk.org/browse/JDK-7116990.
>>
>> As noted in
On Tue, 17 Jun 2025 06:55:38 GMT, Jaikiran Pai wrote:
> Can I please get a review for this change which addresses a regression that
> was introduced in `HttpURLConnection` in Java 24 when we cleaned up the code
> by removing the references to SecurityManager APIs.
>
> When a HTTP request is is
On Tue, 17 Jun 2025 13:28:07 GMT, Daniel Fuchs wrote:
>> Jaikiran Pai has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - Volkan's suggestion - use test specific context root for the handler
>> - Daniel's suggestion - use setIfNotSet
>
>
On Tue, 17 Jun 2025 08:51:26 GMT, Volkan Yazici wrote:
>> Hello Volkan, the server handler in this test is implemented to allow more
>> than one request during its lifetime. So any unexpected requests from other
>> processes would still allow this test to be unaffected by those requests.
>> Di
> Can I please get a review for this change which addresses a regression that
> was introduced in `HttpURLConnection` in Java 24 when we cleaned up the code
> by removing the references to SecurityManager APIs.
>
> When a HTTP request is issued through `java.net.HttpURLConnection`, then the
> r
On Fri, 13 Jun 2025 14:49:24 GMT, Michael McMahon wrote:
>> src/java.base/share/classes/java/net/HttpCookie.java line 892:
>>
>>> 890: assignAttribute(cookie, name, value);
>>> 891: }
>>> 892: assignMaxAgeAttribute(cookie, expiresValue, maxAgeValue);
>>
>> @Michael-M
On Wed, 11 Jun 2025 10:05:28 GMT, Jaikiran Pai wrote:
> Can I please get a review of this change which proposes to remove the
> deprecated-for-removal methods from `MulticastSocket` and
> `DatagramSocketImpl`?
>
> The following methods on `java.net.MulticastSocket` and
> `java.net.DatagramSo
On Mon, 16 Jun 2025 09:44:13 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this change which proposes to enhance the
>> implementation of `ServerSocket` and `ServerSocketChannel` to allow for
>> `backlog` values to be greater than 200 on Windows? This addresses
>> https://bugs.openj
On Mon, 16 Jun 2025 11:16:55 GMT, Daniel Fuchs wrote:
>> Jaikiran Pai has updated the pull request incrementally with four additional
>> commits since the last revision:
>>
>> - include a test for AsynchronousServerSocketChannel
>> - System.err instead of System.out
>> - trim down code comme
25 matches
Mail list logo
