Re: RFR: 8357639: DigestEchoClient fails intermittently due to: java.io.IOException: Data received while in pool [v4]

2025-06-10 Thread Daniel Jeliński
On Mon, 9 Jun 2025 13:56:13 GMT, Daniel Fuchs wrote: >> The java/net/httpclient/DigestEchoClient.java fails intemittently with >> IOException: HTTP/1.1 header parser received no bytes. >> >> Analysis shows that this is caused by the CleanupTrigger which receives data >> after the reused connec

Re: RFR: 8357639: DigestEchoClient fails intermittently due to: java.io.IOException: Data received while in pool [v4]

2025-06-10 Thread Daniel Fuchs
On Tue, 10 Jun 2025 07:03:06 GMT, Daniel Jeliński wrote: >> Daniel Fuchs has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains eight additional >> com

Re: RFR: 8357639: DigestEchoClient fails intermittently due to: java.io.IOException: Data received while in pool [v5]

2025-06-10 Thread Daniel Fuchs
> The java/net/httpclient/DigestEchoClient.java fails intemittently with > IOException: HTTP/1.1 header parser received no bytes. > > Analysis shows that this is caused by the CleanupTrigger which receives data > after the reused connection has been taken out of the HTTP/1.1 clear pool > (Cause

Re: RFR: 8349910: Implement JEP 517: HTTP/3 for the HTTP Client API [v7]

2025-06-10 Thread Artur Barashev
On Fri, 6 Jun 2025 12:00:37 GMT, Daniel Fuchs wrote: >> Hi, >> >> Please find here a PR for the implementation of [JEP 517: HTTP/3 for the >> HTTP Client API](https://openjdk.org/jeps/517). >> >> The CSR can be viewed at [JDK-8350588: Implement JEP 517: HTTP/3 for the >> HTTP Client API](http

Re: RFR: 8349910: Implement JEP 517: HTTP/3 for the HTTP Client API [v7]

2025-06-10 Thread Artur Barashev
On Fri, 6 Jun 2025 12:00:37 GMT, Daniel Fuchs wrote: >> Hi, >> >> Please find here a PR for the implementation of [JEP 517: HTTP/3 for the >> HTTP Client API](https://openjdk.org/jeps/517). >> >> The CSR can be viewed at [JDK-8350588: Implement JEP 517: HTTP/3 for the >> HTTP Client API](http

Re: RFR: 8349910: Implement JEP 517: HTTP/3 for the HTTP Client API [v7]

2025-06-10 Thread Artur Barashev
On Fri, 6 Jun 2025 12:00:37 GMT, Daniel Fuchs wrote: >> Hi, >> >> Please find here a PR for the implementation of [JEP 517: HTTP/3 for the >> HTTP Client API](https://openjdk.org/jeps/517). >> >> The CSR can be viewed at [JDK-8350588: Implement JEP 517: HTTP/3 for the >> HTTP Client API](http

Re: RFR: 8349910: Implement JEP 517: HTTP/3 for the HTTP Client API [v7]

2025-06-10 Thread Artur Barashev
On Fri, 6 Jun 2025 12:00:37 GMT, Daniel Fuchs wrote: >> Hi, >> >> Please find here a PR for the implementation of [JEP 517: HTTP/3 for the >> HTTP Client API](https://openjdk.org/jeps/517). >> >> The CSR can be viewed at [JDK-8350588: Implement JEP 517: HTTP/3 for the >> HTTP Client API](http

Re: RFR: 8340182: Java HttpClient does not follow default retry limit of 3 retries [v4]

2025-06-10 Thread Daniel Fuchs
On Tue, 10 Jun 2025 15:09:33 GMT, Daniel Fuchs wrote: >> p-nima has updated the pull request incrementally with one additional commit >> since the last revision: >> >> apply review feedback and improve readability > > test/jdk/java/net/httpclient/HttpClientAuthRetryLimitTest.java line 136: >

Re: RFR: 8340182: Java HttpClient does not follow default retry limit of 3 retries [v4]

2025-06-10 Thread Daniel Fuchs
On Tue, 10 Jun 2025 13:39:19 GMT, p-nima wrote: >> The AuthenticationFilter did not respect the default retry limit of 3 >> retries in case of invalid credentials supplied. >> >> This PR helps to resolve the bug and tests it with default and updated retry >> limit set via `jdk.httpclient.auth.

Re: RFR: 8357639: DigestEchoClient fails intermittently due to: java.io.IOException: Data received while in pool [v5]

2025-06-10 Thread Daniel Jeliński
On Tue, 10 Jun 2025 09:54:47 GMT, Daniel Fuchs wrote: >> The java/net/httpclient/DigestEchoClient.java fails intemittently with >> IOException: HTTP/1.1 header parser received no bytes. >> >> Analysis shows that this is caused by the CleanupTrigger which receives data >> after the reused conne

Re: RFR: 8340182: Java HttpClient does not follow default retry limit of 3 retries [v3]

2025-06-10 Thread p-nima
On Mon, 9 Jun 2025 14:21:45 GMT, Daniel Fuchs wrote: >> test/jdk/java/net/httpclient/HttpClientAuthRetryLimitTest.java line 132: >> >>> 130: assertEquals("too many authentication attempts. Limit: >>> " + RETRY_LIMIT, exception.getMessage()); >>> 131: assertEquals

Re: RFR: 8349910: Implement JEP 517: HTTP/3 for the HTTP Client API [v7]

2025-06-10 Thread Artur Barashev
On Tue, 22 Apr 2025 19:36:00 GMT, Artur Barashev wrote: >> Daniel Fuchs has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 499 commits: >> >> - merge latest changes from master branch >> - http3: improve H3ConnectionPoolTest.java >

Re: RFR: 8340182: Java HttpClient does not follow default retry limit of 3 retries [v4]

2025-06-10 Thread p-nima
> The AuthenticationFilter did not respect the default retry limit of 3 retries > in case of invalid credentials supplied. > > This PR helps to resolve the bug and tests it with default and updated retry > limit set via `jdk.httpclient.auth.retrylimit=1`. > > The test is green with tiers 1, 2,

Integrated: 8357639: DigestEchoClient fails intermittently due to: java.io.IOException: Data received while in pool

2025-06-10 Thread Daniel Fuchs
On Fri, 23 May 2025 14:35:30 GMT, Daniel Fuchs wrote: > The java/net/httpclient/DigestEchoClient.java fails intemittently with > IOException: HTTP/1.1 header parser received no bytes. > > Analysis shows that this is caused by the CleanupTrigger which receives data > after the reused connection

Re: RFR: 8349910: Implement JEP 517: HTTP/3 for the HTTP Client API [v2]

2025-06-10 Thread Jaikiran Pai
On Fri, 25 Apr 2025 19:07:37 GMT, Artur Barashev wrote: >> Daniel Fuchs has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 409 commits: >> >> - merge latest changes from master branch >> - http3: add missing separator to Http3Disc

Re: RFR: 8340182: Java HttpClient does not follow default retry limit of 3 retries [v4]

2025-06-10 Thread p-nima
On Wed, 4 Jun 2025 13:46:55 GMT, Daniel Fuchs wrote: >> @p-nima, the handler still accepts all calls to `/`, you only salted the >> request URI. Would you mind doing the same in >> `httpTestServer.addHandler(...)` too, please? (You better create a `String >> requestPath` variable and use it bo