RFR: 8355360: -d option of jwebserver command should accept relative paths

2025-05-08 Thread Volkan Yazici
Allows relative paths in the content root directory passed to the `jwebserver`. Changes apply to both the `jwebserver` executable and the `java -m jdk.httpserver` execution. ### Implementation notes Received `Path` is first passed through `.normalize().toAbsolutePath()`, and then used. The res

Re: RFR: 8355360: -d option of jwebserver command should accept relative paths

2025-05-08 Thread Alan Bateman
On Thu, 8 May 2025 09:01:33 GMT, Volkan Yazici wrote: > Allows relative paths in the content root directory passed to the > `jwebserver`. Changes apply to both the `jwebserver` executable and the `java > -m jdk.httpserver` execution. > > ### Implementation notes > > Received `Path` is first p

Re: RFR: 8249824: s/n/w/p/https/HttpsURLConnection/CloseKeepAliveCached.java uses @ignore w/o bugid [v4]

2025-05-08 Thread Mikhail Yankelevich
> * fully automated the test > * removed the race condition > * client on a thread and server on a thread options are now run together > automatically Mikhail Yankelevich has updated the pull request incrementally with one additional commit since the last revision: cleanup and update of the c

Re: RFR: 8249824: s/n/w/p/https/HttpsURLConnection/CloseKeepAliveCached.java uses @ignore w/o bugid [v3]

2025-05-08 Thread Mikhail Yankelevich
On Thu, 8 May 2025 05:54:58 GMT, Rajan Halade wrote: > I understand this is a old test and it is not in scope of this bug to update > existing code. But there are few issues in this test that should be > addressed, for instance, use of deprecated URL, old style threads, old code > styles, typo

Re: RFR: 8355360: -d option of jwebserver command should accept relative paths [v2]

2025-05-08 Thread Volkan Yazici
On Thu, 8 May 2025 09:21:54 GMT, Alan Bateman wrote: >> Volkan Yazici has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Replace `normalize().toAbsolutePath()` with `toRealPath()` > > src/jdk.httpserver/share/classes/sun/net/httpserver/simp

Re: RFR: 8355360: -d option of jwebserver command should accept relative paths [v2]

2025-05-08 Thread Volkan Yazici
> Allows relative paths in the content root directory passed to the > `jwebserver`. Changes apply to both the `jwebserver` executable and the `java > -m jdk.httpserver` execution. > > ### Implementation notes > > Received `Path` is read using `toRealPath()`, and then employed. The rest of > th

Re: RFR: 8356255: Add Stable Field Updaters to allow efficient lazy field evaluations [v8]

2025-05-08 Thread Per Minborg
> This sketch shows how "Stable Updaters" can be used to create stable > computations of `@Stable` fields. Only one updater is needed per class, > similar to `AtomicIntegerFieldUpdater`. Per Minborg has updated the pull request incrementally with one additional commit since the last revision:

Re: RFR: 8356255: Add Stable Field Updaters to allow efficient lazy field evaluations [v9]

2025-05-08 Thread Per Minborg
> This sketch shows how "Stable Updaters" can be used to create stable > computations of `@Stable` fields. Only one updater is needed per class, > similar to `AtomicIntegerFieldUpdater`. Per Minborg has updated the pull request incrementally with one additional commit since the last revision:

Re: RFR: 8356255: Add Stable Field Updaters to allow efficient lazy field evaluations [v10]

2025-05-08 Thread Per Minborg
> This sketch shows how "Stable Updaters" can be used to create stable > computations of `@Stable` fields. Only one updater is needed per class, > similar to `AtomicIntegerFieldUpdater`. Per Minborg has updated the pull request incrementally with one additional commit since the last revision:

Re: RFR: 8356255: Add Stable Field Updaters to allow efficient lazy field evaluations [v10]

2025-05-08 Thread David Beaumont
On Thu, 8 May 2025 13:16:25 GMT, Per Minborg wrote: >> This sketch shows how "Stable Updaters" can be used to create stable >> computations of `@Stable` fields. Only one updater is needed per class, >> similar to `AtomicIntegerFieldUpdater`. > > Per Minborg has updated the pull request incremen

Re: RFR: 8356171: Increase timeout for testcases as preparation for change of default timeout factor

2025-05-08 Thread Stefan Karlsson
On Thu, 8 May 2025 14:51:24 GMT, Leo Korinth wrote: > This change tries to add timeout to individual testcases so that I am able to > run them with a timeout factor of 1 in the future (JDK-8260555). > > The first commit changes the timeout factor to 0.7, so that I can run tests > and test the

Re: RFR: 8356171: Increase timeout for testcases as preparation for change of default timeout factor

2025-05-08 Thread Daniel Fuchs
On Thu, 8 May 2025 14:51:24 GMT, Leo Korinth wrote: > This change tries to add timeout to individual testcases so that I am able to > run them with a timeout factor of 1 in the future (JDK-8260555). > > The first commit changes the timeout factor to 0.7, so that I can run tests > and test the

Re: RFR: 8353642: Deprecate URL::getPermission method and networking permission classes for removal [v4]

2025-05-08 Thread Daniel Fuchs
On Thu, 8 May 2025 16:10:18 GMT, Daniel Fuchs wrote: >> Please find her a patch that deprecate networking permission classes for >> removal. The method `URL::getPermission` now serves little purpose and is >> also deprecated. That method was overridden in subclasses and specified to >> return

Re: RFR: 8356171: Increase timeout for testcases as preparation for change of default timeout factor

2025-05-08 Thread Leo Korinth
On Thu, 8 May 2025 14:51:24 GMT, Leo Korinth wrote: > This change tries to add timeout to individual testcases so that I am able to > run them with a timeout factor of 1 in the future (JDK-8260555). > > The first commit changes the timeout factor to 0.7, so that I can run tests > and test the

Re: RFR: 8356171: Increase timeout for testcases as preparation for change of default timeout factor

2025-05-08 Thread Leo Korinth
On Thu, 8 May 2025 16:04:53 GMT, Stefan Karlsson wrote: >> This change tries to add timeout to individual testcases so that I am able >> to run them with a timeout factor of 1 in the future (JDK-8260555). >> >> The first commit changes the timeout factor to 0.7, so that I can run tests >> and

Re: RFR: 8354024: [JMH] Create ephemeral UnixDomainSocketAddress provider with thread-safe close semantics [v2]

2025-05-08 Thread Michael McMahon
On Tue, 22 Apr 2025 09:44:04 GMT, Volkan Yazici wrote: >> `ServerUdsChannelHolder` is introduced to manage the life cycle of a >> `ServerSocketChannel` created using Unix domain sockets (UDS) in a >> thread-safe manner. >> >> ### Testing >> >> Changes can be tested as follows: >> >> >> make

Re: RFR: 8355360: -d option of jwebserver command should accept relative paths [v3]

2025-05-08 Thread Volkan Yazici
> Allows relative paths in the content root directory passed to the > `jwebserver`. Changes effect both the `jwebserver` executable and the `java > -m jdk.httpserver` execution. > > ### Implementation notes > > Received `Path` is read using `toRealPath()`, and then employed in > `s.n.h.s.FileS

Integrated: 8353440: Disable FTP fallback for non-local file URLs by default

2025-05-08 Thread Eirik Bjørsnøs
On Tue, 15 Apr 2025 12:00:10 GMT, Eirik Bjørsnøs wrote: > Please help review this PR which disables the unspecified but long-standing > feature where an `FtpURLConnection` is opened as a fallback for non-local > file URLs. > > Before this change, if a file URL has a non-local host component, s

RFR: 8356171: Increase timeout for testcases as preparation for change of default timeout factor

2025-05-08 Thread Leo Korinth
This change tries to add timeout to individual testcases so that I am able to run them with a timeout factor of 1 in the future (JDK-8260555). The first commit changes the timeout factor to 0.7, so that I can run tests and test the change (it will finally be changed to 1.0 in JDK-8260555). The n

Re: RFR: 8355360: -d option of jwebserver command should accept relative paths [v3]

2025-05-08 Thread Volkan Yazici
On Thu, 8 May 2025 13:42:37 GMT, Volkan Yazici wrote: >> Allows relative paths in the content root directory passed to the >> `jwebserver`. Changes effect both the `jwebserver` executable and the `java >> -m jdk.httpserver` execution. >> >> ### Implementation notes >> >> Received `Path` is re

Re: RFR: 8353642: Deprecate URL::getPermission method and networking permission classes for removal [v4]

2025-05-08 Thread Daniel Fuchs
> Please find her a patch that deprecate networking permission classes for > removal. The method `URL::getPermission` now serves little purpose and is > also deprecated. That method was overridden in subclasses and specified to > return some of the deprecated permissions. Daniel Fuchs has upda

Re: RFR: 8356171: Increase timeout for testcases as preparation for change of default timeout factor

2025-05-08 Thread Daniel Fuchs
On Thu, 8 May 2025 14:51:24 GMT, Leo Korinth wrote: > This change tries to add timeout to individual testcases so that I am able to > run them with a timeout factor of 1 in the future (JDK-8260555). > > The first commit changes the timeout factor to 0.7, so that I can run tests > and test the

Re: RFR: 8353642: Deprecate URL::getPermission method and networking permission classes for removal [v4]

2025-05-08 Thread Daniel Jeliński
On Thu, 8 May 2025 16:10:18 GMT, Daniel Fuchs wrote: >> Please find her a patch that deprecate networking permission classes for >> removal. The method `URL::getPermission` now serves little purpose and is >> also deprecated. That method was overridden in subclasses and specified to >> return

Re: RFR: 8356171: Increase timeout for testcases as preparation for change of default timeout factor

2025-05-08 Thread David Holmes
On Thu, 8 May 2025 14:51:24 GMT, Leo Korinth wrote: > This change tries to add timeout to individual testcases so that I am able to > run them with a timeout factor of 1 in the future (JDK-8260555). > > The first commit changes the timeout factor to 0.7, so that I can run tests > and test the

Re: RFR: 8356171: Increase timeout for testcases as preparation for change of default timeout factor

2025-05-08 Thread Phil Race
On Thu, 8 May 2025 14:51:24 GMT, Leo Korinth wrote: > This change tries to add timeout to individual testcases so that I am able to > run them with a timeout factor of 1 in the future (JDK-8260555). > > The first commit changes the timeout factor to 0.7, so that I can run tests > and test the

Re: RFR: 8353642: Deprecate URL::getPermission method and networking permission classes for removal [v4]

2025-05-08 Thread Iris Clark
On Thu, 8 May 2025 16:10:18 GMT, Daniel Fuchs wrote: >> Please find her a patch that deprecate networking permission classes for >> removal. The method `URL::getPermission` now serves little purpose and is >> also deprecated. That method was overridden in subclasses and specified to >> return

Re: RFR: 8341346: Add support for exporting TLS Keying Material [v9]

2025-05-08 Thread Bradford Wetmore
> Adds the RFC 5705/8446 TLS Key Exporters API/implementation to JSSE/SunJSSE > respectively. > > CSR is underway. > > Tests include new unit tests for TLSv1-1.3. Will run tier1-2, plus the JCK > API (jck:api/java_security jck:api/javax_crypto jck:api/javax_net > jck:api/javax_security jck:ap

Re: RFR: 8356171: Increase timeout for testcases as preparation for change of default timeout factor

2025-05-08 Thread Leonid Mesnik
On Thu, 8 May 2025 16:43:10 GMT, Leo Korinth wrote: >> This change tries to add timeout to individual testcases so that I am able >> to run them with a timeout factor of 1 in the future (JDK-8260555). >> >> The first commit changes the timeout factor to 0.7, so that I can run tests >> and test

Re: RFR: 8356171: Increase timeout for testcases as preparation for change of default timeout factor

2025-05-08 Thread Leonid Mesnik
On Thu, 8 May 2025 17:03:03 GMT, Leo Korinth wrote: >> doc/testing.md line 385: >> >>> 383: (`-timeoutFactor`). Also, some test cases that programmatically wait a >>> 384: certain amount of time will apply this factor. If we run in >>> 385: interpreted mode (`-Xcomp`), [RunTest.gmk](../make/RunT