Re: RFR: 8272875: Change the default key manager to PKIX [v3]

2025-04-29 Thread Daniel Jeliński
On Tue, 29 Apr 2025 21:51:00 GMT, Artur Barashev wrote: >> The current key manager is SunX509, which is configured in the >> java.security. The SunX509 algorithm does not check the local certificate. >> The PKIX algorithm should be preferred now so that the default key manager >> could be more

Re: RFR: 8272875: Change the default key manager to PKIX [v3]

2025-04-29 Thread Anthony Scarpino
On Tue, 29 Apr 2025 21:51:00 GMT, Artur Barashev wrote: >> The current key manager is SunX509, which is configured in the >> java.security. The SunX509 algorithm does not check the local certificate. >> The PKIX algorithm should be preferred now so that the default key manager >> could be more

Re: RFR: 8272875: Change the default key manager to PKIX [v3]

2025-04-29 Thread Artur Barashev
> The current key manager is SunX509, which is configured in the java.security. > The SunX509 algorithm does not check the local certificate. The PKIX > algorithm should be preferred now so that the default key manager could be > more robust. > > Compatibility considerations: > > 1) Customers

Re: RFR: 8354276: Strict HTTP header validation [v5]

2025-04-29 Thread Daniel Jeliński
> RFC 9113 HTTP/2 mandates certain validation for HTTP headers; the HttpClient > don't fully implement the described requirements. > > This PR adds the following validation: > - pseudo-headers defined for requests are rejected in responses and push > streams > - pseudo-headers defined for respon

Re: RFR: 8354276: Strict HTTP header validation [v5]

2025-04-29 Thread Daniel Fuchs
On Tue, 29 Apr 2025 09:49:42 GMT, Daniel Jeliński wrote: >> RFC 9113 HTTP/2 mandates certain validation for HTTP headers; the HttpClient >> don't fully implement the described requirements. >> >> This PR adds the following validation: >> - pseudo-headers defined for requests are rejected in res

Re: RFR: 8354276: Strict HTTP header validation [v4]

2025-04-29 Thread Daniel Jeliński
On Mon, 28 Apr 2025 14:03:24 GMT, Daniel Fuchs wrote: >> Daniel Jeliński has updated the pull request incrementally with two >> additional commits since the last revision: >> >> - Fix whitespace >> - Use ProtocolException for malformed headers > > src/java.net.http/share/classes/jdk/internal/

Re: RFR: 8354276: Strict HTTP header validation [v4]

2025-04-29 Thread Daniel Jeliński
On Mon, 28 Apr 2025 14:14:29 GMT, Jaikiran Pai wrote: >> Daniel Jeliński has updated the pull request incrementally with two >> additional commits since the last revision: >> >> - Fix whitespace >> - Use ProtocolException for malformed headers > > src/java.net.http/share/classes/jdk/internal/

Re: RFR: 8272875: Change the default key manager to PKIX [v2]

2025-04-29 Thread Sean Mullan
On Thu, 24 Apr 2025 18:30:00 GMT, Artur Barashev wrote: >> The current key manager is SunX509, which is configured in the >> java.security. The SunX509 algorithm does not check the local certificate. >> The PKIX algorithm should be preferred now so that the default key manager >> could be more

Re: RFR: 8354276: Strict HTTP header validation [v6]

2025-04-29 Thread Daniel Jeliński
> RFC 9113 HTTP/2 mandates certain validation for HTTP headers; the HttpClient > don't fully implement the described requirements. > > This PR adds the following validation: > - pseudo-headers defined for requests are rejected in responses and push > streams > - pseudo-headers defined for respon

Re: RFR: 8354276: Strict HTTP header validation [v5]

2025-04-29 Thread Daniel Jeliński
On Tue, 29 Apr 2025 13:32:46 GMT, Daniel Fuchs wrote: >> Daniel Jeliński has updated the pull request incrementally with five >> additional commits since the last revision: >> >> - Add test for malformed push promise headers >> - Fix orphaned header consumer >> - Make HeaderDecoder construct

Re: RFR: 8272875: Change the default key manager to PKIX [v2]

2025-04-29 Thread Sean Mullan
On Thu, 24 Apr 2025 18:30:00 GMT, Artur Barashev wrote: >> The current key manager is SunX509, which is configured in the >> java.security. The SunX509 algorithm does not check the local certificate. >> The PKIX algorithm should be preferred now so that the default key manager >> could be more

Re: RFR: 8348986: Improve coverage of enhanced exception messages [v9]

2025-04-29 Thread Michael McMahon
> Hi, > > Enhanced exception messages are designed to hide sensitive information such > as hostnames, IP > addresses from exception message strings, unless the enhanced mode for the > specific category > has been explicitly enabled. Enhanced exceptions were first introduced in > 8204233 in JD

Re: RFR: 8354276: Strict HTTP header validation [v6]

2025-04-29 Thread Daniel Fuchs
On Tue, 29 Apr 2025 15:40:20 GMT, Daniel Jeliński wrote: >> RFC 9113 HTTP/2 mandates certain validation for HTTP headers; the HttpClient >> don't fully implement the described requirements. >> >> This PR adds the following validation: >> - pseudo-headers defined for requests are rejected in res

Re: RFR: 8272875: Change the default key manager to PKIX [v2]

2025-04-29 Thread Artur Barashev
On Tue, 29 Apr 2025 18:51:58 GMT, Sean Mullan wrote: >> Artur Barashev has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Skip explicit KeyPair initialization and let the provider default set it > > test/jdk/sun/security/tools/keytool/Print

Re: RFR: 8272875: Change the default key manager to PKIX [v2]

2025-04-29 Thread Artur Barashev
On Tue, 29 Apr 2025 19:58:42 GMT, Sean Mullan wrote: >> Artur Barashev has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Skip explicit KeyPair initialization and let the provider default set it > > test/jdk/javax/rmi/ssl/SSLSocketParameter