Re: RFR: 8354826: Make ResolverConfigurationImpl.lock field final

2025-04-16 Thread Alan Bateman
On Thu, 20 Jul 2023 12:05:22 GMT, Andrey Turbanov wrote: > It was made `final` in Windows version of `ResolverConfigurationImpl` under > [JDK-8287104](https://bugs.openjdk.java.net/browse/JDK-8287104). src/java.base/unix/classes/sun/net/dns/ResolverConfigurationImpl.java line 44: > 42: { > 43:

RFR: 8354826: Make ResolverConfigurationImpl.lock field final

2025-04-16 Thread Andrey Turbanov
It was made `final` in Windows version of `ResolverConfigurationImpl` under [JDK-8287104](https://bugs.openjdk.java.net/browse/JDK-8287104). - Commit messages: - [PATCH] Make ResolverConfigurationImpl.lock field final Changes: https://git.openjdk.org/jdk/pull/14955/files Webrev:

Re: RFR: 8354576: InetAddress.getLocalHost() on macos may return address of an interface which is not UP - leading to "Network is down" error

2025-04-16 Thread Jaikiran Pai
On Tue, 15 Apr 2025 08:58:21 GMT, Jaikiran Pai wrote: > Can I please get a review of this change which proposes to address the issue > noted in https://bugs.openjdk.org/browse/JDK-8354576? > > As noted in that issue, the current code in the `lookupAllHostAddr()` > function of `Inet4AddressImpl

Re: RFR: 8353013: java.net.URI.create(String) may have low performance to scan the host/domain name from URI string when the hostname starts with number [v3]

2025-04-16 Thread Michael McMahon
On Wed, 16 Apr 2025 09:46:59 GMT, Rohitash Kumar wrote: >> `scanByte` throws `NumberFormatException` for URIs that start with numbers, >> e.g., https://.x.y/ >> The current flow is `parseIPv4Address` → `scanIPv4Address` → `scanByte`. >> `parseIPv4Address` uses `NumberFormatException` fo

Re: RFR: 8353013: java.net.URI.create(String) may have low performance to scan the host/domain name from URI string when the hostname starts with number [v3]

2025-04-16 Thread Andrey Turbanov
On Mon, 14 Apr 2025 16:34:33 GMT, Rohitash Kumar wrote: >> test/jdk/java/net/URI/Test.java line 1791: >> >>> 1789: >>> 1790: // 8353013 - java.net.URI.create(String) may have low performance >>> to scan the host/domain name from >>> 1791: // URI string when the hostname start

Re: RFR: 8350807: Certificates using MD5 algorithm that are disabled by default are incorrectly allowed in TLSv1.3 when re-enabled [v11]

2025-04-16 Thread Artur Barashev
> MD5 algorithm is prohibited by TLSv1.3 RFC to be used in certificates: > > > Any endpoint receiving any certificate which it would need to > validate using any signature algorithm using an MD5 hash MUST abort > the handshake with a "bad_certificate" alert. > > > > The bug manifests itself wh

Integrated: 8353013: java.net.URI.create(String) may have low performance to scan the host/domain name from URI string when the hostname starts with number

2025-04-16 Thread Rohitash Kumar
On Fri, 28 Mar 2025 15:19:46 GMT, Rohitash Kumar wrote: > `scanByte` throws `NumberFormatException` for URIs that start with numbers, > e.g., https://.x.y/ > The current flow is `parseIPv4Address` → `scanIPv4Address` → `scanByte`. > `parseIPv4Address` uses `NumberFormatException` for co

Re: RFR: 8354826: Make ResolverConfigurationImpl.lock field final

2025-04-16 Thread Daniel Fuchs
On Thu, 20 Jul 2023 12:05:22 GMT, Andrey Turbanov wrote: > It was made `final` in Windows version of `ResolverConfigurationImpl` under > [JDK-8287104](https://bugs.openjdk.java.net/browse/JDK-8287104). Marked as reviewed by dfuchs (Reviewer). - PR Review: https://git.openjdk.org/j

Re: RFR: 8353013: java.net.URI.create(String) may have low performance to scan the host/domain name from URI string when the hostname starts with number [v3]

2025-04-16 Thread Daniel Fuchs
On Wed, 16 Apr 2025 13:03:31 GMT, Andrey Turbanov wrote: >> Thanks! I have updated the comment and added a JMH benchmark. >> >> >> ## Before >> Benchmark (uri) Mode >> Cnt ScoreError Units >> URIAuthorityParsingBenchmark.create h

Integrated: 8354576: InetAddress.getLocalHost() on macos may return address of an interface which is not UP - leading to "Network is down" error

2025-04-16 Thread Jaikiran Pai
On Tue, 15 Apr 2025 08:58:21 GMT, Jaikiran Pai wrote: > Can I please get a review of this change which proposes to address the issue > noted in https://bugs.openjdk.org/browse/JDK-8354576? > > As noted in that issue, the current code in the `lookupAllHostAddr()` > function of `Inet4AddressImpl

Re: RFR: 8354576: InetAddress.getLocalHost() on macos may return address of an interface which is not UP - leading to "Network is down" error

2025-04-16 Thread Jaikiran Pai
On Tue, 15 Apr 2025 08:58:21 GMT, Jaikiran Pai wrote: > Can I please get a review of this change which proposes to address the issue > noted in https://bugs.openjdk.org/browse/JDK-8354576? > > As noted in that issue, the current code in the `lookupAllHostAddr()` > function of `Inet4AddressImpl

Re: RFR: 8353013: java.net.URI.create(String) may have low performance to scan the host/domain name from URI string when the hostname starts with number [v3]

2025-04-16 Thread Michael McMahon
On Wed, 16 Apr 2025 09:46:59 GMT, Rohitash wrote: >> `scanByte` throws `NumberFormatException` for URIs that start with numbers, >> e.g., https://.x.y/ >> The current flow is `parseIPv4Address` → `scanIPv4Address` → `scanByte`. >> `parseIPv4Address` uses `NumberFormatException` for cont

Re: RFR: 8353013: java.net.URI.create(String) may have low performance to scan the host/domain name from URI string when the hostname starts with number [v3]

2025-04-16 Thread duke
On Wed, 16 Apr 2025 09:46:59 GMT, Rohitash Kumar wrote: >> `scanByte` throws `NumberFormatException` for URIs that start with numbers, >> e.g., https://.x.y/ >> The current flow is `parseIPv4Address` → `scanIPv4Address` → `scanByte`. >> `parseIPv4Address` uses `NumberFormatException` fo

Re: RFR: 8353013: java.net.URI.create(String) may have low performance to scan the host/domain name from URI string when the hostname starts with number [v3]

2025-04-16 Thread Rohitash
> `scanByte` throws `NumberFormatException` for URIs that start with numbers, > e.g., https://.x.y/ > The current flow is `parseIPv4Address` → `scanIPv4Address` → `scanByte`. > `parseIPv4Address` uses `NumberFormatException` for control flow, so it > captures the exception, ignores it, a

Re: RFR: 8350807: Certificates using MD5 algorithm that are disabled by default are incorrectly allowed in TLSv1.3 when re-enabled [v11]

2025-04-16 Thread Mark Powers
On Wed, 16 Apr 2025 14:57:20 GMT, Artur Barashev wrote: >> MD5 algorithm is prohibited by TLSv1.3 RFC to be used in certificates: >> >> >> Any endpoint receiving any certificate which it would need to >> validate using any signature algorithm using an MD5 hash MUST abort >> the handshake with a

Re: RFR: 8350807: Certificates using MD5 algorithm that are disabled by default are incorrectly allowed in TLSv1.3 when re-enabled [v11]

2025-04-16 Thread Sean Mullan
On Wed, 16 Apr 2025 14:57:20 GMT, Artur Barashev wrote: >> MD5 algorithm is prohibited by TLSv1.3 RFC to be used in certificates: >> >> >> Any endpoint receiving any certificate which it would need to >> validate using any signature algorithm using an MD5 hash MUST abort >> the handshake with a

Re: RFR: 8350807: Certificates using MD5 algorithm that are disabled by default are incorrectly allowed in TLSv1.3 when re-enabled [v12]

2025-04-16 Thread Artur Barashev
> MD5 algorithm is prohibited by TLSv1.3 RFC to be used in certificates: > > > Any endpoint receiving any certificate which it would need to > validate using any signature algorithm using an MD5 hash MUST abort > the handshake with a "bad_certificate" alert. > > > > The bug manifests itself wh