RFR: 8353949: HttpHeaders.firstValueAsLong unnecessarily boxes to Long

2025-04-09 Thread Volkan Yazici
Avoid unnecessary boxing in `HttpHeaders::firstValueAsLong`. - Commit messages: - Avoid unnecessary boxing in `HttpHeaders::firstValueAsLong` Changes: https://git.openjdk.org/jdk/pull/24561/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=24561&range=00 Issue: https://bugs

Re: RFR: 8352431: java/net/httpclient/EmptyAuthenticate.java uses "localhost" [v3]

2025-04-09 Thread Volkan Yazici
> Overhauls `EmptyAuthenticate` to > > - Test all supported HTTP versions (i.e., HTTP/1.1 and HTTP/2) > - Test both clear-text and SSL > - Use `HttpServerAdapters.HttpTestServer::create` to avoid host-related > problems Volkan Yazici has updated the pull request incrementally with one additional

Re: RFR: 8352431: java/net/httpclient/EmptyAuthenticate.java uses "localhost" [v2]

2025-04-09 Thread Volkan Yazici
On Wed, 9 Apr 2025 11:32:38 GMT, Daniel Fuchs wrote: >> Volkan Yazici has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Apply review suggestions > > test/jdk/java/net/httpclient/EmptyAuthenticate.java line 103: > >> 101: :

RFR: 8285888: Clarify that java.net.http.HttpClient do NOT support Digest authentication

2025-04-09 Thread Michael McMahon
Hi, This is a minor doc change to clarify that java.net.http.HttpClient only supports HTTP Basic authentication. Thanks, Michael - Commit messages: - update Changes: https://git.openjdk.org/jdk/pull/24550/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=24550&range=00 I

Re: RFR: 8352431: java/net/httpclient/EmptyAuthenticate.java uses "localhost" [v2]

2025-04-09 Thread Jaikiran Pai
On Wed, 9 Apr 2025 13:36:23 GMT, Volkan Yazici wrote: >> Overhauls `EmptyAuthenticate` to >> >> - Test all supported HTTP versions (i.e., HTTP/1.1 and HTTP/2) >> - Test both clear-text and SSL >> - Use `HttpServerAdapters.HttpTestServer::create` to avoid host-related >> problems > > Volkan Yazi

Re: RFR: 8285888: Clarify that java.net.http.HttpClient do NOT support Digest authentication

2025-04-09 Thread Jaikiran Pai
On Wed, 9 Apr 2025 14:08:06 GMT, Michael McMahon wrote: > Hi, > > This is a minor doc change to clarify that java.net.http.HttpClient only > supports HTTP Basic authentication. > > Thanks, > Michael The change looks good to me. The copyright year on the file will need an update before integr

Re: RFR: 8352431: java/net/httpclient/EmptyAuthenticate.java uses "localhost" [v2]

2025-04-09 Thread Volkan Yazici
On Wed, 9 Apr 2025 14:21:57 GMT, Daniel Fuchs wrote: >> test/jdk/java/net/httpclient/EmptyAuthenticate.java line 75: >> >>> 73: void test(Version version, boolean secure) throws Exception { >>> 74: String uriPath = >>> "/%s/%s/%s".formatted(EmptyAuthenticate.class.getSimpleName(), v

Re: RFR: 8301991: Convert l10n properties resource bundles to UTF-8 native [v6]

2025-04-09 Thread Magnus Ihse Bursie
On Thu, 11 May 2023 20:21:57 GMT, Justin Lu wrote: >> This PR converts Unicode sequences to UTF-8 native in .properties file. >> (Excluding the Unicode space and tab sequence). The conversion was done >> using native2ascii. >> >> In addition, the build logic is adjusted to support reading in t

Re: RFR: 8352431: java/net/httpclient/EmptyAuthenticate.java uses "localhost" [v4]

2025-04-09 Thread Volkan Yazici
> Overhauls `EmptyAuthenticate` to > > - Test all supported HTTP versions (i.e., HTTP/1.1 and HTTP/2) > - Test both clear-text and SSL > - Use `HttpServerAdapters.HttpTestServer::create` to avoid host-related > problems Volkan Yazici has updated the pull request incrementally with one additional

Re: RFR: 8352431: java/net/httpclient/EmptyAuthenticate.java uses "localhost"

2025-04-09 Thread Jaikiran Pai
On Wed, 9 Apr 2025 11:12:31 GMT, Volkan Yazici wrote: > Overhauls `EmptyAuthenticate` to > > - Test all supported HTTP versions (i.e., HTTP/1.1 and HTTP/2) > - Test both clear-text and SSL > - Use `HttpServerAdapters.HttpTestServer::create` to avoid host-related > problems test/jdk/java/net/ht

Re: RFR: 8352431: java/net/httpclient/EmptyAuthenticate.java uses "localhost" [v2]

2025-04-09 Thread Volkan Yazici
> Overhauls `EmptyAuthenticate` to > > - Test all supported HTTP versions (i.e., HTTP/1.1 and HTTP/2) > - Test both clear-text and SSL > - Use `HttpServerAdapters.HttpTestServer::create` to avoid host-related > problems Volkan Yazici has updated the pull request incrementally with one additional

Re: RFR: 8352431: java/net/httpclient/EmptyAuthenticate.java uses "localhost" [v2]

2025-04-09 Thread Daniel Fuchs
On Wed, 9 Apr 2025 13:36:23 GMT, Volkan Yazici wrote: >> Overhauls `EmptyAuthenticate` to >> >> - Test all supported HTTP versions (i.e., HTTP/1.1 and HTTP/2) >> - Test both clear-text and SSL >> - Use `HttpServerAdapters.HttpTestServer::create` to avoid host-related >> problems > > Volkan Yazi

Re: RFR: 8353698: Output of Simple Web Server is garbled if the console's encoding is not UTF-8 [v3]

2025-04-09 Thread Michael McMahon
On Fri, 4 Apr 2025 09:13:30 GMT, Daishi Tabata wrote: >> The output `jwebserver` and `java -m jdk.httpserver` uses UTF-8 encoding. >> Therefore, if the console encoding is not set to UTF-8 (for example, MS932 >> on Japanese Windows), garbled characters may appear.  >> Since System.out knows the

Re: RFR: 8352431: java/net/httpclient/EmptyAuthenticate.java uses "localhost" [v2]

2025-04-09 Thread Daniel Fuchs
On Wed, 9 Apr 2025 14:18:20 GMT, Daniel Fuchs wrote: >> Volkan Yazici has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Apply review suggestions > > test/jdk/java/net/httpclient/EmptyAuthenticate.java line 75: > >> 73: void test(Versi

Re: RFR: 8352431: java/net/httpclient/EmptyAuthenticate.java uses "localhost"

2025-04-09 Thread Jaikiran Pai
On Wed, 9 Apr 2025 12:06:23 GMT, Daniel Fuchs wrote: >> I'm guessing that this test passes for you locally. If so, then we might >> need some additional investigation here as to why it passes (given the exact >> opposite assertion of what the test was previously asserting). >> >> I see that th

Re: RFR: 8301991: Convert l10n properties resource bundles to UTF-8 native [v6]

2025-04-09 Thread Justin Lu
On Wed, 9 Apr 2025 15:06:32 GMT, Magnus Ihse Bursie wrote: >> Justin Lu has updated the pull request with a new target base due to a merge >> or a rebase. The pull request now contains 16 commits: >> >> - Convert the merged master changes to UTF-8 >> - Merge master and fix conflicts >> - Clo

Integrated: 8353698: Output of Simple Web Server is garbled if the console's encoding is not UTF-8

2025-04-09 Thread Daishi Tabata
On Fri, 4 Apr 2025 06:22:16 GMT, Daishi Tabata wrote: > The output `jwebserver` and `java -m jdk.httpserver` uses UTF-8 encoding. > Therefore, if the console encoding is not set to UTF-8 (for example, MS932 on > Japanese Windows), garbled characters may appear.  > Since System.out knows the con

Re: RFR: 8353641: Deprecate core library permission classes for removal [v8]

2025-04-09 Thread Roger Riggs
On Tue, 8 Apr 2025 06:41:41 GMT, Alan Bateman wrote: >> Roger Riggs has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains 10 additional >> commits sin

Re: RFR: 8352431: java/net/httpclient/EmptyAuthenticate.java uses "localhost"

2025-04-09 Thread Jaikiran Pai
On Wed, 9 Apr 2025 11:12:31 GMT, Volkan Yazici wrote: > Overhauls `EmptyAuthenticate` to > > - Test all supported HTTP versions (i.e., HTTP/1.1 and HTTP/2) > - Test both clear-text and SSL > - Use `HttpServerAdapters.HttpTestServer::create` to avoid host-related > problems test/jdk/java/net/ht

Re: RFR: 8350279: HttpClient: Add a new HttpResponse method to identify connections [v12]

2025-04-09 Thread Daniel Fuchs
On Tue, 8 Apr 2025 19:27:17 GMT, Volkan Yazici wrote: >> Adds `HttpResponse::connectionLabel` method that provides an identifier for >> the connection. >> >> **Implementation note:** The feature is facilitated by >> `HttpConnection::label`, which should not be confused with >> `HttpConnection

Re: RFR: 8352431: java/net/httpclient/EmptyAuthenticate.java uses "localhost"

2025-04-09 Thread Daniel Fuchs
On Wed, 9 Apr 2025 11:12:31 GMT, Volkan Yazici wrote: > Overhauls `EmptyAuthenticate` to > > - Test all supported HTTP versions (i.e., HTTP/1.1 and HTTP/2) > - Test both clear-text and SSL > - Use `HttpServerAdapters.HttpTestServer::create` to avoid host-related > problems test/jdk/java/net/ht

Re: RFR: 8352431: java/net/httpclient/EmptyAuthenticate.java uses "localhost"

2025-04-09 Thread Jaikiran Pai
On Wed, 9 Apr 2025 11:30:58 GMT, Jaikiran Pai wrote: >> Overhauls `EmptyAuthenticate` to >> >> - Test all supported HTTP versions (i.e., HTTP/1.1 and HTTP/2) >> - Test both clear-text and SSL >> - Use `HttpServerAdapters.HttpTestServer::create` to avoid host-related >> problems > > test/jdk/jav

Re: RFR: 8352431: java/net/httpclient/EmptyAuthenticate.java uses "localhost"

2025-04-09 Thread Daniel Fuchs
On Wed, 9 Apr 2025 11:43:25 GMT, Jaikiran Pai wrote: >> test/jdk/java/net/httpclient/EmptyAuthenticate.java line 83: >> >>> 81: >>> responseHeaders.firstValue(WWW_AUTH_HEADER_NAME).orElse(null), >>> 82: () -> "was expecting empty `%s` header in: >>> %s".