RFR: 8351601: [JMH] test UnixSocketChannelReadWrite failed for 2 threads config

2025-03-20 Thread Volkan Yazici
Guards against multi-deletes in `UnixSocketChannelReadWrite`. The fix can be verified as follows: make build-microbenchmark build/linux-x64/jdk/bin/java \ -jar build/linux-x64/images/test/micro/benchmarks.jar \ -f 1 -wi 1 -i 1 -t 2 UnixSocketChannelReadWrite Note that `-t 2` denotes the nu

Re: RFR: 8351339: WebSocket::sendBinary assume that user supplied buffers are BIG_ENDIAN [v4]

2025-03-20 Thread Michael McMahon
On Mon, 17 Mar 2025 07:52:43 GMT, Volkan Yazici wrote: >> Fixes endian handling `jdk.internal.net.http.websocket.Frame.Masker`. >> >> ### Implementation notes >> >> I deleted the `Frame` clone in tests, and rewired the test code depending on >> it to the actual `Frame`. To enable this, I relax

Re: RFR: 8351322: Parameterize link option for pthreads [v2]

2025-03-20 Thread Magnus Ihse Bursie
On Mon, 17 Mar 2025 06:41:31 GMT, David Holmes wrote: >> @magicus why can't we just use `-pthread` everywhere? My recollection is >> that `-pthread` both sets compiler directives needed for pthread programming >> and links to libpthread, so it seems to be what we should be using. ?? > >> Anothe

Re: RFR: 8351322: Parameterize link option for pthreads [v2]

2025-03-20 Thread Magnus Ihse Bursie
On Mon, 17 Mar 2025 10:44:30 GMT, snake66 wrote: >>> Another follow-up is if it would hurt to include $LIBPTHREAD for _all_ >>> Hotspot tests, to avoid the huge list. @dholmes-ora Do you have anything >>> coming to mind directly that would make that infeasible, or is it just a >>> matter of te