Re: RFR: 8281511: java/net/ipv6tests/UdpTest.java fails with checkTime failed [v8]

2025-03-05 Thread serhiysachkov
> switching to nanoTime as suggested in ticket comments serhiysachkov has updated the pull request incrementally with one additional commit since the last revision: 8281511: updating TcpTest to use new checkIfTimeOut method instead of checkTime one - Changes: - all: https://gi

Re: RFR: 8350546: Several java/net/InetAddress tests fails UnknownHostException [v11]

2025-03-05 Thread Daniel Fuchs
On Wed, 5 Mar 2025 01:34:07 GMT, SendaoYan wrote: >> Hi all, >> >> Two java/net/InetAddress tests fails "java.net.UnknownHostException" on some >> special machines. The machine cannot connect to the Internet directly and >> needs to be connected to the Internet through a jump machine. The >>

Bug in java.net.http.WebSocket (?)

2025-03-05 Thread Fischer, Simon
Hi all, no idea if I am in the right place here, but I have no account to create a tracker issue and also could not find out how to get one... I was just using the java.net.html.WebSocket (jdk17 specifically, but the issue should still be there at least in 21 from a quick look into the code) fo

Re: Bug in java.net.http.WebSocket (?)

2025-03-05 Thread Daniel Fuchs
Hi Simon, Thank you for the report. I am not too familiar with WebSocket. But since this is a networking protocol I would expect binary data to be transferred on the wire in network byte order. So the expectation from WebSocket::sendBinary that the byte buffer is in network byte order (big endi

Re: RFR: 8281511: java/net/ipv6tests/UdpTest.java fails with checkTime failed [v7]

2025-03-05 Thread Sergey Sachkov
On Tue, 4 Mar 2025 18:25:58 GMT, Daniel Fuchs wrote: >> test/jdk/java/net/ipv6tests/Tests.java line 161: >> >>> 159: if (got < expected) { >>> 160: throw new RuntimeException("checkIfTimeOut failed: got " + >>> got >>> 161: + ", expected at least " + expe

Re: RFR: 8281511: java/net/ipv6tests/UdpTest.java fails with checkTime failed [v8]

2025-03-05 Thread Sergey Sachkov
On Wed, 5 Mar 2025 10:56:14 GMT, Daniel Fuchs wrote: > Generally looks good - but are these tests more stable now on all supported > os/arch? I've run multiple repititions of tests on supported platforms no failure noticed. - PR Comment: https://git.openjdk.org/jdk/pull/23840#iss

Re: RFR: 8281511: java/net/ipv6tests/UdpTest.java fails with checkTime failed [v8]

2025-03-05 Thread duke
On Wed, 5 Mar 2025 10:42:29 GMT, serhiysachkov wrote: >> switching to nanoTime as suggested in ticket comments > > serhiysachkov has updated the pull request incrementally with one additional > commit since the last revision: > > 8281511: updating TcpTest to use new checkIfTimeOut method inst

Integrated: 8281511: java/net/ipv6tests/UdpTest.java fails with checkTime failed

2025-03-05 Thread serhiysachkov
On Fri, 28 Feb 2025 10:38:19 GMT, serhiysachkov wrote: > switching to nanoTime as suggested in ticket comments This pull request has now been integrated. Changeset: ea9e3cfe Author:Serhiy Sachkov Committer: Mark Sheppard URL: https://git.openjdk.org/jdk/commit/ea9e3cfe03b5284ef0edc

Result: New Networking Group Member: Jaikiran Pai

2025-03-05 Thread Daniel Fuchs
Hi, The vote for Jaikiran Pai (jpai) [1] is now closed. Yes: 4 Veto: 0 Abstain: 0 According to the Bylaws definition of Lazy Consensus, this is sufficient to approve the nomination. best regards, -- daniel [1] https://mail.openjdk.org/pipermail/net-dev/2025-February/025637.html

Result: New Networking Group Member: Daniel Jeliński

2025-03-05 Thread Daniel Fuchs
Hi, The vote for Daniel Jeliński (djelinski) [1] is now closed. Yes: 4 Veto: 0 Abstain: 0 According to the Bylaws definition of Lazy Consensus, this is sufficient to approve the nomination. best regards, -- daniel [1] https://mail.openjdk.org/pipermail/net-dev/2025-February/025638.h

Re: Result: New Networking Group Member: Jaikiran Pai

2025-03-05 Thread Robert Engels
Congrats Jaikiran > On Mar 5, 2025, at 9:18 AM, Daniel Fuchs wrote: > > Hi, > > The vote for Jaikiran Pai (jpai) [1] is now closed. > > Yes: 4 > Veto: 0 > Abstain: 0 > > According to the Bylaws definition of Lazy Consensus, this is > sufficient to approve the nomination. > > best

Re: RFR: 8281511: java/net/ipv6tests/UdpTest.java fails with checkTime failed [v8]

2025-03-05 Thread Daniel Fuchs
On Wed, 5 Mar 2025 10:42:29 GMT, serhiysachkov wrote: >> switching to nanoTime as suggested in ticket comments > > serhiysachkov has updated the pull request incrementally with one additional > commit since the last revision: > > 8281511: updating TcpTest to use new checkIfTimeOut method inst

Re: RFR: 8281511: java/net/ipv6tests/UdpTest.java fails with checkTime failed [v8]

2025-03-05 Thread Daniel Fuchs
On Wed, 5 Mar 2025 10:42:29 GMT, serhiysachkov wrote: >> switching to nanoTime as suggested in ticket comments > > serhiysachkov has updated the pull request incrementally with one additional > commit since the last revision: > > 8281511: updating TcpTest to use new checkIfTimeOut method inst

Re: RFR: 8349705: java.net.URI.scanIPv4Address throws unnecessary URISyntaxException [v2]

2025-03-05 Thread Daniel Fuchs
On Mon, 10 Feb 2025 11:47:25 GMT, Xiaolong Peng wrote: >> java.net.URI.scanIPv4Address is a private method, it is only called by >> java.net.URI.takeIPv4Address and java.net.URI.parseIPv4Address, the >> URISyntaxException("Malformed IPv4 address") is not necessary, returning -1 >> should be go

Re: RFR: 8349705: java.net.URI.scanIPv4Address throws unnecessary URISyntaxException [v2]

2025-03-05 Thread Daniel Fuchs
On Mon, 10 Feb 2025 11:47:25 GMT, Xiaolong Peng wrote: >> java.net.URI.scanIPv4Address is a private method, it is only called by >> java.net.URI.takeIPv4Address and java.net.URI.parseIPv4Address, the >> URISyntaxException("Malformed IPv4 address") is not necessary, returning -1 >> should be go

Re: RFR: 8349705: java.net.URI.scanIPv4Address throws unnecessary URISyntaxException [v2]

2025-03-05 Thread Xiaolong Peng
On Wed, 5 Mar 2025 15:06:37 GMT, Daniel Fuchs wrote: > Hi, sorry for the late reply. I have imported your PR branch on my local repo > and am testing it in our CI. I will approve if my tests come back green. No worries, thank you so much for helping running the test. - PR Comment:

Re: RFR: 8349705: java.net.URI.scanIPv4Address throws unnecessary URISyntaxException [v2]

2025-03-05 Thread duke
On Mon, 10 Feb 2025 11:47:25 GMT, Xiaolong Peng wrote: >> java.net.URI.scanIPv4Address is a private method, it is only called by >> java.net.URI.takeIPv4Address and java.net.URI.parseIPv4Address, the >> URISyntaxException("Malformed IPv4 address") is not necessary, returning -1 >> should be go