Re: RFR: 8343791: Socket.connect API should document whether the socket will be closed when hostname resolution fails or another error occurs [v19]

2024-11-27 Thread Volkan Yazıcı
> This PR, addressing 8343791, changes `Socket::connect()` methods to close the > `Socket` in the event that the connection cannot be established, the timeout > expires before the connection is established, or the socket address is > unresolved. > > `tier3` tests pass against the 9f00f61d3b7fa4

Re: RFR: 8343791: Socket.connect API should document whether the socket will be closed when hostname resolution fails or another error occurs [v17]

2024-11-27 Thread Volkan Yazıcı
On Wed, 27 Nov 2024 10:45:48 GMT, Alan Bateman wrote: > I scanned the test update. My personal view is that there way too much here. > JDK tests typically only use a small subset of the features that JUnit > provides. So very surprised to see the use of extensions in these tests. For > tests i

Re: RFR: 8344220: Remove calls to SecurityManager and doPrivileged in java.net.InetAddress and sun.net.util.IPAddressUtil after JEP 486 integration [v3]

2024-11-27 Thread Daniel Fuchs
On Wed, 27 Nov 2024 12:24:54 GMT, Aleksei Efimov wrote: >> This PR removes calls to and mentions of the `SecurityManager` and the >> `doPrivileged` from the `java.net.InetAddress` and >> `sun.net.util.IPAddressUtil` and related classes. >> >> Noteworthy changes: >> - the default value (`30s`)

Integrated: 8344220: Remove calls to SecurityManager and doPrivileged in java.net.InetAddress and sun.net.util.IPAddressUtil after JEP 486 integration

2024-11-27 Thread Aleksei Efimov
On Tue, 26 Nov 2024 00:31:24 GMT, Aleksei Efimov wrote: > This PR removes calls to and mentions of the `SecurityManager` and the > `doPrivileged` from the `java.net.InetAddress` and > `sun.net.util.IPAddressUtil` and related classes. > > Noteworthy changes: > - the default value (`30s`) of th

Re: RFR: 8343791: Socket.connect API should document whether the socket will be closed when hostname resolution fails or another error occurs [v17]

2024-11-27 Thread Alan Bateman
On Wed, 27 Nov 2024 10:45:48 GMT, Alan Bateman wrote: >> Volkan Yazıcı has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Split tests into multiple files > > I scanned the test update. My personal view is that there way too much here. > JD

Re: RFR: 8343791: Socket.connect API should document whether the socket will be closed when hostname resolution fails or another error occurs [v19]

2024-11-27 Thread Daniel Fuchs
On Wed, 27 Nov 2024 14:34:32 GMT, Volkan Yazıcı wrote: >> This PR, addressing 8343791, changes `Socket::connect()` methods to close >> the `Socket` in the event that the connection cannot be established, the >> timeout expires before the connection is established, or the socket address >> is u

Re: RFR: 8337143: (fc, fs) Move filesystem-related native objects from libnio to libjava [v10]

2024-11-27 Thread Brian Burkhalter
> This proposed change would move the native objects required for NIO file > interaction from the libnio native library to the libjava native library on > Linux, macOS, and Windows. Brian Burkhalter has updated the pull request with a new target base due to a merge or a rebase. The pull request

Re: RFR: 8344908: URLClassPath should not propagate IllegalArgumentException when finding resources in classpath URLs [v4]

2024-11-27 Thread Alan Bateman
On Tue, 26 Nov 2024 06:56:28 GMT, Jaikiran Pai wrote: >> Can I please get a review of this change that proposes to address the issue >> noted in https://bugs.openjdk.org/browse/JDK-8344908? >> >> With this change, the URLClassPath will no longer propagate the >> `IllegalArgumentException` thro

Re: RFR: 8344908: URLClassPath should not propagate IllegalArgumentException when finding resources in classpath URLs [v4]

2024-11-27 Thread Jaikiran Pai
On Tue, 26 Nov 2024 06:56:28 GMT, Jaikiran Pai wrote: >> Can I please get a review of this change that proposes to address the issue >> noted in https://bugs.openjdk.org/browse/JDK-8344908? >> >> With this change, the URLClassPath will no longer propagate the >> `IllegalArgumentException` thro

Integrated: 8344908: URLClassPath should not propagate IllegalArgumentException when finding resources in classpath URLs

2024-11-27 Thread Jaikiran Pai
On Mon, 25 Nov 2024 00:33:41 GMT, Jaikiran Pai wrote: > Can I please get a review of this change that proposes to address the issue > noted in https://bugs.openjdk.org/browse/JDK-8344908? > > With this change, the URLClassPath will no longer propagate the > `IllegalArgumentException` thrown wh

Re: RFR: 8343791: Socket.connect API should document whether the socket will be closed when hostname resolution fails or another error occurs [v17]

2024-11-27 Thread Alan Bateman
On Tue, 26 Nov 2024 20:57:18 GMT, Volkan Yazıcı wrote: >> This PR, addressing 8343791, changes `Socket::connect()` methods to close >> the `Socket` in the event that the connection cannot be established, the >> timeout expires before the connection is established, or the socket address >> is u

RFR: 8344856: Remove calls to SecurityManager and doPrivileged in subclasses of URLConnection in the sun.net package after JEP 486 integration

2024-11-27 Thread Volkan Yazıcı
This change set, addressing [8344856](https://bugs.openjdk.org/browse/JDK-8344856), removes `SecurityManager` and friends from `sun.net.FtpURLConnection`. This is the only leftover from `SM` cleanup in the subclasses of `URLConnection` in the `sun.net` package. Successful `tier1..3` CI runs on

Re: RFR: 8344856: Remove calls to SecurityManager and doPrivileged in subclasses of URLConnection in the sun.net package after JEP 486 integration [v2]

2024-11-27 Thread Volkan Yazıcı
> This change set, addressing > [8344856](https://bugs.openjdk.org/browse/JDK-8344856), removes > `SecurityManager` and friends from > `sun.net.www.protocol.ftp.FtpURLConnection`. This is the only leftover from > `SM` cleanup in the subclasses of `URLConnection` in the `sun.net` package. > Suc

Re: RFR: 8344856: Remove calls to SecurityManager and doPrivileged in subclasses of URLConnection in the sun.net package after JEP 486 integration [v2]

2024-11-27 Thread Volkan Yazıcı
On Wed, 27 Nov 2024 09:13:42 GMT, Daniel Fuchs wrote: >> Volkan Yazıcı has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Remove redundant suppression > > src/java.base/share/classes/sun/net/www/protocol/ftp/FtpURLConnection.java > line 22

Re: RFR: 8344856: Remove calls to SecurityManager and doPrivileged in subclasses of URLConnection in the sun.net package after JEP 486 integration

2024-11-27 Thread Daniel Fuchs
On Wed, 27 Nov 2024 08:21:34 GMT, Volkan Yazıcı wrote: > This change set, addressing > [8344856](https://bugs.openjdk.org/browse/JDK-8344856), removes > `SecurityManager` and friends from > `sun.net.www.protocol.ftp.FtpURLConnection`. This is the only leftover from > `SM` cleanup in the subcl

Re: RFR: 8344856: Remove calls to SecurityManager and doPrivileged in subclasses of URLConnection in the sun.net package after JEP 486 integration [v2]

2024-11-27 Thread Daniel Fuchs
On Wed, 27 Nov 2024 09:22:54 GMT, Volkan Yazıcı wrote: >> This change set, addressing >> [8344856](https://bugs.openjdk.org/browse/JDK-8344856), removes >> `SecurityManager` and friends from >> `sun.net.www.protocol.ftp.FtpURLConnection`. This is the only leftover from >> `SM` cleanup in the

Re: RFR: 8343791: Socket.connect API should document whether the socket will be closed when hostname resolution fails or another error occurs [v18]

2024-11-27 Thread Volkan Yazıcı
> This PR, addressing 8343791, changes `Socket::connect()` methods to close the > `Socket` in the event that the connection cannot be established, the timeout > expires before the connection is established, or the socket address is > unresolved. > > `tier3` tests pass against the 9f00f61d3b7fa4

Re: RFR: 8343791: Socket.connect API should document whether the socket will be closed when hostname resolution fails or another error occurs [v17]

2024-11-27 Thread Volkan Yazıcı
On Wed, 27 Nov 2024 10:47:17 GMT, Alan Bateman wrote: >> Volkan Yazıcı has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Split tests into multiple files > > src/java.base/share/classes/sun/nio/ch/SocketAdaptor.java line 93: > >> 91:

Re: RFR: 8344220: Remove calls to SecurityManager and doPrivileged in java.net.InetAddress and sun.net.util.IPAddressUtil after JEP 486 integration [v3]

2024-11-27 Thread Aleksei Efimov
> This PR removes calls to and mentions of the `SecurityManager` and the > `doPrivileged` from the `java.net.InetAddress` and > `sun.net.util.IPAddressUtil` and related classes. > > Noteworthy changes: > - the default value (`30s`) of the `networkaddress.cache.ttl` security > property responsi

Re: RFR: 8344220: Remove calls to SecurityManager and doPrivileged in java.net.InetAddress and sun.net.util.IPAddressUtil after JEP 486 integration [v3]

2024-11-27 Thread Jaikiran Pai
On Wed, 27 Nov 2024 12:21:59 GMT, Aleksei Efimov wrote: >> This PR removes calls to and mentions of the `SecurityManager` and the >> `doPrivileged` from the `java.net.InetAddress` and >> `sun.net.util.IPAddressUtil` and related classes. >> >> Noteworthy changes: >> - the default value (`30s`)

Re: RFR: 8344856: Remove calls to SecurityManager and doPrivileged in sun.net.www.protocol.ftp.FtpURLConnection after JEP 486 integration [v2]

2024-11-27 Thread duke
On Wed, 27 Nov 2024 09:22:54 GMT, Volkan Yazıcı wrote: >> This change set, addressing >> [8344856](https://bugs.openjdk.org/browse/JDK-8344856), removes >> `SecurityManager` and friends from >> `sun.net.www.protocol.ftp.FtpURLConnection`. This is the only leftover from >> `SM` cleanup in the

Integrated: 8344856: Remove calls to SecurityManager and doPrivileged in sun.net.www.protocol.ftp.FtpURLConnection after JEP 486 integration

2024-11-27 Thread Volkan Yazıcı
On Wed, 27 Nov 2024 08:21:34 GMT, Volkan Yazıcı wrote: > This change set, addressing > [8344856](https://bugs.openjdk.org/browse/JDK-8344856), removes > `SecurityManager` and friends from > `sun.net.www.protocol.ftp.FtpURLConnection`. This is the only leftover from > `SM` cleanup in the subcl