On Mon, 21 Oct 2024 17:20:15 GMT, Sean Mullan wrote:
> > There are a couple of micro benchmarks in test/micro that fork with
> > `jvmArgsPrepend={"-Djava.security.manager=allow"})`, they will need to be
> > examined.
>
> Fixed, will be in next drop. There are a couple of other micro tests that
On Fri, 18 Oct 2024 19:03:30 GMT, Sean Mullan wrote:
>> This is the implementation of JEP 486: Permanently Disable the Security
>> Manager. See [JEP 486](https://openjdk.org/jeps/486) for more details. The
>> [CSR](https://bugs.openjdk.org/browse/JDK-8338412) describes in detail the
>> main ch
On Tue, 22 Oct 2024 21:20:59 GMT, Mandy Chung wrote:
>> Sean Mullan has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 97 commits:
>>
>> - Merge remote-tracking branch 'jdk-sandbox/jep486' into JDK-8338411
>> - Change apiNote to de
On Fri, 18 Oct 2024 19:03:30 GMT, Sean Mullan wrote:
>> This is the implementation of JEP 486: Permanently Disable the Security
>> Manager. See [JEP 486](https://openjdk.org/jeps/486) for more details. The
>> [CSR](https://bugs.openjdk.org/browse/JDK-8338412) describes in detail the
>> main ch
On Mon, 21 Oct 2024 14:34:30 GMT, Julian Waters wrote:
> After 8339120, gcc began catching many different instances of unused code in
> the Windows specific codebase. Some of these seem to be bugs. I've taken the
> effort to mark out all the relevant globals and locals that trigger the
> unuse
On Tue, 22 Oct 2024 15:08:57 GMT, Daniel Fuchs wrote:
>> Please find here a fix that improves flow control in the HTTP/2
>> implementation.
>>
>> The change makes sure that flow control issues are reported to the server as
>> FLOW_CONTROL_ERROR.
>> It also clarify how some system properties th
On Wed, 23 Oct 2024 05:22:45 GMT, Julian Waters wrote:
>> src/jdk.jdi/windows/native/libdt_shmem/shmem_md.c line 47:
>>
>>> 45: {
>>> 46: void *mappedMemory;
>>> 47: // HANDLE memHandle;
>>
>> Why comment out this one but not the one at line 88? It seems they are both
>> equally problemat
On Wed, 23 Oct 2024 11:54:39 GMT, Alan Bateman wrote:
>> Sean Mullan has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 97 commits:
>>
>> - Merge remote-tracking branch 'jdk-sandbox/jep486' into JDK-8338411
>> - Change apiNote to d
On Fri, 18 Oct 2024 19:03:30 GMT, Sean Mullan wrote:
>> This is the implementation of JEP 486: Permanently Disable the Security
>> Manager. See [JEP 486](https://openjdk.org/jeps/486) for more details. The
>> [CSR](https://bugs.openjdk.org/browse/JDK-8338412) describes in detail the
>> main ch
On Fri, 18 Oct 2024 19:03:30 GMT, Sean Mullan wrote:
>> This is the implementation of JEP 486: Permanently Disable the Security
>> Manager. See [JEP 486](https://openjdk.org/jeps/486) for more details. The
>> [CSR](https://bugs.openjdk.org/browse/JDK-8338412) describes in detail the
>> main ch
On Wed, 23 Oct 2024 12:44:53 GMT, Coleen Phillimore wrote:
>> Sean Mullan has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 97 commits:
>>
>> - Merge remote-tracking branch 'jdk-sandbox/jep486' into JDK-8338411
>> - Change apiNote
On Wed, 23 Oct 2024 05:23:39 GMT, Julian Waters wrote:
>> src/jdk.jdwp.agent/share/native/libjdwp/log_messages.c line 53:
>>
>>> 51: #ifndef _WIN32
>>> 52: static MUTEX_T my_mutex = MUTEX_INIT;
>>> 53: #endif
>>
>> The reason for no reference on windows is because of the following on
>> window
On Wed, 23 Oct 2024 19:38:10 GMT, Harshitha Onkar wrote:
>> test/jdk/javax/imageio/CachePremissionsTest/CachePermissionsTest.java line
>> 76:
>>
>>> 74: System.out.println("java.io.tmpdir is " +
>>> System.getProperty("java.io.tmpdir"));
>>> 75:
>>> 76: if (args.length > 1) {
On Wed, 23 Oct 2024 12:14:24 GMT, Alan Bateman wrote:
>> Sean Mullan has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 97 commits:
>>
>> - Merge remote-tracking branch 'jdk-sandbox/jep486' into JDK-8338411
>> - Change apiNote to d
On Tue, 22 Oct 2024 21:36:06 GMT, Mandy Chung wrote:
> Reviewed test/jdk/java/lang/** and test/jdk/sun/reflect/* tests.
Thanks for the comprehensive review. I have incorporated all of your comments
except for removing the enum from
`java/lang/Class/getDeclaredField/FieldSetAccessibleTest.java`
On Mon, 21 Oct 2024 21:12:29 GMT, Phil Race wrote:
>> Sean Mullan has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 97 commits:
>>
>> - Merge remote-tracking branch 'jdk-sandbox/jep486' into JDK-8338411
>> - Change apiNote to depr
On Wed, 23 Oct 2024 05:11:19 GMT, Prasanta Sadhukhan
wrote:
>> Sean Mullan has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 97 commits:
>>
>> - Merge remote-tracking branch 'jdk-sandbox/jep486' into JDK-8338411
>> - Change apiNo
On Mon, 21 Oct 2024 15:45:09 GMT, Hannes Wallnöfer wrote:
>> Please review a doc update to add `@spec` tags to crypto and security APIs
>> in `java.base`.
>>
>> This was authored and proposed as #13336 by @jonathan-gibbons as part of an
>> effort to [add `@spec` tags and an external specifica
On Wed, 23 Oct 2024 21:14:23 GMT, Valerie Peng wrote:
> Is "https://tools.ietf.org/html/rfc8103"; considered external spec? It is
> mentioned in com.sun.crypto.provider.ChaCha20Poly1305Parameters class but not
> covered in this PR. Is there any additional condition for an external
> reference
On Fri, 18 Oct 2024 19:03:30 GMT, Sean Mullan wrote:
>> This is the implementation of JEP 486: Permanently Disable the Security
>> Manager. See [JEP 486](https://openjdk.org/jeps/486) for more details. The
>> [CSR](https://bugs.openjdk.org/browse/JDK-8338412) describes in detail the
>> main ch
On Wed, 23 Oct 2024 12:53:12 GMT, Alan Bateman wrote:
>> src/hotspot/share/prims/jvm.cpp line 1272:
>>
>>> 1270:
>>> 1271:
>>> 1272: // Returns the inherited_access_control_context field of the running
>>> thread.
>>
>> There's some code in this file in
>> static void trace_class_resolution
On Mon, 21 Oct 2024 15:45:09 GMT, Hannes Wallnöfer wrote:
>> Please review a doc update to add `@spec` tags to crypto and security APIs
>> in `java.base`.
>>
>> This was authored and proposed as #13336 by @jonathan-gibbons as part of an
>> effort to [add `@spec` tags and an external specifica
On Wed, 23 Oct 2024 05:11:19 GMT, Prasanta Sadhukhan
wrote:
>> Sean Mullan has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 97 commits:
>>
>> - Merge remote-tracking branch 'jdk-sandbox/jep486' into JDK-8338411
>> - Change apiNo
On Mon, 21 Oct 2024 15:45:09 GMT, Hannes Wallnöfer wrote:
>> Please review a doc update to add `@spec` tags to crypto and security APIs
>> in `java.base`.
>>
>> This was authored and proposed as #13336 by @jonathan-gibbons as part of an
>> effort to [add `@spec` tags and an external specifica
On Mon, 21 Oct 2024 15:45:09 GMT, Hannes Wallnöfer wrote:
>> Please review a doc update to add `@spec` tags to crypto and security APIs
>> in `java.base`.
>>
>> This was authored and proposed as #13336 by @jonathan-gibbons as part of an
>> effort to [add `@spec` tags and an external specifica
On Thu, 24 Oct 2024 02:21:20 GMT, Valerie Peng wrote:
>> Hannes Wallnöfer has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Update copyright header dates
>
> src/java.base/share/classes/java/security/package-info.java line 82:
>
>> 80: *
On Wed, 23 Oct 2024 16:51:23 GMT, Chris Plummer wrote:
>> I wasn't sure whether the global memHandle not being used was a bug, so I
>> commented out the local one. I missed the line 88 one because it wasn't
>> flagged. If it really isn't needed I'll remove that one instead
>
> I'm not sure what
On Mon, 21 Oct 2024 14:34:30 GMT, Julian Waters wrote:
> After 8339120, gcc began catching many different instances of unused code in
> the Windows specific codebase. Some of these seem to be bugs. I've taken the
> effort to mark out all the relevant globals and locals that trigger the
> unuse
On Thu, 24 Oct 2024 03:31:31 GMT, Julian Waters wrote:
>> I'm not sure what you mean by "that one". It's the static one that should be
>> removed. The local variables always hide the static, and there seems to be
>> no reason for the value of memHandle to survive outside of the local scope
>>
29 matches
Mail list logo
