On Fri, 11 Oct 2024 11:46:40 GMT, Eirik Bjørsnøs wrote:
> Please review this PR which adds test coverage for the case where
> `URLClassLoader.defineClass` fails with a `ClassFormatError` _and_ the CRC32
> checksum of the class file byte array did not match the CRC32 value stated in
> the JAR f
On Fri, 11 Oct 2024 11:46:40 GMT, Eirik Bjørsnøs wrote:
> Please review this PR which adds test coverage for the case where
> `URLClassLoader.defineClass` fails with a `ClassFormatError` _and_ the CRC32
> checksum of the class file byte array did not match the CRC32 value stated in
> the JAR f
On Sun, 13 Oct 2024 07:07:52 GMT, Jaikiran Pai wrote:
> .. is merely an implementation detail (which should be free to change any
> time). I think asserting this internal detail through a test case isn't
> necessary.
Thanks Jai. Sure, this test asserts invariants of the implementation, not in
On Fri, 11 Oct 2024 09:09:47 GMT, Michael McMahon wrote:
>> Hi,
>>
>> I closed https://github.com/openjdk/jdk/pull/21249 and am continuing the
>> review on this PR.
>>
>> This fix relaxes the constraints on user set authentication headers.
>> Currently, any user set authentication headers are
