Integrated: 8340326: Remove references to Applet in core-libs/security tests

2024-10-04 Thread Justin Lu
On Thu, 19 Sep 2024 22:25:25 GMT, Justin Lu wrote: > Please review this PR which removes usages of Applet within the corelibs > tests. > > Most changes are removed comments/updated var names. The JBS issue lists more > files than the ones included in this pull request, please see the comment o

RFD: Reorganize sun.net.protocol.www.file.Handler sources to make them more diff friendly

2024-10-04 Thread Eirik Bjørsnøs
Hi, Inspired by JDK-8341142, I noticed that the source code files for sun.net.protocol.www.file.Handler (unix/windows) are actually quite similar in program meaning, but have drifted apart in code style, variable names, comments and general organization. This makes diffs between these files more

Re: RFR: 8340326: Remove references to Applet in core-libs/security tests [v8]

2024-10-04 Thread Justin Lu
On Thu, 3 Oct 2024 18:15:55 GMT, Justin Lu wrote: >> Please review this PR which removes usages of Applet within the corelibs >> tests. >> >> Most changes are removed comments/updated var names. The JBS issue lists >> more files than the ones included in this pull request, please see the >> c

Re: RFR: 8341142: Maintain a single source file for sun.net.www.protocol.jar.JarFileFactory

2024-10-04 Thread Daniel Fuchs
On Sun, 29 Sep 2024 04:49:14 GMT, Jaikiran Pai wrote: > Can I please get a review of this change which proposes to keep a single > source file for `sun.net.www.protocol.jar.JarFileFactory`? > > As noted in https://bugs.openjdk.org/browse/JDK-8341142, the sole difference > between the current t